- User Since
- Oct 28 2016, 2:19 AM (220 w, 2 d)
Nov 30 2020
Nov 24 2020
Thanks, @arichardson and @jrtc27 for your comments.
I am definitely surprised to find that if you explicitly mark the call with the address space, this patch is not required. At first look, this RFC is not required any more but I need sometime to investigate further. If no changes are necessary, this is indeed good news.
Nov 19 2020
The RFC has now been sent to the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146723.html
Nov 16 2020
Fix type check.
Ensure the program address spaces vector doesn't contain duplicates.
Nov 13 2020
This is WIP - there a still a few test failures but I am happy to start getting comments on this.
Oct 23 2020
@sbc100 if it's ok for you, feel free to merge, thanks.
Align with local indent style
Oct 22 2020
Remove unused operand type.
Is this good to merge?
Oct 21 2020
Regarding linter clang-format suggestions - should I reformat the code as suggested or leave it?
Some suggested changes are not necessarily on code I wrote, which is why I ask.
These changes reflect the first set of comments. High on the list is quite a few changes related to setting registers for funcrefs and externrefs. A few things might not be strictly necessary but pave the way for future work.
Thanks for the review - I will submit a new revision.
Oct 20 2020
So the goal here is to add most of the table instructions. This introduces some table relocations, which (in a following patch) we will resolve in the linker.
Oct 13 2020
Further test fixes - missing index
Fix warning due to missing FUNCREF in switch
Oct 12 2020
Fix a bunch more lld tests to include index for tables
Fix tests to include table index in expected dump
Fix build failure
Move Index to first position in WasmTable struct
Fix review nits
Oct 9 2020
Thanks for the reviews. I will fix the nits mentioned and update the revision.
Oct 5 2020
Sep 24 2020
Aug 5 2020
Jul 31 2020
Update externref patch
Mistakingly created - this should have gone to D66035
Jul 29 2020
I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively
Update patch to compile against current master branch
Jul 28 2020
Related work: https://reviews.llvm.org/D81977
There's also this line of work on opaque types that could be potentially interested but seems far from being landed: https://groups.google.com/g/llvm-dev/c/Dw_DYSXGFto/m/OzzK-CkGAwAJ
Please ignore my .gitlab-ci.yml. That's just an internal change that I got uploaded by mistake.
I am looking to see this through and start discussion on this with the goal of landing it.
Initial implementation of reference types in the WebAssembly backend
Jul 27 2020
I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug?
Jul 10 2020
Oct 19 2017
Was this ever fixed and reapplied? The last I can find on this was r313057 where @rob.lougher reverted r313047.
I should point out that r289661, which is part of the 8 patches, does not show up in the review commit list.
Mar 16 2017
Mar 14 2017
Added missing testcase to previous patch.
@efriedma I have uploaded a new patch taking your comments into consideration and rebased on most recent clang sources.
Thanks for the comments.
Mar 13 2017
Apologies for leaving this for so long. Are there any further comments?
How do we get this upstream given I don't have commit rights?
Jan 22 2017
Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delay in submitting this.
Jan 13 2017
Ah no, my mistake. I had the patch applied when I ran the test.
Has this been fixed upstream already?
Jan 10 2017
Apologies for the delay over the holiday season, I will look into this later on after office hours.
Dec 15 2016
Can someone please take a look at this one?
This is not supposed to be marked as accepted.
Abandoning this revision.
Please refer to the new one: https://reviews.llvm.org/D27800
@efriedma Here's the new patch, thanks for your help getting here.
Dec 9 2016
OK, with a lot of help from @eli.friedman I have now a fix. Shall I reuse this review by submitting a new diff or open a new one?
Nov 18 2016
Apologies if I am being shallow and wasting your time but sizeof(T::m) doesn't compile at the moment with clang trunk. Using the same service you used before.
Oct 28 2016
To the reviewers:
I believe there's a better way to handle this. However, I would like to know if this approach is a good one or the reviewers find that there's a much better way to do this and I took it in the wrong direction.