Page MenuHomePhabricator

peterwaller-arm (Peter Waller)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 20 2019, 2:39 AM (105 w, 1 d)

Recent Activity

Tue, Jun 22

peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
Tue, Jun 22, 3:29 AM · Restricted Project

Mon, Jun 21

peterwaller-arm accepted D104643: [AArch64][SVE] Add missing target require to test.
Mon, Jun 21, 7:35 AM · Restricted Project

Thu, Jun 17

peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
Thu, Jun 17, 1:23 PM · Restricted Project
peterwaller-arm added inline comments to D104217: [AArch64][SVE] Add support for fixed length MSCATTER/MGATHER.
Thu, Jun 17, 3:43 AM · Restricted Project
peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
Thu, Jun 17, 3:13 AM · Restricted Project
peterwaller-arm added a comment to D104217: [AArch64][SVE] Add support for fixed length MSCATTER/MGATHER.

Mostly nits -- looks like it needs a rebase.

Thu, Jun 17, 2:06 AM · Restricted Project

Wed, May 26

peterwaller-arm updated the diff for D103170: [CodeGen][AArch64][SVE] Use ld1r[bhsd] for vector splat from memory.
  • Protect against values living on the stack. Intend to introduce this later.
Wed, May 26, 9:08 AM · Restricted Project
peterwaller-arm updated the diff for D103170: [CodeGen][AArch64][SVE] Use ld1r[bhsd] for vector splat from memory.
  • Fix nxv2f64: uimm6s{4 => 8}
Wed, May 26, 8:36 AM · Restricted Project
peterwaller-arm requested review of D103170: [CodeGen][AArch64][SVE] Use ld1r[bhsd] for vector splat from memory.
Wed, May 26, 8:20 AM · Restricted Project

May 24 2021

peterwaller-arm abandoned D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

Abandoning this for now. If the test is failing in this manner it is noticeable.

May 24 2021, 6:36 AM
peterwaller-arm accepted D102777: [AArch64][SVE] Add fixed length codegen for FP_TO_{S,U}INT/{S,U}INT_TO_FP.

LGTM. Optional nit.

May 24 2021, 3:05 AM · Restricted Project

May 20 2021

peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
May 20 2021, 12:33 PM · Restricted Project
peterwaller-arm accepted D102607: [AArch64][SVE] Add fixed length codegen for FP_ROUND/FP_EXTEND.
May 20 2021, 9:30 AM · Restricted Project
peterwaller-arm planned changes to D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

I'll revisit this next week to find a way of inhibiting the test for now, or abandon it.

May 20 2021, 9:29 AM
peterwaller-arm committed rG2d574a110440: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z} (authored by peterwaller-arm).
[CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}
May 20 2021, 9:23 AM
peterwaller-arm closed D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}.
May 20 2021, 9:23 AM · Restricted Project, Restricted Project
peterwaller-arm added a reviewer for D102842: [Verifier] Fail on invalid indices for {insert,extract} vector intrinsics: peterwaller-arm.
May 20 2021, 7:26 AM · Restricted Project
peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
May 20 2021, 4:08 AM · Restricted Project
peterwaller-arm added inline comments to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.
May 20 2021, 2:24 AM · Restricted Project
peterwaller-arm added a comment to D102766: [SelectionDAG] Implement PromoteIntRes_INSERT_SUBVECTOR.

Some suggestions.

May 20 2021, 1:56 AM · Restricted Project

May 19 2021

peterwaller-arm accepted D102765: [SelectionDAG] Add stub implementation of ReplaceInsertSubVectorResults.
May 19 2021, 8:21 AM · Restricted Project
peterwaller-arm accepted D102699: [InstSimplify] Properly constrain {insert,extract}_subvector intrinsic fold.

LGTM, but I missed the issue on the first iteration so please wait for a second accept.

May 19 2021, 7:52 AM · Restricted Project
peterwaller-arm accepted D102607: [AArch64][SVE] Add fixed length codegen for FP_ROUND/FP_EXTEND.
May 19 2021, 7:48 AM · Restricted Project
peterwaller-arm updated the diff for D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}.
  • Move test per review comment.
  • Update ACLE test.
  • Rebase.
May 19 2021, 5:58 AM · Restricted Project, Restricted Project
peterwaller-arm closed D102617: [llvm][AArch64][SVE] Model FFR-using intrinsics with inaccessiblemem.

Committed in rGfd4ef793ea54.

May 19 2021, 5:54 AM · Restricted Project
peterwaller-arm committed rGfd4ef793ea54: [llvm][AArch64][SVE] Model FFR-using intrinsics with inaccessiblemem (authored by peterwaller-arm).
[llvm][AArch64][SVE] Model FFR-using intrinsics with inaccessiblemem
May 19 2021, 5:50 AM
peterwaller-arm added a comment to D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

Until the bug is fixed, this test cannot be re-enabled as a flaky test is worse than no test at all.

May 19 2021, 1:16 AM

May 18 2021

peterwaller-arm added a reviewer for D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output: aemerson.
May 18 2021, 10:14 AM
peterwaller-arm updated subscribers of D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

It was disabled here: https://github.com/llvm/llvm-test-suite/commit/87d67af9d8565d068b6706c081b7ae07addcb882

Is the underlying issue definitely fixed?

May 18 2021, 10:10 AM
peterwaller-arm accepted D102605: [CodeGen] Add support for widening the result of EXTRACT_SUBVECTOR.
May 18 2021, 7:48 AM · Restricted Project
peterwaller-arm updated the summary of D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.
May 18 2021, 7:11 AM
peterwaller-arm requested review of D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.
May 18 2021, 7:10 AM

May 17 2021

peterwaller-arm requested review of D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}.
May 17 2021, 7:13 AM · Restricted Project, Restricted Project
peterwaller-arm added reviewers for D102617: [llvm][AArch64][SVE] Model FFR-using intrinsics with inaccessiblemem: kmclaughlin, awarzynski, sdesmalen, paulwalker-arm, bsmith.
May 17 2021, 5:48 AM · Restricted Project
peterwaller-arm requested review of D102617: [llvm][AArch64][SVE] Model FFR-using intrinsics with inaccessiblemem.
May 17 2021, 5:46 AM · Restricted Project

May 13 2021

peterwaller-arm abandoned D102330: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs for RDFFR_P.

I plan to follow this up early next week with an alternative approach.

May 13 2021, 9:10 AM · Restricted Project

May 12 2021

peterwaller-arm planned changes to D102330: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs for RDFFR_P.
May 12 2021, 8:53 AM · Restricted Project
peterwaller-arm updated the diff for D102330: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs for RDFFR_P.

Run clang-format.

May 12 2021, 8:08 AM · Restricted Project
peterwaller-arm requested review of D102330: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs for RDFFR_P.
May 12 2021, 8:05 AM · Restricted Project
peterwaller-arm accepted D101820: [AArch64][SVE] Extend svdup->insertelement instcombine pattern to support ....
May 12 2021, 7:24 AM · Restricted Project
peterwaller-arm accepted D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains.
May 12 2021, 7:22 AM · Restricted Project, Restricted Project
peterwaller-arm accepted D101833: [AArch64][SVE] Fix missed immediate selection due to mishandling of signedness.
May 12 2021, 7:11 AM · Restricted Project
peterwaller-arm committed rG3fa6510f6ea0: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for… (authored by peterwaller-arm).
[CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for…
May 12 2021, 7:07 AM
peterwaller-arm closed D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
May 12 2021, 7:06 AM · Restricted Project
peterwaller-arm updated the diff for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.

Drop redundant same-bb check.

May 12 2021, 5:53 AM · Restricted Project
peterwaller-arm added a comment to D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.

Found and fixed additional bug here.

May 12 2021, 4:31 AM · Restricted Project
peterwaller-arm updated the diff for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
  • Update for code review
  • Factor loop with pre-existing areCFlagsAccessedBetweenInstrs.
  • Add test case for flags used between Pred and PTest, and fix bug where this was not covered.
May 12 2021, 4:28 AM · Restricted Project
peterwaller-arm committed rG6e6f9a636b19: [AArch64][SVE] Improve sve.convert.to.svbool lowering (authored by peterwaller-arm).
[AArch64][SVE] Improve sve.convert.to.svbool lowering
May 12 2021, 2:58 AM
peterwaller-arm closed D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.
May 12 2021, 2:58 AM · Restricted Project
peterwaller-arm updated the diff for D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.

Update for review comments.

May 12 2021, 2:54 AM · Restricted Project

May 11 2021

peterwaller-arm updated the diff for D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.

Fix wrong indentation.

May 11 2021, 5:31 AM · Restricted Project
peterwaller-arm updated the diff for D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.

Push updates missed out due to an error of mine on the last run.

  • Address review comments.
  • Use update_llc_test_checks to generate tests.
May 11 2021, 4:35 AM · Restricted Project
peterwaller-arm abandoned D102227: [CodeGen][AArch64][SVE] Substitute [rdffr, ptest] => rdffrs.

Apologies for the spam. Again, wrong revision because the commit message got stamped with it. :facepalm:

May 11 2021, 4:19 AM · Restricted Project
peterwaller-arm updated the diff for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.

Update commit message.

May 11 2021, 4:19 AM · Restricted Project
peterwaller-arm updated the diff for D102227: [CodeGen][AArch64][SVE] Substitute [rdffr, ptest] => rdffrs.

Update commit message.

May 11 2021, 4:18 AM · Restricted Project
peterwaller-arm abandoned D102227: [CodeGen][AArch64][SVE] Substitute [rdffr, ptest] => rdffrs.

Accidental dupe of D101357 due to arc diff not doing what I expected.

May 11 2021, 4:02 AM · Restricted Project
peterwaller-arm requested review of D102227: [CodeGen][AArch64][SVE] Substitute [rdffr, ptest] => rdffrs.
May 11 2021, 4:01 AM · Restricted Project

May 6 2021

peterwaller-arm updated the diff for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
  • Update for code review.
  • Drop RDFFR_P - harder than I thought, for a later patch.
May 6 2021, 5:58 AM · Restricted Project
peterwaller-arm updated the diff for D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.
  • Address review comments.
  • Use update_llc_test_checks to generate tests.
May 6 2021, 5:45 AM · Restricted Project
peterwaller-arm added inline comments to D101062: [AArch64][SVE] Better utilisation of unpredicated forms of arithmetic intrinsics.
May 6 2021, 3:31 AM · Restricted Project
peterwaller-arm added inline comments to D101833: [AArch64][SVE] Fix missed immediate selection due to mishandling of signedness.
May 6 2021, 3:20 AM · Restricted Project
peterwaller-arm added inline comments to D101820: [AArch64][SVE] Extend svdup->insertelement instcombine pattern to support ....
May 6 2021, 3:19 AM · Restricted Project
peterwaller-arm added inline comments to D101062: [AArch64][SVE] Better utilisation of unpredicated forms of arithmetic intrinsics.
May 6 2021, 3:01 AM · Restricted Project

May 4 2021

peterwaller-arm added a comment to D101834: [llvm][sve] Lowering for VLS MLOAD/MSTORE.

Disclosure: I had a hand in writing an early draft of a small part of this, so should definitely not be the only reviewer.

May 4 2021, 7:46 AM · Restricted Project
peterwaller-arm added inline comments to D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
May 4 2021, 3:39 AM · Restricted Project

Apr 29 2021

peterwaller-arm requested review of D101544: [AArch64][SVE] Improve sve.convert.to.svbool lowering.
Apr 29 2021, 9:28 AM · Restricted Project

Apr 28 2021

peterwaller-arm added a comment to D101294: [LoopVectorize] Fix scalarisation crash in widenPHIInstruction for scalable vectors.

I've reviewed what's in-diff in detail, I've run and looked at the code and it makes sense to me in as much as I understand it. However, I have little experience here so I will defer acceptance to someone else for now.

Apr 28 2021, 7:35 AM · Restricted Project
peterwaller-arm accepted D101302: [AArch64][SVE] Move convert.{from,to}.svbool optimization into InstCombine.
Apr 28 2021, 3:55 AM · Restricted Project
peterwaller-arm accepted D101169: [AArch64][SVE] Use SIMD variant of INSR when scalar is the result of a vector extract.
Apr 28 2021, 1:41 AM · Restricted Project

Apr 27 2021

peterwaller-arm requested changes to D101302: [AArch64][SVE] Move convert.{from,to}.svbool optimization into InstCombine.

Couple of things which look like they need tidying up.

Apr 27 2021, 9:22 AM · Restricted Project
peterwaller-arm added inline comments to D101369: [AArch64][SVE] Fold insert(zero, extract(X, 0), 0) -> X, when X is known to zero lanes 1-N.
Apr 27 2021, 9:00 AM · Restricted Project
peterwaller-arm accepted D101369: [AArch64][SVE] Fold insert(zero, extract(X, 0), 0) -> X, when X is known to zero lanes 1-N.

LGTM, modulo nit.

Apr 27 2021, 8:58 AM · Restricted Project
peterwaller-arm updated the diff for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.

Fix clang-format issues.

Apr 27 2021, 6:37 AM · Restricted Project
peterwaller-arm added reviewers for D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr: joechrisellis, bsmith, paulwalker-arm, kmclaughlin.
Apr 27 2021, 5:56 AM · Restricted Project
peterwaller-arm requested review of D101357: [CodeGen][AArch64][SVE] Fold [rdffr, ptest] => rdffrs; bugfix for optimizePTestInstr.
Apr 27 2021, 5:55 AM · Restricted Project

Apr 21 2021

peterwaller-arm accepted D100961: [AArch64] Block tryCombineToBSL combines for vectors wider than NEON.
Apr 21 2021, 9:34 AM · Restricted Project

Mar 31 2021

peterwaller-arm accepted D99265: [AArch64][SVE] Add tests for UREM/SREM using fixed SVE types.
Mar 31 2021, 7:54 AM · Restricted Project
peterwaller-arm added a reviewer for D99569: [LoopVectorize] Fix bug where predicated loads/stores were dropped: gilr.
Mar 31 2021, 7:53 AM · Restricted Project
peterwaller-arm added inline comments to D99569: [LoopVectorize] Fix bug where predicated loads/stores were dropped.
Mar 31 2021, 5:53 AM · Restricted Project
peterwaller-arm resigned from D90162: [llvm][AArch64] Prevent spurious zero extension..
Mar 31 2021, 2:20 AM · Restricted Project
peterwaller-arm accepted D99192: [NFC] Add tests for scalable vectorization of loops with large stride acesses.

LGTM.

Mar 31 2021, 2:07 AM · Restricted Project

Mar 30 2021

peterwaller-arm accepted D99418: [AArch64][SVE] Improve codegen for select nodes with fixed types.
Mar 30 2021, 7:04 AM · Restricted Project
peterwaller-arm added inline comments to D99418: [AArch64][SVE] Improve codegen for select nodes with fixed types.
Mar 30 2021, 5:58 AM · Restricted Project

Mar 29 2021

peterwaller-arm accepted D98496: [AArch64][SVE] Lower fixed length INSERT_VECTOR_ELT.
Mar 29 2021, 2:09 AM · Restricted Project

Mar 18 2021

peterwaller-arm committed rG0d6482a76add: [llvm][AArch64][SVE] Lower fixed length vector fabs (authored by peterwaller-arm).
[llvm][AArch64][SVE] Lower fixed length vector fabs
Mar 18 2021, 10:21 AM
peterwaller-arm closed D98434: [llvm][AArch64][SVE] Lower fixed length vector fabs.
Mar 18 2021, 10:21 AM · Restricted Project
peterwaller-arm accepted D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary.
Mar 18 2021, 3:18 AM · Restricted Project

Mar 16 2021

peterwaller-arm accepted D98033: [AArch64][SVEIntrinsicOpts] Factor out redundant SVE mul/fmul intrinsics.

LGTM modulo nit.

Mar 16 2021, 3:29 AM · Restricted Project
peterwaller-arm added a comment to D98690: [AArch64][SVE] Test more types in sve-fixed-length-subvector.ll.

I think this needs a closer look at the CHECK labels - I see 'CHECK_GE' used where I think 'VBITS_GE' is intended. Also, 'CHECKT', which I take it is not intended.

Mar 16 2021, 3:20 AM · Restricted Project

Mar 11 2021

peterwaller-arm added a comment to D98435: [LoopVectorize] Add strict in-order reduction support for fixed-width vectorization.

Some minor nits. Ran out of time for a more thorough review at this moment.

Mar 11 2021, 10:17 AM · Restricted Project
peterwaller-arm requested review of D98434: [llvm][AArch64][SVE] Lower fixed length vector fabs.
Mar 11 2021, 9:46 AM · Restricted Project

Mar 8 2021

peterwaller-arm added inline comments to D98030: [IR] Add vscale_range IR function attribute.
Mar 8 2021, 9:47 AM · Restricted Project, Restricted Project
peterwaller-arm added inline comments to D98033: [AArch64][SVEIntrinsicOpts] Factor out redundant SVE mul/fmul intrinsics.
Mar 8 2021, 4:57 AM · Restricted Project

Mar 4 2021

peterwaller-arm added inline comments to D97858: [AArch64][SVE] Fold vector ZExt/SExt into gather loads where possible.
Mar 4 2021, 1:58 AM · Restricted Project

Feb 8 2021

peterwaller-arm abandoned D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf.

Release note upstream on release/12.x branch in rGbc2dad1671598a87423c61c355d03db49ce76907.

Feb 8 2021, 2:12 AM · Restricted Project

Jan 28 2021

peterwaller-arm added a reviewer for D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf: tstellar.
Jan 28 2021, 3:48 AM · Restricted Project

Jan 26 2021

peterwaller-arm requested review of D95435: [clang][aarch64][WOA64][docs] Release note for longjmp crash with /guard:cf.
Jan 26 2021, 3:59 AM · Restricted Project

Jan 11 2021

peterwaller-arm accepted D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate.
Jan 11 2021, 12:33 PM · Restricted Project, Restricted Project
peterwaller-arm added a comment to D94230: [AArch64][SVE] Coalesce ptrue instrinsic calls where possible.

I'd like to see one-liner comments on each test explaining the spirit of what is being tested.

Jan 11 2021, 9:21 AM · Restricted Project
peterwaller-arm added inline comments to D94230: [AArch64][SVE] Coalesce ptrue instrinsic calls where possible.
Jan 11 2021, 4:00 AM · Restricted Project