Page MenuHomePhabricator

pattop (Patrick Oppenlander)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2021, 4:31 PM (5 w, 1 d)

Recent Activity

Wed, Feb 17

pattop added a comment to D96574: libcxxabi: add builtins to dynamic library link.

Patrick Oppenlander <patrick.oppenlander@gmail.com>

Wed, Feb 17, 2:06 PM · Restricted Project
pattop added a comment to D96574: libcxxabi: add builtins to dynamic library link.

I don't have commit access so someone else will need to commit.

Wed, Feb 17, 1:24 PM · Restricted Project

Thu, Feb 11

pattop requested review of D96574: libcxxabi: add builtins to dynamic library link.
Thu, Feb 11, 8:10 PM · Restricted Project

Mon, Feb 8

pattop updated the diff for D95199: [ELF] Write output sections in PT_LOAD segment order.

Thanks for the feedback!

Mon, Feb 8, 9:22 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Write output sections in PT_LOAD segment order.
Mon, Feb 8, 3:22 PM · Restricted Project

Thu, Feb 4

pattop updated the diff for D95199: [ELF] Write output sections in PT_LOAD segment order.

Maintain section address order as much as possible when assigning file offsets.

Thu, Feb 4, 9:42 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Write output sections in PT_LOAD segment order.
Thu, Feb 4, 9:35 PM · Restricted Project

Mon, Feb 1

pattop updated the diff for D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Use smaller address in test case.

Mon, Feb 1, 2:53 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

Thanks for the update, I'll try and take a look later in the week. Will have to have a think about the zero size section case. If we haven't assigned it to a PT_LOAD and it defines no symbol it may be possible to not put it in the object file.

Mon, Feb 1, 2:19 PM · Restricted Project

Sun, Jan 31

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I can think of a few times I've encountered this on nommu targets. Some examples:

Sun, Jan 31, 10:44 PM · Restricted Project
pattop updated the diff for D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Use a smaller address in test case. This means that if something goes wrong we don't try to make a huge file.

Sun, Jan 31, 9:15 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

Not sure why my comments were automatically marked as done.

Sun, Jan 31, 8:42 PM · Restricted Project
pattop updated the diff for D95199: [ELF] Write output sections in PT_LOAD segment order.

Updated comments.
Add assertion that all sections in a load segment must be allocated.
Fix tbss.s test case.

Sun, Jan 31, 8:40 PM · Restricted Project
pattop added inline comments to D95199: [ELF] Write output sections in PT_LOAD segment order.
Sun, Jan 31, 8:22 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

Thanks for taking the time to review.

Sun, Jan 31, 7:19 PM · Restricted Project
pattop added inline comments to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.
Sun, Jan 31, 2:23 PM · Restricted Project

Thu, Jan 28

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I've also found no good reason why BFD ld forces the program headers to reside in the first PT_LOAD segment. This change was based on that logic.

Thu, Jan 28, 5:08 PM · Restricted Project
pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I agree that the description could be better. Looks like I fixated on the "could not allocate headers" error message when I wrote it.

Thu, Jan 28, 5:01 PM · Restricted Project

Jan 27 2021

pattop added a comment to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

I forgot to mention that I do not have commit access. If this is acceptable someone else will need to commit on my behalf. Thanks again.

Jan 27 2021, 4:28 PM · Restricted Project
pattop added a comment to D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.

Yes, this came from a real use case.

Jan 27 2021, 4:24 PM · Restricted Project
pattop requested review of D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty.
Jan 27 2021, 3:35 PM · Restricted Project

Jan 26 2021

pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

I'm not clear on what the requirements are here.

Jan 26 2021, 3:04 PM · Restricted Project

Jan 23 2021

pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.

Both this patch and D95198 look a bit arbitrary to me. Please see my question in D95198. Also adding @grimar who has improved linker scripts a lot.

Jan 23 2021, 12:28 AM · Restricted Project
pattop added a comment to D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.

Thankyou for taking the time to review and comment.

Jan 23 2021, 12:03 AM · Restricted Project

Jan 21 2021

pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.

Jan 21 2021, 9:49 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

If the direction of the patch is acceptable I can provide a detailed analysis of each required testcase adjustment.

Jan 21 2021, 9:39 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

For out-of-order-sections.s, you could just swap foo and bar.

Jan 21 2021, 9:36 PM · Restricted Project
pattop requested review of D95199: [ELF] Write output sections in PT_LOAD segment order.
Jan 21 2021, 7:04 PM · Restricted Project
pattop requested review of D95198: [ELF] Fix program header alloc when first PT_LOAD is not at lowest VMA.
Jan 21 2021, 7:03 PM · Restricted Project