User Details
- User Since
- Nov 4 2019, 4:38 AM (64 w, 2 d)
Mon, Jan 18
Addressed comments:
- Use shouldUpdateCallSiteInfo() predicate
- Use ToErase->eraseFromParent()
- Reduce function attributes in test
Thu, Jan 14
Dec 9 2020
Dec 3 2020
- Move implementation to DwarfDebug
- Update tests to check DWARF
Dec 2 2020
Jun 17 2020
May 29 2020
@dstenb Thanks for the review. Any additional comments?
May 25 2020
Address comment - delaySlotSupported change.
Compress test-CHECK-lines.
Clang format.
May 22 2020
Address comments.
Rebase.
May 21 2020
Capture "&" instead of "this" in delaySlotSupported lambda.
Address comments.
Change of delay slot guard - use assertions instead of target check.
Address comments.
Transform lambda
nextInstrInterpret
into static function
interpretNextInstr
May 15 2020
Address comment - spelling.
Rebase.
May 14 2020
Address comments:
- tests changes
- patch summary update
May 12 2020
Address comment.
Tests update - use only one !DILocation per scope.
May 11 2020
The main purpose of the "delay slot guard" is to ensure that call_site DIE won't be created for call with delay slot, because it could have incorrect "return PC" value (DW_AT_low_pc, DW_AT_call_return_pc).
This will happen if the call and its delay slot instruction are not in the expected order.
May 4 2020
Address comment.
Apr 28 2020
Address comments.
Apr 24 2020
Merging into https://reviews.llvm.org/D78105.
Address comment.
Add changes from https://reviews.llvm.org/D78104.
Apr 23 2020
Address comments.
@dstenb
Thanks for the review.
I agree with all suggestions.