Page MenuHomePhabricator

nickwasmer (Nick Lewycky)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2019, 3:29 PM (85 w, 2 d)

Recent Activity

Mon, Apr 19

nickwasmer added a comment to D99362: Verify the LLVMContext for Attributes..

The compile time regression fix is up for review at https://reviews.llvm.org/D100738 .

Mon, Apr 19, 1:58 PM · Restricted Project

Sun, Apr 18

nickwasmer added inline comments to D99362: Verify the LLVMContext for Attributes..
Sun, Apr 18, 9:15 PM · Restricted Project
nickwasmer requested review of D100738: Cache attribute checks.
Sun, Apr 18, 9:02 PM · Restricted Project

Thu, Apr 15

nickwasmer added a comment to D99362: Verify the LLVMContext for Attributes..

Is hasParentContext(LLVMContext &C) an acceptable name for what it does? Is there a better one?

Thu, Apr 15, 4:22 PM · Restricted Project

Thu, Apr 8

nickwasmer added a comment to D99362: Verify the LLVMContext for Attributes..

Ping!

Thu, Apr 8, 12:52 PM · Restricted Project

Fri, Apr 2

nickwasmer added a comment to D99362: Verify the LLVMContext for Attributes..

Other than it not being "const" is there any reason you couldn't use FindNodeOrInsertPos to implement contains?

Fri, Apr 2, 2:48 PM · Restricted Project
nickwasmer updated the summary of D99362: Verify the LLVMContext for Attributes..
Fri, Apr 2, 2:48 PM · Restricted Project
nickwasmer updated the summary of D99362: Verify the LLVMContext for Attributes..
Fri, Apr 2, 2:48 PM · Restricted Project
nickwasmer updated the diff for D99362: Verify the LLVMContext for Attributes..
Fri, Apr 2, 2:48 PM · Restricted Project
nickwasmer added a comment to D99362: Verify the LLVMContext for Attributes..

This patch includes a change to FoldingSet. Does it make sense for FoldingSet to have a Contains() method? Was it previously missing because we didn't need it yet, or was it missing because not having it makes for a better API? Should that be broken out into its own patch or

Fri, Apr 2, 9:07 AM · Restricted Project
nickwasmer updated the summary of D99362: Verify the LLVMContext for Attributes..
Fri, Apr 2, 9:07 AM · Restricted Project

Mon, Mar 29

nickwasmer added a comment to D99382: Add -disable-verify flag to llvm-link..

How about a test like llvm/test/LTO/X86/strip-debug-info.ll? Could something similar be done to test llvm-link?

Mon, Mar 29, 9:43 AM · Restricted Project

Thu, Mar 25

nickwasmer updated the diff for D99362: Verify the LLVMContext for Attributes..

Apply clang-format suggestions, mostly just silence clang-tidy suggestions.

Thu, Mar 25, 5:06 PM · Restricted Project
nickwasmer updated the diff for D99382: Add -disable-verify flag to llvm-link..

Apply clang-format suggestion.

Thu, Mar 25, 4:33 PM · Restricted Project
nickwasmer requested review of D99382: Add -disable-verify flag to llvm-link..
Thu, Mar 25, 2:53 PM · Restricted Project
nickwasmer requested review of D99362: Verify the LLVMContext for Attributes..
Thu, Mar 25, 11:34 AM · Restricted Project

Wed, Mar 24

nickwasmer requested review of D99289: Verify that MDNodes belong to the same context as the Module..
Wed, Mar 24, 11:58 AM · Restricted Project

Mar 16 2021

nickwasmer added inline comments to D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..
Mar 16 2021, 12:00 PM · Restricted Project
nickwasmer added a comment to D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

I'm not sure about the intended usage for these APIs, but this looks like a straightforward extension of the existing functionality.

Mar 16 2021, 11:56 AM · Restricted Project

Mar 15 2021

nickwasmer updated the diff for D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

Rebase on top of main after landing the formatting changes separately.

Mar 15 2021, 2:30 PM · Restricted Project

Mar 12 2021

nickwasmer updated the diff for D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

Fix clang-tidy-diff complaints from the builder.

Mar 12 2021, 12:08 PM · Restricted Project
nickwasmer updated the diff for D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

Phab mangled my patch from:

index 96d3672647e8..8d0e06a62d36 100644
--- llvm/unittests/IR/ConstantsTest.cpp
+++ llvm/unittests/IR/ConstantsTest.cpp
@@ -1,717 +1,725 @@

to

diff --git a/llvm/unittests/IR/ConstantsTest.cpp b/unittests/IR/ConstantsTest.cpp
--- a/llvm/unittests/IR/ConstantsTest.cpp
+++ b/unittests/IR/ConstantsTest.cpp
@@ -23,11 +23,11 @@

breaking the build.

Mar 12 2021, 9:53 AM · Restricted Project

Mar 10 2021

nickwasmer updated the diff for D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

Remove one blank line pointed out by clang-format.

Mar 10 2021, 1:46 PM · Restricted Project
nickwasmer updated the diff for D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..

Apply formatting changes raised by "llvm-premerge-checks".

Mar 10 2021, 12:11 PM · Restricted Project

Mar 9 2021

nickwasmer requested review of D98302: Add ConstantDataVector::getRaw() to create a constant data vector from raw data..
Mar 9 2021, 3:49 PM · Restricted Project

Jun 22 2020

nickwasmer abandoned D82349: Use LLVMGetTypeByName2 in llvm-c-test echo test too..
Jun 22 2020, 11:04 PM · Restricted Project, Restricted Project
nickwasmer created D82349: Use LLVMGetTypeByName2 in llvm-c-test echo test too..
Jun 22 2020, 11:04 PM · Restricted Project, Restricted Project

Jun 9 2020

nickwasmer added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

Ping!

Jun 9 2020, 12:07 PM · Restricted Project, Restricted Project

Jun 1 2020

nickwasmer added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

Ping!

Jun 1 2020, 11:18 AM · Restricted Project, Restricted Project

May 26 2020

nickwasmer added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

Ping!

May 26 2020, 1:38 PM · Restricted Project, Restricted Project

May 18 2020

nickwasmer added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

Ping!

May 18 2020, 3:12 PM · Restricted Project, Restricted Project

May 7 2020

nickwasmer added a comment to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..

Ping!

May 7 2020, 9:40 PM · Restricted Project, Restricted Project

Apr 30 2020

nickwasmer added inline comments to D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter..
Apr 30 2020, 11:47 AM · Restricted Project, Restricted Project

Sep 25 2019

nickwasmer added a comment to D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..

Ping!

Sep 25 2019, 2:17 PM · Restricted Project

Sep 18 2019

nickwasmer added inline comments to D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..
Sep 18 2019, 5:22 PM · Restricted Project

Sep 17 2019

nickwasmer updated the diff for D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..

Added tests.

Sep 17 2019, 4:42 PM · Restricted Project

Sep 10 2019

nickwasmer added a comment to D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..

Ping! It's been 1 week since I sent out this patch.

Sep 10 2019, 11:46 AM · Restricted Project

Sep 6 2019

nickwasmer updated the summary of D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..
Sep 6 2019, 1:53 PM · Restricted Project
nickwasmer updated the diff for D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..

Add the ability to update ordering on atomicrmw and fence.

Sep 6 2019, 1:49 PM · Restricted Project

Sep 3 2019

nickwasmer created D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API..
Sep 3 2019, 3:37 PM · Restricted Project