Page MenuHomePhabricator

muiez (Muiez Ahmed)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2020, 8:30 AM (24 w, 6 d)

Recent Activity

Wed, Apr 14

muiez updated the diff for D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Clang tidy

Wed, Apr 14, 11:59 AM · Restricted Project
muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Ping (ready for new round of review, FYI @ldionne)

Wed, Apr 14, 11:16 AM · Restricted Project
muiez updated the diff for D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Added missing functions under LLVM license (FYI: implementations are similar to those in libcxx/src/support/win32/support.cpp).

Wed, Apr 14, 11:14 AM · Restricted Project

Fri, Mar 26

muiez committed rG7e0cc45ced23: [SystemZ][z/OS] Save strings for CC_PRINT env vars (authored by SeanP).
[SystemZ][z/OS] Save strings for CC_PRINT env vars
Fri, Mar 26, 1:39 PM
muiez closed D98554: Save strings for CC_PRINT env vars.
Fri, Mar 26, 1:39 PM · Restricted Project

Wed, Mar 24

muiez added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Wed, Mar 24, 1:41 PM · Restricted Project, Restricted Project

Tue, Mar 23

muiez committed rGf46c41febb88: [SystemZ][z/OS] fix lit test related to alignment (authored by NancyWang2222).
[SystemZ][z/OS] fix lit test related to alignment
Tue, Mar 23, 10:16 AM
muiez closed D98793: [SystemZ][z/OS] fix lit test related to alignment .
Tue, Mar 23, 10:16 AM · Restricted Project

Mon, Mar 22

muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Ping. Do you see a solution or should I revert this?

Mon, Mar 22, 1:55 PM · Restricted Project

Mar 18 2021

muiez committed rGf6af5efcec41: [SystemZ][z/OS] vasprintf fix libc++ (authored by muiez).
[SystemZ][z/OS] vasprintf fix libc++
Mar 18 2021, 12:01 PM
muiez closed D97473: [SystemZ][z/OS] vasprintf fix libc++.
Mar 18 2021, 12:01 PM · Restricted Project

Mar 16 2021

muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

@ldionne, then something needs to be done with support/solaris that has almost the same license, no?
https://github.com/llvm/llvm-project/tree/main/libcxx/src/support/solaris

Yes indeed, I believe those would need to be LLVM licensed. Those support files were added back in 2012 and there's a README explaining it (https://github.com/llvm/llvm-project/blob/main/libcxx/src/support/solaris/README), so I'm not sure what the thought was at the time.

However, regarding new contributions at least, the LLVM developer policy is pretty clear about what licensing is acceptable: https://llvm.org/docs/DeveloperPolicy.html#copyright-license-and-patents.

Mar 16 2021, 11:51 AM · Restricted Project

Mar 15 2021

muiez added a comment to D97473: [SystemZ][z/OS] vasprintf fix libc++.

@ldionne May we get a review please? Thanks

Mar 15 2021, 10:53 AM · Restricted Project
muiez committed rG62705ee01257: [SystemZ][z/OS] Define _LIBCPP_ELAST (authored by muiez).
[SystemZ][z/OS] Define _LIBCPP_ELAST
Mar 15 2021, 6:26 AM
muiez closed D98541: [SystemZ][z/OS] Define _LIBCPP_ELAST.
Mar 15 2021, 6:25 AM · Restricted Project

Mar 12 2021

muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Sorry for not having said that before, but for the next time please wait for a libc++ group approval before landing.

Mar 12 2021, 1:33 PM · Restricted Project
muiez committed rGfebbf68b423b: [SystemZ][z/OS] Missing wchar functions libc++ (authored by muiez).
[SystemZ][z/OS] Missing wchar functions libc++
Mar 12 2021, 12:41 PM
muiez closed D98207: [SystemZ][z/OS] Missing wchar functions libc++.
Mar 12 2021, 12:41 PM · Restricted Project
muiez requested review of D98541: [SystemZ][z/OS] Define _LIBCPP_ELAST.
Mar 12 2021, 11:16 AM · Restricted Project
muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Ping :)

Mar 12 2021, 9:12 AM · Restricted Project
muiez added reviewers for D98207: [SystemZ][z/OS] Missing wchar functions libc++: curdeius, ldionne.
Mar 12 2021, 9:12 AM · Restricted Project

Mar 9 2021

muiez updated the diff for D98207: [SystemZ][z/OS] Missing wchar functions libc++.

Fixed comment

Mar 9 2021, 6:19 AM · Restricted Project
muiez added a comment to D98207: [SystemZ][z/OS] Missing wchar functions libc++.

If I understand correctly, these are almost the same as the files in support/solaris/ but:

  • without the _l suffix, and hence without the loc parameter
  • calling functions without _l and without loc
  • not calling FIX_LOCALE(loc;)
Mar 9 2021, 6:14 AM · Restricted Project

Mar 8 2021

muiez requested review of D98207: [SystemZ][z/OS] Missing wchar functions libc++.
Mar 8 2021, 11:48 AM · Restricted Project
muiez added a comment to D97473: [SystemZ][z/OS] vasprintf fix libc++.

Ping :) @ldionne

Mar 8 2021, 11:03 AM · Restricted Project
muiez updated the diff for D97473: [SystemZ][z/OS] vasprintf fix libc++.

fix for win32

Mar 8 2021, 10:32 AM · Restricted Project
muiez added a comment to D97473: [SystemZ][z/OS] vasprintf fix libc++.

Any ideas as to why the CI build failed with mainly FileNotFoundError for Apple system? The changes seem unrelated.

Mar 8 2021, 6:30 AM · Restricted Project

Mar 5 2021

muiez updated the diff for D98044: [SystemZ][z/OS] Missing locale functions libc++.

added last dot in comment

Mar 5 2021, 7:45 AM · Restricted Project
muiez updated the diff for D98044: [SystemZ][z/OS] Missing locale functions libc++.

addressed comments

Mar 5 2021, 7:34 AM · Restricted Project
muiez updated the diff for D97473: [SystemZ][z/OS] vasprintf fix libc++.

win32 __libcpp_vasprintf fix

Mar 5 2021, 7:19 AM · Restricted Project
muiez updated the diff for D97473: [SystemZ][z/OS] vasprintf fix libc++.

modify old implementation, formatting

Mar 5 2021, 7:11 AM · Restricted Project
muiez updated the diff for D98044: [SystemZ][z/OS] Missing locale functions libc++.

Coding style addressed

Mar 5 2021, 6:41 AM · Restricted Project
muiez requested review of D98044: [SystemZ][z/OS] Missing locale functions libc++.
Mar 5 2021, 6:27 AM · Restricted Project

Mar 4 2021

muiez added a comment to D97051: [SystemZ][z/OS] Missing non-posix functions libc++.

PS: I do not have commit access. May someone commit the patch? Thanks
The author is: Muiez Ahmed

Mar 4 2021, 6:27 AM · Restricted Project

Mar 1 2021

muiez added a comment to D97051: [SystemZ][z/OS] Missing non-posix functions libc++.

Ping :)

Mar 1 2021, 6:20 AM · Restricted Project

Feb 25 2021

muiez requested review of D97473: [SystemZ][z/OS] vasprintf fix libc++.
Feb 25 2021, 6:49 AM · Restricted Project

Feb 24 2021

muiez added a reviewer for D97051: [SystemZ][z/OS] Missing non-posix functions libc++: ldionne.
Feb 24 2021, 8:17 AM · Restricted Project

Feb 19 2021

muiez requested review of D97051: [SystemZ][z/OS] Missing non-posix functions libc++.
Feb 19 2021, 7:45 AM · Restricted Project

Jan 22 2021

muiez accepted D95246: [test] Use host platform specific error message substitution in lit tests .

LGTM

Jan 22 2021, 9:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 7 2021

muiez accepted D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests .
Jan 7 2021, 8:59 AM · Restricted Project, Restricted Project

Nov 24 2020

muiez accepted D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c.
Nov 24 2020, 1:50 PM · Restricted Project

Nov 18 2020

muiez accepted D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder.
Nov 18 2020, 8:37 AM · Restricted Project

Oct 29 2020

muiez added inline comments to D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS.
Oct 29 2020, 1:11 PM · Restricted Project
muiez updated the diff for D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS.

Removed mbsnrtowcs and wcsnrtombs declarations from libcxx wchar.h. Adding those declarations to the system wchar.h instead.

Oct 29 2020, 1:02 PM · Restricted Project

Oct 28 2020

muiez removed a reviewer for D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS: Restricted Project.
Oct 28 2020, 10:34 AM · Restricted Project
muiez removed a reviewer for D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS: Restricted Project.
Oct 28 2020, 10:31 AM · Restricted Project
muiez requested review of D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS.
Oct 28 2020, 10:31 AM · Restricted Project