Page MenuHomePhabricator

msearles (Mark Searles)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2017, 11:02 AM (195 w, 3 d)

Recent Activity

Sep 10 2020

msearles requested review of D87487: [compiler-rt][cmake] Attempt to fix build race condition.
Sep 10 2020, 4:57 PM · Restricted Project

Feb 27 2020

msearles committed rG7a7b4c9f5fff: merge master into amd-stg-open (authored by msearles).
merge master into amd-stg-open
Feb 27 2020, 9:44 AM
msearles committed rG6c1420c79ef3: merge master into amd-stg-open (authored by msearles).
merge master into amd-stg-open
Feb 27 2020, 9:42 AM
msearles committed rGad3a5ecbab8f: merge master into amd-stg-open (authored by msearles).
merge master into amd-stg-open
Feb 27 2020, 9:42 AM
msearles committed rG2e9bfdfa2ab7: Revert "[clangd] Show hower info for expressions" (authored by msearles).
Revert "[clangd] Show hower info for expressions"
Feb 27 2020, 9:40 AM
msearles added a reverting change for rG4d14bfaa2cb1: [clangd] Show hower info for expressions: rG2e9bfdfa2ab7: Revert "[clangd] Show hower info for expressions".
Feb 27 2020, 9:40 AM
msearles committed rGa846b3468fa2: Merge branch master into amd-stg-open (authored by msearles).
Merge branch master into amd-stg-open
Feb 27 2020, 9:35 AM
Gerrit Code Review <gerritcr@atlvgerritapp03.amd.com> committed rG948e5b572492: Merge "[ELF][AMDGPU] Avoid PT_LOAD to have overlapping p_offset range" into amd… (authored by msearles).
Merge "[ELF][AMDGPU] Avoid PT_LOAD to have overlapping p_offset range" into amd…
Feb 27 2020, 9:27 AM
Gerrit Code Review <gerritcr@atlvgerritapp03.amd.com> committed rGa111a670b38b: Merge "[AMDGPU] Function call support is now enabled by default." into amd… (authored by msearles).
Merge "[AMDGPU] Function call support is now enabled by default." into amd…
Feb 27 2020, 9:13 AM
msearles committed rG1c2db10ee350: [AMDGPU] Function call support is now enabled by default. (authored by msearles).
[AMDGPU] Function call support is now enabled by default.
Feb 27 2020, 9:13 AM
msearles committed rG829e99fd4a70: Revert "Revert "[llvm] Migrate llvm::make_unique to std::make_unique"" (authored by msearles).
Revert "Revert "[llvm] Migrate llvm::make_unique to std::make_unique""
Feb 27 2020, 8:58 AM
msearles committed rG00d8337db8af: Revert "Revert "Replace llvm::integer_sequence and friends with the C++14… (authored by msearles).
Revert "Revert "Replace llvm::integer_sequence and friends with the C++14…
Feb 27 2020, 8:58 AM
msearles committed rG948b62622b0b: Revert "Revert "[Support] Base RWMutex on std::shared_timed_mutex (C++14)"" (authored by msearles).
Revert "Revert "[Support] Base RWMutex on std::shared_timed_mutex (C++14)""
Feb 27 2020, 8:58 AM
msearles committed rG2cbe60ec8c2f: Revert "Revert "[ADT] PointerUnion: Use C++14 constexpr std::min"" (authored by msearles).
Revert "Revert "[ADT] PointerUnion: Use C++14 constexpr std::min""
Feb 27 2020, 8:58 AM
msearles committed rG6fac0f6cb4a0: Revert "Revert "Bump llvm-go to C++14"" (authored by msearles).
Revert "Revert "Bump llvm-go to C++14""
Feb 27 2020, 8:58 AM
msearles committed rG25fbf85b4de1: Revert "Revert "Use std::is_final directly"" (authored by msearles).
Revert "Revert "Use std::is_final directly""
Feb 27 2020, 8:57 AM
msearles committed rGcd5df9ed016c: Revert "Revert "Revert "Un-break the bots""" (authored by msearles).
Revert "Revert "Revert "Un-break the bots"""
Feb 27 2020, 8:57 AM
msearles committed rG33e16ac39aa5: Revert "Revert "Move to C++14"" (authored by msearles).
Revert "Revert "Move to C++14""
Feb 27 2020, 8:57 AM
msearles committed rG7260dd13cf46: Revert "Move to C++14" (authored by msearles).
Revert "Move to C++14"
Feb 27 2020, 8:57 AM
msearles committed rG099b9b1c98a9: Revert "Revert "Un-break the bots"" (authored by msearles).
Revert "Revert "Un-break the bots""
Feb 27 2020, 8:57 AM
msearles committed rGa82734270f5a: Revert "Use std::is_final directly" (authored by msearles).
Revert "Use std::is_final directly"
Feb 27 2020, 8:57 AM
msearles committed rGdc333f38957c: Revert "Bump llvm-go to C++14" (authored by msearles).
Revert "Bump llvm-go to C++14"
Feb 27 2020, 8:56 AM
msearles committed rGb53d67516c26: Revert "[ADT] PointerUnion: Use C++14 constexpr std::min" (authored by msearles).
Revert "[ADT] PointerUnion: Use C++14 constexpr std::min"
Feb 27 2020, 8:56 AM
msearles committed rG04941741d6ad: Revert "[Support] Base RWMutex on std::shared_timed_mutex (C++14)" (authored by msearles).
Revert "[Support] Base RWMutex on std::shared_timed_mutex (C++14)"
Feb 27 2020, 8:56 AM
msearles committed rGbc50d51b0e44: Revert "Replace llvm::integer_sequence and friends with the C++14 standard… (authored by msearles).
Revert "Replace llvm::integer_sequence and friends with the C++14 standard…
Feb 27 2020, 8:56 AM
msearles committed rG034fa6587229: Revert "[llvm] Migrate llvm::make_unique to std::make_unique" (authored by msearles).
Revert "[llvm] Migrate llvm::make_unique to std::make_unique"
Feb 27 2020, 8:56 AM
msearles committed rGa3c731e7c4fc: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 8:56 AM
msearles committed rG5d618ac778a3: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 8:35 AM
msearles added a comment to rG1bfb390a0242: SWDEV-179955 - OpenCL/LC - Merge branch master into amd-master.

Apologies; not sure how this (and similar) was generated. Please ignore.

Feb 27 2020, 8:19 AM
msearles committed rG4a40f759cdaf: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 8:14 AM
msearles committed rG77eda95b7f79: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 7:53 AM
Gerrit Code Review <gerritcr@atlvgerritapp03.amd.com> committed rGbe0db7fb901b: Merge "Revert "Revert "[DAGCombiner] fold add/sub with bool operand based on… (authored by msearles).
Merge "Revert "Revert "[DAGCombiner] fold add/sub with bool operand based on…
Feb 27 2020, 7:50 AM
msearles committed rG5692db3b706e: Revert "Revert "[DAGCombiner] fold add/sub with bool operand based on target's… (authored by msearles).
Revert "Revert "[DAGCombiner] fold add/sub with bool operand based on target's…
Feb 27 2020, 7:50 AM
msearles committed rG5eb86c362130: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:46 AM
msearles committed rG29f91b3c39c9: Revert "[DAGCombiner] fold add/sub with bool operand based on target's boolean… (authored by msearles).
Revert "[DAGCombiner] fold add/sub with bool operand based on target's boolean…
Feb 27 2020, 7:46 AM
msearles committed rGefcc61db9f36: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:33 AM
msearles committed rG2c90cbb81f89: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:24 AM
msearles committed rG66011ec07750: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:23 AM
msearles committed rG4d45abcd0100: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:10 AM
msearles committed rG06202450aabd: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 7:09 AM
Gerrit Code Review <gerritcr@atlswgit02.amd.com> committed rGa57235427f33: Merge "Update for removal of old address space mapping" into amd-common (authored by msearles).
Merge "Update for removal of old address space mapping" into amd-common
Feb 27 2020, 7:02 AM
msearles committed rG4b2250a1438a: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 6:25 AM
msearles committed rG262820c615ea: Merge branch 'amd-master' into amd-common (authored by msearles).
Merge branch 'amd-master' into amd-common
Feb 27 2020, 4:27 AM
msearles committed rG0890f8d555a9: Merge branch 'amd-master' of into amd-common (authored by msearles).
Merge branch 'amd-master' of into amd-common
Feb 27 2020, 4:16 AM
msearles committed rGf2349d8430cb: Revert "Revert "[LLD] Migrate llvm::make_unique to std::make_unique"" (authored by msearles).
Revert "Revert "[LLD] Migrate llvm::make_unique to std::make_unique""
Feb 27 2020, 3:07 AM
msearles committed rG9b5838ca317c: Revert "[LLD] Migrate llvm::make_unique to std::make_unique" (authored by msearles).
Revert "[LLD] Migrate llvm::make_unique to std::make_unique"
Feb 27 2020, 3:07 AM
msearles committed rGef2b758d5381: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 3:07 AM
msearles committed rGf8375d79b6cf: Replace last DEBUG occurrence with LLVM_DEBUG in lld. (authored by Nicola).
Replace last DEBUG occurrence with LLVM_DEBUG in lld.
Feb 27 2020, 2:34 AM
msearles committed rG3849018fee3c: Revert "Revert "Replace llvm::integer_sequence and friends with the C++14… (authored by msearles).
Revert "Revert "Replace llvm::integer_sequence and friends with the C++14…
Feb 27 2020, 1:23 AM
msearles committed rG20201401b17c: Revert "Replace llvm::integer_sequence and friends with the C++14 standard… (authored by msearles).
Revert "Replace llvm::integer_sequence and friends with the C++14 standard…
Feb 27 2020, 1:22 AM
msearles committed rGc0d90cf6e7d3: Revert "[Clang] Migrate llvm::make_unique to std::make_unique" (authored by msearles).
Revert "[Clang] Migrate llvm::make_unique to std::make_unique"
Feb 27 2020, 1:22 AM
msearles committed rG45b4bf4f77dc: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 1:22 AM
msearles committed rG75740eaff356: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 1:13 AM
msearles committed rGdc2cd34ee192: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 1:02 AM
msearles committed rG12e9c0eff47f: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 12:57 AM
msearles committed rG9371957db63b: SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common (authored by msearles).
SWDEV-179954 - OpenCL/LC - Merge branch amd-master into amd-common
Feb 27 2020, 12:55 AM
msearles committed rG15a355d64d20: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 12:44 AM
msearles committed rGcc72e9a8e8cb: Merge branch amd-master into amd-common (authored by msearles).
Merge branch amd-master into amd-common
Feb 27 2020, 12:44 AM

Feb 26 2020

msearles added a comment to D74995: [AMDGPU] Revert 'Don’t marke the .note section as ALLOC'.

TBH, these were Konstantin's findings; he knows the details.

Feb 26 2020, 7:24 AM · Restricted Project, Restricted Project

Feb 21 2020

msearles committed rGd3e170c43886: Revert "[AMDGPU] Don’t marke the .note section as ALLOC" (authored by msearles).
Revert "[AMDGPU] Don’t marke the .note section as ALLOC"
Feb 21 2020, 4:12 PM
msearles added a reverting change for rG977cd661cf01: [AMDGPU] Don’t marke the .note section as ALLOC: rGd3e170c43886: Revert "[AMDGPU] Don’t marke the .note section as ALLOC".
Feb 21 2020, 4:12 PM
msearles closed D74995: [AMDGPU] Revert 'Don’t marke the .note section as ALLOC'.
Feb 21 2020, 4:11 PM · Restricted Project, Restricted Project
msearles added a reverting change for rG977cd661cf01: [AMDGPU] Don’t marke the .note section as ALLOC: D74995: [AMDGPU] Revert 'Don’t marke the .note section as ALLOC'.
Feb 21 2020, 3:53 PM
msearles created D74995: [AMDGPU] Revert 'Don’t marke the .note section as ALLOC'.
Feb 21 2020, 3:53 PM · Restricted Project, Restricted Project

Oct 17 2019

msearles committed rL375161: Request commit access for msearles.
Request commit access for msearles
Oct 17 2019, 1:04 PM

Aug 12 2019

msearles accepted D66115: [AMDGPU] Use PredicateControl in MIMGBaseOpcode. NFC..

LGTM

Aug 12 2019, 3:25 PM · Restricted Project

Jul 11 2019

msearles accepted D64584: [AMDGPU] gfx908 mfma support.

LGTM

Jul 11 2019, 2:09 PM · Restricted Project
msearles accepted D64594: [AMDGPU] gfx908 agpr spilling.

LGTM

Jul 11 2019, 2:08 PM · Restricted Project
msearles accepted D64593: [AMDGPU] gfx908 hazard recognizer.

LGTM

Jul 11 2019, 2:08 PM · Restricted Project
msearles accepted D64590: [AMDGPU] gfx908 scheduling.

LGTM

Jul 11 2019, 2:08 PM · Restricted Project

Jul 10 2019

msearles accepted D64431: [AMDGPU] gfx908 dot instruction support.

LGTM

Jul 10 2019, 4:20 PM · Restricted Project
msearles accepted D64435: [AMDGPU] gfx908 atomic fadd and atomic pk_fadd.

LGTM

Jul 10 2019, 4:18 PM · Restricted Project

Jun 19 2019

msearles accepted D63205: Virtualize TargetInstrInfo::getRegClass().

LGTM

Jun 19 2019, 2:09 PM · Restricted Project

Jun 18 2019

msearles accepted D63506: [AMDGPU] gfx1010 disassembler changes for wave32.

LGTM

Jun 18 2019, 11:33 AM · Restricted Project

Jun 16 2019

msearles accepted D63351: [AMDGPU] gfx10 conditional registers handling.

LGTM

Jun 16 2019, 10:08 AM · Restricted Project

May 13 2019

msearles accepted D61875: [AMDGPU] gfx1010 clang target.

LGTM

May 13 2019, 3:57 PM · Restricted Project

May 3 2019

msearles accepted D61536: [AMDGPU] gfx1010 hazard recognizer.

LGTM

May 3 2019, 7:22 PM · Restricted Project
msearles accepted D61527: [AMDGPU] gfx1010: use fmac instructions.

LGTM

May 3 2019, 7:19 PM · Restricted Project
msearles accepted D61534: [AMDGPU] gfx1010 wait count insertion.

LGTM

May 3 2019, 2:01 PM · Restricted Project
msearles accepted D61531: [AMDGPU] gfx1010 s_code_end generation.

LGTM

May 3 2019, 2:00 PM · Restricted Project
msearles accepted D61529: [AMDGPU] gfx1010 loop alignment.

LGTM

May 3 2019, 1:58 PM · Restricted Project

Apr 26 2019

msearles committed rG76c5b62988ff: Revert "AMDGPU: Split block for si_end_cf" (authored by msearles).
Revert "AMDGPU: Split block for si_end_cf"
Apr 26 2019, 5:51 PM
msearles committed rL359363: Revert "AMDGPU: Split block for si_end_cf".
Revert "AMDGPU: Split block for si_end_cf"
Apr 26 2019, 5:51 PM
msearles closed D61213: [AMDGPU] Revert "AMDGPU: Split block for si_end_cf".
Apr 26 2019, 5:51 PM · Restricted Project, Restricted Project
msearles created D61213: [AMDGPU] Revert "AMDGPU: Split block for si_end_cf".
Apr 26 2019, 2:51 PM · Restricted Project, Restricted Project

Apr 23 2019

msearles accepted D61031: [AMDGPU] Fixed addReg() in SIOptimizeExecMaskingPreRA.cpp.

LGTM

Apr 23 2019, 10:56 AM · Restricted Project

Apr 4 2019

msearles accepted D60293: [AMDGPU] rename vi-insts into gfx8-insts.

LGTM

Apr 4 2019, 4:41 PM · Restricted Project

Mar 19 2019

msearles accepted D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.

LGTM

Mar 19 2019, 5:23 PM · Restricted Project

Mar 14 2019

msearles accepted D59365: AMDGPU: Correct type for waitcnt debug flag.

LGTM

Mar 14 2019, 8:35 AM

Mar 13 2019

msearles added inline comments to D59312: AMDGPU: Fix a SIAnnotateControlFlow issue when there are multiple backedges..
Mar 13 2019, 10:56 AM · Restricted Project

Feb 26 2019

msearles accepted D58688: AMDGPU: Enable function calls by default.

LGTM; 1 minor nit (typo in comment); no need to re-review

Feb 26 2019, 4:04 PM

Feb 21 2019

msearles committed rG599ce44d3f39: [AMDGPU] remove unused AssemblerPredicates (authored by msearles).
[AMDGPU] remove unused AssemblerPredicates
Feb 21 2019, 10:20 AM
msearles committed rL354604: [AMDGPU] remove unused AssemblerPredicates.
[AMDGPU] remove unused AssemblerPredicates
Feb 21 2019, 10:19 AM
msearles closed D58516: [AMDGPU] remove unused AssemblerPredicates.
Feb 21 2019, 10:19 AM · Restricted Project, Restricted Project
msearles updated the diff for D58516: [AMDGPU] remove unused AssemblerPredicates.

Address reviewer feedback - remove unused 'NotHasVOP3PInsts'

Feb 21 2019, 10:01 AM · Restricted Project, Restricted Project
msearles created D58516: [AMDGPU] remove unused AssemblerPredicates.
Feb 21 2019, 9:48 AM · Restricted Project, Restricted Project

Feb 1 2019

Herald added a project to D57539: [InstCombine] Extra null-checking on TFE/LWE support: Restricted Project.
Feb 1 2019, 8:24 AM · Restricted Project

Jan 17 2019

msearles accepted D56874: [WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC..

LGTM

Jan 17 2019, 1:08 PM
msearles added a comment to D56874: [WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC..

Would you kindly apply the same fix to:

Jan 17 2019, 12:26 PM
msearles added a comment to D56762: [WebAssembly] Store section alignment as a power of 2.

Yes, it looks like ULL should fix the warning: https://reviews.llvm.org/D56874

Jan 17 2019, 12:25 PM