Page MenuHomePhabricator

mkitzan (Michael Kitzan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 3:46 PM (38 w, 6 d)

Recent Activity

Sep 18 2020

mkitzan updated the diff for D87936: [GISel] Add new combines for G_ADD.
  • Changed G_ADD(x, -cst) -> G_SUB(x, cst) to use APInt
  • Added vector and s128 test cases (though some combines don't fire with these input types)
Sep 18 2020, 6:24 PM · Restricted Project
mkitzan added inline comments to D87936: [GISel] Add new combines for G_ADD.
Sep 18 2020, 5:50 PM · Restricted Project
mkitzan added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Sep 18 2020, 3:10 PM · Restricted Project
mkitzan added a comment to D87936: [GISel] Add new combines for G_ADD.

Out of curiosity, is the first rule a win or canonicalisation?

Sep 18 2020, 2:57 PM · Restricted Project
mkitzan added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Sep 18 2020, 1:17 PM · Restricted Project
mkitzan requested review of D87936: [GISel] Add new combines for G_ADD.
Sep 18 2020, 1:14 PM · Restricted Project

Sep 17 2020

mkitzan updated the diff for D87870: [GISel] Add new combines for G_FMUL.
  • Changed G_FMUL(x, -1.0) to fold into G_FSUB(0.0, x)
  • Fixed clang-tidy warnings
  • Changed some fp constants in comments from {n} to {n}.0
Sep 17 2020, 5:25 PM · Restricted Project
mkitzan added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Sep 17 2020, 4:47 PM · Restricted Project
mkitzan added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Sep 17 2020, 4:36 PM · Restricted Project
mkitzan added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Sep 17 2020, 4:24 PM · Restricted Project
mkitzan requested review of D87870: [GISel] Add new combines for G_FMUL.
Sep 17 2020, 4:20 PM · Restricted Project

Sep 16 2020

mkitzan updated subscribers of D86360: Add new hidden option -print-changed which only reports changes to IR.

I can't take credit for that. It was @hliao who committed the fix (thanks btw!).

Sep 16 2020, 1:30 PM · Restricted Project
mkitzan added inline comments to D86360: Add new hidden option -print-changed which only reports changes to IR.
Sep 16 2020, 11:34 AM · Restricted Project
mkitzan closed D86393: [GISel] Add combines for unary FP instrs with constant operand.

Committed in c4e589b7954

Sep 16 2020, 10:36 AM · Restricted Project
mkitzan committed rGc4e589b7954c: [GISel] Add new combines for unary FP instrs with constant operand (authored by mkitzan).
[GISel] Add new combines for unary FP instrs with constant operand
Sep 16 2020, 10:34 AM

Sep 15 2020

mkitzan committed rG7bc77c8526b6: Test commit (authored by mkitzan).
Test commit
Sep 15 2020, 6:02 PM
mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.
  • Rebased and fixed merge conflicts
  • Removed unnecessary type checks in constantFoldFpUnary
  • Removed G_FPTRUNC special case for S64 in constantFoldFpUnary
Sep 15 2020, 4:32 PM · Restricted Project
mkitzan added a comment to D87668: [GISel] Add new GISel combiners for G_MUL.

Thanks again Aditya! I'll reach out to Chris about commit access.

Sep 15 2020, 3:06 PM · Restricted Project
mkitzan added a comment to D87668: [GISel] Add new GISel combiners for G_MUL.

Thanks for the review. Still don't have commit access, will need someone to commit on my behalf. Thanks in advance!

Sep 15 2020, 2:18 PM · Restricted Project
mkitzan updated the diff for D87668: [GISel] Add new GISel combiners for G_MUL.
  • Changed mul_by_one to right_identity_one
  • Changed mul_by_neg_one to use matchConstantOp
Sep 15 2020, 12:17 PM · Restricted Project

Sep 14 2020

mkitzan updated the diff for D87668: [GISel] Add new GISel combiners for G_MUL.
  • Rebased and fixed merge conflicts
Sep 14 2020, 8:19 PM · Restricted Project
mkitzan requested review of D87668: [GISel] Add new GISel combiners for G_MUL.
Sep 14 2020, 8:05 PM · Restricted Project
mkitzan added inline comments to D86393: [GISel] Add combines for unary FP instrs with constant operand.
Sep 14 2020, 6:37 PM · Restricted Project
mkitzan added a comment to D87554: [GISel]: Add combine for G_FABS to G_FABS.

Thanks Aditya!

Sep 14 2020, 3:12 PM · Restricted Project
mkitzan added a comment to D87554: [GISel]: Add combine for G_FABS to G_FABS.

Thanks for the review. Still don't have commit access, will need someone to commit on my behalf. Thanks in advance!

Sep 14 2020, 2:45 PM · Restricted Project
mkitzan updated the diff for D87554: [GISel]: Add combine for G_FABS to G_FABS.
  • Used replaceRegWith instead of building a copy
Sep 14 2020, 10:06 AM · Restricted Project

Sep 11 2020

mkitzan requested review of D87554: [GISel]: Add combine for G_FABS to G_FABS.
Sep 11 2020, 7:10 PM · Restricted Project

Sep 4 2020

mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.
  • Collapsed the many combine rules into a single combine rule with a list of matchable opcodes
  • Made the default switch case in constantFoldFpUnary be llvm_unreachable
Sep 4 2020, 5:12 PM · Restricted Project
mkitzan added inline comments to D86393: [GISel] Add combines for unary FP instrs with constant operand.
Sep 4 2020, 2:43 PM · Restricted Project
mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.
  • Added LLT helper function to get float semantic from scalar LLT (IEEE fp semantics only at the moment)
  • Updated constantFoldFpUnary to use the new helper function
  • Rebased / fixed merge conflicts
Sep 4 2020, 11:47 AM · Restricted Project

Aug 27 2020

mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.
  • Rebased and fixed merge conflicts
  • Changed setInstr to setInstrAndDebugLoc
Aug 27 2020, 7:28 PM · Restricted Project
mkitzan added inline comments to D86393: [GISel] Add combines for unary FP instrs with constant operand.
Aug 27 2020, 7:02 PM · Restricted Project
mkitzan added a comment to D83833: [GISel] Add new GISel combiners for G_SELECT.

It was conflicted until the rebase update, so I doubt it was committed. Thanks for committing this!

Aug 27 2020, 9:02 AM · Restricted Project

Aug 25 2020

mkitzan updated the diff for D83833: [GISel] Add new GISel combiners for G_SELECT.
  • Rebased and resolved conflicts
  • Fixed test/CodeGen/AMDGPU/GlobalISel/postlegalizercombiner-select.mir to continue testing unmerge with same regs
Aug 25 2020, 11:48 PM · Restricted Project
mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.
  • match / apply functions use Optional<APFloat> to pass info about the constant FP.
  • Updated rounding modes to be rmNearestTiesToEven
  • Refactored constantFoldFpUnary
Aug 25 2020, 9:52 AM · Restricted Project

Aug 24 2020

mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.

Rebased and resolved conflicts with new changes to Combine.td.

Aug 24 2020, 9:27 AM · Restricted Project

Aug 22 2020

mkitzan removed a reviewer for D86393: [GISel] Add combines for unary FP instrs with constant operand: jpaquette.
Aug 22 2020, 11:32 AM · Restricted Project
mkitzan added inline comments to D86393: [GISel] Add combines for unary FP instrs with constant operand.
Aug 22 2020, 11:27 AM · Restricted Project
mkitzan added inline comments to D86393: [GISel] Add combines for unary FP instrs with constant operand.
Aug 22 2020, 10:46 AM · Restricted Project
mkitzan updated the diff for D86393: [GISel] Add combines for unary FP instrs with constant operand.

Fixed clang-tidy feedback
(not enough)

Aug 22 2020, 9:20 AM · Restricted Project

Aug 21 2020

mkitzan requested review of D86393: [GISel] Add combines for unary FP instrs with constant operand.
Aug 21 2020, 11:27 PM · Restricted Project
mkitzan added a comment to D83833: [GISel] Add new GISel combiners for G_SELECT.

Thanks for the reviews. I don't have commit access, would be appreciated if someone could commit on my behalf. Thanks!

Aug 21 2020, 10:57 AM · Restricted Project

Jul 31 2020

mkitzan closed D84909: [GISel] Add combiners for G_INTTOPTR and G_PTRTOINT.
Jul 31 2020, 10:33 AM · Restricted Project

Jul 30 2020

mkitzan added a comment to D84909: [GISel] Add combiners for G_INTTOPTR and G_PTRTOINT.

Thanks, Aditya!

Jul 30 2020, 9:16 PM · Restricted Project
mkitzan added a comment to D84909: [GISel] Add combiners for G_INTTOPTR and G_PTRTOINT.

Great, thanks for the review! I don't have commit access. Would be great if someone could commit on my behalf.

Jul 30 2020, 5:31 PM · Restricted Project
mkitzan updated the diff for D84909: [GISel] Add combiners for G_INTTOPTR and G_PTRTOINT.

Moved the two new combiner rules to identity_combines.

Jul 30 2020, 4:25 PM · Restricted Project

Jul 29 2020

mkitzan requested review of D84909: [GISel] Add combiners for G_INTTOPTR and G_PTRTOINT.
Jul 29 2020, 8:52 PM · Restricted Project

Jul 22 2020

mkitzan updated the diff for D83833: [GISel] Add new GISel combiners for G_SELECT.

Removed the combine for undef selectee value. Will open a separate patch to track that work.

Jul 22 2020, 6:17 PM · Restricted Project
mkitzan updated the summary of D83833: [GISel] Add new GISel combiners for G_SELECT.
Jul 22 2020, 5:55 PM · Restricted Project
mkitzan added inline comments to D83833: [GISel] Add new GISel combiners for G_SELECT.
Jul 22 2020, 5:14 PM · Restricted Project

Jul 15 2020

mkitzan added a comment to D83833: [GISel] Add new GISel combiners for G_SELECT.

Maybe? It's unclear to me what makes a ConstantExpr poison in the first place, and how combining with it would result in incorrect code (...new hire rolling through).

Jul 15 2020, 12:05 PM · Restricted Project
mkitzan updated the diff for D83833: [GISel] Add new GISel combiners for G_SELECT.
Jul 15 2020, 11:10 AM · Restricted Project
mkitzan updated the diff for D83833: [GISel] Add new GISel combiners for G_SELECT.

Looks like my local build wasn't building all the targets (sorry, fixed now). The AMDGPU test failed as a result of moving the existing select_same_val combiner out of the identity_combines group. The diff update moves select_same_val back to identity_combines group. The update does not address @arsenm's comment (waiting on feedback from @craig.topper).

Jul 15 2020, 10:53 AM · Restricted Project

Jul 14 2020

mkitzan added a reviewer for D83833: [GISel] Add new GISel combiners for G_SELECT: volkan.
Jul 14 2020, 5:07 PM · Restricted Project
mkitzan created D83833: [GISel] Add new GISel combiners for G_SELECT.
Jul 14 2020, 5:06 PM · Restricted Project

May 8 2020

mkitzan added a comment to D78796: [Support] Refactor LEB128 encoding into an input iterator.

Hey Nicolas, just add some thoughts on this patch.

May 8 2020, 10:42 AM · Restricted Project

May 7 2020

mkitzan added a comment to D78795: [Support] Add raw_ostream_iterator: ostream_iterator for raw_ostream..

Looks like a good helper class. Just some minor nits. (haven't looked into the tests just yet)

May 7 2020, 10:14 AM · Restricted Project