Page MenuHomePhabricator

mikeurbach (Mike Urbach)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2020, 10:22 AM (6 w, 6 h)

Recent Activity

Yesterday

mikeurbach added inline comments to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Tue, Oct 27, 11:55 AM · Restricted Project
mikeurbach added inline comments to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Tue, Oct 27, 8:45 AM · Restricted Project

Mon, Oct 26

mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Thanks for the feedback. A couple questions to inline comments, otherwise I'm addressing the rest of the comments.

Mon, Oct 26, 8:14 PM · Restricted Project
mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Can this logic be generalized for all Regions? In the patch https://reviews.llvm.org/D90118 I need to drop arguments for region of an linalg::IndexedGenericOp. Having this method there would be more ergonomic.

Mon, Oct 26, 1:13 PM · Restricted Project

Fri, Oct 23

mikeurbach removed reviewers for D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike: mravishankar, antiagainst, rriddle, ftynse, herhut.
Fri, Oct 23, 3:07 PM · Restricted Project
mikeurbach added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

I'm not sure if there is a way to mark this as a draft, but please consider it as such. I'm trying to illustrate the ideas discussed here: https://llvm.discourse.group/t/moving-erasearguments-from-funcop-to-functionlike/2016.

Fri, Oct 23, 3:04 PM · Restricted Project
mikeurbach requested review of D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.
Fri, Oct 23, 2:50 PM · Restricted Project

Sep 23 2020

mikeurbach added a comment to D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

This is my first contribution to LLVM, so I will need need some assistance per the policy. @mehdi_amini as the reviewer, do you mind committing this on my behalf? Not sure if this is already associated in Phabricator, but my name is Mike Urbach, and email is mikeurbach@gmail.com. The GitHub username is also mikeurbach, if that is needed.

Sep 23 2020, 11:01 AM · Restricted Project
mikeurbach updated the diff for D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

Use arc diff --edit --verbatim to update summary

Sep 23 2020, 10:59 AM · Restricted Project
mikeurbach added a comment to D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

@mehdi_amini I've amended the commit description to include some background on the issue this revision intends to fix.

Sep 23 2020, 10:00 AM · Restricted Project
mikeurbach updated the diff for D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..

Update description about custom directive attribute parsing

Sep 23 2020, 9:58 AM · Restricted Project

Sep 17 2020

mikeurbach requested review of D87860: [mlir][OpFormatGen] Update "custom" directives for attributes..
Sep 17 2020, 2:57 PM · Restricted Project