Page MenuHomePhabricator

manojgupta (Manoj Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2016, 10:04 PM (226 w, 1 d)

Recent Activity

Mon, Apr 12

manojgupta added a comment to D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

Thanks for the quick turn around, I can verify that https://reviews.llvm.org/rGee8a5e4bc2c986b8e6c07e81fb58dc1e5a5c2d17 fixes the issue.

Mon, Apr 12, 12:19 PM · Restricted Project
manojgupta updated subscribers of D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

@cjdb please pick the fix once available to chrome os.

Mon, Apr 12, 9:30 AM · Restricted Project

Sun, Apr 11

manojgupta added a comment to D98511: [llvm-objcopy][NFC] Move ownership keeping code into restoreStatOnFile().

@avl Did you test this change? It has broken setuid permission preservation with sudo.

Sun, Apr 11, 6:02 PM · Restricted Project

Mar 11 2021

manojgupta accepted D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

@MaskRay I have verified that Chrome OS builds are not affected by this change.

Mar 11 2021, 10:05 AM · Restricted Project

Mar 5 2021

manojgupta updated subscribers of D97993: [Driver] Suppress GCC detection under -B.

Thanks for the clarification. I do not have any objections but I feel that am not the right person to approve this change.
@tstellar can you please review it?

Mar 5 2021, 12:38 PM · Restricted Project
manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

Another concern is people generally want clang to work out of box without any special arguments. As a user, after installing clang's distro package or building from source, I expect that basic compilation should work out-of-box which includes gcc detection.
i.e. "clang foo.cpp -o foo" should just work in most cases.

Mar 5 2021, 12:10 PM · Restricted Project

Mar 4 2021

manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

Thanks for explaining that it only affects "-B". While I believe that this change won't affect us in Chrome OS, I think it should be reviewed and approved by a few Linux distro contributors since there is already known reliance e.g. Android on the current behavior.

Mar 4 2021, 5:49 PM · Restricted Project
manojgupta added a comment to D97902: [docs] Improve documentation of -B and --gcc-toolchain.

thanks, this is much needed documentation.

Mar 4 2021, 5:39 PM · Restricted Project
manojgupta added a comment to D97993: [Driver] Suppress GCC detection under -B.

I am not sure of the rationale or upside of this change and why do we want to drop gcc detection? GCC does not need to do the GCC detection because it has the needed information at configure time.

Mar 4 2021, 5:33 PM · Restricted Project
manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

With the special rule, it is: if --gcc-toolchain is $sysroot/usr, suppress sysroot GCC detection as well.

Clang -B and --gcc-toolchain have some weird behaviors. Hope you can share your opinions on https://lists.llvm.org/pipermail/cfe-dev/2021-March/067827.html

Mar 4 2021, 3:25 PM · Restricted Project
manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

In Chrome OS, we currently both "-B" and "--prefix". "-B" points to binutils bin directory and the "--prefix" has the binutils directory + target suffix. Should we drop "-B" and still get the same behavior?

Mar 4 2021, 2:10 PM · Restricted Project

Mar 3 2021

manojgupta added a comment to D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection.

Thanks @MaskRay for this clean up. I can't speak for all of Gentoo but please give me a couple of days to at least test this on Chrome OS.

Mar 3 2021, 4:31 PM · Restricted Project

Feb 25 2021

manojgupta added a comment to rGb94c215592bd: [Utils] collectBitParts - add truncate() handling.

@RKSimon We identified that this caused a clang crash on our ToT builds https://bugs.chromium.org/p/chromium/issues/detail?id=1182316.

Feb 25 2021, 11:01 AM

Feb 24 2021

manojgupta added inline comments to D97253: [llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits.
Feb 24 2021, 10:57 AM · Restricted Project

Feb 23 2021

manojgupta accepted D97253: [llvm-objcopy] If input=output, preserve umask bits, otherwise drop S_ISUID/S_ISGID bits.

Thanks a lot Fangrui.

Feb 23 2021, 8:05 AM · Restricted Project

Feb 16 2021

manojgupta added a comment to D96292: [llvm-objcopy] Drop S_ISUID and S_ISGID bits.

This change make further deviation from GNU tools. Lets wait for resolution of D93881. This will not be needed if D93881 is merged.

This change actually makes our behavior consistent with current GNU strip/objcopy. GNU strip/objcopy does not copy S_ISUID and S_ISGID bits.

chmod u+s,g+s,o+x a
sudo llvm-strip a -o b

Currently b has S_ISUID and S_ISGID bits.

Feb 16 2021, 8:34 AM · Restricted Project

Feb 9 2021

manojgupta added a reviewer for D96308: [llvm-objcopy] Avoid rename if input filename = output filename: jcai19.
Feb 9 2021, 1:29 PM · Restricted Project

Feb 8 2021

manojgupta requested changes to D96292: [llvm-objcopy] Drop S_ISUID and S_ISGID bits.

This change make further deviation from GNU tools. Lets wait for resolution of D93881. This will not be needed if D93881 is merged.

Feb 8 2021, 2:18 PM · Restricted Project

Feb 5 2021

manojgupta added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 5 2021, 12:08 PM · Restricted Project

Feb 4 2021

manojgupta added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 4 2021, 7:37 PM · Restricted Project
manojgupta added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 4 2021, 7:23 PM · Restricted Project

Feb 3 2021

manojgupta added a comment to D95994: [ELF] Allow R_386_GOTOFF from .debug_info.

Thanks Fangrui for working on this!

Feb 3 2021, 6:51 PM · Restricted Project

Feb 2 2021

manojgupta added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 2 2021, 8:49 PM · Restricted Project

Jan 20 2021

manojgupta added a comment to D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid.

This CL has caused two issues in Chrome OS :
Compilation fail with FORTIFY: https://bugs.chromium.org/p/chromium/issues/detail?id=1168199
Runtime failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1167504

Jan 20 2021, 10:26 AM · Restricted Project

Jan 6 2021

manojgupta added a comment to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.

Could you just update the build instructions for these few packages?

I see over 600 uses of of fowners in Gentoo and over 55 in Chrome OS (public). Not all uses are related to binary files but asking to fix the build system instead of fixing the incompatibility is a non-trivial and a no-go.

[1] https://github.com/gentoo/gentoo/search?q=fowners&type=code
[2] https://source.chromium.org/search?q=fowners&sq=&ss=chromiumos

OK. If that is the case, I am happy that llvm-objcopy adopts the GNU objcopy behavior.

But I think we should do better: instead of: (1) create a temp file (2) open it by name again (3) check it is a regular file with one hard link & it is writable (S_IWUSR) (4) fstat (5) fchown,
we should just modify the destination in place (for objcopy file and strip file). If the file has been mapped readonly, on many platforms it may be unwritable. We have to accept this.

The various security checks is to prevent vulnerability.

Thanks, we will work on an improved patch with the added checks.

Jan 6 2021, 7:16 PM · Restricted Project
manojgupta added a comment to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.

GNU objcopy and strip preserve the ownership of a file when it's overwritten, e.g. while "sudo objcopy foo -o bar" creates a new file bar with root access, "sudo objcopy foo" will keep the owner and group of foo unchanged. Currently llvm-objcopy and llvm-strip behave differently, always changing the ownership to root.

objcopy foo -o bar => objcopy foo bar

I am unsure that we want to adopt the GNU behavior because

(1) there were security vulnerabilities
(2) the code is subtle and untestable
(3) the behavior is self inconsistent. The behaviors of sudo objcopy foo and sudo -u mail objcopy foo (if user mail has write permission to the directory) are different.

Jan 6 2021, 6:26 PM · Restricted Project
manojgupta added a comment to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.

It sounds like portage should be using something like setuidgid to drop privileges for parts of the build.

Jan 6 2021, 4:13 PM · Restricted Project
manojgupta added a comment to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.

I don't think we want to introduce a filename based chmod API. Unless it is essential (very unlikely), it is easy for developers to make time-of-check time-of-use (TOCTOU) race condition allowing bypass of protection mechanism due to symlink attacks.

binutils 2.36 will fix the issue https://sourceware.org/bugzilla/show_bug.cgi?id=26945

Jan 6 2021, 3:29 PM · Restricted Project

Dec 11 2020

manojgupta added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

Hi Daniel,

Dec 11 2020, 5:02 PM

Nov 26 2020

manojgupta added a comment to D92176: Don't use sysroot/include when sysroot is empty..

lgtm but not an expert in this area.

Nov 26 2020, 11:11 AM · Restricted Project

Oct 22 2020

manojgupta added inline comments to D89988: adds basic -Wfree-nonheap-object functionality.
Oct 22 2020, 3:47 PM · Restricted Project

Oct 14 2020

manojgupta committed rG18432bea7648: [Driver]: fix compiler-rt path when printing libgcc for baremetal (authored by cjdb).
[Driver]: fix compiler-rt path when printing libgcc for baremetal
Oct 14 2020, 10:36 AM
manojgupta closed D89327: fixes compiler-rt bug when printing libgcc for baremetal.
Oct 14 2020, 10:36 AM · Restricted Project

Oct 13 2020

manojgupta updated subscribers of D89327: fixes compiler-rt bug when printing libgcc for baremetal.
Oct 13 2020, 12:55 PM · Restricted Project
manojgupta accepted D89327: fixes compiler-rt bug when printing libgcc for baremetal.
Oct 13 2020, 12:53 PM · Restricted Project
manojgupta added inline comments to D89327: fixes compiler-rt bug when printing libgcc for baremetal.
Oct 13 2020, 10:46 AM · Restricted Project
manojgupta added inline comments to D89327: fixes compiler-rt bug when printing libgcc for baremetal.
Oct 13 2020, 10:18 AM · Restricted Project

Oct 10 2020

manojgupta abandoned D53608: [builtins] Build float128 soft float builtins for x86_64..
Oct 10 2020, 7:07 PM · Restricted Project, Restricted Project

Sep 26 2020

manojgupta added inline comments to D87901: [Driver] Filter out <libdir>/gcc and <libdir>/gcc-cross if they do not exists.
Sep 26 2020, 10:57 AM · Restricted Project

Sep 4 2020

manojgupta accepted D87143: Check whether Gentoo-specific configuration directory exists.

Looks ok to me.

Sep 4 2020, 11:18 AM · Restricted Project
manojgupta added a reviewer for D87143: Check whether Gentoo-specific configuration directory exists: mgorny.
Sep 4 2020, 9:43 AM · Restricted Project

Aug 28 2020

manojgupta updated subscribers of D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

--warn-backrefs-exclude='*' disables all warnings. We may need --no-warn-backrefs if it is more like the option users want to use. If you are happy to try out, I'd happy to know whether ChromeOS packages have no warnings if --warn-backrefs is added (--fatal-warnings upgrade warnings to errors).

Aug 28 2020, 11:24 AM · Restricted Project
manojgupta added a comment to D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

@MaskRay Is there a global option to disable e.g --no-warn-backrefs . It is not easy for us to add -warn-backrefs-exclude=<glob> individually to all packages where we need to suppress the error.

Aug 28 2020, 9:06 AM · Restricted Project

Jun 1 2020

manojgupta added a comment to D80870: [LV] Make sure smallest/widest type sizes are powers-of-2..

D80491 has been breaking our ToT builds for a week now. Can this be submitted soon. If not please consider reverting D80491.

Jun 1 2020, 11:19 AM · Restricted Project

Apr 28 2020

manojgupta added a comment to D78862: [IR] Convert null-pointer-is-valid into an enum attribute.

@nikic Thanks for the work.

Apr 28 2020, 2:34 PM · Restricted Project, Restricted Project
manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

@manojgupta can you give a build recipe? None of the buildbots are failing.

Apr 28 2020, 2:02 PM · Restricted Project
manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Hi @manojgupta. I am not familiar enough with this piece of code to understand whether it could be fixed by simply using any other general-purpose register instead of r7.

Can you request it to someone more accustomed to compiler-rt?

Apr 28 2020, 10:11 AM · Restricted Project
manojgupta updated subscribers of D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

@vhscampos This change is more restrictive than GCC. e.g. https://godbolt.org/z/wP8_ic where clang errors out but GCC does not error out.

Apr 28 2020, 9:38 AM · Restricted Project

Apr 26 2020

manojgupta added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

I believe chromium's version is a copy of compiler-rt's implementation of clear_cache [1] .
@vhscampos Can you please fix compiler-rt version as well?

Apr 26 2020, 3:11 AM · Restricted Project

Apr 7 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

I opened https://github.com/ClangBuiltLinux/linux/issues/979 to see if we can fix this in Linux kernel.

Apr 7 2020, 12:31 PM · Restricted Project

Apr 2 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Yes, it'd be nice if all of the FORTIFY handling can be improved. For a simple call like memcpy of 8 bytes in the example, there is no reason to emit all these stack/range checks since they'd degrade memcpy performance.

Apr 2 2020, 6:27 PM · Restricted Project

Apr 1 2020

manojgupta updated subscribers of D67900: [libc++] Use builtin type traits whenever possible.

Copying an email reply to phab thread from @EricWF , not sure why it did not make it here.

Apr 1 2020, 10:26 AM · Restricted Project

Mar 31 2020

manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Unfortunately, cherry-picking the kernel patches didn't work including latest memcpy for x86 (https://github.com/torvalds/linux/commit/170d13ca3a2fdaaa0283399247631b76b441cca2 and https://github.com/torvalds/linux/commit/c228d294f2040c3a5f5965ff04d4947d0bf6e7da ).
Also tried ToT Linux kernel but still the same problem.

Mar 31 2020, 10:00 PM · Restricted Project
manojgupta updated subscribers of D71082: Allow system header to provide their own implementation of some builtin.

I was able to reduce to following:

Mar 31 2020, 8:22 PM · Restricted Project
manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

Sure, I am trying to root cause the issue. Will report back hopefully soon.

Mar 31 2020, 3:59 PM · Restricted Project
manojgupta added a comment to D71082: Allow system header to provide their own implementation of some builtin.

We believe this change (relanded as https://reviews.llvm.org/rGd437fba8ef626b6d8b7928540f630163a9b04021) is causing a mis-compile in Linux kernel 4.4 builds resulting in local test failures.
Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1066638

Mar 31 2020, 2:52 PM · Restricted Project
manojgupta accepted D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
Mar 31 2020, 9:24 AM · Restricted Project, Restricted Project

Mar 23 2020

manojgupta added a comment to D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.

Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval.

Mar 23 2020, 2:11 PM · Restricted Project, Restricted Project

Mar 20 2020

manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Thanks for the quick fix, verified that the crash is fixed on trunk.

Mar 20 2020, 11:55 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro?

Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Mar 18 2020

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Thanks a lot!

Mar 18 2020, 3:13 PM · Restricted Project
manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Friendly ping @pcc and @ldionne . We have been carrying this patch I think for too long now.
Also, we have not discovered any LTO issues elsewhere so can't tell from our side if there are other places in libc++ that need visibility annotations.

Mar 18 2020, 1:35 PM · Restricted Project

Mar 17 2020

manojgupta updated subscribers of D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
Mar 17 2020, 8:31 AM · Restricted Project, Restricted Project

Mar 13 2020

manojgupta added a comment to D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Can you also test on the reduced test cases in https://bugs.llvm.org/show_bug.cgi?id=45181 ?

Mar 13 2020, 3:40 PM · Restricted Project, debug-info

Mar 12 2020

manojgupta added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

I see another crash with this change when building gdb.

Mar 12 2020, 2:19 AM · Restricted Project, Restricted Project, Restricted Project, debug-info

Mar 6 2020

manojgupta added a comment to D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast.

Thanks, Verified that this fixes the kernel warnings in my local builds with https://gist.github.com/nathanchance/767cccf4d093c1342e1994083518815e!

Mar 6 2020, 12:08 PM · Restricted Project

Mar 4 2020

manojgupta accepted D75065: [cmake] Strip quotes in compiler-rt/lib/crt and explicitly throw error if check executable fails.
Mar 4 2020, 2:41 PM · Restricted Project, Restricted Project

Feb 27 2020

manojgupta updated subscribers of D75238: [DAGCombine] Fix alias analysis for unaligned accesses.
Feb 27 2020, 11:34 AM · Restricted Project

Feb 24 2020

manojgupta added a reviewer for D75065: [cmake] Strip quotes in compiler-rt/lib/crt and explicitly throw error if check executable fails: phosek.
Feb 24 2020, 11:07 AM · Restricted Project, Restricted Project

Feb 18 2020

manojgupta added a reviewer for D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all: hfinkel.
Feb 18 2020, 10:35 AM · Restricted Project

Feb 5 2020

manojgupta added a comment to D74039: Make llvm::crc32() work also for input sizes larger than 32 bits..

Thanks, should this be cherry picked to 11.0 release as well?

Feb 5 2020, 1:21 PM · Restricted Project

Oct 10 2019

manojgupta added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Oct 10 2019, 1:16 PM · Restricted Project

Sep 30 2019

manojgupta updated subscribers of rL373168: [MC] Emit unused undefined symbol even if its binding is not set.

Opened PR43518 with repro instructions.

Sep 30 2019, 5:33 PM
manojgupta added a comment to rL373168: [MC] Emit unused undefined symbol even if its binding is not set.

Heads up: This is causing an error when building Chrome on ARM32 (Thumb2):

Sep 30 2019, 5:17 PM

Sep 13 2019

manojgupta committed rG41d9d5092a17: Reland r371785: Add -Wpoison-system-directories warning (authored by manojgupta).
Reland r371785: Add -Wpoison-system-directories warning
Sep 13 2019, 11:00 AM
manojgupta committed rL371878: Reland r371785: Add -Wpoison-system-directories warning.
Reland r371785: Add -Wpoison-system-directories warning
Sep 13 2019, 11:00 AM

Sep 12 2019

manojgupta committed rG38f6b3fd8dd7: Revert r371785. (authored by manojgupta).
Revert r371785.
Sep 12 2019, 5:33 PM
manojgupta committed rL371799: Revert r371785..
Revert r371785.
Sep 12 2019, 5:33 PM
manojgupta closed D52524: Add -Wpoison-system-directories warning.

Submitted as https://reviews.llvm.org/rL371785.
Thanks for the patch!

Sep 12 2019, 3:50 PM · Restricted Project
manojgupta committed rG4fe273216190: Add -Wpoison-system-directories warning (authored by manojgupta).
Add -Wpoison-system-directories warning
Sep 12 2019, 3:41 PM
manojgupta committed rL371785: Add -Wpoison-system-directories warning.
Add -Wpoison-system-directories warning
Sep 12 2019, 3:41 PM

Sep 4 2019

manojgupta added a comment to D67090: [llvm-objcopy][llvm-strip] Support --only-keep-debug.

Thanks for working on it. Have you tested if Linux perf can symbolize the perf traces using the split debug files especially with large binaries?

Sep 4 2019, 4:15 AM · Restricted Project

Aug 23 2019

manojgupta committed rG30232770fbe5: Revert r369233. (authored by manojgupta).
Revert r369233.
Aug 23 2019, 11:04 AM
manojgupta committed rL369790: Revert r369233..
Revert r369233.
Aug 23 2019, 11:04 AM

Aug 21 2019

manojgupta updated subscribers of rL369233: [MC] Don't emit .symver redirected symbols to the symbol table.

Hi Fangrui,

Aug 21 2019, 3:05 PM

Aug 19 2019

manojgupta added reviewers for D52524: Add -Wpoison-system-directories warning: rtrieu, aaron.ballman.

Adding a few more reviewers since I am not very familiar with this part of clang.
Please also update the patch description as suggested by @thakis

Aug 19 2019, 12:10 PM · Restricted Project
manojgupta added inline comments to D52524: Add -Wpoison-system-directories warning.
Aug 19 2019, 10:51 AM · Restricted Project

Aug 14 2019

manojgupta added inline comments to D52524: Add -Wpoison-system-directories warning.
Aug 14 2019, 8:20 PM · Restricted Project
manojgupta added a comment to D52524: Add -Wpoison-system-directories warning.

Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't you tell them to not use -I/usr/include?

Aug 14 2019, 7:59 PM · Restricted Project
manojgupta added a comment to D52524: Add -Wpoison-system-directories warning.

Couldn't cross build users just pass -nostdsysteminc to tell clang to not look in system header locations?

Aug 14 2019, 4:15 PM · Restricted Project

Aug 3 2019

manojgupta updated subscribers of D65019: [ARM] push LR before __gnu_mcount_nc.
Aug 3 2019, 10:52 AM · Restricted Project, Restricted Project

Jul 16 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

@pcc can you please submit this patch if there are no objections?

Jul 16 2019, 10:47 AM · Restricted Project

Jul 15 2019

manojgupta added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm are you still working on this patch?

Jul 15 2019, 11:32 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

@ldionne Does Peter's example answer your questions?

Jun 24 2019, 1:28 PM · Restricted Project

May 29 2019

manojgupta added inline comments to D62627: [NFC] Do not run CGProfilePass when not using integrated assembler.
May 29 2019, 2:41 PM · Restricted Project, Restricted Project

May 28 2019

manojgupta added a comment to D48680: Add missing visibility annotation for __base.

Hi Peter and Marshall,

May 28 2019, 11:54 AM · Restricted Project

Apr 10 2019

manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 10 2019, 8:04 AM · Restricted Project
manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 10 2019, 8:00 AM · Restricted Project
manojgupta added a comment to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.

The motivation for this change is to make "crypto" setting an additive option e.g. like "-mavx" used in many media packages. Some packages in Chrome want to enable crypto conditionally for a few files to allow crypto feature to be used based on runtime cpu detection. They set "-march=armv8+crypto" flag but it gets overridden by the global "-march=armv8a" flag set by the build system in Chrome OS because the target cpu does not support crypto causing compile-time errors.
Ability to specify "-mcrypto" standalone makes it an additive option and ensures that it it is not lost. i.e. this will help in decoupling "-mcrypto" from "-march" so that they could be set independently. The current additive alternate is '-Xclang -target-feature -Xclang "+crypto" ' which is ugly.

Apr 10 2019, 7:37 AM · Restricted Project

Apr 9 2019

manojgupta added inline comments to D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64.
Apr 9 2019, 11:03 AM · Restricted Project