Page MenuHomePhabricator

mamai (Marianne Mailhot-Sarrasin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2015, 1:48 PM (330 w, 1 d)

Recent Activity

Feb 17 2021

mamai committed rGf0ec9f1bb3f2: [Pipeliner] Fixed optimization remarks and debug dumps Initiation (authored by mamai).
[Pipeliner] Fixed optimization remarks and debug dumps Initiation
Feb 17 2021, 9:30 AM
mamai closed D95692: [Pipeliner] Fixed optimization remarks and debug dumps Initiation Interval value.
Feb 17 2021, 9:30 AM · Restricted Project

Feb 16 2021

mamai requested review of D95692: [Pipeliner] Fixed optimization remarks and debug dumps Initiation Interval value.
Feb 16 2021, 12:05 PM · Restricted Project
mamai updated the diff for D95692: [Pipeliner] Fixed optimization remarks and debug dumps Initiation Interval value.

Updated patch with the cleaner approach of creating a getInitiationInterval() function.

Feb 16 2021, 11:46 AM · Restricted Project

Feb 10 2021

mamai added inline comments to D95692: [Pipeliner] Fixed optimization remarks and debug dumps Initiation Interval value.
Feb 10 2021, 6:44 AM · Restricted Project

Jan 29 2021

mamai requested review of D95692: [Pipeliner] Fixed optimization remarks and debug dumps Initiation Interval value.
Jan 29 2021, 11:45 AM · Restricted Project

Oct 23 2020

mamai accepted D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743).

LGTM

Oct 23 2020, 11:22 AM · Restricted Project

Apr 23 2018

mamai committed rL330590: [doc] Removed obsolete -count-aa from AliasAnalysis documentation.
[doc] Removed obsolete -count-aa from AliasAnalysis documentation
Apr 23 2018, 6:51 AM
mamai closed D45876: [doc] Removed obsolete -count-aa from AliasAnalysis documentation.
Apr 23 2018, 6:51 AM

Apr 20 2018

mamai created D45876: [doc] Removed obsolete -count-aa from AliasAnalysis documentation.
Apr 20 2018, 5:48 AM

Sep 28 2016

mamai updated subscribers of D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Hi Konstantin,

Sep 28 2016, 6:55 PM

May 27 2016

mamai updated the diff for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Updated diff adding more checks in dag-combine-ldst.ll to make sure the %r0 comes from the right place.

May 27 2016, 11:08 AM
mamai added inline comments to D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.
May 27 2016, 10:15 AM

May 25 2016

mamai added a comment to D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Is my last change correct? I ran the opt -instnamer and added a new line as asked.

May 25 2016, 5:58 AM

May 19 2016

mamai updated the diff for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.
May 19 2016, 11:46 AM
mamai added a comment to D20432: [DAGCombiner] Keep debug information when folding (sext (truncate x)) -> (sextinreg x).

Good questions.

May 19 2016, 8:36 AM
mamai retitled D20432: [DAGCombiner] Keep debug information when folding (sext (truncate x)) -> (sextinreg x) from to [DAGCombiner] Keep debug information when folding (sext (truncate x)) -> (sextinreg x).
May 19 2016, 6:57 AM
mamai added a reviewer for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled: probinson.
May 19 2016, 6:27 AM

May 16 2016

mamai added a comment to D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Here is a link to the RFC thread: https://groups.google.com/forum/#!topic/llvm-dev/JRM2tlYlJ6I. The idea doesn't seem very popular.

May 16 2016, 7:10 AM

May 13 2016

mamai added a comment to D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Sorry, I haven't started it yet. I will do that right now!

May 13 2016, 9:44 AM
mamai updated the diff for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Added a test case showing that the optimization is done in /O1 and not in /O0. Also added the fix to 2 test cases that were broken by this patch since the code generated changed slightly in /O0.

May 13 2016, 8:58 AM

May 12 2016

mamai committed rL269340: [LLDB] Added support for PHI nodes to IR interpreter.
[LLDB] Added support for PHI nodes to IR interpreter
May 12 2016, 1:07 PM
mamai closed D19124: [LLDB] Added support for PHI nodes to IR interpreter by committing rL269340: [LLDB] Added support for PHI nodes to IR interpreter.
May 12 2016, 1:07 PM

May 10 2016

mamai resigned from D20115: Loop unroller: set thresholds for optsize and minsize functions to zero.

Ok then, it sounds good to me, at least for the test part. But I don't think I am the right person to accept this commit. I don't know why there was a threshold of 50 for optimize for size or why there was another threshold for partial unrolling. There might frontends other than clang that used it?

May 10 2016, 11:36 AM
mamai added inline comments to D20115: Loop unroller: set thresholds for optsize and minsize functions to zero.
May 10 2016, 10:31 AM

May 4 2016

mamai committed rL268524: Adding test cases showing the behavior of LoopUnrollPass according to optnone….
Adding test cases showing the behavior of LoopUnrollPass according to optnone…
May 4 2016, 10:51 AM
mamai closed D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes by committing rL268524: Adding test cases showing the behavior of LoopUnrollPass according to optnone….
May 4 2016, 10:51 AM
mamai abandoned D19925: Fixed test not to depend on loop unrolling pass.

The test have been fixed otherwise in rev 268523.

May 4 2016, 10:46 AM
mamai added a reviewer for D19925: Fixed test not to depend on loop unrolling pass: rnk.
May 4 2016, 10:30 AM
mamai retitled D19925: Fixed test not to depend on loop unrolling pass from to Fixed test not to depend on loop unrolling pass.
May 4 2016, 10:20 AM
mamai committed rL268509: Do not disable completely loop unroll when optimizing for size..
Do not disable completely loop unroll when optimizing for size.
May 4 2016, 8:32 AM
mamai closed D19827: Do not disable completely loop unroll when optimizing for size. by committing rL268509: Do not disable completely loop unroll when optimizing for size..
May 4 2016, 8:32 AM
mamai updated D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes.
May 4 2016, 6:15 AM
mamai updated the diff for D19827: Do not disable completely loop unroll when optimizing for size..

Modified the patch not to affect /O1 optimization level.

May 4 2016, 6:09 AM

May 3 2016

mamai updated the diff for D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes.
  • Merged test cases into one file.
  • Added a case for minsize.
  • Modified the test that shows the behavior of optsize when no unroll factor is specified.
May 3 2016, 1:30 PM
mamai added a comment to D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes.

Ok, thanks! I will modify the test cases and merge them in one file.

May 3 2016, 1:02 PM
mamai added a comment to D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes.
  • I am not sure it is possible to merge the optsize tests in one call to opt, since one of them use the -unroll-count parameter and not the other. Do you see another way to do that?
May 3 2016, 11:16 AM
mamai retitled D19870: Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes from to Adding test cases showing the behavior of LoopUnrollPass according to optnone and optsize attributes.
May 3 2016, 7:42 AM
mamai updated subscribers of D19827: Do not disable completely loop unroll when optimizing for size..

I think the blog comment is right. The pragma should make the loop unroll even in /Os. I think it is essential to allow the user to optimize some specific loops even if he generally wants to optimize for size the rest of the code. I will add tests that show the behavior of the loop unroll pass when optnone or optsize are specified.

May 3 2016, 7:16 AM

May 2 2016

mamai retitled D19827: Do not disable completely loop unroll when optimizing for size. from to Do not disable completely loop unroll according to optimization level..
May 2 2016, 1:15 PM
mamai updated the diff for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.

Fixed indentation.

May 2 2016, 8:54 AM

Apr 26 2016

mamai added a reviewer for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled: qcolombet.
Apr 26 2016, 10:47 AM

Apr 20 2016

mamai updated the diff for D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled.
Apr 20 2016, 6:23 AM

Apr 19 2016

mamai retitled D19268: [DAGCombiner] Do not remove the load of stored values when optimizations are disabled from to [DAGCombiner] Skip folding constants when optimizations are disabled.
Apr 19 2016, 8:58 AM
mamai committed rL266733: LLDB: Fixed two race conditions when stopping private state thread.
LLDB: Fixed two race conditions when stopping private state thread
Apr 19 2016, 6:27 AM
mamai closed D19122: LLDB: Fixed race condition on timeout when stopping private state thread by committing rL266733: LLDB: Fixed two race conditions when stopping private state thread.
Apr 19 2016, 6:27 AM

Apr 14 2016

mamai committed rL266321: clang-format: Last line in incomplete block is indented incorrectly.
clang-format: Last line in incomplete block is indented incorrectly
Apr 14 2016, 8:02 AM
mamai closed D19065: clang-format: Last line in incomplete block is indented incorrectly by committing rL266321: clang-format: Last line in incomplete block is indented incorrectly.
Apr 14 2016, 8:02 AM
mamai committed rL266320: clang-format: Implemented tab usage for continuation and indentation.
clang-format: Implemented tab usage for continuation and indentation
Apr 14 2016, 7:58 AM
mamai closed D19028: clang-format: Implemented tab usage for continuation and indentation by committing rL266320: clang-format: Implemented tab usage for continuation and indentation.
Apr 14 2016, 7:58 AM
mamai committed rL266319: clang-format: Allow include of clangFormat.h in managed context.
clang-format: Allow include of clangFormat.h in managed context
Apr 14 2016, 7:53 AM
mamai closed D19064: clang-format: Allow include of clangFormat.h in managed context by committing rL266319: clang-format: Allow include of clangFormat.h in managed context.
Apr 14 2016, 7:53 AM

Mar 30 2016

mamai committed rL264860: gold-plugin: Fixed typo in an error message..
gold-plugin: Fixed typo in an error message.
Mar 30 2016, 5:26 AM

Mar 23 2016

mamai added a comment to D18412: [clang-tidy] Add support for different char-types for the readability-redundant-string-cstr checker..

nit: in summary, consiring -> considering ?

Mar 23 2016, 1:13 PM

Mar 11 2016

mamai committed rL263247: More UTF string conversion wrappers.
More UTF string conversion wrappers
Mar 11 2016, 8:04 AM
mamai closed D17549: [PATCH] More UTF string conversion wrappers by committing rL263247: More UTF string conversion wrappers.
Mar 11 2016, 8:04 AM
mamai committed rL263233: Fixed MemoryCache L1 cache flush.
Fixed MemoryCache L1 cache flush
Mar 11 2016, 5:55 AM
mamai closed D18050: Fixed MemoryCache L1 cache flush by committing rL263233: Fixed MemoryCache L1 cache flush.
Mar 11 2016, 5:55 AM

Mar 10 2016

mamai committed rL263166: Fixed ValueObject::GetExpressionPath() for paths including anonymous….
Fixed ValueObject::GetExpressionPath() for paths including anonymous…
Mar 10 2016, 2:16 PM
mamai closed D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union by committing rL263166: Fixed ValueObject::GetExpressionPath() for paths including anonymous….
Mar 10 2016, 2:16 PM
mamai committed rL263165: Test commit access.
Test commit access
Mar 10 2016, 1:59 PM
mamai added a comment to D18050: Fixed MemoryCache L1 cache flush.
Mar 10 2016, 10:34 AM
mamai retitled D18050: Fixed MemoryCache L1 cache flush from to Fixed MemoryCache L1 cache flush.
Mar 10 2016, 10:17 AM

Mar 9 2016

mamai added a comment to D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.

Thanks! Could someone commit it for me? I don't have commit access.

Mar 9 2016, 2:06 PM
mamai updated the diff for D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.

Replaced the test by a new case in lang/c/anonymous test, as suggested by Jim. Is this correct?

Mar 9 2016, 1:54 PM
mamai added a comment to D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.

Sure. Would you have a suggestion of how to call it? Maybe something like variable_flat since it is the command used? Also, is it the right place to add it in functionalities or should it be elsewhere?

Mar 9 2016, 12:11 PM
mamai updated the diff for D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.

Fixed test header, removed useless include.

Mar 9 2016, 11:55 AM
mamai retitled D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union from to Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.
Mar 9 2016, 11:43 AM

Feb 26 2016

mamai added a comment to D17167: Fix bug with register values byte order in expression evaluation.

Are the changes correct? And if so, could someone commit it for me? I don't have commit access.

Feb 26 2016, 7:52 AM

Feb 19 2016

mamai updated the diff for D17167: Fix bug with register values byte order in expression evaluation.

I have updated the patch to add the assertion.

Feb 19 2016, 6:53 AM

Feb 17 2016

mamai added a reviewer for D17167: Fix bug with register values byte order in expression evaluation: clayborg.
Feb 17 2016, 6:53 AM

Feb 11 2016

mamai retitled D17167: Fix bug with register values byte order in expression evaluation from to Fix bug with register values byte order in expression evaluation.
Feb 11 2016, 1:21 PM

Feb 9 2016

mamai added a comment to D16868: [lldb] Fix invalid shift operator overload in Scalar.

I don't have commit access. It would be great if you can push it for me. Thanks !

Feb 9 2016, 5:49 AM

Feb 8 2016

mamai updated the diff for D16868: [lldb] Fix invalid shift operator overload in Scalar.

Added a small unit test for scalar right shift operator, which invokes the >>= operator.

Feb 8 2016, 10:20 AM
mamai added a comment to D16868: [lldb] Fix invalid shift operator overload in Scalar.

Scalar::operator<<= works well as-is because it uses APInt &operator<<=(unsigned shiftAmt), whereas the right shift equivalent is not implemented. Should I add APInt &operator>>=, or should I change Scalar::operator<<= for consistency ?

Feb 8 2016, 9:00 AM
mamai updated the diff for D16868: [lldb] Fix invalid shift operator overload in Scalar.
Feb 8 2016, 6:43 AM

Feb 3 2016

mamai retitled D16868: [lldb] Fix invalid shift operator overload in Scalar from to [lldb] Fix invalid shift operator overload in Scalar.
Feb 3 2016, 3:03 PM