- User Since
- Jan 31 2020, 8:11 AM (28 w, 7 h)
Sat, Aug 8
Minor fixes in comments.
Hi Uday @bondhugula Thank you for your latest review :) Please see whether the latest version looks better.
Improved comments of getIndexSet.
Fri, Aug 7
Thank you Uday! @bondhugula Would you mind helping me commit this if it looks OK :)
Removed redundant getOperation().
Thu, Aug 6
Thank you very much Uday @bondhugula for all your help! I've just improved the diff based on your reviews, would you mind taking a look again when you have time? Thanks!
- Changed the naming of getIVs to getEnclosingAffineForAndIfOps
- Improved updateValuePosMap documentation
- Added comments to isSymbolDetermined
Hi Uday @bondhugula sorry to bother but would you mind giving this diff one more round of review when you've got time? Thanks!
Sun, Aug 2
Improved comments in buildDimAndSymbolPositonMaps.
Sat, Aug 1
Fixed OpInst typo and removed unnecessary comments.
Rephrased the doc comment of checkTilingLegality.
Thank you again Uday for your reviews! Please check again if I've missed any other things. :)
Improved doc and API design based on reviews.
Thank you very much Uday for pointing out all these issues! Sorry for costing you much time for doing so. I have fixed all of them and some other similar things. Would you mind taking another round of review to see if it is OK? Thanks!
Fixed issues pinpointed by review comments.
Hi @bondhugula Thank you very much for your detailed comments :) I've improved this diff based on your suggestions. Please do let me know if there is any other I should look at.
Fixed several issues based on review comments.
Fri, Jul 31
Hi Uday @bondhugula would you mind reviewing this again when you're available? Thanks!
Improved loop tiling legality checking implementation - now based on ensuring non-negative dependence component exists.
Thu, Jul 30
Hi @bondhugula Thank you for your comments. I've updated this diff according to your suggestions.
Improved API design, comments, and unittests.
Wed, Jul 29
Improved comments a bit.
Please do ignore my previous comment on the current implementation doesn't work well. It does work properly based on the test case I've provided.
Fixed problem in constraint system
Hi Uday (@bondhugula)
Squashed recent commits into one.
- Added unittest for memref-dependence-check with affine.if
- Fixed issues in getCommonBlock that doesn't consider the existence of affine.if
- Fixed issues in addAffineIfDomain that doesn't consider local variable
- Changed getInstIndexSet naming to getOpIndexSet
Tue, Jul 28
Hi Alex @ftynse , if this diff looks ok would you mind helping me committing it? Thanks!
Mon, Jul 27
Fixed top-level comment problems and reverted AffineOps.cpp changes.
Sun, Jul 26
Fri, Jul 24
Thank you very much @bondhugula for your comments! I've updated this diff accordingly :)
Fixed issues about cmd, file naming, and missing NL.
Reverted the accidental change in loop-tiling.mlir
Thu, Jul 23
Added memory layouts to the first two examples.
Tue, Jul 21
Finished fixing other examples in the properties section.