Page MenuHomePhabricator

kumasento (Ruizhe Zhao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2020, 8:11 AM (28 w, 7 h)

Recent Activity

Sat, Aug 8

kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Some minor fixes.

Sat, Aug 8, 9:51 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Minor fixes in comments.

Sat, Aug 8, 9:50 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Hi Uday @bondhugula Thank you for your latest review :) Please see whether the latest version looks better.

Sat, Aug 8, 12:37 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved comments of getIndexSet.

Sat, Aug 8, 12:35 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved comments.

Sat, Aug 8, 12:32 AM · Restricted Project

Fri, Aug 7

kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you Uday! @bondhugula Would you mind helping me commit this if it looks OK :)

Fri, Aug 7, 4:20 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Removed redundant getOperation().

Fri, Aug 7, 4:20 AM · Restricted Project

Thu, Aug 6

kumasento added inline comments to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Thu, Aug 6, 1:46 PM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you very much Uday @bondhugula for all your help! I've just improved the diff based on your reviews, would you mind taking a look again when you have time? Thanks!

Thu, Aug 6, 8:16 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
  1. Changed the naming of getIVs to getEnclosingAffineForAndIfOps
  2. Improved updateValuePosMap documentation
  3. Added comments to isSymbolDetermined
Thu, Aug 6, 8:15 AM · Restricted Project
kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Looks great - let me know if you'd like me to commit.

Thu, Aug 6, 7:28 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Hi Uday @bondhugula sorry to bother but would you mind giving this diff one more round of review when you've got time? Thanks!

Thu, Aug 6, 1:34 AM · Restricted Project

Sun, Aug 2

kumasento retitled D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops from [MLIR] Consider AffineIfOp when getting the index set of an operation wrapped in nested loops to [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Sun, Aug 2, 2:42 AM · Restricted Project
kumasento retitled D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops from [MLIR][Affine] Take into account AffineIfOp when getting the index set of an operation wrapped in nested loops to [MLIR] Consider AffineIfOp when getting the index set of an operation wrapped in nested loops.
Sun, Aug 2, 2:42 AM · Restricted Project
kumasento retitled D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops from [MLIR][Affine] Take into account `affine.if` in `getInstIndexSet`. to [MLIR][Affine] Take into account AffineIfOp when getting the index set of an operation wrapped in nested loops.
Sun, Aug 2, 2:41 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved comments in buildDimAndSymbolPositonMaps.

Sun, Aug 2, 2:32 AM · Restricted Project

Sat, Aug 1

kumasento added inline comments to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:57 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Fixed OpInst typo and removed unnecessary comments.

Sat, Aug 1, 8:57 AM · Restricted Project
kumasento added inline comments to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:26 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Rephrased the doc comment of checkTilingLegality.

Sat, Aug 1, 8:24 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you again Uday for your reviews! Please check again if I've missed any other things. :)

Sat, Aug 1, 8:11 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved doc and API design based on reviews.

Sat, Aug 1, 8:09 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you very much Uday for pointing out all these issues! Sorry for costing you much time for doing so. I have fixed all of them and some other similar things. Would you mind taking another round of review to see if it is OK? Thanks!

Sat, Aug 1, 5:06 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Fixed issues pinpointed by review comments.

Sat, Aug 1, 5:05 AM · Restricted Project
kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Hi @bondhugula Thank you very much for your detailed comments :) I've improved this diff based on your suggestions. Please do let me know if there is any other I should look at.

Sat, Aug 1, 4:07 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Fixed several issues based on review comments.

Sat, Aug 1, 4:02 AM · Restricted Project
kumasento retitled D84882: [MLIR] Add tiling validity check to loop tiling pass from [MLIR][Affine] Added legality validator for loop tiling to [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 3:39 AM · Restricted Project

Fri, Jul 31

kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Hi Uday @bondhugula would you mind reviewing this again when you're available? Thanks!

Fri, Jul 31, 10:52 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Improved loop tiling legality checking implementation - now based on ensuring non-negative dependence component exists.

Fri, Jul 31, 10:50 AM · Restricted Project
kumasento retitled D84882: [MLIR] Add tiling validity check to loop tiling pass from [MLIR][Affine] Added checkTilingLegality to [MLIR][Affine] Added legality validator for loop tiling.
Fri, Jul 31, 10:09 AM · Restricted Project

Thu, Jul 30

kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Please expand the commit summary a little. The h in h^T . R here are always the canonical directions with the current tiling pass. You really don't need to do anything with FlatAffineConstraints. Instead, the conditions of Irigoin and Triolet would just simplify here to checking whether all dependence components are non-negative along the dimensions you want to tile. And checking this by simply looking at the dependence information is sufficient. You may want to expand on the motivation if you intended something else.

Thu, Jul 30, 7:35 AM · Restricted Project
kumasento added inline comments to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Thu, Jul 30, 1:40 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Hi @bondhugula Thank you for your comments. I've updated this diff according to your suggestions.

Thu, Jul 30, 1:38 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved API design, comments, and unittests.

Thu, Jul 30, 1:36 AM · Restricted Project

Wed, Jul 29

kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Improved comments a bit.

Wed, Jul 29, 3:15 PM · Restricted Project
kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Please do ignore my previous comment on the current implementation doesn't work well. It does work properly based on the test case I've provided.

Wed, Jul 29, 3:10 PM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Fixed problem in constraint system

Wed, Jul 29, 3:06 PM · Restricted Project
kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Hi Uday (@bondhugula)

Wed, Jul 29, 12:03 PM · Restricted Project
kumasento added a reviewer for D84882: [MLIR] Add tiling validity check to loop tiling pass: bondhugula.
Wed, Jul 29, 11:53 AM · Restricted Project
kumasento requested review of D84882: [MLIR] Add tiling validity check to loop tiling pass.
Wed, Jul 29, 11:52 AM · Restricted Project
kumasento added a comment to D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg..

Much better, thanks @kumasento

Wed, Jul 29, 10:20 AM · Restricted Project
kumasento added a reviewer for D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg.: mehdi_amini.
Wed, Jul 29, 6:11 AM · Restricted Project
kumasento abandoned D84830: Added if unittests & fixed bugs w/ local var.
Wed, Jul 29, 6:05 AM · Restricted Project
kumasento reclaimed D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Wed, Jul 29, 6:05 AM · Restricted Project
kumasento abandoned D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Wed, Jul 29, 6:04 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Squashed recent commits into one.

Wed, Jul 29, 4:04 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
  1. Added unittest for memref-dependence-check with affine.if
  2. Fixed issues in getCommonBlock that doesn't consider the existence of affine.if
  3. Fixed issues in addAffineIfDomain that doesn't consider local variable
  4. Changed getInstIndexSet naming to getOpIndexSet
Wed, Jul 29, 4:04 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thanks very much for completing these! I'll be able to review this tomorrow. You could consider adding a few test cases to exercise these. These changes could be tested by adding test cases with affine.if's for say memref dep analysis or memref-bound-checking or affine data copy generation - whichever appears easier.

Wed, Jul 29, 4:04 AM · Restricted Project
kumasento requested review of D84830: Added if unittests & fixed bugs w/ local var.
Wed, Jul 29, 4:04 AM · Restricted Project

Tue, Jul 28

kumasento added a comment to D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.

Hi Alex @ftynse , if this diff looks ok would you mind helping me committing it? Thanks!

Tue, Jul 28, 12:48 AM · Restricted Project

Mon, Jul 27

kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Fixed top-level comment problems and reverted AffineOps.cpp changes.

Mon, Jul 27, 2:09 PM · Restricted Project
kumasento added a reviewer for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops: bondhugula.
Mon, Jul 27, 12:59 PM · Restricted Project
Herald added a project to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops: Restricted Project.
Mon, Jul 27, 12:59 PM · Restricted Project

Sun, Jul 26

kumasento added a comment to D84531: [MLIR][Affine] Add test for non-hyperrectangular loop tiling.

Let me know if you'd like me to commit this for you.

Sun, Jul 26, 1:01 AM · Restricted Project

Fri, Jul 24

kumasento added a reviewer for D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg.: ftynse.
Fri, Jul 24, 11:19 AM · Restricted Project
kumasento added a comment to D84531: [MLIR][Affine] Add test for non-hyperrectangular loop tiling.

Thank you very much @bondhugula for your comments! I've updated this diff accordingly :)

Fri, Jul 24, 11:18 AM · Restricted Project
kumasento updated the diff for D84531: [MLIR][Affine] Add test for non-hyperrectangular loop tiling.

Fixed issues about cmd, file naming, and missing NL.

Fri, Jul 24, 11:18 AM · Restricted Project
kumasento updated the diff for D84531: [MLIR][Affine] Add test for non-hyperrectangular loop tiling.

Reverted the accidental change in loop-tiling.mlir

Fri, Jul 24, 7:09 AM · Restricted Project
Herald added a project to D84531: [MLIR][Affine] Add test for non-hyperrectangular loop tiling: Restricted Project.
Fri, Jul 24, 7:07 AM · Restricted Project

Thu, Jul 23

kumasento retitled D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc from Fixed obsolete examples in the MLIR Linalg Dialect doc to [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.
Thu, Jul 23, 10:45 AM · Restricted Project
kumasento retitled D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg. from Use AnyTypeOf for LinalgOperand for better error msg. to [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg..
Thu, Jul 23, 10:44 AM · Restricted Project
Herald added a project to D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg.: Restricted Project.
Thu, Jul 23, 9:23 AM · Restricted Project
kumasento added inline comments to D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.
Thu, Jul 23, 9:02 AM · Restricted Project
kumasento updated the diff for D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.

Added memory layouts to the first two examples.

Thu, Jul 23, 8:57 AM · Restricted Project

Tue, Jul 21

kumasento updated the summary of D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.
Tue, Jul 21, 1:40 PM · Restricted Project
kumasento added inline comments to D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.
Tue, Jul 21, 5:23 AM · Restricted Project
kumasento added inline comments to D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.
Tue, Jul 21, 5:10 AM · Restricted Project
kumasento updated the diff for D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc.

Finished fixing other examples in the properties section.

Tue, Jul 21, 5:04 AM · Restricted Project
Herald added a project to D84229: [MLIR][Linalg] Fixed obsolete examples in the MLIR Linalg Dialect doc: Restricted Project.
Tue, Jul 21, 4:02 AM · Restricted Project