Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (275 w, 1 d)

Recent Activity

Wed, Jan 5

krasimir added a reviewer for D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0: mprobst.
Wed, Jan 5, 2:15 AM · Restricted Project, Restricted Project

Fri, Dec 24

krasimir added a reverting change for rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library.: rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library.".
Fri, Dec 24, 3:05 AM
krasimir committed rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library." (authored by krasimir).
Revert "[ASan] Moved optimized callbacks into a separate library."
Fri, Dec 24, 3:05 AM
krasimir added a reverting change for D116182: [ASan] Moved optimized callbacks into a separate library.: rG969a51ff3632: Revert "[ASan] Moved optimized callbacks into a separate library.".
Fri, Dec 24, 3:05 AM · Restricted Project, Restricted Project

Wed, Dec 22

krasimir added a comment to D116031: [ArgPromotion][TTI] Pass types to ABI compatibility hook.

Added a dependent quick fix https://github.com/llvm/llvm-project/commit/37c8d5915f37432f49fd4b0e6ec318ae68750af1.

Wed, Dec 22, 1:08 AM · Restricted Project
krasimir committed rG37c8d5915f37: fix build bots after f5ac23b5ae090d64d31f0b6624470af97dc20bf6 (authored by krasimir).
fix build bots after f5ac23b5ae090d64d31f0b6624470af97dc20bf6
Wed, Dec 22, 1:05 AM

Dec 19 2021

krasimir committed rG3a3fcd6a23ad: [clang-format] add regression tests for braced lists (authored by krasimir).
[clang-format] add regression tests for braced lists
Dec 19 2021, 7:10 AM
krasimir closed D116001: [clang-format] add regression tests for braced lists.
Dec 19 2021, 7:09 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rGc41b3b0fa0f4: [clang-format] Adjust braced list detection: rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:06 AM
krasimir committed rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection" (authored by krasimir).
Revert "[clang-format] Adjust braced list detection"
Dec 19 2021, 7:06 AM
krasimir added a reverting change for D114583: [clang-format] Adjust braced list detection: rGd96bf6ea4618: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:05 AM · Restricted Project, Restricted Project
krasimir closed D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 7:05 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D116001: [clang-format] add regression tests for braced lists: MyDeveloperDay.
Dec 19 2021, 6:12 AM · Restricted Project, Restricted Project
krasimir requested review of D116001: [clang-format] add regression tests for braced lists.
Dec 19 2021, 6:11 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D116000: Revert "[clang-format] Adjust braced list detection": MyDeveloperDay.
Dec 19 2021, 5:50 AM · Restricted Project, Restricted Project
krasimir added a reverting change for rGc41b3b0fa0f4: [clang-format] Adjust braced list detection: D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM
krasimir requested review of D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM · Restricted Project, Restricted Project
krasimir added a reverting change for D114583: [clang-format] Adjust braced list detection: D116000: Revert "[clang-format] Adjust braced list detection".
Dec 19 2021, 5:49 AM · Restricted Project, Restricted Project
krasimir committed rGeeed24e766a1: [Bazel] update build files for (authored by krasimir).
[Bazel] update build files for
Dec 19 2021, 5:39 AM

Dec 13 2021

krasimir added a comment to D114583: [clang-format] Adjust braced list detection.

It appears that this regressed the formatting of initializer lists in some cases:

# Before
% cat ~/test.cc
class A {
  A() : a{} {}
Dec 13 2021, 2:54 AM · Restricted Project, Restricted Project

Nov 16 2021

krasimir added a comment to D113957: DebugInfo: Stop modifying Operation::Error inside of verify().

Thank you! This and the follow-up https://reviews.llvm.org/D113958 look reasonable to me.
Letting the people more familiar with the DebugInfo parts of the codebase have a chance to review.

Nov 16 2021, 2:47 AM · Restricted Project
krasimir added a comment to D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.

I pushed fa39ec5786c08e78cc247a48c17aef66ca5985fb, a35226b9b606f4ea32e7db9e2f4de0d99ab6bef0, and 7a1b670f0f2f0a38a673b5554bb2c4d9d50447bf to fix most of the blockers. Then https://reviews.llvm.org/D113957 fixes Operation::verify() and https://reviews.llvm.org/D113958 makes it iterate over const Operation and removes the mutable.

Thank you! These look good!

Nov 16 2021, 2:41 AM · Restricted Project

Nov 15 2021

krasimir added a reviewer for D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c: dexonsmith.
Nov 15 2021, 2:12 PM · Restricted Project
krasimir added a comment to D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.

Sorry for submitting quickly, I just wanted to unblock build bots. I still think that this patch is OK considering the weirdness of this Operation class.

Nov 15 2021, 2:10 PM · Restricted Project
krasimir committed rG3d1d8c767be5: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c (authored by krasimir).
[llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c
Nov 15 2021, 1:09 PM
krasimir closed D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 1:09 PM · Restricted Project
krasimir updated subscribers of D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 12:44 PM · Restricted Project
krasimir added a reviewer for D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c: bkramer.
Nov 15 2021, 12:43 PM · Restricted Project
krasimir requested review of D113934: [llvm] adapt DWARFExpression.h for 6b9b86db9dd974585a5c71cf2e5231d1e3385f7c.
Nov 15 2021, 12:42 PM · Restricted Project

Oct 1 2021

krasimir added a reverting change for rG1fb37334bdb3: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction…: rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)….
Oct 1 2021, 2:40 AM
krasimir committed rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)… (authored by krasimir).
Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)…
Oct 1 2021, 2:40 AM
krasimir added a reverting change for D108136: [LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction patterns: rG685f1bfd0af3: Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y)….
Oct 1 2021, 2:40 AM · Restricted Project

Sep 29 2021

krasimir committed rG6cffc35746b4: [Bazel] fix for aa53785f23b2b89a9a423af131697b1f7c92869f (authored by krasimir).
[Bazel] fix for aa53785f23b2b89a9a423af131697b1f7c92869f
Sep 29 2021, 1:54 AM

Sep 27 2021

krasimir committed rG8cb234e07d46: [Bazel] Fix for 6498b0e991babe71e69ab02e1afa7f5535f2be0f (authored by krasimir).
[Bazel] Fix for 6498b0e991babe71e69ab02e1afa7f5535f2be0f
Sep 27 2021, 1:45 AM
krasimir committed rG92b475f0b079: [lldb] silence -Wsometimes-uninitialized warnings (authored by krasimir).
[lldb] silence -Wsometimes-uninitialized warnings
Sep 27 2021, 12:39 AM

Sep 24 2021

krasimir added a comment to D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA.

I like this. Consider only displaying the major version (e.g., clang-format 14 instead of clang-format 14.0.0).

Sep 24 2021, 11:25 AM · Restricted Project, Restricted Project

Aug 27 2021

krasimir accepted D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change.
Aug 27 2021, 6:06 AM · Restricted Project, Restricted Project
krasimir accepted D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change.
Aug 27 2021, 2:22 AM · Restricted Project, Restricted Project

Aug 25 2021

krasimir committed rGe708808f875f: [clang-format] Support TypeScript override keyword (authored by jankuehle).
[clang-format] Support TypeScript override keyword
Aug 25 2021, 5:13 AM
krasimir closed D108692: [clang-format] Support TypeScript override keyword.
Aug 25 2021, 5:13 AM · Restricted Project, Restricted Project
krasimir accepted D108692: [clang-format] Support TypeScript override keyword.

Thank you!
Let me know if you would like me to commit this for you in case you don't have commit rights for LLVM.

Aug 25 2021, 3:40 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D108692: [clang-format] Support TypeScript override keyword: krasimir.
Aug 25 2021, 3:33 AM · Restricted Project, Restricted Project

Aug 24 2021

krasimir committed rGbefb9dc3694e: [clang-format] keep TypeScript argument decorators in line (authored by krasimir).
[clang-format] keep TypeScript argument decorators in line
Aug 24 2021, 3:38 AM
krasimir closed D108620: [clang-format] keep TypeScript argument decorators in line.
Aug 24 2021, 3:38 AM · Restricted Project, Restricted Project
krasimir added inline comments to D108620: [clang-format] keep TypeScript argument decorators in line.
Aug 24 2021, 3:05 AM · Restricted Project, Restricted Project
krasimir updated the diff for D108620: [clang-format] keep TypeScript argument decorators in line.
  • consider also functions and setters
Aug 24 2021, 3:04 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D108620: [clang-format] keep TypeScript argument decorators in line: MyDeveloperDay.
Aug 24 2021, 2:42 AM · Restricted Project, Restricted Project
krasimir requested review of D108620: [clang-format] keep TypeScript argument decorators in line.
Aug 24 2021, 2:23 AM · Restricted Project, Restricted Project

Aug 23 2021

krasimir committed rGf3671a688db2: [clang-format] break after the closing paren of a TypeScript decoration (authored by krasimir).
[clang-format] break after the closing paren of a TypeScript decoration
Aug 23 2021, 6:53 AM
krasimir closed D108538: [clang-format] break after the closing paren of a TypeScript decoration.
Aug 23 2021, 6:53 AM · Restricted Project, Restricted Project
krasimir updated the summary of D108538: [clang-format] break after the closing paren of a TypeScript decoration.
Aug 23 2021, 3:43 AM · Restricted Project, Restricted Project
krasimir added a project to D108538: [clang-format] break after the closing paren of a TypeScript decoration: Restricted Project.
Aug 23 2021, 3:42 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D108538: [clang-format] break after the closing paren of a TypeScript decoration: MyDeveloperDay.
Aug 23 2021, 3:41 AM · Restricted Project, Restricted Project
krasimir updated the summary of D108538: [clang-format] break after the closing paren of a TypeScript decoration.
Aug 23 2021, 3:40 AM · Restricted Project, Restricted Project
krasimir requested review of D108538: [clang-format] break after the closing paren of a TypeScript decoration.
Aug 23 2021, 3:39 AM · Restricted Project, Restricted Project

Aug 12 2021

krasimir committed rG45934922fa88: [clang-format] improve distinction of K&R function definitions vs attributes (authored by krasimir).
[clang-format] improve distinction of K&R function definitions vs attributes
Aug 12 2021, 1:30 AM
krasimir closed D107950: [clang-format] improve distinction of K&R function definitions vs attributes.
Aug 12 2021, 1:29 AM · Restricted Project, Restricted Project
krasimir added reviewers for D107950: [clang-format] improve distinction of K&R function definitions vs attributes: owenpan, MyDeveloperDay.
Aug 12 2021, 12:30 AM · Restricted Project, Restricted Project
krasimir requested review of D107950: [clang-format] improve distinction of K&R function definitions vs attributes.
Aug 12 2021, 12:30 AM · Restricted Project, Restricted Project

Aug 11 2021

krasimir committed rG0fc27ef19670: [clang-format] handle trailing comments in function definition detection (authored by krasimir).
[clang-format] handle trailing comments in function definition detection
Aug 11 2021, 11:57 PM
krasimir closed D107907: [clang-format] handle trailing comments in function definition detection.
Aug 11 2021, 11:57 PM · Restricted Project, Restricted Project
krasimir updated the diff for D107907: [clang-format] handle trailing comments in function definition detection.
  • apply reviewer suggestion
Aug 11 2021, 11:54 PM · Restricted Project, Restricted Project
krasimir added a reviewer for D107907: [clang-format] handle trailing comments in function definition detection: owenpan.
Aug 11 2021, 8:07 AM · Restricted Project, Restricted Project
krasimir requested review of D107907: [clang-format] handle trailing comments in function definition detection.
Aug 11 2021, 8:06 AM · Restricted Project, Restricted Project

Aug 3 2021

krasimir committed rGf6bc614546e1: [clan-format] detect function definitions more conservatively (authored by krasimir).
[clan-format] detect function definitions more conservatively
Aug 3 2021, 7:21 AM
krasimir closed D107269: [clan-format] detect function definitions more conservatively.
Aug 3 2021, 7:20 AM · Restricted Project, Restricted Project
krasimir added inline comments to D107269: [clan-format] detect function definitions more conservatively.
Aug 3 2021, 2:55 AM · Restricted Project, Restricted Project
krasimir updated the diff for D107269: [clan-format] detect function definitions more conservatively.
  • apply review suggestion
Aug 3 2021, 2:52 AM · Restricted Project, Restricted Project
krasimir committed rG4f4f2783056f: [clang-format] don't break between function and function name in JS (authored by krasimir).
[clang-format] don't break between function and function name in JS
Aug 3 2021, 2:19 AM
krasimir closed D107267: [clang-format] don't break between function and function name in JS.
Aug 3 2021, 2:19 AM · Restricted Project, Restricted Project

Aug 2 2021

krasimir added reviewers for D107269: [clan-format] detect function definitions more conservatively: MyDeveloperDay, owenpan.
Aug 2 2021, 6:02 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D107267: [clang-format] don't break between function and function name in JS: owenpan.
Aug 2 2021, 6:01 AM · Restricted Project, Restricted Project
krasimir requested review of D107269: [clan-format] detect function definitions more conservatively.
Aug 2 2021, 6:01 AM · Restricted Project, Restricted Project
krasimir updated the summary of D107267: [clang-format] don't break between function and function name in JS.
Aug 2 2021, 5:28 AM · Restricted Project, Restricted Project
krasimir requested review of D107267: [clang-format] don't break between function and function name in JS.
Aug 2 2021, 5:27 AM · Restricted Project, Restricted Project

Jul 8 2021

krasimir added a comment to D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel..

I'm unfamiliar with the altivec API. What's a reasonable source code update that preserves the current default behavior -altivec-src-compat=mixed under -altivec-src-compat=xl, i.e., under -altivec-src-compat=xl how would we compare vector bool or vector pixel to produce a vector?

For vector bool comparison one could use vec_cmpeq and vec_compne (see https://www.ibm.com/docs/en/xl-c-and-cpp-linux/16.1.1?topic=functions-vec-cmpeq). However, vec_cmp* interfaces do not currently support vector pixel. Do you have a concrete use case for comparing vector pixels? If so I think we should consider adding corresponding overloads to altivec.h.

Jul 8 2021, 1:00 AM · Restricted Project

Jul 1 2021

krasimir added a comment to D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel..

I'm unfamiliar with the altivec API. What's a reasonable source code update that preserves the current default behavior -altivec-src-compat=mixed under -altivec-src-compat=xl, i.e., under -altivec-src-compat=xl how would we compare vector bool or vector pixel to produce a vector?

Jul 1 2021, 2:43 AM · Restricted Project

Jun 15 2021

krasimir committed rG54bd95cd96bc: [clang-format] distinguish function type casts after… (authored by krasimir).
[clang-format] distinguish function type casts after…
Jun 15 2021, 1:29 AM
krasimir closed D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba.
Jun 15 2021, 1:29 AM · Restricted Project

Jun 14 2021

krasimir updated the summary of D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba.
Jun 14 2021, 2:53 AM · Restricted Project
krasimir requested review of D104209: [clang-format] distinguish function type casts after 21c18d5a04316891110cecc2bf37ce51533decba.
Jun 14 2021, 2:51 AM · Restricted Project

Jun 11 2021

krasimir accepted D104101: clang-format: [JS] don't sort named imports if off..
Jun 11 2021, 2:56 AM · Restricted Project

May 10 2021

krasimir added a comment to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

Do we have some widely used code style that requires the new option (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options)?
I agree with @MyDeveloperDay that this option as-is is likely not addressing all the cases where we would want this to apply.

May 10 2021, 2:26 AM · Restricted Project, Restricted Project

May 5 2021

krasimir added inline comments to D101702: [clang-format] Add more support for C# 8 nullables.
May 5 2021, 2:41 AM · Restricted Project, Restricted Project
krasimir accepted D101702: [clang-format] Add more support for C# 8 nullables.
May 5 2021, 2:34 AM · Restricted Project, Restricted Project

May 4 2021

krasimir committed rG8fa56f7ededc: [clang-format] Prevent extraneous space insertion in bitshift operators (authored by penagos).
[clang-format] Prevent extraneous space insertion in bitshift operators
May 4 2021, 3:30 AM
krasimir closed D100778: [clang-format] Prevent extraneous space insertion in bitshift operators.
May 4 2021, 3:29 AM · Restricted Project
krasimir added a comment to D100778: [clang-format] Prevent extraneous space insertion in bitshift operators.

@penagos, I'll submit this for you.

May 4 2021, 2:32 AM · Restricted Project

Apr 30 2021

krasimir accepted D101515: clang-format: [JS] handle "off" in imports.
Apr 30 2021, 4:00 AM · Restricted Project

Apr 29 2021

krasimir added a comment to D101515: clang-format: [JS] handle "off" in imports.

@h-joo , seems we had a comment race :D cheers!

Apr 29 2021, 2:20 PM · Restricted Project
krasimir added inline comments to D101515: clang-format: [JS] handle "off" in imports.
Apr 29 2021, 2:18 PM · Restricted Project

Apr 27 2021

krasimir added a comment to D100238: [sanitizer] Set IndentPPDirectives: AfterHash in .clang-format.

@euhlmann @krasimir How hard to support one-column indentation for preprocessor directives only? The majority of the sanitizer code base uses one-column indentation for nested directives.

Apr 27 2021, 1:36 AM · Restricted Project
krasimir accepted D100778: [clang-format] Prevent extraneous space insertion in bitshift operators.
Apr 27 2021, 1:26 AM · Restricted Project

Apr 26 2021

krasimir added inline comments to D100778: [clang-format] Prevent extraneous space insertion in bitshift operators.
Apr 26 2021, 2:33 AM · Restricted Project
krasimir committed rG5987d7c59da5: [clang-format] fix indent in alignChainedConditionals (authored by krasimir).
[clang-format] fix indent in alignChainedConditionals
Apr 26 2021, 2:07 AM
krasimir closed D101033: [clang-format] fix indent in alignChainedConditionals.
Apr 26 2021, 2:07 AM · Restricted Project
krasimir updated the summary of D101033: [clang-format] fix indent in alignChainedConditionals.
Apr 26 2021, 2:00 AM · Restricted Project

Apr 23 2021

krasimir added a reviewer for D101033: [clang-format] fix indent in alignChainedConditionals: Typz.
Apr 23 2021, 7:06 AM · Restricted Project
krasimir added a comment to D101033: [clang-format] fix indent in alignChainedConditionals.

I also have a limited understanding based on the original patch https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea together with examining affected test cases.
I believe the intention of this section is to handle, e.g., the alignment of eeeeeeeeeeeeeeeeee and bbbbbbbbbbbbbbbb and 3333333333333333 in cases like this, where the previous toke is the ::

return aaaaaaaaaaaaaaaa ? (aaaaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbb :
                           ccccccccccccc     ? dddddddddddddddddd :
                                               eeeeeeeeeeeeeeeeee) :
       bbbbbbbbbbbbbbbb ? 2222222222222222 :
                          3333333333333333;

The check for tok::question that I remove in this context seems superfluous in the first place: I believe currently we don't support a style where chained ternaries are formatted with newlines after the ?-s and alignment across the operands on a new line after the line ending with ?.

Apr 23 2021, 7:06 AM · Restricted Project

Apr 22 2021

krasimir added a reviewer for D101033: [clang-format] fix indent in alignChainedConditionals: sammccall.
Apr 22 2021, 2:46 AM · Restricted Project