Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (224 w, 14 h)

Recent Activity

Dec 17 2020

krasimir committed rGe71a4cc20789: fix a -Wunused-variable warning in release build (authored by krasimir).
fix a -Wunused-variable warning in release build
Dec 17 2020, 2:53 AM
krasimir added a reverting change for rGcee1e7d14f46: [libc][NFC][Obvious] Remove few unnecessary #include directives in tests.: rG352cba2441c6: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h.
Dec 17 2020, 2:22 AM
krasimir committed rG352cba2441c6: [libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h (authored by krasimir).
[libc] add back math.h #include utils/FPUtil/ManipulationFunctions.h
Dec 17 2020, 2:22 AM

Dec 9 2020

krasimir accepted D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess.

This is very nice :)

Dec 9 2020, 7:21 AM · Restricted Project, Restricted Project

Dec 6 2020

krasimir added inline comments to D92257: [clang-format] Add option to control the space at the front of a line comment.
Dec 6 2020, 10:46 AM · Restricted Project, Restricted Project

Nov 11 2020

krasimir committed rG77b484116971: [clang-format] do not break before @tags in JS comments (authored by krasimir).
[clang-format] do not break before @tags in JS comments
Nov 11 2020, 3:31 AM
krasimir closed D91078: [clang-format] do not break before @tags in JS comments.
Nov 11 2020, 3:31 AM · Restricted Project, Restricted Project

Nov 10 2020

krasimir accepted D91132: clang-format: [JS] support new assignment operators..
Nov 10 2020, 12:21 AM · Restricted Project

Nov 9 2020

krasimir added a reviewer for D91078: [clang-format] do not break before @tags in JS comments: mprobst.
Nov 9 2020, 7:09 AM · Restricted Project, Restricted Project
krasimir added inline comments to D91078: [clang-format] do not break before @tags in JS comments.
Nov 9 2020, 7:00 AM · Restricted Project, Restricted Project
krasimir requested review of D91078: [clang-format] do not break before @tags in JS comments.
Nov 9 2020, 6:57 AM · Restricted Project, Restricted Project
krasimir committed rG7b7170fa5791: [clang-format] avoid introducing multiline comments (authored by krasimir).
[clang-format] avoid introducing multiline comments
Nov 9 2020, 6:30 AM
krasimir closed D90949: [clang-format] avoid introducing multiline comments.
Nov 9 2020, 6:30 AM · Restricted Project, Restricted Project
krasimir added inline comments to D90949: [clang-format] avoid introducing multiline comments.
Nov 9 2020, 2:20 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90949: [clang-format] avoid introducing multiline comments.
  • address review comments
Nov 9 2020, 2:17 AM · Restricted Project, Restricted Project

Nov 6 2020

krasimir added a project to D90949: [clang-format] avoid introducing multiline comments: Restricted Project.
Nov 6 2020, 8:26 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D90949: [clang-format] avoid introducing multiline comments: sammccall.
Nov 6 2020, 8:16 AM · Restricted Project, Restricted Project
krasimir requested review of D90949: [clang-format] avoid introducing multiline comments.
Nov 6 2020, 8:16 AM · Restricted Project, Restricted Project
krasimir committed rG2dbcbd357d1d: [clang-format] do not break before { in JS comments (authored by krasimir).
[clang-format] do not break before { in JS comments
Nov 6 2020, 1:35 AM
krasimir closed D90908: [clang-format] do not break before { in JS comments.
Nov 6 2020, 1:35 AM · Restricted Project, Restricted Project
krasimir added a reviewer for D90908: [clang-format] do not break before { in JS comments: mprobst.
Nov 6 2020, 12:53 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90908: [clang-format] do not break before { in JS comments.

collect commits

Nov 6 2020, 12:52 AM · Restricted Project, Restricted Project
krasimir updated the diff for D90908: [clang-format] do not break before { in JS comments.

update test case range

Nov 6 2020, 12:50 AM · Restricted Project, Restricted Project
krasimir requested review of D90908: [clang-format] do not break before { in JS comments.
Nov 6 2020, 12:47 AM · Restricted Project, Restricted Project

Oct 29 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

This doe snot lgtm. clang-format should not depend on clangFrontend, see the lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find another fix here (and include a test for whatever this fixes). I'll revert this for now.

Oct 29 2020, 7:47 AM · Restricted Project, Restricted Project
krasimir committed rGdf00267f1fdb: clang-format: Add a consumer to diagnostics engine (authored by krasimir).
clang-format: Add a consumer to diagnostics engine
Oct 29 2020, 3:29 AM
krasimir closed D90121: clang-format: Add a consumer to diagnostics engine.
Oct 29 2020, 3:29 AM · Restricted Project, Restricted Project

Oct 28 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

@krasimir What would our next steps be to get this change into LLVM source tree? JIC, I don't have commit rights :)

Oct 28 2020, 1:58 PM · Restricted Project, Restricted Project

Oct 27 2020

krasimir accepted D90121: clang-format: Add a consumer to diagnostics engine.

Thank you! Your fix looks good for clang-format.

Oct 27 2020, 3:37 AM · Restricted Project, Restricted Project

Oct 26 2020

krasimir added a comment to D90121: clang-format: Add a consumer to diagnostics engine.

This looks reasonable.

Oct 26 2020, 1:44 AM · Restricted Project, Restricted Project

Aug 10 2020

krasimir removed a reviewer for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends: krasimir.
Aug 10 2020, 7:34 AM
krasimir removed a reviewer for D56345: [clang-format] Assert that filenames are not empty: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D58404: [clang-format] Add basic support for formatting C# files: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58819: [clang-format] clang-format off/on not respected when using C Style comments: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D58922: [clang-format] broken after lambda with return type template with boolean literal: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59627: [clang-format] Keep protobuf "package" statement on one line: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59629: [clang-format] correctly format protobuf fields named "enum".: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D60115: Adding 'CLion integration' to clang-format doc: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60308: Leave alone the semicolon after the MacroBlockBegin name: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60374: clang-format incorrectly indents wrapped closing parenthesis: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61001: [clang-format][tests] Explicitly specify style in some tests: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61276: [clang-format] Fix bug in block comment reflow that joins * and /: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61297: [clang-format] Fix bug that misses some function-like macro usages: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61559: Fix the crash when formatting unsupported encodings: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D64775: [Format/ObjC] Avoid breaking between unary operators and operands: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.: krasimir.
Aug 10 2020, 7:30 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D66650: clang-format: chromium style: Disable across-block include reordering.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D67750: Allow additional file suffixes/extensions considered as source in main include grouping: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68783: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2): krasimir.
Aug 10 2020, 7:28 AM · Restricted Project
krasimir removed a reviewer for D69971: clang-format: [JS] support null operators.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D69972: clang-format: [JS] test declared fields.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D71512: [clang-format] Fix short block when braking after control statement: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D73977: [clang-format] Allow a comment to follow a C# attribute specifier: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation: krasimir.
Aug 10 2020, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D75791: [clang-format] Added new option IndentExternBlock: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D76197: clang-format: Use block indentation for braced initializations: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D77682: [clang-format] Always break line after enum opening brace: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D78879: [clang-format] [PR45357] Fix issue found with operator spacing: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79008: [clang-format] insert space after C# keyword var in var (key, value): krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79204: [clang-format] NFC - clang-format the FormatTests: krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda: krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79372: [clang-format] [PR45126] Help text is missing all available formats: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79388: [clang-format] Fix AlignConsecutive on PP blocks: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79414: [clang-format] C# always regards && as a binary operator: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79465: [clang-format] Fix line lengths w/ comments in align: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79905: [clang-format] [PR44476] Add space between template and attribute: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension: krasimir.
Aug 10 2020, 7:20 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80309: [clang-format][docfix] Update predefined styles in docs: krasimir.
Aug 10 2020, 7:20 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80486: [clang-format][PR46043] Parse git config w/ implicit values: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project
krasimir removed a reviewer for D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style: krasimir.
Aug 10 2020, 7:18 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D82707: [clang][docs] Remove untracked files from formatted status: krasimir.
Aug 10 2020, 7:18 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack: krasimir.
Aug 10 2020, 7:17 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: krasimir.
Aug 10 2020, 7:16 AM · Restricted Project, Restricted Project

Aug 3 2020

krasimir accepted D85016: [clang-format] Add space between method modifier and a tuple return type in C#.

Thank you!

Aug 3 2020, 8:52 AM · Restricted Project

Jul 20 2020

krasimir added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

@wanders, thank you for digging through code to get a feeling of the usage!

Jul 20 2020, 3:38 AM · Restricted Project, Restricted Project

Jun 26 2020

krasimir added inline comments to D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 26 2020, 2:40 AM · Restricted Project