Page MenuHomePhabricator

krasimir (Krasimir Georgiev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2016, 5:32 AM (205 w, 6 d)

Recent Activity

Aug 10 2020

krasimir removed a reviewer for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends: krasimir.
Aug 10 2020, 7:34 AM
krasimir removed a reviewer for D56345: [clang-format] Assert that filenames are not empty: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language: krasimir.
Aug 10 2020, 7:34 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D57923: [Format/ObjC] Fix [foo bar]->baz formatting as lambda arrow: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project
krasimir removed a reviewer for D58404: [clang-format] Add basic support for formatting C# files: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58819: [clang-format] clang-format off/on not respected when using C Style comments: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D58922: [clang-format] broken after lambda with return type template with boolean literal: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D58941: [clang-format][docs][NFC] Fix example for Allman brace breaking style: krasimir.
Aug 10 2020, 7:33 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59627: [clang-format] Keep protobuf "package" statement on one line: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D59629: [clang-format] correctly format protobuf fields named "enum".: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D60115: Adding 'CLion integration' to clang-format doc: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60308: Leave alone the semicolon after the MacroBlockBegin name: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project
krasimir removed a reviewer for D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60374: clang-format incorrectly indents wrapped closing parenthesis: krasimir.
Aug 10 2020, 7:32 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61001: [clang-format][tests] Explicitly specify style in some tests: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project
krasimir removed a reviewer for D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61276: [clang-format] Fix bug in block comment reflow that joins * and /: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61297: [clang-format] Fix bug that misses some function-like macro usages: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D61559: Fix the crash when formatting unsupported encodings: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D64775: [Format/ObjC] Avoid breaking between unary operators and operands: krasimir.
Aug 10 2020, 7:31 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D65012: Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.: krasimir.
Aug 10 2020, 7:30 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D66650: clang-format: chromium style: Disable across-block include reordering.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D67750: Allow additional file suffixes/extensions considered as source in main include grouping: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project
krasimir removed a reviewer for D68072: [clang-format] Reference qualifiers in member templates causing extra indentation.: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68707: [clang-format] throws an incorrect assertion in consumeToken() formatting the MSVC stl: krasimir.
Aug 10 2020, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D68783: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2): krasimir.
Aug 10 2020, 7:28 AM · Restricted Project
krasimir removed a reviewer for D69971: clang-format: [JS] support null operators.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D69972: clang-format: [JS] test declared fields.: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D71512: [clang-format] Fix short block when braking after control statement: krasimir.
Aug 10 2020, 7:28 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D73977: [clang-format] Allow a comment to follow a C# attribute specifier: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.: krasimir.
Aug 10 2020, 7:27 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation: krasimir.
Aug 10 2020, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D75791: [clang-format] Added new option IndentExternBlock: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
krasimir removed a reviewer for D76197: clang-format: Use block indentation for braced initializations: krasimir.
Aug 10 2020, 7:25 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D77682: [clang-format] Always break line after enum opening brace: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D78879: [clang-format] [PR45357] Fix issue found with operator spacing: krasimir.
Aug 10 2020, 7:24 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79008: [clang-format] insert space after C# keyword var in var (key, value): krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79204: [clang-format] NFC - clang-format the FormatTests: krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda: krasimir.
Aug 10 2020, 7:23 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79372: [clang-format] [PR45126] Help text is missing all available formats: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79388: [clang-format] Fix AlignConsecutive on PP blocks: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79414: [clang-format] C# always regards && as a binary operator: krasimir.
Aug 10 2020, 7:22 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79465: [clang-format] Fix line lengths w/ comments in align: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D79905: [clang-format] [PR44476] Add space between template and attribute: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80115: [clang-format] [PR45816] Add AlignConsecutiveBitFields: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults: krasimir.
Aug 10 2020, 7:21 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension: krasimir.
Aug 10 2020, 7:20 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80309: [clang-format][docfix] Update predefined styles in docs: krasimir.
Aug 10 2020, 7:20 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80486: [clang-format][PR46043] Parse git config w/ implicit values: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project
krasimir removed a reviewer for D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases: krasimir.
Aug 10 2020, 7:19 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style: krasimir.
Aug 10 2020, 7:18 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D82707: [clang][docs] Remove untracked files from formatted status: krasimir.
Aug 10 2020, 7:18 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack: krasimir.
Aug 10 2020, 7:17 AM · Restricted Project, Restricted Project
krasimir removed a reviewer for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: krasimir.
Aug 10 2020, 7:16 AM · Restricted Project, Restricted Project

Aug 3 2020

krasimir accepted D85016: [clang-format] Add space between method modifier and a tuple return type in C#.

Thank you!

Aug 3 2020, 8:52 AM · Restricted Project

Jul 20 2020

krasimir added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

@wanders, thank you for digging through code to get a feeling of the usage!

Jul 20 2020, 3:38 AM · Restricted Project, Restricted Project

Jun 26 2020

krasimir added inline comments to D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 26 2020, 2:40 AM · Restricted Project

Jun 24 2020

krasimir committed rG0fad648b65b9: [clang-format] restore indent in conditionals when AlignOperands is DontAlign (authored by krasimir).
[clang-format] restore indent in conditionals when AlignOperands is DontAlign
Jun 24 2020, 4:17 AM
krasimir closed D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 24 2020, 4:17 AM · Restricted Project
krasimir updated the diff for D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
  • try to update Phabricator diff
Jun 24 2020, 4:17 AM · Restricted Project
krasimir updated the diff for D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
  • refresh Phabricator diff
Jun 24 2020, 4:16 AM · Restricted Project
krasimir updated the diff for D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
  • add a FIXME
Jun 24 2020, 3:44 AM · Restricted Project

Jun 19 2020

krasimir retitled D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign from [clang-format] restore indent in conditionals AlignOperands is DontAlign to [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 19 2020, 9:12 AM · Restricted Project
krasimir added a reviewer for D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign: sammccall.
Jun 19 2020, 9:12 AM · Restricted Project
krasimir updated the summary of D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 19 2020, 8:37 AM · Restricted Project
krasimir abandoned D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign.
Jun 19 2020, 8:37 AM · Restricted Project
krasimir created D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 19 2020, 8:37 AM · Restricted Project
krasimir updated the diff for D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign.
  • add a regression test
Jun 19 2020, 8:37 AM · Restricted Project
krasimir created D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign.
Jun 19 2020, 6:59 AM · Restricted Project

Jun 9 2020

krasimir accepted D81467: [clang-format] Microsoft style fixes for C# properties.

Thank you!

Jun 9 2020, 6:33 AM · Restricted Project, Restricted Project

Jun 8 2020

krasimir accepted D81394: [clang-format] Brace breaking for C# lambdas.

Thank you!

Jun 8 2020, 1:18 PM · Restricted Project, Restricted Project

Jun 5 2020

krasimir accepted D81255: [clang-format] treat 'lock' as a keyword for C# code.
Jun 5 2020, 5:27 AM · Restricted Project, Restricted Project

Jun 4 2020

krasimir accepted D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide.
Jun 4 2020, 8:11 AM · Restricted Project, Restricted Project
krasimir added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

Another weak argument about why the current rule makes sense (break before << between two string literals) is: suppose you don't want such a break. Then you can change your code to concatenate the two string literals into a single one, avoiding the problem altogether, if possible (this can be unacceptable in cases where the combined length of the two string literals is excessive, but at that point we will likely break because of the column limit; or when there is a chain of more than 2 string literals and the user wishes to keep them fluently reflowing as the code evolves.)

Jun 4 2020, 2:40 AM · Restricted Project, Restricted Project

May 28 2020

krasimir added a comment to D50078: clang-format: support aligned nested conditionals formatting.

I'm happy with this patch!

We found a couple of rough edges:

  • alignment after ?: and
  • new formatting of _ ? _ ? _ : _ : _ patterns is bad

These are illustrated as examples D and E below (A, B and C look good to me). test.cc is how I'd expect clang-format to behave with this patch with BreakBeforeTernaryOperators = true, like in LLVM style.

  • alignment after ?:: this is a GNU extension and we've seen it used in C++ and ObjC: https://stackoverflow.com/questions/24538096/in-objective-c. I think this is special enough for us to consider an occurrence of ?: to break a ternary operator chain for the purposes of this alignment. I'd expect a +4 alignment of the last 2 lines of example D for consistency with A.
  • new formatting doesn't work for _ ? _ ? _ : _ : _ patterns; old formatting is better in that case. I think the new chained alignment works very well for _ ? _ : _ ? _ : _ ... cases, but we should attempt it otherwise.
% cat test.cc
//-- column 80 ----------------------------------------------------------------V
// A
int i = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa 
            ? bbbbbbbbbbbbbbbbbbb
            : cccccccccccccccccccc;
 
//-- column 80 ----------------------------------------------------------------V
// B
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbbb
        : cccccccccccccccccccc     ? dddddddddddddddddddd
                                   : eeeeeeeeeeeeeeeee;
 
//-- column 80 ----------------------------------------------------------------V
// C
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa
            ?: bbbbbbbbbbbbbbbbbbb ? ccccccccccccc
                                   : ddddddddd;
 
//-- column 80 ----------------------------------------------------------------V
// D
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa
            ?: bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
                   ? bbbbbbbbbbbbbbbbbbb
                   : cccccccccccccccccccc;
 
//-- column 80 ----------------------------------------------------------------V
// E 
return temp[0] > temp[1] ? temp[0] > temp[2] ? 0 : 2
                         : temp[1] > temp[2] ? 1 : 2;
% bin/clang-format -style=llvm test.cc
//-- column 80 ----------------------------------------------------------------V
// A
int i = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
            ? bbbbbbbbbbbbbbbbbbb
            : cccccccccccccccccccc;
 
//-- column 80 ----------------------------------------------------------------V
// B
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbbb
        : cccccccccccccccccccc     ? dddddddddddddddddddd
                                   : eeeeeeeeeeeeeeeee;
 
//-- column 80 ----------------------------------------------------------------V
// C
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa
            ?: bbbbbbbbbbbbbbbbbbb ? ccccccccccccc
                                   : ddddddddd;
 
//-- column 80 ----------------------------------------------------------------V
// D
int i = aaaaaaaaaaaaaaaaaaaaaaaaaa
            ?: bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb
               ? bbbbbbbbbbbbbbbbbbb
               : cccccccccccccccccccc;
 
//-- column 80 ----------------------------------------------------------------V
// E
return temp[0] > temp[1]   ? temp[0] > temp[2] ? 0 : 2
       : temp[1] > temp[2] ? 1
                           : 2;
May 28 2020, 4:51 AM · Restricted Project, Restricted Project

May 26 2020

krasimir accepted D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

This is nice! Thank you!

May 26 2020, 10:17 AM · Restricted Project, Restricted Project
krasimir added inline comments to D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.
May 26 2020, 9:11 AM · Restricted Project, Restricted Project
krasimir added inline comments to D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.
May 26 2020, 6:27 AM · Restricted Project, Restricted Project
krasimir added a comment to D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format.
May 26 2020, 6:27 AM · Restricted Project, Restricted Project
krasimir added a comment to D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format.

maybe for now we just do

if (FormatTok->is(tok::l_square) && !Style.isObjC())
    parseSquare();
May 26 2020, 3:11 AM · Restricted Project, Restricted Project

May 25 2020

krasimir added a comment to D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format.

Unfortunately this introduced a bad regression with ObjC method expressions in if bodies:

if (argc > 5) [obj func:arg];

is now formatted as:

if (argc > 5)[obj func:arg]
  ;
May 25 2020, 9:05 AM · Restricted Project, Restricted Project
krasimir added a comment to D50078: clang-format: support aligned nested conditionals formatting.

I'm happy with this patch!

May 25 2020, 6:56 AM · Restricted Project, Restricted Project

May 22 2020

krasimir added a comment to D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions.

Just some thoughts.

May 22 2020, 6:23 AM · Restricted Project, Restricted Project

May 18 2020

krasimir accepted D79325: [clang-format] [PR42164] Add Option to Break before While.

Thank you!

May 18 2020, 1:34 AM · Restricted Project, Restricted Project

May 15 2020

krasimir added inline comments to D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon.
May 15 2020, 6:28 AM · Restricted Project, Restricted Project
krasimir requested changes to D79325: [clang-format] [PR42164] Add Option to Break before While.
May 15 2020, 4:29 AM · Restricted Project, Restricted Project

May 14 2020

krasimir accepted D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly.

Awesome! Thank you!

May 14 2020, 1:36 PM · Restricted Project, Restricted Project