Page MenuHomePhabricator

kmclaughlin (Kerry McLaughlin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2019, 8:51 AM (80 w, 3 d)

Recent Activity

Fri, Jan 22

kmclaughlin requested review of D95245: [SVE] Add support for scalable vectorization of loops with int/fast FP reductions.
Fri, Jan 22, 9:28 AM · Restricted Project

Wed, Jan 13

kmclaughlin committed rG2170e0ee60db: [SVE][CodeGen] CTLZ, CTTZ & CTPOP operations (predicates) (authored by kmclaughlin).
[SVE][CodeGen] CTLZ, CTTZ & CTPOP operations (predicates)
Wed, Jan 13, 4:26 AM
kmclaughlin closed D94428: [SVE][CodeGen] CTLZ, CTTZ & CTPOP operations (predicates).
Wed, Jan 13, 4:25 AM · Restricted Project

Tue, Jan 12

kmclaughlin requested review of D94525: [SVE][CodeGen] Remove performMaskedGatherScatterCombine.
Tue, Jan 12, 9:52 AM · Restricted Project

Mon, Jan 11

kmclaughlin requested review of D94428: [SVE][CodeGen] CTLZ, CTTZ & CTPOP operations (predicates).
Mon, Jan 11, 9:25 AM · Restricted Project
kmclaughlin committed rGc37f68a8885c: [SVE][CodeGen] Fix legalisation of floating-point masked gathers (authored by kmclaughlin).
[SVE][CodeGen] Fix legalisation of floating-point masked gathers
Mon, Jan 11, 3:28 AM
kmclaughlin closed D94171: [SVE][CodeGen] Fix legalisation of floating-point masked gathers.
Mon, Jan 11, 3:28 AM · Restricted Project

Fri, Jan 8

kmclaughlin updated the diff for D94171: [SVE][CodeGen] Fix legalisation of floating-point masked gathers.

Removed the isVectorUnpack helper added in the previous revision. If the index values are already extended to i64 by an unpkhi/lo, then the gather does not also need to extend the index.
This affects the masked_gather_nxv4f64 test, which has been updated as follows:

Fri, Jan 8, 6:42 AM · Restricted Project

Thu, Jan 7

kmclaughlin updated the diff for D94171: [SVE][CodeGen] Fix legalisation of floating-point masked gathers.
  • Added a new helper function, isVectorUnpack
  • Added tests which load <vscale x 4 x half> & <vscale x 2 x float>
Thu, Jan 7, 3:43 AM · Restricted Project

Wed, Jan 6

kmclaughlin requested review of D94171: [SVE][CodeGen] Fix legalisation of floating-point masked gathers.
Wed, Jan 6, 5:32 AM · Restricted Project

Dec 18 2020

kmclaughlin committed rG52e4084d9c3b: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter (authored by kmclaughlin).
[SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter
Dec 18 2020, 3:57 AM
kmclaughlin closed D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter.
Dec 18 2020, 3:57 AM · Restricted Project

Dec 17 2020

kmclaughlin committed rG7c504b6dd063: [AArch64] Renamed sve-masked-scatter-legalise.ll. NFC. (authored by kmclaughlin).
[AArch64] Renamed sve-masked-scatter-legalise.ll. NFC.
Dec 17 2020, 3:41 AM
kmclaughlin committed rG6d2a78996bee: [SVE][CodeGen] Add bfloat16 support to scalable masked gather (authored by kmclaughlin).
[SVE][CodeGen] Add bfloat16 support to scalable masked gather
Dec 17 2020, 3:10 AM
kmclaughlin closed D93307: [SVE][CodeGen] Add bfloat16 support to scalable masked gather.
Dec 17 2020, 3:09 AM · Restricted Project

Dec 16 2020

kmclaughlin updated the diff for D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter.
  • Improve codegen where the splat value is a constant, but out of range for the immediate addressing mode, e.g.
mov x8, xzr
add z1.d, z1.d, #32 // =0x20
st1b { z0.d }, p0, [x8, z1.d]
ret

->

mov w8, #32
st1b { z0.d }, p0, [x8, z1.d]
ret
Dec 16 2020, 8:49 AM · Restricted Project
kmclaughlin added inline comments to D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter.
Dec 16 2020, 7:04 AM · Restricted Project
kmclaughlin updated the diff for D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter.
  • Refactored selectGatherScatterAddrMode based on the suggestions from @sdesmalen
  • Added bfloat tests to the new test files added by this patch
  • Removed unused %offset from sve-masked-gather.ll and removed duplicate tests from sve-masked-scatter-legalise.ll
Dec 16 2020, 7:03 AM · Restricted Project
kmclaughlin updated the diff for D93307: [SVE][CodeGen] Add bfloat16 support to scalable masked gather.
  • Added patterns for bfloat16 extract_subvector to AArch64SVEInstrInfo.td
Dec 16 2020, 3:27 AM · Restricted Project
kmclaughlin added inline comments to D93307: [SVE][CodeGen] Add bfloat16 support to scalable masked gather.
Dec 16 2020, 2:52 AM · Restricted Project

Dec 15 2020

kmclaughlin requested review of D93307: [SVE][CodeGen] Add bfloat16 support to scalable masked gather.
Dec 15 2020, 8:35 AM · Restricted Project

Dec 14 2020

kmclaughlin added a comment to D93050: [SVE][CodeGen] Lower scalable floating-point vector reductions.

Thanks @cameron.mcinally & @paulwalker-arm for reviewing this patch!

Dec 14 2020, 3:49 AM · Restricted Project
kmclaughlin committed rGc5ced82c8e49: [SVE][CodeGen] Lower scalable floating-point vector reductions (authored by kmclaughlin).
[SVE][CodeGen] Lower scalable floating-point vector reductions
Dec 14 2020, 3:48 AM
kmclaughlin closed D93050: [SVE][CodeGen] Lower scalable floating-point vector reductions.
Dec 14 2020, 3:48 AM · Restricted Project

Dec 11 2020

kmclaughlin requested review of D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter.
Dec 11 2020, 10:42 AM · Restricted Project
kmclaughlin added inline comments to D93050: [SVE][CodeGen] Lower scalable floating-point vector reductions.
Dec 11 2020, 4:26 AM · Restricted Project
kmclaughlin updated the diff for D93050: [SVE][CodeGen] Lower scalable floating-point vector reductions.
  • Reordered the condition added to LowerReductionToSVE which sets RdxVT
Dec 11 2020, 4:23 AM · Restricted Project

Dec 10 2020

kmclaughlin requested review of D93050: [SVE][CodeGen] Lower scalable floating-point vector reductions.
Dec 10 2020, 9:32 AM · Restricted Project
kmclaughlin committed rGabe7775f5a43: [SVE][CodeGen] Extend index of masked gathers (authored by kmclaughlin).
[SVE][CodeGen] Extend index of masked gathers
Dec 10 2020, 5:55 AM
kmclaughlin closed D91433: [SVE][CodeGen] Extend index of masked gathers.
Dec 10 2020, 5:55 AM · Restricted Project

Dec 9 2020

kmclaughlin committed rG05edfc54750b: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather (authored by kmclaughlin).
[SVE][CodeGen] Add DAG combines for s/zext_masked_gather
Dec 9 2020, 3:55 AM
kmclaughlin closed D92230: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather.
Dec 9 2020, 3:54 AM · Restricted Project
kmclaughlin committed rG4519ff4b6f02: [SVE][CodeGen] Add the ExtensionType flag to MGATHER (authored by kmclaughlin).
[SVE][CodeGen] Add the ExtensionType flag to MGATHER
Dec 9 2020, 3:20 AM
kmclaughlin closed D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.
Dec 9 2020, 3:20 AM · Restricted Project

Dec 7 2020

kmclaughlin updated the diff for D92230: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather.
  • Renamed ResNeedsExtend -> ResNeedsSignExtend
  • Added a test to sve-masked-gather-legalize.ll for a zero-extended gather load with multiple uses
Dec 7 2020, 8:03 AM · Restricted Project
kmclaughlin committed rG111f559bbd12: [SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER (authored by kmclaughlin).
[SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER
Dec 7 2020, 5:31 AM
kmclaughlin closed D92319: [SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER.
Dec 7 2020, 5:31 AM · Restricted Project
kmclaughlin committed rGf6dd32fd3584: [SVE][CodeGen] Lower scalable masked gathers (authored by kmclaughlin).
[SVE][CodeGen] Lower scalable masked gathers
Dec 7 2020, 4:22 AM
kmclaughlin closed D91092: [SVE][CodeGen] Lower scalable masked gathers.
Dec 7 2020, 4:21 AM · Restricted Project

Dec 3 2020

kmclaughlin added inline comments to D90942: [SVE][CodeGen] Improve codegen of scalable masked scatters.
Dec 3 2020, 2:30 AM · Restricted Project

Dec 2 2020

kmclaughlin updated the diff for D92319: [SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER.
  • Moved changes to set the default IndexType to SIGNED_UNSCALED to D91092
  • Remove any unnecessary sign/zero extensions of the Index in LowerMGATHER
Dec 2 2020, 9:42 AM · Restricted Project
kmclaughlin added inline comments to D91092: [SVE][CodeGen] Lower scalable masked gathers.
Dec 2 2020, 9:22 AM · Restricted Project
kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • Removed Index = Index.getOperand(0) from LowerMGATHER, which was incorrectly removing the sign/zero extend of Index if getGatherScatterIndexIsExtended returns true
Dec 2 2020, 9:16 AM · Restricted Project

Nov 30 2020

kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • Changed the default IndexType set by visitMaskedGather to ISD::SIGNED_UNSCALED
Nov 30 2020, 10:26 AM · Restricted Project
kmclaughlin updated the diff for D92319: [SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER.
  • Reordered this to depend on D91092, as this more clearly demonstrates the benefit of the changes in this patch to the sve-masked-gather* tests
Nov 30 2020, 8:05 AM · Restricted Project
kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • I mistakenly created this patch to depend on D92319, this revision removes this dependency
Nov 30 2020, 7:59 AM · Restricted Project
kmclaughlin updated the diff for D92230: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather.
  • Moved the addition of the -aarch64-enable-mgather-combine option to D91092 in order to more clearly demonstrate the value added by the combines in this patch.
Nov 30 2020, 6:35 AM · Restricted Project
kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • Moved the addition of the -aarch64-enable-mgather-combine flag from D92230 into this patch & updated the RUN lines of tests included here to use this option (set to 0)
  • Moved changes to DAGCombiner.cpp into a new patch, D92319
Nov 30 2020, 6:29 AM · Restricted Project
kmclaughlin requested review of D92319: [SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER.
Nov 30 2020, 6:20 AM · Restricted Project

Nov 27 2020

kmclaughlin updated the diff for D92230: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather.

Added an option to disable the existing combines in AArch64ISelLowering for s/zext_masked_gathers (performSignExtendInRegCombine & performSVEAndCombine)

Nov 27 2020, 9:52 AM · Restricted Project
kmclaughlin added a comment to D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.

Hi @sdesmalen, I've updated the series as suggested and the patches are now in the following order:
D91092 - Lower scalable masked scatters (with references to ExtensionType in LowerMGATHER removed)
D91084 - Add the ExtensionType flag to MGATHER
D92230 - DAG combines for z/sext of a masked gather, adding ExtensionType back into LowerMGATHER

Nov 27 2020, 7:45 AM · Restricted Project
kmclaughlin requested review of D92230: [SVE][CodeGen] Add DAG combines for s/zext_masked_gather.
Nov 27 2020, 7:19 AM · Restricted Project
kmclaughlin updated the diff for D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.

Removed isConstantSplatVectorMaskForType() & the DAG combines for s/ext_masked_gather (these will be added in a follow up patch)

Nov 27 2020, 7:10 AM · Restricted Project
kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.

Reordering the scalable masked gather patch series that this is a part of, as suggested on D91084. This is now the first patch in the series.

Nov 27 2020, 7:05 AM · Restricted Project

Nov 26 2020

kmclaughlin committed rG4bee3197f665: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR (authored by kmclaughlin).
[SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR
Nov 26 2020, 3:24 AM
kmclaughlin closed D91363: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.
Nov 26 2020, 3:24 AM · Restricted Project

Nov 25 2020

kmclaughlin updated the diff for D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.
  • Replaced calls to TLI.isLoadExtLegal with TLI.isVectorLoadExtDesirable in the masked gather combines, which also checks the type of load operation being used
  • Removed unnecessary !LegalOperations from the zext_masked_gather combine and added a check for hasOneUse(), matching the sext_masked_gather combine
Nov 25 2020, 11:13 AM · Restricted Project
kmclaughlin committed rG603d40da9d53: [SVE][CodeGen] Add a DAG combine to extend mscatter indices (authored by kmclaughlin).
[SVE][CodeGen] Add a DAG combine to extend mscatter indices
Nov 25 2020, 3:22 AM
kmclaughlin closed D90945: [SVE][CodeGen] Add a DAG combine to extend mscatter indices.
Nov 25 2020, 3:22 AM · Restricted Project

Nov 23 2020

kmclaughlin updated subscribers of D91363: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.
Nov 23 2020, 3:41 AM · Restricted Project
kmclaughlin committed rGd3a0f9b9ec88: [APInt] Add the truncOrSelf resizing operator to APInt (authored by kmclaughlin).
[APInt] Add the truncOrSelf resizing operator to APInt
Nov 23 2020, 3:40 AM
kmclaughlin closed D91445: [APInt] Add the truncOrSelf resizing operator to APInt.
Nov 23 2020, 3:40 AM · Restricted Project

Nov 13 2020

kmclaughlin added inline comments to D91363: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.
Nov 13 2020, 10:48 AM · Restricted Project
kmclaughlin updated the diff for D91363: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.
  • Removed the EltSize < SplatVal.getBitWidth() check from isConstantSplatVector and used truncOrSelf instead
Nov 13 2020, 10:45 AM · Restricted Project
kmclaughlin requested review of D91445: [APInt] Add the truncOrSelf resizing operator to APInt.
Nov 13 2020, 10:41 AM · Restricted Project
kmclaughlin accepted D90093: [SVE] Move INT_TO_FP i1 promotion into custom lowering..
Nov 13 2020, 10:24 AM · Restricted Project
kmclaughlin requested review of D91433: [SVE][CodeGen] Extend index of masked gathers.
Nov 13 2020, 8:49 AM · Restricted Project
kmclaughlin committed rG306c8ab20841: [SVE][CodeGen] Improve codegen of scalable masked scatters (authored by kmclaughlin).
[SVE][CodeGen] Improve codegen of scalable masked scatters
Nov 13 2020, 3:26 AM
kmclaughlin closed D90942: [SVE][CodeGen] Improve codegen of scalable masked scatters.
Nov 13 2020, 3:26 AM · Restricted Project

Nov 12 2020

kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • Added the getExtendedGatherOpcode() function, which returns a signed gather load opcode (e.g GLD1_MERGE_ZERO -> GLD1S_MERGE_ZERO)
  • Get the extension type of the gather load in LowerMGATHER and use the signed gather opcode returned by getExtendedGatherOpcode() if the extension type is EXTLOAD/SEXTLOAD,
Nov 12 2020, 10:20 AM · Restricted Project
kmclaughlin updated the diff for D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.

Added DAG combines for the following:

  • fold (and (masked_gather x)) -> (zext_masked_gather x)
  • fold (sext_inreg (masked_gather x)) -> (sext_masked_gather x)
Nov 12 2020, 9:39 AM · Restricted Project
kmclaughlin requested review of D91363: [SVE][CodeGen] Extend isConstantSplatValue to support ISD::SPLAT_VECTOR.
Nov 12 2020, 9:26 AM · Restricted Project

Nov 11 2020

kmclaughlin committed rG170947a5def3: [SVE][CodeGen] Lower scalable masked scatters (authored by kmclaughlin).
[SVE][CodeGen] Lower scalable masked scatters
Nov 11 2020, 3:56 AM
kmclaughlin closed D90941: [SVE][CodeGen] Lower scalable masked scatters.
Nov 11 2020, 3:56 AM · Restricted Project
kmclaughlin committed rGffbbfc76ca20: [SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER (authored by kmclaughlin).
[SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER
Nov 11 2020, 3:14 AM
kmclaughlin closed D90939: [SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER.
Nov 11 2020, 3:14 AM · Restricted Project

Nov 10 2020

kmclaughlin added a comment to D91092: [SVE][CodeGen] Lower scalable masked gathers.

@craig.topper After changing the refineUniformBase function in D90942 to use getSplatVector() when trying to get the base pointer from a splat, the output of one of the X86 masked gather tests in masked_gather_scatter.ll has changed ("test14", where the base pointer is not a splat, so getUniformBase returns false).
Could you please take a look over this to make sure the changes are correct in this circumstance?

Nov 10 2020, 11:21 AM · Restricted Project
kmclaughlin updated the diff for D91092: [SVE][CodeGen] Lower scalable masked gathers.
  • Rebased after updating the parent patch, D90942
  • Moved SplitVecRes_MGATHER/SplitVecOp_MGATHER changes to D91084
Nov 10 2020, 11:07 AM · Restricted Project
kmclaughlin updated the diff for D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.
  • Moved changes to SplitVecRes_MGATHER & SplitVecOp_MGATHER into this patch from D91092
Nov 10 2020, 10:58 AM · Restricted Project
kmclaughlin updated the diff for D90942: [SVE][CodeGen] Improve codegen of scalable masked scatters.
  • Replaced check for ISD::SPLAT_VECTOR opcode in refineUniformBase with SelectionDAG::getSplatVector()
  • Applied changes suggested by clang-format
Nov 10 2020, 7:58 AM · Restricted Project
kmclaughlin updated the diff for D90941: [SVE][CodeGen] Lower scalable masked scatters.
  • Moved SplitVecOp_MSCATTER changes to the parent patch, D90939
  • Applied changes suggested by clang-format
Nov 10 2020, 7:53 AM · Restricted Project
kmclaughlin updated the diff for D90939: [SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER.
  • Made IsTrunc the last parameter to the MaskedScatterSDNode constructor
  • Moved changes to SplitVecOp_MSCATTER, which split MemVT before creating the 'Hi' & 'Lo' scatters, into this patch from D90941
Nov 10 2020, 7:48 AM · Restricted Project

Nov 9 2020

kmclaughlin requested review of D91092: [SVE][CodeGen] Lower scalable masked gathers.
Nov 9 2020, 10:50 AM · Restricted Project
kmclaughlin requested review of D91084: [SVE][CodeGen] Add the ExtensionType flag to MGATHER.
Nov 9 2020, 8:04 AM · Restricted Project

Nov 6 2020

kmclaughlin abandoned D89576: [SVE][CodeGen] Lower scalable masked scatters.

Abandoning this revision as it has been split into several smaller patches:

  • Add the truncating store flag: D90939
  • Lower masked scatters: D90941
  • Improve codegen with refineUniformBase & refineIndexType: D90942
  • DAG combine for extending index: D90945
Nov 6 2020, 7:14 AM · Restricted Project
kmclaughlin requested review of D90945: [SVE][CodeGen] Add a DAG combine to extend mscatter indices.
Nov 6 2020, 7:05 AM · Restricted Project
kmclaughlin requested review of D90942: [SVE][CodeGen] Improve codegen of scalable masked scatters.
Nov 6 2020, 6:59 AM · Restricted Project
kmclaughlin requested review of D90941: [SVE][CodeGen] Lower scalable masked scatters.
Nov 6 2020, 6:50 AM · Restricted Project
kmclaughlin requested review of D90939: [SVE][CodeGen] Add the isTruncatingStore flag to MSCATTER.
Nov 6 2020, 6:43 AM · Restricted Project

Nov 4 2020

kmclaughlin added a comment to D89382: [SVE][CodeGen] Lower scalable integer vector reductions.

Thanks for reviewing this, @paulwalker-arm!

Nov 4 2020, 3:47 AM · Restricted Project
kmclaughlin committed rGf2412d372d93: [SVE][CodeGen] Lower scalable integer vector reductions (authored by kmclaughlin).
[SVE][CodeGen] Lower scalable integer vector reductions
Nov 4 2020, 3:40 AM
kmclaughlin closed D89382: [SVE][CodeGen] Lower scalable integer vector reductions.
Nov 4 2020, 3:40 AM · Restricted Project

Nov 3 2020

kmclaughlin added inline comments to D89576: [SVE][CodeGen] Lower scalable masked scatters.
Nov 3 2020, 8:33 AM · Restricted Project
kmclaughlin updated the diff for D89576: [SVE][CodeGen] Lower scalable masked scatters.
  • Changed isLegalMaskedGSIndexType to return true if the instruction can perform the sign extend (i.e. if the index is extended from i32 and the number of elements is at least 4)
  • Added getCanonicalIndexType to convert redundant addressing modes (e.g. scaling is redundant when accessing bytes)
  • Added a target-specific DAG combine for mscatter to promote indices smaller than i32
  • Added various tests for type legalisation in sve-masked-scatter-legalise.ll
Nov 3 2020, 8:32 AM · Restricted Project

Oct 28 2020

kmclaughlin updated the diff for D89382: [SVE][CodeGen] Lower scalable integer vector reductions.

Changes to LowerPredReductionToSVE:

  • Fixed if statement which should be using ||
  • Removed unnecessary And when lowering VECREDUCE_XOR
  • Wrapped case blocks in {} where necessary
Oct 28 2020, 11:21 AM · Restricted Project

Oct 26 2020

kmclaughlin added inline comments to D89382: [SVE][CodeGen] Lower scalable integer vector reductions.
Oct 26 2020, 11:09 AM · Restricted Project
kmclaughlin updated the diff for D89382: [SVE][CodeGen] Lower scalable integer vector reductions.
  • Changed fix for the warning in computeKnownBits for extract_vector_elt to match D87651
  • Moved check for i1 types in LowerVECREDUCE outside of the switch statement
Oct 26 2020, 10:57 AM · Restricted Project
kmclaughlin updated the diff for D89576: [SVE][CodeGen] Lower scalable masked scatters.
  • Added isLegalMaskedGSIndexType to query if the index type is legal for masked scatters (returning true for nxv2i32, nxv4i32 & nxv2i64 on AArch64)
Oct 26 2020, 10:02 AM · Restricted Project

Oct 21 2020

kmclaughlin updated the diff for D89382: [SVE][CodeGen] Lower scalable integer vector reductions.
  • Changed getNode() to check if the operand type of vecreduce min/max is i1 instead of the result type
  • Fixed a mistake with the changes to getNode() in the previous patch, where the transformations of [s|u]min & [s|u]max would also apply to other operations
Oct 21 2020, 10:07 AM · Restricted Project
kmclaughlin updated the diff for D89382: [SVE][CodeGen] Lower scalable integer vector reductions.
  • Moved the transformations of i1 [s|u]min & [s|u]max -> and/or to SelectionDAG::getNode()
  • Removed custom lowering of vecreduce_[s|u]min & vecreduce_[s|u]max for predicate types
Oct 21 2020, 9:09 AM · Restricted Project