Page MenuHomePhabricator

kernhanda (Kern Handa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 28 2019, 12:07 AM (48 w, 6 d)

Recent Activity

May 1 2020

kernhanda added inline comments to D79230: [MLIR][crashfix] Fall back to malloc when alignment is 0 for align-alloc.
May 1 2020, 1:21 AM · Restricted Project
kernhanda updated the diff for D79230: [MLIR][crashfix] Fall back to malloc when alignment is 0 for align-alloc.

clang-format

May 1 2020, 12:43 AM · Restricted Project
kernhanda created D79230: [MLIR][crashfix] Fall back to malloc when alignment is 0 for align-alloc.
May 1 2020, 12:39 AM · Restricted Project

Mar 6 2020

kernhanda created D75769: [mlir][nfc] Fix building mlir_c_runner_utils for Windows.
Mar 6 2020, 1:15 PM · Restricted Project
kernhanda added a comment to D75769: [mlir][nfc] Fix building mlir_c_runner_utils for Windows.

This will need to be committed on my behalf.

Mar 6 2020, 1:15 PM · Restricted Project

Feb 19 2020

kernhanda added a comment to D74820: [MLIR] Support memrefs with memref element types..

Is there any guidance on what other changes would be required to land this change? I'll write some tests in the meanwhile to ensure that the standard to llvm conversion works well, at least.

Feb 19 2020, 7:55 AM · Restricted Project, Restricted Project
kernhanda added a comment to D74820: [MLIR] Support memrefs with memref element types..

Perhaps memref should be agnostic to the element type it contains? Tensors and Vector types can remain more constrained, but memref should be able to act on many kinds of types, not just the basic fundamental ones.

Feb 19 2020, 1:26 AM · Restricted Project, Restricted Project
kernhanda created D74820: [MLIR] Support memrefs with memref element types..
Feb 19 2020, 1:26 AM · Restricted Project, Restricted Project

Feb 18 2020

kernhanda updated the diff for D74686: [NFC][mlir] Adding more operators to EDSC TemplatedIndexedValue.

Added comments

Feb 18 2020, 7:42 PM · Restricted Project

Feb 16 2020

kernhanda created D74686: [NFC][mlir] Adding more operators to EDSC TemplatedIndexedValue.
Feb 16 2020, 2:27 AM · Restricted Project

Feb 12 2020

kernhanda updated the diff for D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

Rebased

Feb 12 2020, 10:25 PM · Restricted Project

Feb 10 2020

kernhanda added a comment to D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

Ping. :) Someone will also have to commit this on my behalf.

Feb 10 2020, 11:14 AM · Restricted Project

Feb 7 2020

kernhanda added inline comments to D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.
Feb 7 2020, 11:28 PM · Restricted Project
kernhanda updated the diff for D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

ran clang-format

Feb 7 2020, 11:28 PM · Restricted Project
kernhanda updated the diff for D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

fixing build fix

Feb 7 2020, 11:28 PM · Restricted Project

Feb 6 2020

kernhanda added a comment to D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

Someone will have to commit this on my behalf.

Feb 6 2020, 2:34 PM · Restricted Project
kernhanda updated the diff for D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.

constant_data -> constant

Feb 6 2020, 11:37 AM · Restricted Project
kernhanda created D74119: [NFC][mlir] Adding some helpful EDSC intrinsics.
Feb 6 2020, 4:21 AM · Restricted Project
kernhanda retitled D74119: [NFC][mlir] Adding some helpful EDSC intrinsics from [mlir] Adding some helpful EDSC intrinsics to [NFC][mlir] Adding some helpful EDSC intrinsics.
Feb 6 2020, 4:21 AM · Restricted Project

Feb 5 2020

kernhanda updated the diff for D74097: [mlir] Build fix for mlir-opt.

formatting

Feb 5 2020, 4:56 PM · Restricted Project
kernhanda updated the summary of D74097: [mlir] Build fix for mlir-opt.
Feb 5 2020, 3:42 PM · Restricted Project
kernhanda created D74097: [mlir] Build fix for mlir-opt.
Feb 5 2020, 3:42 PM · Restricted Project

Feb 4 2020

kernhanda added a comment to D73986: [nfc][mlir] Mark the MLIR tools for installation in CMake.

I'll need someone to commit this on my behalf since I don't have sufficient privileges.

Feb 4 2020, 3:27 PM · Restricted Project
kernhanda created D73986: [nfc][mlir] Mark the MLIR tools for installation in CMake.
Feb 4 2020, 11:44 AM · Restricted Project
kernhanda updated the summary of D73986: [nfc][mlir] Mark the MLIR tools for installation in CMake.
Feb 4 2020, 11:44 AM · Restricted Project

Jan 27 2020

kernhanda added a comment to D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.

Could you plz rebase on master? It does not seem to apply anymore. And fix clang-format while you are there.

Jan 27 2020, 8:44 AM · Restricted Project
kernhanda updated the diff for D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.

Rebased on master. clang-format'ed

Jan 27 2020, 8:44 AM · Restricted Project
kernhanda added a comment to D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.

Ping. :) Looking for someone to submit this on my behalf.

Jan 27 2020, 8:02 AM · Restricted Project

Jan 24 2020

kernhanda added a comment to D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.

I don't have commit access, so someone else will have to submit this.

Jan 24 2020, 12:55 PM · Restricted Project
kernhanda updated the diff for D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.

clang-format

Jan 24 2020, 12:36 PM · Restricted Project
kernhanda created D73377: [NFC] [mlir] [linalg] Merge Utils/Intrinsics.h into EDSC/Intrinsics.h.
Jan 24 2020, 12:16 PM · Restricted Project

Jan 9 2020

kernhanda added a comment to D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows.

Not sure if we're waiting for more approvals, but in case we're not, just a reminder that someone else will have to commit this on my behalf. :) Thanks!

Jan 9 2020, 9:17 AM · Restricted Project

Jan 8 2020

kernhanda updated the diff for D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows.

Added comments on #endif statements to indicate block they're closing.

Jan 8 2020, 11:27 AM · Restricted Project
kernhanda added inline comments to D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows.
Jan 8 2020, 11:27 AM · Restricted Project

Jan 7 2020

kernhanda added a comment to D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows.

I don't have commit access, so someone else will have to submit this.

Jan 7 2020, 8:17 PM · Restricted Project
kernhanda created D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows.
Jan 7 2020, 8:17 PM · Restricted Project

Jan 5 2020

kernhanda created D72232: [mlir] Update mlir/CMakeLists.txt to install *.def files.
Jan 5 2020, 1:37 PM · Restricted Project
kernhanda added a comment to D72232: [mlir] Update mlir/CMakeLists.txt to install *.def files.

I don't have commit access, so someone else will have to submit this.

Jan 5 2020, 1:37 PM · Restricted Project

Dec 28 2019

kernhanda added a comment to D71958: Update mlir/CMakeLists.txt to install *.td files.

I can commit it for you. Please let me know what name and email to associate your commit with, I don't seem to find them in the description.

Dec 28 2019, 3:17 PM · Restricted Project
kernhanda added a comment to D71958: Update mlir/CMakeLists.txt to install *.td files.

I don't have commit access, so someone else will have to submit this.

Dec 28 2019, 1:27 PM · Restricted Project
kernhanda updated the summary of D71958: Update mlir/CMakeLists.txt to install *.td files.
Dec 28 2019, 10:03 AM · Restricted Project
kernhanda added a comment to D71958: Update mlir/CMakeLists.txt to install *.td files.

Could you please specify why you need them installed in the commit description?

Dec 28 2019, 10:03 AM · Restricted Project
kernhanda created D71958: Update mlir/CMakeLists.txt to install *.td files.
Dec 28 2019, 2:33 AM · Restricted Project