Page MenuHomePhabricator

kentsommer (Kent Sommer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 19 2019, 5:17 PM (95 w, 3 d)

Recent Activity

Mar 5 2021

kentsommer accepted D97927: [clang-format] Rename case sorting.

Sorry for the slow response!

Mar 5 2021, 1:29 AM · Restricted Project, Restricted Project

Jan 28 2021

kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

NFC rebase to fix CI

Jan 28 2021, 5:11 PM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

NFC Rebase

Jan 28 2021, 3:36 AM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Fixed release notes typo

Jan 28 2021, 2:46 AM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Added release notes, updated commit message and summary

Jan 28 2021, 2:44 AM · Restricted Project, Restricted Project
kentsommer added a comment to D95017: [clang-format] Add case aware include sorting..

Concerning the --sort-includes command-line flag. I'd rather keep it as is and, if need be, work on accepting an optional string argument.
Please update release notes.

Jan 28 2021, 2:08 AM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Remove improper enum mapping

Jan 28 2021, 1:24 AM · Restricted Project, Restricted Project
kentsommer added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 28 2021, 1:22 AM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Turn SortIncludes into an enum

Jan 28 2021, 1:16 AM · Restricted Project, Restricted Project

Jan 25 2021

kentsommer added a comment to D95017: [clang-format] Add case aware include sorting..

Should we then revert ASAP and rework it later? @MyDeveloperDay

Jan 25 2021, 10:48 PM · Restricted Project, Restricted Project
kentsommer added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 25 2021, 3:07 PM · Restricted Project, Restricted Project

Jan 24 2021

kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Undo some accidental comment formatting

Jan 24 2021, 6:10 PM · Restricted Project, Restricted Project
kentsommer added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 24 2021, 6:04 PM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Addressed comments

Jan 24 2021, 6:03 PM · Restricted Project, Restricted Project

Jan 21 2021

kentsommer added a comment to D95017: [clang-format] Add case aware include sorting..

I do not have commit access.

Jan 21 2021, 2:37 PM · Restricted Project, Restricted Project

Jan 20 2021

kentsommer added a comment to D95017: [clang-format] Add case aware include sorting..

@HazardyKnusperkeks let me know if the additions to the unit test are along the lines you were hoping for or not, I think this captures what you had in mind.

Jan 20 2021, 10:20 PM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Expanded unit test

Jan 20 2021, 10:18 PM · Restricted Project, Restricted Project
kentsommer added a project to D95017: [clang-format] Add case aware include sorting.: Restricted Project.
Jan 20 2021, 2:16 PM · Restricted Project, Restricted Project
kentsommer updated the diff for D95017: [clang-format] Add case aware include sorting..

Fix both failing unit tests

Jan 20 2021, 12:07 AM · Restricted Project, Restricted Project

Jan 19 2021

kentsommer added a comment to D95017: [clang-format] Add case aware include sorting..

I'll work on fixing the unit tests. Thought they ran with check-clang-format but I was obviously wrong.

Jan 19 2021, 8:42 PM · Restricted Project, Restricted Project
kentsommer added reviewers for D95017: [clang-format] Add case aware include sorting.: MyDeveloperDay, curdeius.
Jan 19 2021, 7:25 PM · Restricted Project, Restricted Project
kentsommer requested review of D95017: [clang-format] Add case aware include sorting..
Jan 19 2021, 7:20 PM · Restricted Project, Restricted Project

Jan 8 2021

kentsommer abandoned D94287: [clang-format] Fix include sorting bug.

Seems to be a duplicate of D94206.

Jan 8 2021, 12:03 AM · Restricted Project, Restricted Project

Jan 7 2021

kentsommer added a reviewer for D94287: [clang-format] Fix include sorting bug: krasimir.
Jan 7 2021, 10:43 PM · Restricted Project, Restricted Project
kentsommer requested review of D94287: [clang-format] Fix include sorting bug.
Jan 7 2021, 10:41 PM · Restricted Project, Restricted Project