Page MenuHomePhabricator

kbobrovs (Konstantin Bobrovsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 19 2016, 8:58 PM (238 w, 5 d)

Recent Activity

Jul 2 2020

kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

According to {{clang/include/clang/Basic/Builtins.def}}, you can represent pointers and references via * and &; for vectors - there are V, q, and E. I don't know how to deal with template parameter here, but reference to 4-component vector should be something like &E4i

Jul 2 2020, 6:22 PM · Restricted Project
kbobrovs updated the diff for D81905: Enhance Itanium demangler interface..

Added one more workaround needed to compile with MSVC++.

Jul 2 2020, 6:22 PM · Restricted Project

Jun 29 2020

kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

That having been said, did you try declaring the builtin and then declaring it as a function template in the header file?

Jun 29 2020, 5:27 PM · Restricted Project
kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

Thanks. Regarding this patch itself, did you explain how this API is to be used?

Jun 29 2020, 3:50 PM · Restricted Project

Jun 25 2020

kbobrovs updated the diff for D81905: Enhance Itanium demangler interface..

Reduced diff to minimum needed.

Jun 25 2020, 9:49 PM · Restricted Project
kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

Please upload the patch with full context.

Done. Sorry for missing that procedure detail.

Jun 25 2020, 2:44 PM · Restricted Project
kbobrovs updated the diff for D81905: Enhance Itanium demangler interface..

Added full context.

Jun 25 2020, 2:11 PM · Restricted Project

Jun 24 2020

kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

The patch by itself is just ItaniumDemangler.h interface enhancements (+ compilation error fix - objcProto->getProtocol()) :-)
If the change is OK by itself (not taking into account potential future uses), I would appreciate approval.

Jun 24 2020, 7:33 PM · Restricted Project

Jun 23 2020

kbobrovs updated the diff for D81905: Enhance Itanium demangler interface..

Applied clang-format.

Jun 23 2020, 6:53 PM · Restricted Project
kbobrovs updated the diff for D81905: Enhance Itanium demangler interface..

Had to add few more fixes to get my code including ItanumDemangler.h compiled. Plus returning NodeArray by const ref is more efficient.

Jun 23 2020, 4:43 PM · Restricted Project

Jun 21 2020

kbobrovs added a comment to D81905: Enhance Itanium demangler interface..

Yes, I infer semantics properties. I use demangler to implement lowering of "C++ intrinsics" - Itanium-mangled C++ name (e.g. templated function instantiation) - for my SPIRV-based target. Lowering depends on the name, template parameter values and argument types (if overloaded). https://github.com/intel/llvm/pull/1881

Jun 21 2020, 4:56 PM · Restricted Project

Jun 15 2020

kbobrovs created D81905: Enhance Itanium demangler interface..
Jun 15 2020, 8:55 PM · Restricted Project
kbobrovs added a reviewer for D81905: Enhance Itanium demangler interface.: erik.pilkington.
Jun 15 2020, 8:55 PM · Restricted Project
kbobrovs added a reviewer for D81905: Enhance Itanium demangler interface.: rsmith.
Jun 15 2020, 8:55 PM · Restricted Project

May 30 2019

Vladimir Lazarev <vladimir.lazarev@intel.com> committed rGad8e079b85ac: [SYCL] Fix auto-deduction of device binary image format when extracting from a… (authored by kbobrovs).
[SYCL] Fix auto-deduction of device binary image format when extracting from a…
May 30 2019, 8:06 AM
Vladimir Lazarev <vladimir.lazarev@intel.com> committed rG78584744f77d: [SYCL] Don't force SPIRV format in device binary image. (authored by kbobrovs).
[SYCL] Don't force SPIRV format in device binary image.
May 30 2019, 8:06 AM
Vladimir Lazarev <vladimir.lazarev@intel.com> committed rG2b26dcb6b9ae: [SYCL] Restore SYCL_USE_KERNEL_SPV env var handling to load SPIRV program from… (authored by kbobrovs).
[SYCL] Restore SYCL_USE_KERNEL_SPV env var handling to load SPIRV program from…
May 30 2019, 8:06 AM
Vladimir Lazarev <vladimir.lazarev@intel.com> committed rG09a19d2088ff: [SYCL] Add support for multiple device binaries, extend device binary… (authored by kbobrovs).
[SYCL] Add support for multiple device binaries, extend device binary…
May 30 2019, 8:05 AM
Vladimir Lazarev <vladimir.lazarev@intel.com> committed rG0738099b4ab8: [SYCL] Add multiple target binaries support. (authored by kbobrovs).
[SYCL] Add multiple target binaries support.
May 30 2019, 8:04 AM