Page MenuHomePhabricator

jstenglein (Jeremy Stenglein)
Cisco Systems, Inc.

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2019, 11:57 AM (93 w, 5 d)

Recent Activity

Mar 9 2020

jstenglein added a comment to D75768: Add a warning for builtin_return_address/frame_address with > 0 argument.

I did a bit of research and I don't think i know of anything better than 'most' here, and noone else had an opinion at the end of last week so I'll take that silence as consent. Approved!

Mar 9 2020, 10:13 AM · Restricted Project

Mar 6 2020

jstenglein added a comment to D75768: Add a warning for builtin_return_address/frame_address with > 0 argument.

Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine.

Thanks for the comments. It is already part of -Wall since I put it in -Wmost and -Wall includes -Wmost:
def All : DiagGroup<"all", [Most, Parentheses, Switch, SwitchBool, MisleadingIndentation]>;

Right, I know. I'm wondering about what made you choose most? I dont know our rules for warning groups, so hopefully someone else can comment.

Mar 6 2020, 1:48 PM · Restricted Project
jstenglein added a comment to D75768: Add a warning for builtin_return_address/frame_address with > 0 argument.

Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine.

Mar 6 2020, 1:15 PM · Restricted Project
jstenglein created D75768: Add a warning for builtin_return_address/frame_address with > 0 argument.
Mar 6 2020, 12:43 PM · Restricted Project