Page MenuHomePhabricator

jonpa (Jonas Paulsson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2015, 1:18 AM (296 w, 3 d)

Recent Activity

Yesterday

jonpa added a comment to D90231: [GVN] Don't replace argument to @llvm.is.constant.*().

I completely agree with Roman that this patch is very undesirable since it has a high chance of breaking other reasonable uses of the intrinsic.

Thu, Oct 29, 4:19 AM · Restricted Project

Wed, Oct 28

jonpa added a comment to D90231: [GVN] Don't replace argument to @llvm.is.constant.*().

I'm sorry, i do not understand. Is the test case over-reduced?
In land.rhs BB, %shl *is* constant, and therefore the folding happens:

IIUC, the idea of the intrinsic is to check if a value is *compile-time* constant. %shl is known to be 0 in %land.rhs given the icmp, but during runtime it actually can have any value.

In land.rhs it can only ever be 0, because in land.rhs, %shl got replaced with 0.

I think i'd like to see the bigger/less reduced test case..

Wed, Oct 28, 2:53 AM · Restricted Project
jonpa added a comment to D90231: [GVN] Don't replace argument to @llvm.is.constant.*().

I think it makes general sense to not optimize the argument to @llvm.is.constant.

Sometimes, it may be necessary to optimize the argument to @llvm.is.constant so that you even recognize it is in fact constant. An example might be a constant argument propagated into an inlined function which uses @llvm.is.constant on the argument variable. (This seems to be a quite typical use of the predicate e.g. in kernel sources.)

Not sure if this would be affected by your proposed patch, but it's something to keep in mind.

Wed, Oct 28, 2:43 AM · Restricted Project
jonpa added a comment to D90231: [GVN] Don't replace argument to @llvm.is.constant.*().

I'm sorry, i do not understand. Is the test case over-reduced?
In land.rhs BB, %shl *is* constant, and therefore the folding happens:

Wed, Oct 28, 2:33 AM · Restricted Project
jonpa added reviewers for D90231: [GVN] Don't replace argument to @llvm.is.constant.*(): joerg, void.

Was semantics of LLVM's @llvm.is.constant defined in some document since the last time @llvm.is.constant patch?

I see in the reference manual: "If its argument is known to be a manifest compile-time constant value, then the intrinsic will be converted to a constant true value. Otherwise, it will be converted to a constant false value..." So clearly, having GVN turn this into a run-time check is wrong.

Wed, Oct 28, 1:58 AM · Restricted Project

Tue, Oct 27

jonpa abandoned D90091: [SelectionDAGBuilder] Let asm constraint "i" accept an undef operand..

Thanks for review, but as you suspected this test case did not reflect the true problem. A new patch is suggested at: https://reviews.llvm.org/D90231.

Tue, Oct 27, 7:38 AM · Restricted Project
jonpa requested review of D90231: [GVN] Don't replace argument to @llvm.is.constant.*().
Tue, Oct 27, 7:36 AM · Restricted Project

Mon, Oct 26

jonpa added inline comments to D89665: [LSR] ignore profitable chain optimization when instruction number is the major cost.
Mon, Oct 26, 6:35 AM · Restricted Project

Sat, Oct 24

jonpa requested review of D90091: [SelectionDAGBuilder] Let asm constraint "i" accept an undef operand..
Sat, Oct 24, 1:55 AM · Restricted Project
jonpa committed rG7c026a83ee90: [SystemZ] Define MaxInstLength to have the value of 6. (authored by jonpa).
[SystemZ] Define MaxInstLength to have the value of 6.
Sat, Oct 24, 12:21 AM
jonpa closed D90065: [SystemZ] Define MaxInstLength to have the value of 6..
Sat, Oct 24, 12:21 AM · Restricted Project

Fri, Oct 23

jonpa requested review of D90065: [SystemZ] Define MaxInstLength to have the value of 6..
Fri, Oct 23, 11:51 AM · Restricted Project

Wed, Oct 21

jonpa committed rG1606755da0e4: [SystemZ] Mark unsaved argument R6 as live throughout function. (authored by jonpa).
[SystemZ] Mark unsaved argument R6 as live throughout function.
Wed, Oct 21, 5:40 AM
jonpa closed D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.
Wed, Oct 21, 5:39 AM · Restricted Project
jonpa requested review of D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.
Wed, Oct 21, 4:47 AM · Restricted Project
jonpa updated the diff for D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.
  • Removed the adding of R6 to live-in lists and return instructions.
Wed, Oct 21, 4:47 AM · Restricted Project
jonpa added a comment to D89773: [IRCE] consolidate profitability check.

This is a promised follow-up after D89451.

Is this a typo?

Wed, Oct 21, 4:37 AM · Restricted Project
jonpa committed rG42a82862b625: Reapply "[clang] Improve handling of physical registers in inline (authored by jonpa).
Reapply "[clang] Improve handling of physical registers in inline
Wed, Oct 21, 1:55 AM
jonpa closed D87279: [clang] Fix handling of physical registers in inline assembly operands..
Wed, Oct 21, 1:55 AM · Restricted Project

Tue, Oct 20

jonpa updated the diff for D86519: [SystemZ] New pass for domain reassignment from integer to vector..

Patch still experimental.

Tue, Oct 20, 4:55 AM · Restricted Project

Sat, Oct 17

jonpa added a comment to D89447: [MachineInstr] Add support for instructions with multiple memory operands..

I removed that check that one of those two MMOs needs to be store. No change to test now. But, that sounds a little weird that one instruction claims mayLoad and mayStore but only has isLoad MMO. Maybe we need to change that MMO in prefetch to be both isLoad and isStore.

Sat, Oct 17, 4:49 AM · Restricted Project
jonpa updated the diff for D87279: [clang] Fix handling of physical registers in inline assembly operands..

Sorry, here's the test case included as well...

Sat, Oct 17, 3:51 AM · Restricted Project
jonpa added inline comments to D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.
Sat, Oct 17, 3:07 AM · Restricted Project

Fri, Oct 16

jonpa updated the diff for D87279: [clang] Fix handling of physical registers in inline assembly operands..

That makes sense... Patch updated to keep the tying of operands for this case of earlyclobber.

Fri, Oct 16, 6:52 AM · Restricted Project
jonpa added a comment to D87279: [clang] Fix handling of physical registers in inline assembly operands..

The problem seems to be with a tied earlyclobber operand:

Fri, Oct 16, 5:10 AM · Restricted Project
jonpa added a comment to D89447: [MachineInstr] Add support for instructions with multiple memory operands..

@jonpa can you check whether the SystemZ test case you added still checks what it was intended to check here?

Fri, Oct 16, 4:24 AM · Restricted Project
jonpa updated the diff for D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.

Updated per review to use a MIR test instead.

Fri, Oct 16, 3:31 AM · Restricted Project

Thu, Oct 15

jonpa requested review of D89451: [SystemZ] Mark unsaved argument R6 as live throughout function.
Thu, Oct 15, 1:11 AM · Restricted Project

Wed, Oct 14

jonpa committed rG6756d43af97e: [SystemZ] Bugfix in SystemZVectorConstantInfo (authored by jonpa).
[SystemZ] Bugfix in SystemZVectorConstantInfo
Wed, Oct 14, 6:37 AM
jonpa closed D89389: [SystemZ] Bugfix in SystemZVectorConstantInfo.
Wed, Oct 14, 6:37 AM · Restricted Project
jonpa requested review of D89389: [SystemZ] Bugfix in SystemZVectorConstantInfo.
Wed, Oct 14, 5:49 AM · Restricted Project
jonpa requested review of D87279: [clang] Fix handling of physical registers in inline assembly operands..
Wed, Oct 14, 12:04 AM · Restricted Project

Tue, Oct 13

jonpa reopened D87279: [clang] Fix handling of physical registers in inline assembly operands..

Patch temporarily reverted.

Tue, Oct 13, 11:46 PM · Restricted Project
jonpa added a reverting change for D87279: [clang] Fix handling of physical registers in inline assembly operands.: rG625fa4761702: Revert "[clang] Improve handling of physical registers in inline assembly….
Tue, Oct 13, 11:44 PM · Restricted Project
jonpa added a reverting change for rGc78da037783b: [clang] Improve handling of physical registers in inline assembly operands.: rG625fa4761702: Revert "[clang] Improve handling of physical registers in inline assembly….
Tue, Oct 13, 11:44 PM
jonpa committed rG625fa4761702: Revert "[clang] Improve handling of physical registers in inline assembly… (authored by jonpa).
Revert "[clang] Improve handling of physical registers in inline assembly…
Tue, Oct 13, 11:44 PM
jonpa committed rGc78da037783b: [clang] Improve handling of physical registers in inline assembly operands. (authored by jonpa).
[clang] Improve handling of physical registers in inline assembly operands.
Tue, Oct 13, 6:11 AM
jonpa closed D87279: [clang] Fix handling of physical registers in inline assembly operands..
Tue, Oct 13, 6:11 AM · Restricted Project
jonpa updated the diff for D86519: [SystemZ] New pass for domain reassignment from integer to vector..

Latest improvements (still in progress):

Tue, Oct 13, 4:10 AM · Restricted Project

Fri, Oct 9

jonpa committed rGd851495f2fe6: [SystemZ] Use LA instead of AGR in eliminateFrameIndex(). (authored by jonpa).
[SystemZ] Use LA instead of AGR in eliminateFrameIndex().
Fri, Oct 9, 4:07 AM
jonpa closed D89034: [SystemZ] Use LA instead of AGR in eliminateFrameIndex()..
Fri, Oct 9, 4:07 AM · Restricted Project
jonpa updated the diff for D89034: [SystemZ] Use LA instead of AGR in eliminateFrameIndex()..

Updated per review.

Fri, Oct 9, 12:59 AM · Restricted Project
jonpa updated the diff for D87279: [clang] Fix handling of physical registers in inline assembly operands..

Updated message string per review.

Fri, Oct 9, 12:44 AM · Restricted Project

Thu, Oct 8

jonpa requested review of D89034: [SystemZ] Use LA instead of AGR in eliminateFrameIndex()..
Thu, Oct 8, 4:24 AM · Restricted Project
jonpa updated the diff for D87279: [clang] Fix handling of physical registers in inline assembly operands..

Updated per review to use SmallSet.

Thu, Oct 8, 2:27 AM · Restricted Project

Wed, Oct 7

jonpa added inline comments to D87279: [clang] Fix handling of physical registers in inline assembly operands..
Wed, Oct 7, 1:43 AM · Restricted Project
jonpa updated the diff for D87279: [clang] Fix handling of physical registers in inline assembly operands..

Updated per review by eliminating the call to 'count'.

Wed, Oct 7, 1:43 AM · Restricted Project

Tue, Oct 6

jonpa committed rG5588dbce73be: [SystemZAsmParser] Treat VR128 separately in ParseDirectiveInsn(). (authored by jonpa).
[SystemZAsmParser] Treat VR128 separately in ParseDirectiveInsn().
Tue, Oct 6, 5:47 AM
jonpa closed D88888: [SystemZAsmParser] Treat VR128 separately in ParseDirectiveInsn()..
Tue, Oct 6, 5:47 AM · Restricted Project
jonpa added reviewers for D87279: [clang] Fix handling of physical registers in inline assembly operands.: RKSimon, jyu2, t.p.northover, echristo, dylanmckay, aaron.ballman.

Last chance for anyone to speak up about any objections to committing this...

Tue, Oct 6, 5:38 AM · Restricted Project
jonpa requested review of D88888: [SystemZAsmParser] Treat VR128 separately in ParseDirectiveInsn()..
Tue, Oct 6, 4:29 AM · Restricted Project

Mon, Oct 5

jonpa committed rG34b61d6cd58a: [SystemZ] Add support for .insn directives for vector instructions. (authored by jonpa).
[SystemZ] Add support for .insn directives for vector instructions.
Mon, Oct 5, 7:54 AM
jonpa closed D88357: [SystemZ] Add support for .insn directives for vector instructions.
Mon, Oct 5, 7:53 AM · Restricted Project
jonpa added inline comments to D88357: [SystemZ] Add support for .insn directives for vector instructions.
Mon, Oct 5, 3:50 AM · Restricted Project
jonpa updated the diff for D88357: [SystemZ] Add support for .insn directives for vector instructions.

Updated per review.

Mon, Oct 5, 3:50 AM · Restricted Project

Sep 30 2020

jonpa committed rG9f5da55f5d92: [SystemZ] Support bare nop instructions (authored by jonpa).
[SystemZ] Support bare nop instructions
Sep 30 2020, 2:25 AM

Sep 29 2020

jonpa committed rG75a5febe31cb: [SystemZ] Don't emit PC-relative memory accesses to unaligned symbols. (authored by jonpa).
[SystemZ] Don't emit PC-relative memory accesses to unaligned symbols.
Sep 29 2020, 5:54 AM
jonpa closed D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..
Sep 29 2020, 5:53 AM · Restricted Project
jonpa added inline comments to D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..
Sep 29 2020, 2:57 AM · Restricted Project
jonpa updated the diff for D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..

Updated per review.

Sep 29 2020, 2:57 AM · Restricted Project

Sep 28 2020

jonpa added a comment to D87279: [clang] Fix handling of physical registers in inline assembly operands..

ping!

Sep 28 2020, 5:58 AM · Restricted Project

Sep 26 2020

jonpa requested review of D88357: [SystemZ] Add support for .insn directives for vector instructions.
Sep 26 2020, 6:40 AM · Restricted Project

Sep 25 2020

jonpa abandoned D87506: [SystemZ] Make LibFunc_bcmp unavailable.

Replaced by https://reviews.llvm.org/D87988

Sep 25 2020, 9:25 AM · Restricted Project

Sep 24 2020

jonpa added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

This looks ok to me, but let's wait for @uweigand as well.

Sep 24 2020, 7:35 AM · Restricted Project

Sep 23 2020

jonpa closed D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..

Committed as 370a8c8.

Sep 23 2020, 6:39 AM · Restricted Project
jonpa committed rG370a8c802558: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant. (authored by jonpa).
[SystemZ] Make sure not to call getZExtValue on a >64 bit constant.
Sep 23 2020, 6:37 AM
jonpa added inline comments to D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..
Sep 23 2020, 6:15 AM · Restricted Project
jonpa added reviewers for D87279: [clang] Fix handling of physical registers in inline assembly operands.: glider, void.
Sep 23 2020, 3:26 AM · Restricted Project
jonpa removed a reviewer for D87279: [clang] Fix handling of physical registers in inline assembly operands.: void.
Sep 23 2020, 3:25 AM · Restricted Project
jonpa added a reviewer for D87279: [clang] Fix handling of physical registers in inline assembly operands.: void.
Sep 23 2020, 3:24 AM · Restricted Project
jonpa updated the diff for D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..

Thanks for review!

Sep 23 2020, 3:19 AM · Restricted Project
jonpa added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Right, I will adjust to make it more clear.

Sep 23 2020, 1:16 AM · Restricted Project

Sep 22 2020

jonpa added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?

Sep 22 2020, 7:19 AM · Restricted Project
jonpa added inline comments to D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..
Sep 22 2020, 7:02 AM · Restricted Project
jonpa updated the diff for D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..

Updated per review (see inline comments).

Sep 22 2020, 7:02 AM · Restricted Project
jonpa added a comment to D87279: [clang] Fix handling of physical registers in inline assembly operands..

ping!

Sep 22 2020, 3:22 AM · Restricted Project
jonpa requested review of D88082: [SystemZ] Make sure not to call getZExtValue on a >64 bit constant..
Sep 22 2020, 3:19 AM · Restricted Project

Sep 11 2020

jonpa requested review of D87510: [SystemZ] Don't emit PC-relative memory accesses to unaligned (packed) symbols..
Sep 11 2020, 6:25 AM · Restricted Project
jonpa requested review of D87506: [SystemZ] Make LibFunc_bcmp unavailable.
Sep 11 2020, 4:28 AM · Restricted Project

Sep 8 2020

jonpa committed rG6dc3e22b5752: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted type in WidenVecRes_Convert. (authored by jonpa).
[DAGTypeLegalizer] Handle ZERO_EXTEND of promoted type in WidenVecRes_Convert.
Sep 8 2020, 7:55 AM
jonpa closed D86268: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted integer in WidenVecRes_Convert..
Sep 8 2020, 7:55 AM · Restricted Project
jonpa requested review of D87279: [clang] Fix handling of physical registers in inline assembly operands..
Sep 8 2020, 4:56 AM · Restricted Project

Sep 7 2020

jonpa abandoned D87130: [SelectionDAGBuilder] Remember to copy the FMF flags in visitBinary()..

Not needed anymore thanks to D87200.

Sep 7 2020, 1:30 AM · Restricted Project

Sep 5 2020

jonpa committed rG714ceefad9b9: [SelectionDAG] Always intersect SDNode flags during getNode() node memoization. (authored by jonpa).
[SelectionDAG] Always intersect SDNode flags during getNode() node memoization.
Sep 5 2020, 1:32 AM
jonpa closed D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode()..
Sep 5 2020, 1:32 AM · Restricted Project

Sep 4 2020

jonpa added a comment to D87130: [SelectionDAGBuilder] Remember to copy the FMF flags in visitBinary()..

I think this makes sense to me, but I want to point out that this partially reverts the commit https://reviews.llvm.org/D46854. I guess there may be other parts of this commit that should be reverted?

Sep 4 2020, 7:31 AM · Restricted Project
jonpa updated the diff for D86268: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted integer in WidenVecRes_Convert..

But we do not know anything about the relationship between C and B necessarily.

Added a check for this.

Sep 4 2020, 6:56 AM · Restricted Project
jonpa added a comment to D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode()..

The problem occurs when setFlags is done after memoization was already performed.

Ah, now I see what you mean :-)

Sep 4 2020, 3:32 AM · Restricted Project
jonpa removed reviewers for D87132: [Partial Inliner] Compute intrinsic cost through TTI: jnspaulsson, jonpa.
Sep 4 2020, 2:54 AM · Restricted Project, Restricted Project
jonpa requested review of D87130: [SelectionDAGBuilder] Remember to copy the FMF flags in visitBinary()..
Sep 4 2020, 1:45 AM · Restricted Project
jonpa updated the diff for D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode()..

We have to favor correctness over performance, so that's the right change. But if you already have some idea/example of how we are losing the flags on those SPEC tests, it would be great to add reduced versions as regression tests.

Sep 4 2020, 1:10 AM · Restricted Project

Sep 3 2020

jonpa updated the diff for D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode()..

Patch updated per review.

Sep 3 2020, 8:57 AM · Restricted Project

Sep 1 2020

jonpa added reviewers for D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode().: craig.topper, eli.friedman.
Sep 1 2020, 7:22 AM · Restricted Project

Aug 31 2020

jonpa requested review of D86871: [SelectionDAG] Let NSW/NUW flags be cleared by default in call to getNode()..
Aug 31 2020, 4:35 AM · Restricted Project

Aug 30 2020

jonpa updated the diff for D86519: [SystemZ] New pass for domain reassignment from integer to vector..

Latest improvements and fixes.

Aug 30 2020, 1:45 AM · Restricted Project

Aug 25 2020

jonpa added a comment to D86268: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted integer in WidenVecRes_Convert..

ping!

Aug 25 2020, 7:11 AM · Restricted Project
jonpa added a comment to D86519: [SystemZ] New pass for domain reassignment from integer to vector..

Note: This patch still has a way to go before being ready to commit...

Aug 25 2020, 3:51 AM · Restricted Project
jonpa requested review of D86519: [SystemZ] New pass for domain reassignment from integer to vector..
Aug 25 2020, 3:50 AM · Restricted Project

Aug 24 2020

jonpa committed rG8ac70694b9f9: [SystemZ] Preserve the MachineMemOperand in emitCondStore() in all cases. (authored by jonpa).
[SystemZ] Preserve the MachineMemOperand in emitCondStore() in all cases.
Aug 24 2020, 5:09 AM

Aug 20 2020

jonpa added inline comments to D86268: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted integer in WidenVecRes_Convert..
Aug 20 2020, 1:19 AM · Restricted Project