Page MenuHomePhabricator

johannes (Johannes Altmanninger)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2017, 3:22 AM (190 w, 3 d)

Recent Activity

Dec 20 2019

johannes committed rG04329dbfa6c2: [lldb] Fix test using lld on non-linux systems (authored by johannes).
[lldb] Fix test using lld on non-linux systems
Dec 20 2019, 4:31 AM
johannes added a comment to D71487: [LLDB] Fix address computation for inline function.

I'm having some troubles fixing this build failure:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/

Dec 20 2019, 2:49 AM · Restricted Project
johannes committed rG92211bf0f15b: [LLDB] Fix address computation for inline function (authored by johannes).
[LLDB] Fix address computation for inline function
Dec 20 2019, 12:09 AM
johannes closed D71487: [LLDB] Fix address computation for inline function.
Dec 20 2019, 12:09 AM · Restricted Project

Dec 19 2019

johannes updated the diff for D71487: [LLDB] Fix address computation for inline function.

check if the function's section is executable

Dec 19 2019, 3:20 PM · Restricted Project
johannes added inline comments to D71487: [LLDB] Fix address computation for inline function.
Dec 19 2019, 3:20 PM · Restricted Project
johannes updated the diff for D71487: [LLDB] Fix address computation for inline function.
  • Use addr.IsSectionOffset() as suggested.
  • Add test that links two copies of a compilation unit and makes sure that lldb only resolves it once.
Dec 19 2019, 9:02 AM · Restricted Project

Dec 16 2019

johannes added a comment to D71487: [LLDB] Fix address computation for inline function.

Thanks for the very useful feedback! Now I can finally see why this is happening.

Dec 16 2019, 1:58 PM · Restricted Project
johannes updated the diff for D71487: [LLDB] Fix address computation for inline function.

different approach (WIP): ignore functions with DW_AT_low_pc = 0

Dec 16 2019, 1:33 PM · Restricted Project

Dec 13 2019

johannes updated the diff for D71487: [LLDB] Fix address computation for inline function.

typo

Dec 13 2019, 12:51 PM · Restricted Project
johannes created D71487: [LLDB] Fix address computation for inline function.
Dec 13 2019, 12:51 PM · Restricted Project

Dec 3 2019

johannes committed rG09667bc19204: [asan] Remove debug locations from alloca prologue instrumentation (authored by johannes).
[asan] Remove debug locations from alloca prologue instrumentation
Dec 3 2019, 2:30 AM
johannes added a reverting change for rGaaf4bb239487: [asan] Set debug location in ASan function prologue.: rG09667bc19204: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 3 2019, 2:30 AM
johannes closed D70894: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 3 2019, 2:29 AM · Restricted Project
johannes updated the diff for D70894: [asan] Remove debug locations from alloca prologue instrumentation.

update comment and commit message

Dec 3 2019, 2:10 AM · Restricted Project

Dec 2 2019

johannes updated the summary of D70894: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 2 2019, 5:16 AM · Restricted Project
johannes updated the summary of D70894: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 2 2019, 5:16 AM · Restricted Project
johannes added reviewers for D70894: [asan] Remove debug locations from alloca prologue instrumentation: eugenis, aprantl.
Dec 2 2019, 4:48 AM · Restricted Project
johannes abandoned D70895: [asan] Remove debug locations from alloca prologue instrumentation.

duplicate of https://reviews.llvm.org/D70894

Dec 2 2019, 4:48 AM · Restricted Project
johannes created D70895: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 2 2019, 4:48 AM · Restricted Project
johannes created D70894: [asan] Remove debug locations from alloca prologue instrumentation.
Dec 2 2019, 4:48 AM · Restricted Project

Nov 30 2019

johannes added a comment to D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.
In D70302#1763025, @rnk wrote:

Fix looks good post commit, but we should enhance the test.

Nov 30 2019, 12:49 AM · Restricted Project

Nov 27 2019

johannes added a comment to D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.

Committed as 1ac700cdef787383ad49a0e37d9894491ef19480 - this should be a safe fix

Nov 27 2019, 4:26 PM · Restricted Project
johannes committed rG1ac700cdef78: [CodeGen] Fix clang crash on aggregate initialization of array of labels (authored by johannes).
[CodeGen] Fix clang crash on aggregate initialization of array of labels
Nov 27 2019, 4:17 PM
johannes closed D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.
Nov 27 2019, 4:17 PM · Restricted Project
johannes updated the diff for D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.

update commit message

Nov 27 2019, 4:08 PM · Restricted Project

Nov 15 2019

johannes added inline comments to D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.
Nov 15 2019, 8:18 AM · Restricted Project
johannes updated the diff for D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.

Remove unnecessary const on parameter

Nov 15 2019, 8:09 AM · Restricted Project
johannes created D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels.
Nov 15 2019, 3:39 AM · Restricted Project

Aug 27 2018

johannes added a comment to D34329: [clang-diff] Initial implementation..

@arphaman @johannes Is that normal that clang-diff isn't installed by cmake? (like clang-format?)

Aug 27 2018, 6:36 AM

Apr 14 2018

johannes removed a reviewer for D45637: [DebugInfo] Ignore DBG_VALUE instructions in PostRA Machine Sink: johannes.
Apr 14 2018, 6:03 AM · debug-info

Dec 27 2017

johannes updated the diff for D40782: [tablegen] Replace strconcat, listconcat by concat.

use generic concat

Dec 27 2017, 2:51 AM

Dec 20 2017

johannes added a comment to D40782: [tablegen] Replace strconcat, listconcat by concat.

I use a different approach now, WDYT?

I'm not sure I like this. Before it was clear: !strconcat is for strings, !codeconcat was for code. Having !strconcat also work on code, and return something which isn't a string, seems unfortunate. And we also have !listconcat. If we want to unify things, I think it would make sense to add !concat (which works on all of those things). [If you do this, then also support !strconcat and !listconcat as aliases to be nice to out-of-tree backends].

Dec 20 2017, 7:31 AM

Dec 18 2017

johannes added a comment to D40782: [tablegen] Replace strconcat, listconcat by concat.

I use a different approach now, WDYT?

Dec 18 2017, 12:57 AM
johannes retitled D40782: [tablegen] Replace strconcat, listconcat by concat from [tablegen] Add !codeconcat operator which works like !strconcat to [tablegen] Make strconcat return code if all arguments are code.
Dec 18 2017, 12:57 AM
johannes updated the diff for D40782: [tablegen] Replace strconcat, listconcat by concat.

remove codeconcat, make strconcat return code if all arguments are

Dec 18 2017, 12:55 AM

Dec 12 2017

johannes updated the diff for D40782: [tablegen] Replace strconcat, listconcat by concat.

add documentation + test

Dec 12 2017, 5:56 AM

Dec 4 2017

johannes added a comment to D40731: Integrate CHash into CLang.

For my changes to StmtDataCollectors: I tried to leave the already existing entries in StmtDataCollector.td untouched and the test-cases still work OK. If there is something somebody could break by changing these files it would be good to have a test case for it.

Dec 4 2017, 6:43 AM
johannes updated subscribers of D40731: Integrate CHash into CLang.
Dec 4 2017, 6:24 AM
johannes added a comment to D40731: Integrate CHash into CLang.

So you can define a category for cHash and add let cHash = [{ .. }] or let cHash = TypeIIClone; if you just want to reuse it.
With this patch you can also use !codeconcat to append some code: https://reviews.llvm.org/D40782

Dec 4 2017, 6:13 AM
johannes updated the diff for D40782: [tablegen] Replace strconcat, listconcat by concat.

adhere to the column limit

Dec 4 2017, 6:10 AM
johannes created D40782: [tablegen] Replace strconcat, listconcat by concat.
Dec 4 2017, 6:07 AM
johannes added a comment to D40731: Integrate CHash into CLang.

I think it would be quite nice if we manage to consolidate the implementation of hashing mechanisms.

Dec 4 2017, 5:54 AM
johannes created D40781: [DataCollection] Allow choosing between collection categories.
Dec 4 2017, 5:28 AM

Nov 5 2017

johannes created D39664: [clang-diff] patching: implement updates.
Nov 5 2017, 12:00 PM
johannes created D39663: [clang-diff] Split source ranges at points where nodes are inserted..
Nov 5 2017, 11:55 AM
johannes updated the summary of D37005: [clang-diff] Initial implementation of patching.
Nov 5 2017, 11:54 AM
johannes updated the diff for D37005: [clang-diff] Initial implementation of patching.

update

Nov 5 2017, 11:53 AM
johannes created D39662: [clang-diff] Enable postorder traversal.
Nov 5 2017, 11:49 AM
johannes created D39661: [clang-diff] Move printing of changes to the ASTDiff library.
Nov 5 2017, 11:48 AM
johannes created D39660: [clang-diff] Don't ignore nodes from other files.
Nov 5 2017, 11:46 AM
johannes created D39659: [clang-diff] Store changes within ASTDiff::Impl.
Nov 5 2017, 11:45 AM
johannes created D39658: [clang-diff] Treat QualType / TypeLoc as a node.
Nov 5 2017, 11:44 AM
johannes updated the diff for D37003: [clang-diff] Support templates.

update

Nov 5 2017, 11:22 AM
johannes updated the diff for D36688: [clang-diff] Fix matching for unnamed NamedDecs.

update

Nov 5 2017, 11:22 AM
johannes created D39656: [clang-diff] Remove getNodeValue.
Nov 5 2017, 11:21 AM
johannes updated the diff for D37001: [clang-diff] Use data collectors for node comparison.

use raw source code of owned tokens instead

Nov 5 2017, 11:20 AM
johannes created D39655: [clang-diff] Expose Node::getSourceRange().
Nov 5 2017, 11:14 AM
johannes abandoned D39654: [clang-diff] Expose Node::getSourceRange().
Nov 5 2017, 11:11 AM
johannes created D39654: [clang-diff] Expose Node::getSourceRange().
Nov 5 2017, 11:10 AM
johannes created D39653: [clang-diff] Add utility functions, forbid copying Node.
Nov 5 2017, 11:07 AM
johannes updated the diff for D36997: [clang-diff] Honor macros.

update

Nov 5 2017, 11:05 AM
johannes updated the diff for D36687: [clang-diff] Match nodes with the same parent and same value.

update

Nov 5 2017, 11:04 AM
johannes created D39652: [clang-diff] NFC: factor out getCompilationDatabase().
Nov 5 2017, 11:03 AM
johannes created D39651: [clang-diff] NFC: renames, moves.
Nov 5 2017, 11:02 AM
johannes created D39650: [clang-diff] Make getSourceRangeOffsets a member of Node.
Nov 5 2017, 11:00 AM
johannes created D39649: [clang-diff] Split findPositionInParent.
Nov 5 2017, 10:59 AM
johannes created D39648: [clang-diff] NFC: organise header.
Nov 5 2017, 10:57 AM
johannes created D39647: [clang-diff] NFC: remove Mapping.
Nov 5 2017, 10:56 AM
johannes created D39646: [clang-diff] Rename ChangeKind::None to NoChange.
Nov 5 2017, 10:55 AM
johannes created D39645: [clang-diff] NFC: replace const Node & with a typedef'd NodeRef.
Nov 5 2017, 10:54 AM
johannes created D39644: [clang-diff] Use references to Node instead of NodeId.
Nov 5 2017, 10:51 AM

Sep 13 2017

johannes added inline comments to D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order.
Sep 13 2017, 5:58 AM
johannes updated the diff for D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order.

use CXXOperatorCallExpr::isPrefixOp() to determine whether it's infix or postfix
directly traverse statement children instead of copying

Sep 13 2017, 5:56 AM

Sep 11 2017

johannes added inline comments to D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order.
Sep 11 2017, 7:02 AM

Sep 9 2017

johannes created D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order.
Sep 9 2017, 3:46 AM
johannes created D37662: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order.
Sep 9 2017, 3:46 AM

Sep 6 2017

johannes added a comment to D37383: [AST] Add TableGen for StmtDataCollectors.

@teemperor ok for you? did phabricator make you a blocking reviewer because of the affected code, or did I do that somehow?

Sep 6 2017, 6:07 AM

Sep 1 2017

johannes updated the diff for D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor.

undo visibility change

Sep 1 2017, 12:52 PM
johannes added a comment to D37383: [AST] Add TableGen for StmtDataCollectors.

@arphaman I suggested tablegen in D36664 because I remembered we had some CMake sanity check about not having an *.inc in our include dir: https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure if it actually fires for our case, but it looks like it does.

Sep 1 2017, 12:49 PM
johannes created D37383: [AST] Add TableGen for StmtDataCollectors.
Sep 1 2017, 9:22 AM
johannes updated the diff for D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor.

fix by adding an option in RecursiveASTVisitor

Sep 1 2017, 9:22 AM
johannes added inline comments to D37001: [clang-diff] Use data collectors for node comparison.
Sep 1 2017, 12:28 AM

Aug 29 2017

johannes added inline comments to D37005: [clang-diff] Initial implementation of patching.
Aug 29 2017, 6:23 AM
johannes updated the diff for D37005: [clang-diff] Initial implementation of patching.

fixes

Aug 29 2017, 6:22 AM
johannes added a comment to D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor.

This is currently broken, if a user provides a TraverseClassTemplateDecl, then the same method in this class will not be called, I think I will add a flag (probably not user visible) in RecursiveASTVisitor.h to switch the order for templates

Aug 29 2017, 5:56 AM

Aug 28 2017

johannes added a comment to D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

Yeah, this seems to be the best solution for this. I think I ran into the same issue when working on the StmtDataCollector - basically there can only be two Traverse*, one in the Derived class and the other one needs to do all the magic with walking the specialisation hierarchy.

Aug 28 2017, 1:36 PM
johannes updated the diff for D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

use a specialized getStmtChildren to fix the order for CXXOperatorCallExpr

Aug 28 2017, 1:29 PM
johannes updated the diff for D37005: [clang-diff] Initial implementation of patching.

split to ASTDiff/ASTPatch

Aug 28 2017, 11:42 AM
johannes updated the diff for D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

detect prefix/postfix from number of arguments

Aug 28 2017, 6:49 AM
johannes added a comment to D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

The previous version didn't call TraverseDecl of the derived class, this is fixed now.
The public getDerived.TraverseStmt() does not accept a DataRecursionQueue, so this also could not be used (I think)
I used the wrapper TraverseStmtBase, which should behave exactly as the method that originally traverses CXXOperatorCallExpr

Aug 28 2017, 6:24 AM
johannes updated the diff for D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

do call derived TraverseStmt for children of CXXOperatorCallExpr

Aug 28 2017, 6:19 AM
johannes updated the diff for D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.

use RecursiveASTVisitor::TraverseStmt

Aug 28 2017, 5:01 AM
johannes added inline comments to D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.
Aug 28 2017, 4:04 AM

Aug 27 2017

johannes updated the diff for D37005: [clang-diff] Initial implementation of patching.

use rewriter to patch a third AST

Aug 27 2017, 4:02 PM
johannes created D37201: [clang-diff] Use correct SourceRange for CXXConstructExpr.
Aug 27 2017, 3:58 PM
johannes created D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor.
Aug 27 2017, 3:57 PM
johannes closed D36187: [clang-diff] Use the relative name for NamedDecls.
Aug 27 2017, 3:53 PM

Aug 25 2017

johannes updated the diff for D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor.

test ordering, class template

Aug 25 2017, 10:06 AM
johannes added inline comments to D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr.
Aug 25 2017, 8:39 AM