Page MenuHomePhabricator

jgorbe (Jorge Gorbe Moya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 3:56 PM (226 w, 3 d)

Recent Activity

May 5 2021

jgorbe added a comment to D99980: [SLP]Improve cost model for the vectorized extractelements..
May 5 2021, 12:16 PM · Restricted Project

May 3 2021

jgorbe added a comment to D99980: [SLP]Improve cost model for the vectorized extractelements..

Hi, we're seeing some build failures after this patch. If you build the following reduced test case with clang -cc1 -emit-obj -O3 -vectorize-slp reduced.cc

May 3 2021, 4:33 PM · Restricted Project

Apr 21 2021

jgorbe added a comment to D100466: clang-format: [JS] merge import lines..

Hi, one of our tests is failing because of this patch and it looks like an actual bug. clang-format now turns this file:

import './a';
import {bar} from './a';

into this:

barimport './a';
Apr 21 2021, 1:28 PM · Restricted Project

Feb 23 2021

jgorbe committed rG979ca1c05f83: Defer the decision whether to use the CU or TU index until after reading the… (authored by jgorbe).
Defer the decision whether to use the CU or TU index until after reading the…
Feb 23 2021, 1:26 PM
jgorbe closed D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 23 2021, 1:26 PM · Restricted Project
jgorbe added a comment to D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

I'm going to go ahead and commit this given that I have just made the last suggested modification and the patch has already been up for review without further comments for a long while (sorry for the late replies, work keeps getting in the way of work).

Feb 23 2021, 1:22 PM · Restricted Project
jgorbe updated the diff for D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

Changed logic that checked the type of unit to use header.IsTypeUnit() as suggested by reviewer.

Feb 23 2021, 1:20 PM · Restricted Project

Feb 11 2021

jgorbe updated the diff for D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

Moved index handling to DWARFUnit.cpp as suggested by Pavel.

Feb 11 2021, 2:54 PM · Restricted Project
jgorbe added inline comments to D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 11 2021, 10:46 AM · Restricted Project

Feb 5 2021

jgorbe requested review of D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 5 2021, 6:19 PM · Restricted Project

Jan 5 2021

jgorbe committed rGa39b19821b6b: Make DWARFUnit use the dwo_id from the DWARF5 CU header. (authored by jgorbe).
Make DWARFUnit use the dwo_id from the DWARF5 CU header.
Jan 5 2021, 4:41 PM
jgorbe closed D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..
Jan 5 2021, 4:40 PM · Restricted Project
jgorbe added a comment to D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..

Thanks for accepting the patch! (and sorry for the late reply, I was on vacation). I'll commit this now :)

Jan 5 2021, 3:44 PM · Restricted Project

Dec 16 2020

jgorbe requested review of D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..
Dec 16 2020, 9:59 PM · Restricted Project

Dec 14 2020

jgorbe added a comment to D91589: [DAGCombiner] Fold (sext (not i1 x)) -> (add (zext i1 x), -1).

Hi! We have bisected a clang crash to this patch. The following reduced test case crashes clang when built with clang -O1 -frounding-math:

Dec 14 2020, 5:23 PM · Restricted Project

Dec 3 2020

jgorbe added a comment to D80706: [DAGCombine] Add hook to allow target specific test for sqrt input.

Found a crash that seems to be caused by this patch. This is a reduced test case:

extern "C"
#define a(b, c, args) d(double, b, , args)
#define d(g, b, c, args) g b args
    a(sqrt, , (double));
int e;
double f = sqrt(e);

Building with clang -target powerpc64le-grtev4-linux-gnu -ffast-math repro.cpp crashes a top-of-tree clang.

Dec 3 2020, 5:56 PM · Restricted Project

Nov 19 2020

jgorbe committed rG314a0d73a844: Fix crash after looking up dwo_id=0 in CU index. (authored by jgorbe).
Fix crash after looking up dwo_id=0 in CU index.
Nov 19 2020, 11:15 AM
jgorbe closed D91670: Fix crash after looking up dwo_id=0 in CU index..
Nov 19 2020, 11:15 AM · Restricted Project
jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Thanks everyone for the reviews! I'm committing this now.

Nov 19 2020, 10:53 AM · Restricted Project

Nov 18 2020

jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

then the check Rows[H].getSignature() != S won't fail

The condition fails. It should return nullptr but returned a Rows entry.

Nov 18 2020, 12:26 PM · Restricted Project
jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Updated diff addressing the new round of feedback.

Nov 18 2020, 11:40 AM · Restricted Project
jgorbe updated the diff for D91670: Fix crash after looking up dwo_id=0 in CU index..

Addressed reviewer comments.

Nov 18 2020, 11:38 AM · Restricted Project

Nov 17 2020

jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Thanks for the comments!

Nov 17 2020, 6:08 PM · Restricted Project
jgorbe updated the diff for D91670: Fix crash after looking up dwo_id=0 in CU index..

Changed test expectation from "not a stack dump" to the actual output from llvm-symbolizer for the test case.

Nov 17 2020, 6:05 PM · Restricted Project
jgorbe requested review of D91670: Fix crash after looking up dwo_id=0 in CU index..
Nov 17 2020, 5:32 PM · Restricted Project

Aug 18 2020

jgorbe accepted D86163: Default to disabling the libunwind frameheader cache.

LGTM

Aug 18 2020, 1:40 PM · Restricted Project, Restricted Project

Aug 10 2020

jgorbe added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

This looks good to me FWIW. I'd prefer if someone more experienced with the project would accept it, though.

Aug 10 2020, 2:25 PM · Restricted Project, Restricted Project

Aug 6 2020

jgorbe added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Aug 6 2020, 5:52 PM · Restricted Project, Restricted Project

Apr 7 2020

jgorbe committed rG82576d6fecfe: [libunwind] Fix UB in EHHeaderParser::findFDE (authored by jgorbe).
[libunwind] Fix UB in EHHeaderParser::findFDE
Apr 7 2020, 3:17 PM
jgorbe closed D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.
Apr 7 2020, 3:17 PM · Restricted Project, Restricted Project
jgorbe created D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.
Apr 7 2020, 2:10 PM · Restricted Project, Restricted Project

Mar 17 2020

jgorbe added a comment to D75689: [VectorCombine] fold extract-extract-op with different extraction indexes.

Thanks for the note about the flags. We have tried both of them, and any (or both) of them being present causes the regression to go away, so that unblocks us while we work on producing a proper test case.

Mar 17 2020, 4:46 PM · Restricted Project

Mar 16 2020

jgorbe added a comment to D75689: [VectorCombine] fold extract-extract-op with different extraction indexes.

We're seeing some large performance regressions on Eigen (http://eigen.tuxfamily.org/) running on haswell and skylake machines with this patch. Could you please revert it?

Mar 16 2020, 6:03 PM · Restricted Project

Mar 12 2020

jgorbe accepted D75954: Cache uwnind frame headers as they are found..
Mar 12 2020, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2020

jgorbe added a comment to D75954: Cache uwnind frame headers as they are found..

Thanks for doing the extra work of adding a test. Just one final nit.

Mar 11 2020, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe added a comment to D75954: Cache uwnind frame headers as they are found..

I think it looks good now. My only issue is that it seems to rely on a couple of glibc-specific features: glibc modifying the fields adds and subs in dl_phdr_info when loading/unloading libraries (which this patch uses to know when to invalidate the cache), and dl_iterate_phdr holding a lock (which the patch relies on to avoid races while accessing the cache). What other libc implementations do we support? Do they share these behaviors we rely on here?

Mar 11 2020, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2020

jgorbe added inline comments to D75954: Cache uwnind frame headers as they are found..
Mar 10 2020, 3:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2020

jgorbe accepted D75781: Rework findUnwindSectionsByPhdr to be more optimal..

Thanks!

Mar 9 2020, 6:22 PM · Restricted Project
jgorbe added inline comments to D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mar 9 2020, 5:17 PM · Restricted Project
jgorbe accepted D75692: Lazily save initialState of registers during unwind..

Looks good to me.

Mar 9 2020, 5:17 PM · Restricted Project
jgorbe added inline comments to D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mar 9 2020, 3:40 PM · Restricted Project
jgorbe added inline comments to D75692: Lazily save initialState of registers during unwind..
Mar 9 2020, 3:07 PM · Restricted Project

Mar 6 2020

jgorbe accepted D75705: Split findUnwindSectionsByPhdr into target-specific functions..

As far as I can tell (there is indeed a lot of ifdeffing going on, please keep an eye on the buildbots) this change seems to be both NFC and an improvement to the previous state, so LGTM.

Mar 6 2020, 12:43 PM · Restricted Project

Feb 18 2020

jgorbe committed rG1ae8d81147a0: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and… (authored by jgorbe).
[libunwind] Fix memory leak in handling of DW_CFA_remember_state and…
Feb 18 2020, 11:58 AM
jgorbe closed D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Feb 18 2020, 11:58 AM · Restricted Project

Feb 4 2020

jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Could anyone please take another look at this?

Feb 4 2020, 2:50 PM · Restricted Project

Jan 14 2020

jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Ping?

Jan 14 2020, 3:43 PM · Restricted Project

Dec 3 2019

jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Ping

Dec 3 2019, 12:06 PM · Restricted Project

Nov 18 2019

jgorbe added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

I found a clang crash that seems to be caused by this patch. Here's a reduced test case:

Nov 18 2019, 1:03 AM · Restricted Project, Restricted Project

Nov 15 2019

jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Sorry it took me so long to respond to this. Please take another look.

Nov 15 2019, 1:40 PM · Restricted Project
jgorbe updated the diff for D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Nov 15 2019, 1:39 PM · Restricted Project
jgorbe updated the diff for D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Nov 15 2019, 1:21 PM · Restricted Project

Oct 14 2019

jgorbe committed rGb052331bd614: Revert "Dead Virtual Function Elimination" (authored by jgorbe).
Revert "Dead Virtual Function Elimination"
Oct 14 2019, 4:30 PM
jgorbe added a reverting change for rG9f6a873268e1: Dead Virtual Function Elimination: rGb052331bd614: Revert "Dead Virtual Function Elimination".
Oct 14 2019, 4:30 PM
jgorbe committed rL374844: Revert "Dead Virtual Function Elimination".
Revert "Dead Virtual Function Elimination"
Oct 14 2019, 4:24 PM
jgorbe added a comment to rL374539: Dead Virtual Function Elimination.

Hi Oliver,

Oct 14 2019, 3:50 PM

Oct 10 2019

jgorbe committed rL374393: Add github commit access for my github account @slackito.
Add github commit access for my github account @slackito
Oct 10 2019, 10:43 AM

Oct 3 2019

jgorbe added inline comments to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Oct 3 2019, 3:38 PM · Restricted Project
jgorbe updated the diff for D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Re-made the test asm file starting with a -O2 compilation to avoid some unnecessary code.

Oct 3 2019, 3:38 PM · Restricted Project

Sep 6 2019

jgorbe added inline comments to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Sep 6 2019, 6:15 PM · Restricted Project
jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

It's just that it seemed weird/hacky to use asm just to stick assembler directives in the middle of the generated code instead of actual assembly, so I generated an assembly version and cleaned it up a bit. I'm happy to go back to the original shorter C++ version if that's not a concern.

Sep 6 2019, 6:15 PM · Restricted Project
jgorbe updated the diff for D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Added a test case that seems to work well with the existing testing setup if I rebuild LLVM with ASan enabled. I have checked out other usages of .cfi_* directives in other LLVM assembly test files and they seem to run them through some llvm tool with -triple <something including linux>, so I have added a REQUIRES: linux line to avoid breakage.

Sep 6 2019, 5:59 PM · Restricted Project

Aug 30 2019

jgorbe added a comment to D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.

Looking into how to add a test now. I'm not familiar at all with libunwind code, so I have no idea how to cause this leak to happen from the outside (and then the test would only work when running under asan). Any pointers would be much appreciated.

Aug 30 2019, 12:50 PM · Restricted Project

Aug 28 2019

jgorbe added reviewers for D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state: phosek, mstorsjo.
Aug 28 2019, 2:10 PM · Restricted Project
jgorbe created D66904: [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state.
Aug 28 2019, 1:55 PM · Restricted Project

Aug 2 2019

jgorbe added a comment to rL366570: [MachineCSE][MachinePRE] Avoid hoisting code from code regions into hot BBs..

FYI we have detected a 2-3% performance regression on Haswell machines in test-suite/MicroBenchmarks/ImageProcessing/Interpolation that seems to be caused by this commit.

Aug 2 2019, 11:04 AM

Jun 7 2019

jgorbe committed rG13427e64de2b: [lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry. (authored by jgorbe).
[lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry.
Jun 7 2019, 2:07 PM
jgorbe committed rL362843: [lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry..
[lldb] Fix msan use-of-uninitialized-value in DWARFDebugLine::FileNameEntry.
Jun 7 2019, 2:06 PM

Jun 6 2019

jgorbe abandoned D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp.
Jun 6 2019, 2:00 PM
jgorbe removed reviewers for D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp: clayborg, labath.
Jun 6 2019, 2:00 PM
jgorbe added a comment to D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp.

Hm, I just realized I'm undoing https://reviews.llvm.org/D58883.

Jun 6 2019, 1:55 PM
jgorbe created D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp.
Jun 6 2019, 1:53 PM
jgorbe added a comment to D62948: lit/Register: Avoid stdio in register write tests.

About %T not working for "process launch", what about something like RUN: %lldb -b --one-line-before-file "process launch --stdout %T/x86-zmm-write.out" -s %s %t and then FileCheck-ing?

Jun 6 2019, 1:46 PM

May 23 2019

jgorbe committed rG56d69ef8ca1f: [lldb] Make sure RegularExpression constructors always initialize member… (authored by jgorbe).
[lldb] Make sure RegularExpression constructors always initialize member…
May 23 2019, 1:12 PM
jgorbe committed rLLDB361546: [lldb] Make sure RegularExpression constructors always initialize member….
[lldb] Make sure RegularExpression constructors always initialize member…
May 23 2019, 1:11 PM
jgorbe committed rL361546: [lldb] Make sure RegularExpression constructors always initialize member….
[lldb] Make sure RegularExpression constructors always initialize member…
May 23 2019, 1:11 PM
jgorbe closed D62334: [lldb] Make sure RegularExpression constructors always initialize member variables.
May 23 2019, 1:11 PM · Restricted Project
jgorbe updated the diff for D62334: [lldb] Make sure RegularExpression constructors always initialize member variables.

Fixed indentation.

May 23 2019, 11:39 AM · Restricted Project
jgorbe created D62334: [lldb] Make sure RegularExpression constructors always initialize member variables.
May 23 2019, 11:36 AM · Restricted Project

May 22 2019

jgorbe committed rG33dbab82715c: [lldb] Fix use-of-uninitialized-value in Driver (authored by jgorbe).
[lldb] Fix use-of-uninitialized-value in Driver
May 22 2019, 4:36 PM
jgorbe committed rL361444: [lldb] Fix use-of-uninitialized-value in Driver.
[lldb] Fix use-of-uninitialized-value in Driver
May 22 2019, 4:36 PM
jgorbe committed rLLDB361444: [lldb] Fix use-of-uninitialized-value in Driver.
[lldb] Fix use-of-uninitialized-value in Driver
May 22 2019, 4:36 PM

May 9 2019

jgorbe committed rGadf427b82d40: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler (authored by jgorbe).
[lldb] build.py: fix behavior when passing --compiler=/path/to/compiler
May 9 2019, 9:46 AM
jgorbe committed rLLDB360355: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.
[lldb] build.py: fix behavior when passing --compiler=/path/to/compiler
May 9 2019, 9:46 AM
jgorbe committed rL360355: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.
[lldb] build.py: fix behavior when passing --compiler=/path/to/compiler
May 9 2019, 9:46 AM
jgorbe closed D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.
May 9 2019, 9:46 AM · Restricted Project, Restricted Project
jgorbe updated the diff for D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.

Removed trailing blank lines from test case, will commit now. Thanks for the review!

May 9 2019, 9:46 AM · Restricted Project, Restricted Project
jgorbe updated the diff for D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.

Added a new test that checks that, when a full path to a compiler is specified:

May 9 2019, 9:38 AM · Restricted Project, Restricted Project

May 8 2019

jgorbe created D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler.
May 8 2019, 7:25 PM · Restricted Project, Restricted Project

Apr 26 2019

jgorbe committed rG1dbd42ab5bab: Revert Fix interactions between __builtin_constant_p and constexpr to match… (authored by jgorbe).
Revert Fix interactions between __builtin_constant_p and constexpr to match…
Apr 26 2019, 5:31 PM
jgorbe committed rL359361: Revert Fix interactions between __builtin_constant_p and constexpr to match….
Revert Fix interactions between __builtin_constant_p and constexpr to match…
Apr 26 2019, 5:30 PM
jgorbe committed rC359361: Revert Fix interactions between __builtin_constant_p and constexpr to match….
Revert Fix interactions between __builtin_constant_p and constexpr to match…
Apr 26 2019, 5:30 PM

Apr 22 2019

jgorbe added a comment to D60608: Make TestVSCode_step pass reliably.

Thanks for the fix!

Apr 22 2019, 11:30 AM · Restricted Project

Apr 16 2019

jgorbe added a comment to D60153: Re-enable most lldb-vscode tests on Linux..

Thanks! Please let me know if it happens again and I'll try my best to debug it.

Apr 16 2019, 3:03 PM · Restricted Project, Restricted Project

Apr 3 2019

jgorbe committed rG060bf99f493e: Re-enable most lldb-vscode tests on Linux. (authored by jgorbe).
Re-enable most lldb-vscode tests on Linux.
Apr 3 2019, 1:44 PM
jgorbe committed rLLDB357633: Re-enable most lldb-vscode tests on Linux..
Re-enable most lldb-vscode tests on Linux.
Apr 3 2019, 1:42 PM
jgorbe committed rL357633: Re-enable most lldb-vscode tests on Linux..
Re-enable most lldb-vscode tests on Linux.
Apr 3 2019, 1:42 PM
jgorbe closed D60153: Re-enable most lldb-vscode tests on Linux..
Apr 3 2019, 1:42 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D60153: Re-enable most lldb-vscode tests on Linux..

Increased wait time in test binary for TestVSCode_attach.py from 5 to 10 seconds.

Apr 3 2019, 1:38 PM · Restricted Project, Restricted Project

Apr 2 2019

jgorbe created D60153: Re-enable most lldb-vscode tests on Linux..
Apr 2 2019, 2:42 PM · Restricted Project, Restricted Project