User Details
User Details
- User Since
- Sep 27 2016, 5:43 PM (225 w, 5 d)
May 8 2017
May 8 2017
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Ran check-clang
Apr 5 2017
Apr 5 2017
jbangert updated the diff for D29622: Add a batch query and replace tool based on AST matchers..
Fix command line tool.
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
- Merge branch 'master' of http://llvm.org/git/clang into replace_template
Feb 24 2017
Feb 24 2017
jbangert added inline comments to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
use llvm::report_fatal_error instead of unreachable.
Feb 22 2017
Feb 22 2017
jbangert accepted D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Thanks, added tests for parser failures.
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
- additional tests
Feb 9 2017
Feb 9 2017
jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Fixed the test -- I am still getting used to the different ninja test targets.
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
- fix test
Feb 7 2017
Feb 7 2017
jbangert added a comment to D29622: Add a batch query and replace tool based on AST matchers..
Thank you for the feedback, addressed and reformatted using llvm style.
jbangert updated the diff for D29622: Add a batch query and replace tool based on AST matchers..
Response to initial code review.
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
- use iter
jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
(marking other comments as done).
jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Thank you for the initial feedback!
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
- change to push_back
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Address code feedback & Reformat with clang-format --style llvm.
Feb 6 2017
Feb 6 2017
jbangert updated the summary of D29613: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Jan 11 2017
Jan 11 2017
jbangert updated the diff for D26015: Correctly classify main file includes if there is a prefix added.
- Add header to unit test fixture.
Jan 4 2017
Jan 4 2017
jbangert added a comment to D26015: Correctly classify main file includes if there is a prefix added.
I slightly changed the approach of this CL, and added a test. This now also works in clang_tidy is called from a different working directory.
jbangert retitled D26015: Correctly classify main file includes if there is a prefix added from Don't include the same file twice in IncludeInserter, even if misclassified. to Correctly classify main file includes if there is a prefix added.
jbangert updated the diff for D26015: Correctly classify main file includes if there is a prefix added.
Instead modify IncludeInserter to classify correctly.
Oct 26 2016
Oct 26 2016
jbangert retitled D26015: Correctly classify main file includes if there is a prefix added from to Don't include the same file twice in IncludeInserter, even if misclassified..
Oct 14 2016
Oct 14 2016
jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 14 2016, 1:26 PM · Restricted Project
Oct 11 2016
Oct 11 2016
jbangert added a comment to D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Thanks for the review!
Oct 11 2016, 5:03 PM · Restricted Project
jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 11 2016, 5:02 PM · Restricted Project
Oct 10 2016
Oct 10 2016
jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 10 2016, 4:53 PM · Restricted Project
Oct 3 2016
Oct 3 2016
Oct 3 2016, 3:20 PM · Restricted Project
Sep 27 2016
Sep 27 2016
jbangert retitled D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser from to [ClangTidy] Add UsingInserter and NamespaceAliaser.
Sep 27 2016, 6:29 PM · Restricted Project