Page MenuHomePhabricator

jbangert (Julian Bangert)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2016, 5:43 PM (225 w, 5 d)

Recent Activity

May 8 2017

jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

Ran check-clang

May 8 2017, 2:00 PM

Apr 5 2017

jbangert updated the diff for D29622: Add a batch query and replace tool based on AST matchers..

Fix command line tool.

Apr 5 2017, 3:33 PM
jbangert accepted D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Apr 5 2017, 2:11 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Apr 5 2017, 2:09 PM

Feb 24 2017

jbangert added inline comments to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Feb 24 2017, 3:15 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

use llvm::report_fatal_error instead of unreachable.

Feb 24 2017, 3:05 PM

Feb 22 2017

jbangert accepted D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

Thanks, added tests for parser failures.

Feb 22 2017, 2:25 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
  • additional tests
Feb 22 2017, 2:23 PM

Feb 9 2017

jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

Fixed the test -- I am still getting used to the different ninja test targets.

Feb 9 2017, 2:13 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
  • fix test
Feb 9 2017, 2:12 PM

Feb 7 2017

jbangert added a comment to D29622: Add a batch query and replace tool based on AST matchers..

Thank you for the feedback, addressed and reformatted using llvm style.

Feb 7 2017, 6:31 PM
jbangert updated the diff for D29622: Add a batch query and replace tool based on AST matchers..

Response to initial code review.

Feb 7 2017, 6:31 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
  • use iter
Feb 7 2017, 6:30 PM
jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

(marking other comments as done).

Feb 7 2017, 6:29 PM
jbangert added a comment to D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

Thank you for the initial feedback!

Feb 7 2017, 6:29 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
  • change to push_back
Feb 7 2017, 6:16 PM
jbangert updated the diff for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.

Address code feedback & Reformat with clang-format --style llvm.

Feb 7 2017, 6:15 PM
jbangert created D29622: Add a batch query and replace tool based on AST matchers..
Feb 7 2017, 1:12 AM
jbangert abandoned D29614: Add a batch query and replace tool based on AST matchers..
Feb 7 2017, 1:11 AM
jbangert created D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Feb 7 2017, 1:09 AM
jbangert abandoned D29613: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Feb 7 2017, 1:08 AM

Feb 6 2017

jbangert created D29614: Add a batch query and replace tool based on AST matchers..
Feb 6 2017, 5:36 PM
jbangert updated the summary of D29613: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Feb 6 2017, 5:34 PM
jbangert created D29613: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Feb 6 2017, 5:32 PM

Jan 11 2017

jbangert updated the diff for D26015: Correctly classify main file includes if there is a prefix added.
  • Add header to unit test fixture.
Jan 11 2017, 10:42 AM

Jan 4 2017

jbangert added a comment to D26015: Correctly classify main file includes if there is a prefix added.

I slightly changed the approach of this CL, and added a test. This now also works in clang_tidy is called from a different working directory.

Jan 4 2017, 4:03 PM
jbangert retitled D26015: Correctly classify main file includes if there is a prefix added from Don't include the same file twice in IncludeInserter, even if misclassified. to Correctly classify main file includes if there is a prefix added.
Jan 4 2017, 4:02 PM
jbangert updated the diff for D26015: Correctly classify main file includes if there is a prefix added.

Instead modify IncludeInserter to classify correctly.

Jan 4 2017, 4:00 PM

Oct 26 2016

jbangert retitled D26015: Correctly classify main file includes if there is a prefix added from to Don't include the same file twice in IncludeInserter, even if misclassified..
Oct 26 2016, 3:24 PM

Oct 14 2016

jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 14 2016, 1:26 PM · Restricted Project

Oct 11 2016

jbangert added a comment to D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.

Thanks for the review!

Oct 11 2016, 5:03 PM · Restricted Project
jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 11 2016, 5:02 PM · Restricted Project

Oct 10 2016

jbangert updated the diff for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser.
Oct 10 2016, 4:53 PM · Restricted Project

Oct 3 2016

jbangert added a reviewer for D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser: hokein.
Oct 3 2016, 3:20 PM · Restricted Project

Sep 27 2016

jbangert retitled D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser from to [ClangTidy] Add UsingInserter and NamespaceAliaser.
Sep 27 2016, 6:29 PM · Restricted Project