Page MenuHomePhabricator

imaihal (Haruki Imai)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2020, 10:42 PM (32 w, 1 d)

Recent Activity

Tue, Nov 17

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

@rriddle Thanks for reviewing many times! I don't have commit access. Could you commit this patch if you don't have any other comments?

Tue, Nov 17, 1:13 AM · Restricted Project, Restricted Project

Sun, Nov 15

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Hi, @rriddle, do you have any comments on this patch?

Sun, Nov 15, 10:15 PM · Restricted Project, Restricted Project

Tue, Nov 10

imaihal added a comment to D88719: [mlir] Normalize the results of normalizable operations.

Looks good. Please address the remaining minor comments.

Tue, Nov 10, 10:22 PM · Restricted Project
imaihal added inline comments to D88719: [mlir] Normalize the results of normalizable operations.
Tue, Nov 10, 10:04 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Rebased and reflected comments.

Tue, Nov 10, 10:00 PM · Restricted Project

Sun, Nov 1

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Can you try Eli's suggestion in this patch?

Sun, Nov 1, 6:42 PM · Restricted Project, Restricted Project

Sat, Oct 31

imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Sat, Oct 31, 9:00 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Updated comments and inserted assert.

Sat, Oct 31, 8:49 AM · Restricted Project, Restricted Project

Fri, Oct 30

imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Use ulittle for eidian conversion.

Fri, Oct 30, 10:10 AM · Restricted Project, Restricted Project

Wed, Oct 28

imaihal added inline comments to D88719: [mlir] Normalize the results of normalizable operations.
Wed, Oct 28, 8:38 AM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Reflected the comment.

Wed, Oct 28, 8:35 AM · Restricted Project

Tue, Oct 27

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@rriddle Thanks for your review. I don't have commit access. If you don't have other comments, could you commit this patch?

Tue, Oct 27, 9:03 PM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Tue, Oct 27, 8:57 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Avoid warning message.

Tue, Oct 27, 8:16 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Avoid warning in assert().

Tue, Oct 27, 7:45 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Rebased.

Tue, Oct 27, 8:56 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflect comments.

Tue, Oct 27, 7:44 AM · Restricted Project, Restricted Project

Mon, Oct 26

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@rriddle Thanks for your comments. I answered some of the comments.

Mon, Oct 26, 6:58 PM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Mon, Oct 26, 7:49 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflected comments and rebased.

Mon, Oct 26, 7:41 AM · Restricted Project, Restricted Project

Oct 20 2020

imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 11:18 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Removed unnecessary headers.

Oct 20 2020, 11:13 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Moved the convEndianBE into DenseIntOrFPElementsAttr class and removed EndianUtilities.

Oct 20 2020, 10:48 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 7:00 AM · Restricted Project, Restricted Project
imaihal retitled D80695: [mlir] Convert raw data in dense element attributes for big-endian machines. from [mlir] Convert raw data in dense element attributes into big-endian format. to [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 6:48 AM · Restricted Project, Restricted Project
imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@mehdi_amini Thanks for your review! I reflected all of your comments.

Oct 20 2020, 6:30 AM · Restricted Project, Restricted Project
imaihal added inline comments to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
Oct 20 2020, 6:29 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Reflected @mehdi_amini's comments.

Oct 20 2020, 6:21 AM · Restricted Project, Restricted Project

Oct 19 2020

imaihal retitled D80695: [mlir] Convert raw data in dense element attributes for big-endian machines. from [mlir] Added big endian version of "dense-elements-hex.mlir" to [mlir] Convert raw data in dense element attributes into big-endian format..
Oct 19 2020, 8:54 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Implemented the conversion from LE to BE in AttributeParser and from BE to LE in AsmPrinter
, assuming that HEX in dense.attr is always LE.

Oct 19 2020, 8:52 AM · Restricted Project, Restricted Project

Oct 5 2020

imaihal added a comment to D88719: [mlir] Normalize the results of normalizable operations.

@bondhugula @avarmapml Thanks for your comments! I updated the code to reflect your comments. I moved part of code in the lambda to Util.cpp. Could you review again?

Oct 5 2020, 5:46 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Rebased and fixed a comment.

Oct 5 2020, 5:42 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Updated test case to include two operation results.

Oct 5 2020, 9:09 AM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Reflected comments and rebased.

Oct 5 2020, 12:13 AM · Restricted Project

Oct 2 2020

imaihal updated subscribers of D88719: [mlir] Normalize the results of normalizable operations.

@bondhugula @avarmapml I found the results(returend memref) of normalizable operation were not normalized by --normalize-memrefs.
In test case, %1 was not normalized. This patch fixes it.
%1 = "test.op_norm_ret"(%arg0, %arg1) : (memref<1x32768xf32>, memref<1x16x14x14xf32, #map1>) -> (memref<1x16x14x14xf32, #map1>)

Oct 2 2020, 2:23 PM · Restricted Project
imaihal updated the diff for D88719: [mlir] Normalize the results of normalizable operations.

Fix to remove warning message (newOp -> *newOp)

Oct 2 2020, 1:19 AM · Restricted Project
imaihal requested review of D88719: [mlir] Normalize the results of normalizable operations.
Oct 2 2020, 12:35 AM · Restricted Project

Sep 25 2020

imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Rebased

Sep 25 2020, 12:48 AM · Restricted Project, Restricted Project

Sep 23 2020

imaihal added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

@bondhugula It seems there is no additional comments. Could you commit also this patch?

Sep 23 2020, 7:06 PM · Restricted Project, Restricted Project
imaihal added a comment to D88156: [mlir] Normalize memrefs in LoadOp and StoreOp of Standard Ops.

@AlexEichenberger

glad to see that the traits make such changes easy...

Yes. The traits are very useful. We might need to add them in other ops depending on use-case, but it is easy.

Sep 23 2020, 7:04 PM · Restricted Project
imaihal updated the diff for D88156: [mlir] Normalize memrefs in LoadOp and StoreOp of Standard Ops.

Reflected the comment about map, and rebased

Sep 23 2020, 6:16 PM · Restricted Project
imaihal updated subscribers of D88156: [mlir] Normalize memrefs in LoadOp and StoreOp of Standard Ops.

When we use load and store ops like the test in this patch, the --normalize-memrefs does not work. This patch fix it by adding MemRefsNormalizable trait in load and store ops.
If we can use affine.load and affine.store in this test, the normalization works, but sometimes affine.load can not be used. In the case, we need to use std.load.

Sep 23 2020, 8:50 AM · Restricted Project
imaihal requested review of D88156: [mlir] Normalize memrefs in LoadOp and StoreOp of Standard Ops.
Sep 23 2020, 8:25 AM · Restricted Project

Sep 22 2020

imaihal added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

@bondhugula @AlexEichenberger @avarmapml Do you have any other comments?

Sep 22 2020, 5:44 PM · Restricted Project, Restricted Project

Sep 18 2020

imaihal added inline comments to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Sep 18 2020, 3:31 PM · Restricted Project, Restricted Project

Sep 17 2020

imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Updated comments and rename test func

Sep 17 2020, 8:11 AM · Restricted Project, Restricted Project
imaihal added inline comments to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Sep 17 2020, 7:29 AM · Restricted Project, Restricted Project

Sep 16 2020

imaihal added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Sep 16 2020, 11:52 PM · Restricted Project, Restricted Project
imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Fixed comments and format

Sep 16 2020, 11:50 PM · Restricted Project, Restricted Project
imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Rebased

Sep 16 2020, 11:36 PM · Restricted Project, Restricted Project
imaihal added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Sorry, I may did wrong operaton... I will fix this.

Sep 16 2020, 11:35 PM · Restricted Project, Restricted Project
imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Rebased and rephrased the comment.

Sep 16 2020, 11:34 PM · Restricted Project, Restricted Project
imaihal added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

@bondhugula @avarmapml Thanks for your comments! I added test and comments, and renamed the variables to reflect @bondhugula 's comments.

Sep 16 2020, 11:04 PM · Restricted Project, Restricted Project
imaihal updated the diff for D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Added test and comments, and renamee variables to reflrect comments

Sep 16 2020, 10:59 PM · Restricted Project, Restricted Project
imaihal updated subscribers of D87746: [mlir] Fix of updating function signature in normalizing memrefs.

This bug was discussed here https://llvm.discourse.group/t/memrefs-and-maps-for-tiling/1279/21
Following example failed because spv.EntryPoint "GLCompute" @empty can't be casted to CallOp. I created the example to reproduce errors happened in my code which uses EntryPoint op of my own dialect. This example may not be practical, but this reproduced the same error with my code.

Sep 16 2020, 1:06 AM · Restricted Project, Restricted Project
imaihal requested review of D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Sep 16 2020, 12:53 AM · Restricted Project, Restricted Project

Sep 14 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

I thought native byte order should be written in dense.attr.

Well that's my point all along: let's not do that and make the serialization/deserialization cross-platform.

Sep 14 2020, 5:48 PM · Restricted Project, Restricted Project

Sep 10 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

I don't understand what you're referring to right now: can you elaborate how a user would write the hex in BE?
I expect a users to form the data in memory in BE on a BE machine, and then the printer will print in LE form always.

Sep 10 2020, 1:03 AM · Restricted Project, Restricted Project

Sep 8 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

If we can assume the hex data is always little-endian, it can be converted here, but we can't assume that.

Why? We control the printer and parser, don't we?

Sep 8 2020, 9:38 PM · Restricted Project, Restricted Project
imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Thanks. I checked the source code. The dense attribute with hex data is parsed here https://github.com/llvm/llvm-project/blob/master/mlir/lib/Parser/AttributeParser.cpp#L682-L684
If we can assume the hex data is always little-endian, it can be converted here, but we can't assume that. So, my understanding is that the hex data of dense-elements-hex.mlir should be generated depending on the endianness. Is this possible? I'm looking for similar examples.

Sep 8 2020, 6:09 PM · Restricted Project, Restricted Project

Sep 6 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Could the HEX dump be made independent of the platform? Having the printed format dumped on a BE loadable on a LE and vice-versa would be nicer I think.

Sep 6 2020, 6:04 PM · Restricted Project, Restricted Project

Aug 31 2020

imaihal updated subscribers of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Hi, I'm looking for reviewers for this patch. This patch is old. So, I need to update, but I would like to hear your comments about how we should pass this test on big-endian machines. Since current test includes HEX of little endian, this test fails on big-endian machines.
@jpienaar, @ftynse, @mehdi_amini, @rriddle @Smit You were reviewers for patches including this test before. Could you give me your comments?

Aug 31 2020, 7:14 PM · Restricted Project, Restricted Project

Jul 21 2020

imaihal added inline comments to D83656: [mlir] Set alignment in AllocOp of normalizeMemref().
Jul 21 2020, 11:15 PM · Restricted Project

Jul 19 2020

imaihal added a comment to D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

@bondhugula Thanks for your review! I reflected your comments.
I think I don't have right to land this patch. Could you land this if you don't have additional comments?

Jul 19 2020, 5:57 PM · Restricted Project

Jul 14 2020

imaihal updated the diff for D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Rebase

Jul 14 2020, 9:24 PM · Restricted Project
imaihal updated the diff for D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Rebase again

Jul 14 2020, 7:23 PM · Restricted Project
imaihal updated the diff for D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Rebase

Jul 14 2020, 6:31 PM · Restricted Project
imaihal updated the diff for D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Change CHECK to CHECK-NEXT

Jul 14 2020, 6:05 PM · Restricted Project
imaihal added inline comments to D83656: [mlir] Set alignment in AllocOp of normalizeMemref().
Jul 14 2020, 5:27 PM · Restricted Project
imaihal added a comment to D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Thanks for your comments! I updated.

Jul 14 2020, 1:07 AM · Restricted Project
imaihal updated the diff for D83656: [mlir] Set alignment in AllocOp of normalizeMemref().

Remove redundant code

Jul 14 2020, 1:03 AM · Restricted Project

Jul 13 2020

imaihal updated the summary of D83656: [mlir] Set alignment in AllocOp of normalizeMemref().
Jul 13 2020, 5:31 PM · Restricted Project
imaihal updated the summary of D83656: [mlir] Set alignment in AllocOp of normalizeMemref().
Jul 13 2020, 5:29 PM · Restricted Project

Jul 12 2020

Herald added a project to D83656: [mlir] Set alignment in AllocOp of normalizeMemref(): Restricted Project.
Jul 12 2020, 11:57 PM · Restricted Project

Jun 29 2020

imaihal added a comment to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

@rriddle Hi, is it possible to give me your comments about this patch? I'm asking because you were a reviewer of the previous patch including this file.

Jun 29 2020, 8:24 PM · Restricted Project, Restricted Project

Jun 10 2020

imaihal added a comment to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

In general, I'd like to strongly discourage directly checking endian::system_endianness(), in favor of using the endian-sensitive read/write helpers from llvm/Support/Endian.h. For example, you can copy_n from an endian::ulittle64_t* to a uint64_t*. Using a distinct codepath for big-endian means more code, and that code gets less testing.

Thanks for the comments Eli! Didn't know about those. Will recommend the same in the future.

Jun 10 2020, 7:57 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Reflect reviewer's comments.

Jun 10 2020, 7:25 PM · Restricted Project, Restricted Project
imaihal added inline comments to D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
Jun 10 2020, 7:25 PM · Restricted Project, Restricted Project

Jun 2 2020

Herald added a project to D80695: [mlir] Convert raw data in dense element attributes for big-endian machines.: Restricted Project.

Could anyone be a reviewer of this patch? This patch is about one of the MLIR test (dense-elements-hex.mlir).

Jun 2 2020, 6:07 PM · Restricted Project, Restricted Project

May 28 2020

imaihal updated the summary of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
May 28 2020, 10:27 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
May 28 2020, 10:27 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
May 28 2020, 10:27 PM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Rebased with master

May 28 2020, 7:34 AM · Restricted Project, Restricted Project
imaihal updated the diff for D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..

Fixed "No newline at end of file"

May 28 2020, 1:02 AM · Restricted Project, Restricted Project
imaihal created D80695: [mlir] Convert raw data in dense element attributes for big-endian machines..
May 28 2020, 12:30 AM · Restricted Project, Restricted Project

May 26 2020

imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
May 26 2020, 10:18 PM · Restricted Project, Restricted Project

May 20 2020

imaihal updated the diff for D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).

Fixed variable name to meet camelBack style

May 20 2020, 7:53 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
May 20 2020, 7:53 PM · Restricted Project, Restricted Project
imaihal updated the summary of D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
May 20 2020, 7:53 PM · Restricted Project, Restricted Project

May 19 2020

imaihal created D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word).
May 19 2020, 11:57 PM · Restricted Project, Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

@ftynse and @mehdi_amini, Could you help to commit this if this patch ready for commit? I don't have write access to the repository.

May 19 2020, 7:16 PM · Restricted Project
imaihal added inline comments to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
May 19 2020, 6:13 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Changed getHostCPUName() part to reflect the comment.

May 19 2020, 6:11 PM · Restricted Project

May 18 2020

imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

My wrong operation(submission) may add LLDB tag on this patch.

May 18 2020, 8:04 PM · Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Thanks for the review! I changed the variable name to camelBack

May 18 2020, 8:04 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
  • [NFC] Replace MaybeAlign with Align in TargetTransformInfo.
  • [mlir][SystemZ] Fix incompatible datalayout in SystemZ
May 18 2020, 8:04 PM · Restricted Project
imaihal updated the diff for D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

[mlir][SystemZ] Fix incompatible datalayout in SystemZ

May 18 2020, 7:32 PM · Restricted Project
imaihal added a comment to D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.

Without this patch, following tests fail in SystemZ(z14)

MLIR :: mlir-cpu-runner/linalg_integration_test.mlir
MLIR :: mlir-cpu-runner/sgemm_naive_codegen.mlir
MLIR :: mlir-cpu-runner/simple.mlir
MLIR :: mlir-cpu-runner/unranked_memref.mlir
MLIR :: mlir-cpu-runner/utils.mlir

Error message is as follows.

Failure value returned from cantFail wrapped call
Added modules have incompatible data layouts: E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-a:8:16-n32:64 (module) vs E-m:e-i1:8:16-i8:8:16-i64:6\
4-f128:64-v128:64-a:8:16-n32:64 (jit)
May 18 2020, 9:07 AM · Restricted Project
imaihal created D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ.
May 18 2020, 9:07 AM · Restricted Project

Apr 30 2020

imaihal added a comment to D78076: [mlir] Support big endian in DenseElementsAttr.

@rriddle Is this patch ready for commit? If so, could you help to commit this? I think I don't have write access to the repository.

Apr 30 2020, 6:07 PM · Restricted Project