One last kind ping

Ping

Address rsmith's comments.

Kind ping

Implemented @riccibruno's and @rsmith's comments.
While I agree with the general notion about the flaws with the current implementation, I feel that the more major refactoring proposed in this review is out of the scope of this minor fix.

1. Refactor CheckArrayAccess() to take AllowPastTheEnd parameter to avoid a false positive array out-of-bounds warning for &(cond ? arr1[N] : arr2[N]).
2. Use IgnoreParenCasts() instead of IgnoreParenImpCasts() in CheckArrayAccess() to avoid false negatives when explicit cast is involved.

In D71714#1791464, @riccibruno wrote:

These are not the only AST nodes representing cast expressions (there is also CXXFunctionalCastExpr, ...). What about replacing the IgnoreParenImpCasts() above by IgnoreParenCasts() ? Incidentally doing this uncovers another test (Parser/cxx-ambig-decl-expr.cpp ) where this diagnostic is triggered.

Doxygen format the documentation.

@aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't have commit access?

Update LexerUtils.h documentation.

Fix documentation in LexerUtils.h

I think this would likely make everything much more complicated, but perhaps we should think about this for the configuration at least now so we future proof ourselves.

In D69764#1775842, @MyDeveloperDay wrote:

In D69764#1775835, @ilya wrote:

In D69764#1732235, @aaron.ballman wrote:

I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood.

Also, should this apply to other qualifiers like volatile or restrict? If so, the name ConstStyle should probably be CVQualifierStyle or something else.

+1.
In addition to volatile and restrict, in my organization we'd also be interested in applying this to address space qualifiers (custom keywords added in our downstream fork). Can this be generalized to accept a map of qualifier keywords and its desired orientation?

Could you give me an example of what you mean?

In D69764#1732235, @aaron.ballman wrote:

I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood.

Also, should this apply to other qualifiers like volatile or restrict? If so, the name ConstStyle should probably be CVQualifierStyle or something else.