- User Since
- Nov 26 2019, 8:48 AM (66 w, 4 d)
Mar 13 2020
One last kind ping
Feb 17 2020
Jan 21 2020
Jan 14 2020
Address rsmith's comments.
Jan 6 2020
Dec 23 2019
Implemented @riccibruno's and @rsmith's comments.
While I agree with the general notion about the flaws with the current implementation, I feel that the more major refactoring proposed in this review is out of the scope of this minor fix.
- Refactor CheckArrayAccess() to take AllowPastTheEnd parameter to avoid a false positive array out-of-bounds warning for &(cond ? arr1[N] : arr2[N]).
- Use IgnoreParenCasts() instead of IgnoreParenImpCasts() in CheckArrayAccess() to avoid false negatives when explicit cast is involved.
Doxygen format the documentation.
@aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't have commit access?
Update LexerUtils.h documentation.
Dec 19 2019
Dec 18 2019
Fix documentation in LexerUtils.h
Dec 10 2019
I think this would likely make everything much more complicated, but perhaps we should think about this for the configuration at least now so we future proof ourselves.