Page MenuHomePhabricator

ilya-golovenko (Ilya Golovenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Jul 16, 4:29 AM (2 w, 6 d)

Recent Activity

Today

ilya-golovenko added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

I agree the fix is not correct. I will check how it currently works with clangd built from master branch.

Wed, Aug 5, 7:56 AM · Restricted Project

Yesterday

ilya-golovenko updated the summary of D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..
Tue, Aug 4, 3:39 PM · Restricted Project
ilya-golovenko added reviewers for D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.: kadircet, sammccall.

I'm not quite sure my fix is the best way to fix the issue, so any advices are appreciated.

Tue, Aug 4, 3:38 PM · Restricted Project
ilya-golovenko requested review of D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..
Tue, Aug 4, 3:35 PM · Restricted Project

Sat, Aug 1

ilya-golovenko added a comment to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

thanks, lgtm!

let me know if i should land this for you

Sat, Aug 1, 1:21 PM · Restricted Project

Fri, Jul 31

ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Simplify logic in traverseDecl method

Fri, Jul 31, 9:02 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Remove invalid comment

Fri, Jul 31, 5:14 AM · Restricted Project
ilya-golovenko added a comment to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

@kadircet I decided to add OnlyChildren to enum VisitKind instead of making a VisitKindSet - this helped to minimize the changes in shouldVisit(). What do you think?

Fri, Jul 31, 5:13 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Changes afte code review, add test for export context

Fri, Jul 31, 5:11 AM · Restricted Project

Wed, Jul 29

ilya-golovenko added inline comments to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Wed, Jul 29, 7:07 AM · Restricted Project
ilya-golovenko updated the diff for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

Trigger new build

Wed, Jul 29, 5:57 AM · Restricted Project
ilya-golovenko added reviewers for D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".: kadircet, sammccall.
Wed, Jul 29, 5:42 AM · Restricted Project
ilya-golovenko requested review of D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Wed, Jul 29, 5:41 AM · Restricted Project

Wed, Jul 22

ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account...
By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

Not that I'm aware of :( I have way too many accounts myself, I'd be interested in that, too. I think not having your email associated with it anymore would be good.

Hopefully, reviews move to GitHub at some point and this will not be necessary.

Wed, Jul 22, 4:47 AM · Restricted Project
ilya-golovenko updated subscribers of D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account...
By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?

Wed, Jul 22, 4:12 AM · Restricted Project
ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

@sammccall sorry for bothering you, could you please land this for me?

Wed, Jul 22, 2:33 AM · Restricted Project

Mon, Jul 20

ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Thanks! Do you have commit access, or should I land this for you?

Mon, Jul 20, 9:16 PM · Restricted Project
ilya-golovenko added a comment to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Thanks for doing this! And sorry about the shaky windows support...

(There are potentially other lurking issues due to filenames being used as keys internally, particularly case-insensitivity issues...)

Mon, Jul 20, 9:11 AM · Restricted Project
ilya-golovenko added inline comments to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..
Mon, Jul 20, 9:06 AM · Restricted Project
ilya-golovenko updated the diff for D84172: [clangd] Fix conversion from Windows UNC paths to file URI format..

Address code review comments.

Mon, Jul 20, 9:05 AM · Restricted Project
ilya-golovenko added reviewers for D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.: sammccall, kadircet.
Mon, Jul 20, 7:35 AM · Restricted Project
Herald added a project to D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.: Restricted Project.
Mon, Jul 20, 7:31 AM · Restricted Project
ilya-golovenko abandoned D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Mon, Jul 20, 7:12 AM · Restricted Project, Restricted Project
ilya-golovenko updated the diff for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

Consistent naming: hasDriveLetter => isWindowsPath

Mon, Jul 20, 7:11 AM · Restricted Project, Restricted Project
ilya-golovenko removed a reviewer for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.: walrus.
Mon, Jul 20, 6:57 AM · Restricted Project, Restricted Project
ilya-golovenko commandeered D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Mon, Jul 20, 6:55 AM · Restricted Project, Restricted Project
ilya-golovenko updated the diff for D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

Consistent naming: Name => Path

Mon, Jul 20, 6:34 AM · Restricted Project, Restricted Project
ilya-golovenko updated the summary of D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..
Mon, Jul 20, 5:16 AM · Restricted Project, Restricted Project
ilya-golovenko added a comment to D84150: [clangd] Fix conversion from Windows UNC paths to file URI format..

This is an attempt to improve handling of Windows UNC paths in clangd. Any feedback is appreciated.

Mon, Jul 20, 5:11 AM · Restricted Project, Restricted Project
ilya-golovenko added a project to D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.: Restricted Project.
Mon, Jul 20, 5:09 AM · Restricted Project, Restricted Project