Page MenuHomePhabricator

iajbar (Ikhlas Ajbar)
User

Projects

User does not belong to any projects.

User Details

User Since
May 6 2015, 7:43 PM (289 w, 5 d)

Recent Activity

Oct 23 2020

iajbar added a comment to D66492: [Clang][CodeGen] set alias linkage on QualType.

Clang crashes when calling getLLVMLinkageVarDefinition() in EmitAliasDefinition() when compiling this testcase:
enum a_type { a , b, c};
typedef enum a_type b_type;
void foo(b_type x, enum a_type y){}
void bar(b_type x, enum b_type y) attribute ((alias ("foo")));

Oct 23 2020, 11:39 AM · Restricted Project, Restricted Project

Jul 28 2020

iajbar committed rGd50d4c3d440c: [Hexagon] Correct the order of operands when lowering funnel shift-left (authored by iajbar).
[Hexagon] Correct the order of operands when lowering funnel shift-left
Jul 28 2020, 7:24 PM

Jun 24 2020

iajbar committed rG085701b8b008: [Hexagon] Reducing minimum alignment requirement (authored by iajbar).
[Hexagon] Reducing minimum alignment requirement
Jun 24 2020, 8:38 AM

Apr 3 2018

iajbar added a comment to D44880: [Hexagon] peel loops with runtime small trip counts.

I committed this patch with canPeel() check before setting PeelCount in Hexagon Target. Thank you very much Max for your Review.

Apr 3 2018, 4:02 PM
iajbar committed rL329129: [Hexagon] peel loops with runtime small trip counts.
[Hexagon] peel loops with runtime small trip counts
Apr 3 2018, 3:58 PM

Apr 2 2018

iajbar committed rL329042: peel loops with runtime small trip counts.
peel loops with runtime small trip counts
Apr 2 2018, 8:45 PM
iajbar added a comment to D44919: [LoopUnroll][NFC] Remove redundant canPeel check.

Thank you very much Max for your review. It is very much appreciated.

Apr 2 2018, 8:07 PM
iajbar added a comment to D44880: [Hexagon] peel loops with runtime small trip counts.

Thank you very much Max for your review. I tried to zero UP.PeelCount before every return from computeUnrollCount that stands before computePeelCount and it causes test/Transforms/LoopUnroll/pr33437.ll to fail. This test expects to peel a loop first and than unrolling it.

Apr 2 2018, 8:07 PM
iajbar added a comment to D44919: [LoopUnroll][NFC] Remove redundant canPeel check.

Maybe it passes for you because my patch was reverted. When I compile opt with your patch and my patch, I see the error
https://reviews.llvm.org/D44919
https://reviews.llvm.org/D44880

Apr 2 2018, 5:02 AM

Mar 30 2018

iajbar reopened D44919: [LoopUnroll][NFC] Remove redundant canPeel check.

Hello Max, This assert(canPeel(L)) causes several tests to fail when I set PeelCount in Hexagon target. Apparently there is another path that is taken that calls peelLoop() and does not go through computePeelCount(). So it looks like the second check for canPeel in needed. Here is a test case: opt -march=hexagon -O3 -S < test.ll

  • test.ll ---

target datalayout = "e-m:e-p:32:32:32-a:0-n16:32-i64:64:64-i32:32:32-i16:16:16-i1:8:8-f32:32:32-f64:64:64-v32:32:32-v64:64:64-v512:512:512-v1024:1024:1024-v2048:2048:2048"
target triple = "hexagon"

Mar 30 2018, 12:04 PM

Mar 29 2018

iajbar committed rL328855: [Hexagon] add missing lit config file.
[Hexagon] add missing lit config file
Mar 29 2018, 8:35 PM
iajbar committed rL328854: peel loops with runtime small trip counts.
peel loops with runtime small trip counts
Mar 29 2018, 8:08 PM
iajbar closed D44880: [Hexagon] peel loops with runtime small trip counts.
Mar 29 2018, 8:08 PM

Mar 28 2018

iajbar added inline comments to D44880: [Hexagon] peel loops with runtime small trip counts.
Mar 28 2018, 10:07 AM
iajbar updated the diff for D44880: [Hexagon] peel loops with runtime small trip counts.

Thanks Max. Please note that this patch also fixes a bug as well. Without this patch, the value passed by the flag -unroll-peel-count was ignored.

Mar 28 2018, 10:06 AM

Mar 27 2018

iajbar updated the diff for D44880: [Hexagon] peel loops with runtime small trip counts.

I addressed the comments from Max and Florian.

Mar 27 2018, 7:29 AM

Mar 26 2018

iajbar added inline comments to D44880: [Hexagon] peel loops with runtime small trip counts.
Mar 26 2018, 9:04 PM
iajbar updated the diff for D44880: [Hexagon] peel loops with runtime small trip counts.
Mar 26 2018, 8:59 PM

Mar 25 2018

iajbar added reviewers for D44880: [Hexagon] peel loops with runtime small trip counts: mkazantsev, sanjoy.
Mar 25 2018, 12:05 PM
iajbar created D44880: [Hexagon] peel loops with runtime small trip counts.
Mar 25 2018, 11:59 AM

May 19 2015

iajbar closed D9547: Factor out Hexagon code to build args..
May 19 2015, 11:30 AM
iajbar closed D9710: Factor out SmallDataThreshold.
May 19 2015, 11:29 AM
iajbar closed D9775: Remove unused function HasPICArg()..
May 19 2015, 11:29 AM

May 14 2015

iajbar committed rL237374: Remove unused function HasPICArg()..
Remove unused function HasPICArg().
May 14 2015, 10:45 AM
iajbar retitled D9775: Remove unused function HasPICArg(). from to Remove unused function HasPICArg()..
May 14 2015, 10:24 AM
iajbar committed rL237364: Factor out SmallDataThreshold.
Factor out SmallDataThreshold
May 14 2015, 6:55 AM

May 13 2015

iajbar updated the diff for D9710: Factor out SmallDataThreshold.
May 13 2015, 1:27 PM

May 12 2015

iajbar abandoned D9640: Factor out SmallDataThreshold..
May 12 2015, 4:30 PM
iajbar updated the diff for D9640: Factor out SmallDataThreshold..
May 12 2015, 4:29 PM
iajbar accepted D9713: [Hexagon] Check for underflow/wrap in hardware loop pass.
May 12 2015, 4:02 PM
iajbar accepted D9722: [Hexagon] Generate hardware loop for a vectorized loop.
May 12 2015, 3:27 PM
iajbar accepted D9720: [Hexagon] Remove dead constant assignment in hardware loop pass.
May 12 2015, 2:51 PM
iajbar accepted D9678: [Hexagon] Generate hardware loop when loop has a critical edge.
May 12 2015, 2:46 PM
iajbar added a reviewer for D9710: Factor out SmallDataThreshold: apazos.
May 12 2015, 10:39 AM
iajbar added a reviewer for D9710: Factor out SmallDataThreshold: hiraditya.
May 12 2015, 10:30 AM
iajbar retitled D9710: Factor out SmallDataThreshold from to Factor out SmallDataThreshold.
May 12 2015, 10:30 AM
iajbar accepted D9680: [Hexagon] Generate loop1 instruction for nested loops.
May 12 2015, 5:42 AM

May 11 2015

iajbar added a reviewer for D9640: Factor out SmallDataThreshold.: hiraditya.
May 11 2015, 2:49 PM

May 9 2015

iajbar added reviewers for D9640: Factor out SmallDataThreshold.: sundeepk, apazos.
May 9 2015, 1:09 PM
iajbar retitled D9640: Factor out SmallDataThreshold. from to Factor out SmallDataThreshold..
May 9 2015, 12:49 PM

May 8 2015

iajbar committed rL236926: Factor out Hexagon code to build args..
Factor out Hexagon code to build args.
May 8 2015, 7:16 PM

May 7 2015

iajbar accepted D9568: [Hexagon] Generate more hardware loops.
May 7 2015, 2:36 PM
iajbar updated the diff for D9547: Factor out Hexagon code to build args..
May 7 2015, 1:33 PM

May 6 2015

iajbar retitled D9547: Factor out Hexagon code to build args. from to Factor out Hexagon code to build args..
May 6 2015, 8:32 PM