Page MenuHomePhabricator

haowei (Haowei Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2017, 3:05 PM (192 w, 13 h)

Recent Activity

Today

haowei added inline comments to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Wed, Jan 20, 1:23 AM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Wed, Jan 20, 1:21 AM · Restricted Project

Yesterday

haowei added inline comments to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Tue, Jan 19, 6:11 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Tue, Jan 19, 6:09 PM · Restricted Project

Fri, Jan 15

haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

For the case to test error message when sh_size % sh_entsize is not 0, I didn't find any good examples that I can manipulate the sh_entsize through yaml2obj. Do you have good suggestions to write unit tests for these cases?

Can you elaborate what the problem is? There are many examples in both yaml2obj and llvm-readelf test suites that are using the EntSize key to set the sh_entsize.

Fri, Jan 15, 6:31 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Fri, Jan 15, 6:29 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Fri, Jan 15, 6:03 PM · Restricted Project

Thu, Jan 14

haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

Is it important that the .dynsym is used directly when .hash/.gnu.hash is available? At the moment, your test doesn't really show whether it is used or whether you go straight to the dynamic tags for details, I believe - to do that, you'd need to have one given bogus values for the size, and show that this is not sued. Additionally, you have no testing for your error messages, nor do you have testing that shows that the .gnu.hash is used above the .hash section.

Thu, Jan 14, 4:59 PM · Restricted Project
haowei added inline comments to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Thu, Jan 14, 12:11 AM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Thu, Jan 14, 12:10 AM · Restricted Project

Wed, Jan 13

haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

I rebased the code, it seems upset the Phabricator since it does not distinguish between rebase changes and actual changes.

What do you mean it seems upset? The review here looks fine to me.

If I compare Diff 2 and Diff 3 in Phabricator, the result looks weird as rebase changes were included.

Wed, Jan 13, 10:15 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Wed, Jan 13, 9:59 PM · Restricted Project

Tue, Jan 12

haowei added inline comments to D94461: [llvm-ifs] Add option to use InterfaceStub library.
Tue, Jan 12, 4:09 PM · Restricted Project
haowei updated the diff for D94461: [llvm-ifs] Add option to use InterfaceStub library.

fix some code style issues.

Tue, Jan 12, 4:06 PM · Restricted Project
haowei updated the diff for D94461: [llvm-ifs] Add option to use InterfaceStub library.
Tue, Jan 12, 3:59 PM · Restricted Project

Mon, Jan 11

haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

I rebased the code, it seems upset the Phabricator since it does not distinguish between rebase changes and actual changes.

Mon, Jan 11, 10:37 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Mon, Jan 11, 10:26 PM · Restricted Project
haowei requested review of D94461: [llvm-ifs] Add option to use InterfaceStub library.
Mon, Jan 11, 5:35 PM · Restricted Project

Wed, Jan 6

haowei committed rG8deaec122ec6: [analyzer] Update Fuchsia checker to catch releasing unowned handles. (authored by Daniel Hwang <arkay@google.com>).
[analyzer] Update Fuchsia checker to catch releasing unowned handles.
Wed, Jan 6, 4:24 PM
haowei closed D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles..
Wed, Jan 6, 4:24 PM · Restricted Project
haowei accepted D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles..
Wed, Jan 6, 11:28 AM · Restricted Project

Tue, Jan 5

haowei added inline comments to D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles..
Tue, Jan 5, 7:38 PM · Restricted Project
haowei abandoned D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:53 PM
haowei abandoned D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:53 PM
haowei abandoned D36024: [analyzer] Improved bug reporting in MagentaHandleChecker.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:52 PM
haowei abandoned D36023: [analyzer] Add array support for MagentaHandleChecker.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:52 PM
haowei abandoned D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:51 PM
haowei abandoned D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel.

An updated version was landed in f4c26d993bdc . This diff is no longer needed.

Tue, Jan 5, 3:50 PM
haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

friendly ping.

Tue, Jan 5, 3:43 PM · Restricted Project

Tue, Dec 29

haowei committed rGa1d058926686: [llvm-elfabi] Add flag to preserve timestamp when output is the same (authored by haowei).
[llvm-elfabi] Add flag to preserve timestamp when output is the same
Tue, Dec 29, 8:32 PM
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

fix test on mac

Tue, Dec 29, 8:29 PM · Restricted Project
haowei added a comment to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Looks like this breaks tests on mac: http://45.33.8.238/macm1/897/step_10.txt

Please take a look, and revert for now if it takes a while to fix.

Change was reverted. Looks like touch on bsd behaves differently from the gnu one.

Tue, Dec 29, 5:30 PM · Restricted Project
haowei added a reverting change for rGfddb41744958: [llvm-elfabi] Add flag to preserve timestamp when output is the same: rGd034a94e7b3c: Revert "[llvm-elfabi] Add flag to preserve timestamp when output is the same".
Tue, Dec 29, 5:27 PM
haowei committed rGd034a94e7b3c: Revert "[llvm-elfabi] Add flag to preserve timestamp when output is the same" (authored by haowei).
Revert "[llvm-elfabi] Add flag to preserve timestamp when output is the same"
Tue, Dec 29, 5:27 PM
haowei added a reverting change for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same: rGd034a94e7b3c: Revert "[llvm-elfabi] Add flag to preserve timestamp when output is the same".
Tue, Dec 29, 5:27 PM · Restricted Project
haowei committed rGfddb41744958: [llvm-elfabi] Add flag to preserve timestamp when output is the same (authored by haowei).
[llvm-elfabi] Add flag to preserve timestamp when output is the same
Tue, Dec 29, 3:06 PM
haowei closed D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Tue, Dec 29, 3:05 PM · Restricted Project

Tue, Dec 22

haowei added a comment to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

--preserve-dates in this utility is different from --preserve-dates in GNU/LLVM objcopy, so I am a bit unsure this is the right name. In llvm-tblgen such an option is called --write-if-changed

Tue, Dec 22, 3:29 PM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Tue, Dec 22, 3:27 PM · Restricted Project

Mon, Dec 21

haowei added inline comments to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Mon, Dec 21, 11:34 AM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Mon, Dec 21, 11:30 AM · Restricted Project

Dec 18 2020

haowei added inline comments to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 18 2020, 9:52 PM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 18 2020, 9:51 PM · Restricted Project

Dec 17 2020

haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 17 2020, 4:19 PM · Restricted Project
haowei added a comment to D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.

What others said - there are six cases we should care about:

  1. Section headers are stripped and the ELF has no hash/gnu_hash dynamic tag - this can be treated as an error, I think since the ELF gABI requires a hash table.
  2. Section headers are stripped, but there is a DT_HASH
  3. Section headers are stripped, but there is a DT_GNU_HASH
  4. Section headers present but there is no .hash or .gnu.hash section - this might be treated as an error, I think since the ELF gABI requires a hash table.
  5. Section headers present with .hash section
  6. Section headers present with .gnu.hash section

I think all of the tools should handle all of these situations (llvm-readelf, llvm-objdump, llvm-elfabi, ...) so it definitely seems like this should be part of the Object library.

Dec 17 2020, 3:51 PM · Restricted Project
haowei updated the diff for D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Dec 17 2020, 3:26 PM · Restricted Project

Dec 16 2020

haowei committed rG8a3c41be94ca: [IR] Fixed the typo in attributes test (authored by gulfem).
[IR] Fixed the typo in attributes test
Dec 16 2020, 3:07 PM
haowei closed D93420: [IR] Fixed the typo in attributes test.
Dec 16 2020, 3:07 PM · Restricted Project

Dec 15 2020

haowei requested review of D93362: [llvm-elfabi] Support ELF file that lacks .gnu.hash section.
Dec 15 2020, 8:33 PM · Restricted Project

Dec 14 2020

haowei added inline comments to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 14 2020, 6:42 PM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 14 2020, 6:13 PM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 14 2020, 6:11 PM · Restricted Project
haowei committed rG7c0e3a77bc43: [clang][IR] Add support for leaf attribute (authored by gulfem).
[clang][IR] Add support for leaf attribute
Dec 14 2020, 2:49 PM
haowei closed D90275: [clang][IR] Add support for leaf attribute.
Dec 14 2020, 2:48 PM · Restricted Project, Restricted Project

Dec 11 2020

haowei added inline comments to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 11 2020, 12:12 AM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 11 2020, 12:08 AM · Restricted Project

Dec 10 2020

haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 10 2020, 11:43 PM · Restricted Project

Dec 9 2020

haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Add this feature to ELF Stub output as well.

Dec 9 2020, 8:59 PM · Restricted Project
haowei added inline comments to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 9 2020, 4:03 PM · Restricted Project
haowei updated the diff for D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Address review comments.

Dec 9 2020, 3:59 PM · Restricted Project

Dec 8 2020

haowei requested review of D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.
Dec 8 2020, 5:51 PM · Restricted Project

Dec 7 2020

haowei committed rG3ce78f54edcf: [analyzer] Ignore annotations if func is inlined. (authored by aabbaabb).
[analyzer] Ignore annotations if func is inlined.
Dec 7 2020, 11:28 AM
haowei closed D91902: [analyzer] Ignore annotations if func is inlined..
Dec 7 2020, 11:28 AM · Restricted Project

Dec 1 2020

haowei accepted D92444: [CMake][Fuchsia] Install llvm-elfabi.

LGTM

Dec 1 2020, 7:45 PM · Restricted Project

Nov 24 2020

haowei added a comment to D91223: Support struct annotations in FuchsiaHandleChecker..

@haowei https://llvm.org/docs/DeveloperPolicy.html#commit-messages Please use git commit --amend --author for future patches where the majority of the work is done by others.

Nov 24 2020, 5:17 PM · Restricted Project
haowei committed rG803745b945f4: [llvm-elfabi] Emit ELF .dynsym, .dynamic sections (authored by haowei).
[llvm-elfabi] Emit ELF .dynsym, .dynamic sections
Nov 24 2020, 12:17 AM
haowei closed D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections.
Nov 24 2020, 12:17 AM · Restricted Project

Nov 23 2020

haowei committed rGcf4330871844: [llvm-elfabi] Emit ELF header and string table sections (authored by haowei).
[llvm-elfabi] Emit ELF header and string table sections
Nov 23 2020, 12:19 PM
haowei added a reverting change for rG53c5fdd59a5c: [llvm-elfabi] Emit ELF header and string table sections: rGae736d295763: Revert "[llvm-elfabi] Emit ELF header and string table sections".
Nov 23 2020, 11:59 AM
haowei added a reverting change for D61767: [llvm-elfabi] Emit ELF header and string table section: rGae736d295763: Revert "[llvm-elfabi] Emit ELF header and string table sections".
Nov 23 2020, 11:59 AM · Restricted Project
haowei committed rGae736d295763: Revert "[llvm-elfabi] Emit ELF header and string table sections" (authored by haowei).
Revert "[llvm-elfabi] Emit ELF header and string table sections"
Nov 23 2020, 11:59 AM
haowei committed rG53c5fdd59a5c: [llvm-elfabi] Emit ELF header and string table sections (authored by haowei).
[llvm-elfabi] Emit ELF header and string table sections
Nov 23 2020, 11:35 AM
haowei closed D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 23 2020, 11:34 AM · Restricted Project

Nov 21 2020

haowei committed rG914f6c4ff8a4: [StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker (authored by haowei).
[StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker
Nov 21 2020, 8:03 PM
haowei closed D91223: Support struct annotations in FuchsiaHandleChecker..
Nov 21 2020, 8:02 PM · Restricted Project

Nov 19 2020

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 19 2020, 2:27 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 19 2020, 2:25 PM · Restricted Project
haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 19 2020, 1:55 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 19 2020, 1:48 PM · Restricted Project

Nov 18 2020

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 8:32 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 8:31 PM · Restricted Project
haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 4:34 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 4:29 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 3:49 PM · Restricted Project
haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 18 2020, 12:08 AM · Restricted Project

Nov 17 2020

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 17 2020, 8:39 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 17 2020, 8:35 PM · Restricted Project
haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 17 2020, 12:22 AM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 17 2020, 12:19 AM · Restricted Project

Nov 16 2020

haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 16 2020, 11:19 PM · Restricted Project

Nov 13 2020

haowei added a comment to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

I apologize for the late response, I somehow missed the earlier responses. We have successfully used this feature in Fuchsia and found it useful, but I agree that the issues raised need to be addressed. Unfortunately @paulkirth is no longer working on this project. I hope that someone from our team can take a look but it might take a few weeks. If you prefer, we could revert this change and then reland an improved version in the future?

I would very much prefer *NOT* not revert if someone is going to step up to work on these problems soon (within next 4 weeks?).

That being said, in light of that bug, my original doubts about the underlying data type (a novel MD_misexpect,
with structure different from MD_prof) have reappeared with double strength. I really think they should share underlying type.

I'll be posting a revert soon.

Nov 13 2020, 3:16 PM · Restricted Project, Restricted Project
haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 13 2020, 12:50 AM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 13 2020, 12:49 AM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 13 2020, 12:38 AM · Restricted Project

Nov 11 2020

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 11 2020, 2:16 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 11 2020, 2:14 PM · Restricted Project
haowei committed rGad0da312c05d: [NFC] Reformat llvm-elfabi (authored by haowei).
[NFC] Reformat llvm-elfabi
Nov 11 2020, 10:42 AM
haowei closed D90362: scan-build supprot relative 'file' in cdb..

Landed in https://github.com/llvm/llvm-project/commit/d93287cac89fd50a105ac4a59c079884b8e53e49

Nov 11 2020, 9:40 AM · Restricted Project

Nov 10 2020

haowei added inline comments to D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 10 2020, 9:02 PM · Restricted Project
haowei updated the diff for D61767: [llvm-elfabi] Emit ELF header and string table section.
Nov 10 2020, 9:00 PM · Restricted Project