Page MenuHomePhabricator

glaubitz (John Paul Adrian Glaubitz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2018, 2:05 AM (147 w, 4 d)

Recent Activity

Yesterday

glaubitz added a comment to D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting.

Not sure if this is related, but on SPARC, stage2 builds recently started to fail with:

Fri, Nov 27, 8:36 AM · Restricted Project

Wed, Nov 25

glaubitz added a comment to D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

Yeah, @hvdijk has made multiple other improvements which should finally allow the backend to be usable.

Wed, Nov 25, 1:48 AM · Restricted Project

Mon, Nov 23

glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Thanks so much! Would you mind pushing that change for me? I don't have commit access at the moment.

Mon, Nov 23, 4:24 PM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

I changed it to 4.5 to be consisted with the other Multi-Arch tests for x86, MIPS and PowerPC. That's all.

Mon, Nov 23, 3:04 PM · Restricted Project

Fri, Nov 20

glaubitz added reviewers for D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux: danalbert, maskray0.
Fri, Nov 20, 4:06 AM · Restricted Project

Tue, Nov 17

glaubitz added a comment to D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.

Thanks a lot Rainer for taking of all of these issues on SPARC!

Tue, Nov 17, 4:53 AM · Restricted Project

Fri, Nov 13

glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393746, @ro wrote:

Please feel free to reach out to the corresponding debian-$ARCH mailing list for such questions. Debian-specific layouts are not
necessarily obvious at first glance to people not very familiar with the distribution.

I could have. However, my only interest in Linux/SPARC was to have a comparison point for my Solaris/SPARC work to determine which test failures occur on all SPARC targets and which ones are Solaris-specific. I simply don't have to time to dig deeper into Linux issues.

Fri, Nov 13, 5:44 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

! In D90524#2393635, @ro wrote:

I had an extremely hard time researching the history of directory layouts for my patch D85582. Do as you like, I'm out of this.

Fri, Nov 13, 4:44 AM · Restricted Project
glaubitz edited reviewers for D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux, added: echristo, MaskRay, phosek; removed: nemanjai, chandlerc, rengolin, dschuff, ro, jyknight.
Fri, Nov 13, 4:42 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393320, @ro wrote:

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Please be a little more patient: one ping a week is considered appropriate, but after only two days is a bit over the top.

Fri, Nov 13, 2:23 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393319, @ro wrote:

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Quite the contrary: the comment you cited

// FIXME: This is a bit of a hack. We should really unify this code for
// reasoning about oslibdir spellings with the lib dir spellings in the
// GCCInstallationDetector, but that is a more significant refactoring.

pretty clearly is about how/where support for that layout is implemented in the clang Driver code, not about the layout itself.

Fri, Nov 13, 2:21 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Fri, Nov 13, 1:43 AM · Restricted Project

Wed, Nov 11

glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Wed, Nov 11, 3:28 AM · Restricted Project

Mon, Nov 9

glaubitz abandoned D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.
Mon, Nov 9, 5:59 AM · Restricted Project
glaubitz added a comment to D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

Merged into D90524.

Mon, Nov 9, 5:58 AM · Restricted Project
glaubitz updated the diff for D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Update as requested in previous review, also merge with D90549.

Mon, Nov 9, 5:57 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Hi Rainer!

Mon, Nov 9, 5:43 AM · Restricted Project
glaubitz added a comment to D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

Ping.

Mon, Nov 9, 3:56 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Ping.

Mon, Nov 9, 3:55 AM · Restricted Project

Sun, Nov 8

glaubitz added a comment to D91031: Add new worker debian-akiko-m68k for Linux 32-bit M68k.

This should be merged once M68k support has been merged into LLVM, see:

Sun, Nov 8, 6:04 AM
glaubitz requested review of D91031: Add new worker debian-akiko-m68k for Linux 32-bit M68k.
Sun, Nov 8, 6:03 AM

Tue, Nov 3

glaubitz added a comment to D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.

Hi Adrian,

LGTM.
But could you rebase the patch on top of https://reviews.llvm.org/D90530, please?

Tue, Nov 3, 1:12 AM
glaubitz updated the diff for D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.

Rebase patch.

Tue, Nov 3, 1:11 AM

Mon, Nov 2

glaubitz added a reviewer for D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux: dschuff.
Mon, Nov 2, 3:28 PM · Restricted Project
glaubitz added a reviewer for D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree: dschuff.
Mon, Nov 2, 3:28 PM · Restricted Project
glaubitz added a comment to D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

One other question then: do you know if Debian and/or Ubuntu still have the same support for running x32 programs on the regular x86-64 distribution? (presumably yes, since you aren't changing the existing behavior).
AFAIK clang's current support was developed against Ubuntu, but I haven't tried it in a long time and to my knowledge nobody has submitted any patches for x32 in a while either.

Mon, Nov 2, 3:21 PM · Restricted Project
glaubitz updated the diff for D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

Regenerated with more context (using git format-patch -W).

Mon, Nov 2, 2:05 PM · Restricted Project
glaubitz added a comment to D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

Can you upload the diff with full context (e.g. use diff -U 9999 or use arcanist to upload)?

I'm a bit confused; the commit message talks about X32 being a separate architecture, but you're not adding any new architecture triples here (it still uses x86_64 as the architecture and selects the ABI via the environment). AFAICS what really changes is that the structure of the include and lib directories is now multi-arch style with the x32 headers alongside the x86_64 base headers?

Mon, Nov 2, 2:02 PM · Restricted Project

Sun, Nov 1

glaubitz added reviewers for D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux: chandlerc, rengolin.
Sun, Nov 1, 6:39 AM · Restricted Project
glaubitz added a comment to D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

This change is required to fix testsuite failures as a result of this fix: https://reviews.llvm.org/D90524

Sun, Nov 1, 6:06 AM · Restricted Project
glaubitz updated the diff for D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

Rebase patch for monorepo, add Debian MultiArch tests.

Sun, Nov 1, 5:00 AM · Restricted Project
glaubitz updated the diff for D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

The previous patch accidentally missed the necessary files changes in Inputs/debian_multiarch_tree,
let's hope this one is correct now.

Sun, Nov 1, 4:29 AM · Restricted Project
glaubitz updated the diff for D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

Update the patch to include the linux-header-search.cpp tests as well.

Sun, Nov 1, 3:20 AM · Restricted Project
glaubitz updated the diff for D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

Update commit comment to reflect the rename of CHECK-DEBIAN-SPARC32 to CHECK-DEBIAN-SPARC.

Sun, Nov 1, 2:10 AM · Restricted Project
glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

The tests are fixed by this change: https://reviews.llvm.org/D90549.

Sun, Nov 1, 2:06 AM · Restricted Project
glaubitz requested review of D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.
Sun, Nov 1, 2:01 AM · Restricted Project

Sat, Oct 31

glaubitz added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Hmm, I'm not sure why the CHECK-DEBIAN-SPARC32 test is failing but I assume the expected output needs to be updated.

Sat, Oct 31, 8:09 AM · Restricted Project
glaubitz added a comment to D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.

Please merge https://reviews.llvm.org/D90530 first, I'll update this revision afterwards.

Sat, Oct 31, 7:39 AM
glaubitz requested review of D90530: [zorg] Limit parallel link jobs to 4 for clang-sparc64-linux-multistage.
Sat, Oct 31, 7:37 AM
glaubitz requested review of D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
Sat, Oct 31, 2:15 AM · Restricted Project
glaubitz added a comment to D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.

Please let's wait with merging this as I need to make sure it doesn't break the testsuite.

Sat, Oct 31, 1:40 AM
glaubitz requested review of D90521: [zorg] Limit clang-sparc64-linux-multistage to Sparc target.
Sat, Oct 31, 12:33 AM

Oct 28 2020

glaubitz added a comment to D90148: [zorg] Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC.

Could someone with access commit this patch for me?

Oct 28 2020, 11:35 PM
glaubitz added a comment to D89940: [sanitizer] Use __atomic_load/store() built-ins for generic 32-bit targets.

Could someone with access commit this patch for me?

Oct 28 2020, 11:33 PM · Restricted Project
glaubitz updated the diff for D90148: [zorg] Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC.

Rebased with latest zorg repository.

Oct 28 2020, 3:36 AM

Oct 26 2020

glaubitz requested review of D90148: [zorg] Add new worker debian-stadler-sparc64 for Linux 64-bit SPARC.
Oct 26 2020, 4:43 AM

Oct 24 2020

glaubitz added a comment to D89940: [sanitizer] Use __atomic_load/store() built-ins for generic 32-bit targets.

This patch unbreaks the build on bi-arch systems which are not x86 or MIPS, so I think it's okay to pick up the change and rewrite the code in cleaner terms later.

Oct 24 2020, 1:08 PM · Restricted Project
glaubitz updated the diff for D89940: [sanitizer] Use __atomic_load/store() built-ins for generic 32-bit targets.

Replace tabs with spaces to fix indentation.

Oct 24 2020, 11:13 AM · Restricted Project
glaubitz updated the diff for D89940: [sanitizer] Use __atomic_load/store() built-ins for generic 32-bit targets.

Addressed all comments and suggestions.

Oct 24 2020, 11:11 AM · Restricted Project

Oct 22 2020

glaubitz requested review of D89940: [sanitizer] Use __atomic_load/store() built-ins for generic 32-bit targets.
Oct 22 2020, 2:46 AM · Restricted Project

Oct 19 2020

glaubitz added inline comments to D88390: [M68k] (Patch 4/8) MC layer and object file support.
Oct 19 2020, 2:17 AM · Restricted Project

Oct 17 2020

glaubitz added inline comments to D88390: [M68k] (Patch 4/8) MC layer and object file support.
Oct 17 2020, 10:50 AM · Restricted Project
glaubitz added inline comments to D88390: [M68k] (Patch 4/8) MC layer and object file support.
Oct 17 2020, 7:20 AM · Restricted Project

Mar 31 2019

glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Well, I don't really know what to add here. The GCCDIST path on 32-bit PowerPC SUSE distributions has always been "powerpc64-suse-linux" according to SUSE's gcc maintainer Richard Biener and my patch just fixes that.

Mar 31 2019, 6:08 AM · Restricted Project

Dec 29 2018

glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation:

  • We seem to be changing the set of aliases here, but what happens if someone actually explicitly specifies --target=powerpc-suse-linux?
Dec 29 2018, 2:39 PM · Restricted Project
glaubitz added a comment to D54409: PowerPC/SPE: Fix load/store handling for SPE.

Other than the minor nit about the test case, LGTM.

Dec 29 2018, 1:46 PM · Restricted Project

Dec 21 2018

glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

Ok, I found the fix for the first crash that landed in 8.0 trunk. It works fine for me if backported to 7.0.1:
https://reviews.llvm.org/D50461

Dec 21 2018, 8:33 AM · Restricted Project, Restricted Project

Dec 8 2018

glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

Might the first crash from https://reviews.llvm.org/D49754#1183753 reproduce for you or perhaps you have already bisected to trunk to figure out the changest that fixes it?

Dec 8 2018, 2:18 AM · Restricted Project, Restricted Project

Dec 6 2018

glaubitz added a comment to D54583: PowerPC: Optimize SPE double parameter calling setup.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D49754 and https://reviews.llvm.org/D54409 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:31 AM · Restricted Project
glaubitz added a comment to D54409: PowerPC/SPE: Fix load/store handling for SPE.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D49754 and https://reviews.llvm.org/D54583 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:31 AM · Restricted Project
glaubitz added a comment to D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang.

I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D54409 and https://reviews.llvm.org/D54583 saw no regressions on x86_64 and 32-bit PowerPC.

Dec 6 2018, 1:28 AM · Restricted Project, Restricted Project

Dec 5 2018

glaubitz updated the diff for D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Added a comment explaining the unusual triplet name.

Dec 5 2018, 7:55 AM · Restricted Project
glaubitz added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Well, I agree on the comment to clarify why it has to be powerpc64-suse-linux, but I'm not sure whether anyone will ever start a SUSE derivative for 32-bit PowerPC, then fix the path in SUSE's gcc and then do a mass-rebuild. I think the probability is pretty low.

Dec 5 2018, 7:50 AM · Restricted Project
glaubitz created D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.
Dec 5 2018, 7:26 AM · Restricted Project

Oct 2 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Oct 2 2018, 4:54 AM

Sep 18 2018

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Can someone commit this, please?

Sep 18 2018, 11:31 AM

Sep 17 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

How do we move forward now?

Sep 17 2018, 5:42 AM

Sep 16 2018

glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I was so much looking forward to this getting merged :-(.

Sep 16 2018, 11:29 AM

Sep 14 2018

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Great, thanks a lot! I'm also just learning how to contribute to LLVM as their setup is a bit unusual ;-).

Sep 14 2018, 2:40 PM
glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

@JDevlieghere Can you commit this fix on behalf of jrtc27? He's currently on vacation.

Sep 14 2018, 2:23 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

@LionNatsu Could you push your commit yourself or do you need someone else to push it?

Sep 14 2018, 2:20 PM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot.

Sep 14 2018, 6:09 AM
glaubitz added a comment to D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.

I don't have commit access, btw. So it would be nice if someone else could commit this for me.

Sep 14 2018, 3:26 AM

Sep 13 2018

glaubitz created D52066: [Driver] Fix missing MultiArch include dir on powerpcspe.
Sep 13 2018, 6:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Chandler!

Sep 13 2018, 5:46 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

I'd be very happy to support Artyom as a co-maintainer. I assume Artyom wants to be the code owner since he already stated, he wants to develop the code at LLVM upstream.

Sep 13 2018, 5:20 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

No worries. Very glad it got finally picked up for review.

Sep 13 2018, 5:13 PM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Sep 13 2018, 5:00 PM
glaubitz updated subscribers of D50858: [M680x0] Add ELF and Triple info.

Hi Kristina!

Sep 13 2018, 12:38 PM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

or ask someone to commit for you -- I can do so if you like.

Sep 13 2018, 12:05 PM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have pushed a rebase revision here: https://reviews.llvm.org/D52050

Sep 13 2018, 12:02 PM
glaubitz created D52050: [Driver] Fix architecture triplets and search paths for Linux x32.
Sep 13 2018, 12:01 PM · Restricted Project
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I don't think that "test/Driver/linux-header-search.cpp" needs to be updated. x32 is actually supported in both an x86_64-linux-gnu environment and x86_64-linux-gnux32 environment. In order to update test/Driver/linux-header-search.cpp, we would have to add a debian-10-x32 chroot to the LLVM test environment. However, the patch by @jrtc27 actually doesn't break the previous tests as his patch just allows the native header and library paths as altnernative search paths.

Sep 13 2018, 11:59 AM
glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

I have just rebased the patch and I am looking at the tests now.

Sep 13 2018, 11:42 AM
glaubitz added a comment to D50858: [M680x0] Add ELF and Triple info.

@m4yers I think you need to add reviewers here as well, no?

Sep 13 2018, 11:22 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Has this been merged now? I don't see it in the github mirror yet.

Sep 13 2018, 11:18 AM

Sep 11 2018

glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Ok, thanks for the explanation. I wasn't sure how it's handled in LLVM. I'm in the OpenJDK upstream project and we always require two reviewers for changes to Hotspot!

Sep 11 2018, 9:28 AM
glaubitz added a comment to D51108: [PowerPC] Fix wrong ABI for i1 stack arguments on PPC32.

Does this still need a review from cuviper?

Sep 11 2018, 8:49 AM

Aug 30 2018

glaubitz added inline comments to D50858: [M680x0] Add ELF and Triple info.
Aug 30 2018, 1:57 PM

Aug 27 2018

glaubitz added a comment to D51335: [SROA] Fix alignment for uses of PHI nodes..

This patch fixes a problem with Rust emitting code with causing unaligned access: https://github.com/rust-lang/rust/issues/53181

Aug 27 2018, 11:47 PM

May 13 2018

glaubitz added a comment to D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32.

Is there any chance this PR can get completed?

May 13 2018, 5:28 AM

Feb 28 2018

glaubitz added a comment to D43630: [Driver] Fix search paths on x32.

As a heads-up, powerpcspe needs a similar treatment as it suffers from the same problem:

Feb 28 2018, 2:15 AM

Feb 20 2018

glaubitz added a comment to D43271: [Sparc] Include __tls_get_addr in symbol table for TLS calls to it.

Cool, thank you! \o/

Feb 20 2018, 2:14 AM