Page MenuHomePhabricator

ggeorgakoudis (Giorgis Georgakoudis)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 5:55 PM (55 w, 6 d)

Recent Activity

Mon, Jan 11

ggeorgakoudis committed rG975170551283: [OpenMPOpt][WIP] Expand parallel region merging (authored by ggeorgakoudis).
[OpenMPOpt][WIP] Expand parallel region merging
Mon, Jan 11, 8:06 AM
ggeorgakoudis closed D90909: [OpenMPOpt][WIP] Expand parallel region merging.
Mon, Jan 11, 8:06 AM · Restricted Project

Wed, Jan 6

ggeorgakoudis added inline comments to D90909: [OpenMPOpt][WIP] Expand parallel region merging.
Wed, Jan 6, 8:28 AM · Restricted Project
ggeorgakoudis updated the diff for D90909: [OpenMPOpt][WIP] Expand parallel region merging.

Updated for comments.

Wed, Jan 6, 8:27 AM · Restricted Project

Dec 11 2020

ggeorgakoudis committed rGe007b3286429: [OpenMP] Add time profiling for libomptarget (authored by ggeorgakoudis).
[OpenMP] Add time profiling for libomptarget
Dec 11 2020, 6:54 PM
ggeorgakoudis closed D93055: [OpenMP] Add time profiling for libomptarget.
Dec 11 2020, 6:53 PM · Restricted Project
ggeorgakoudis updated the diff for D93055: [OpenMP] Add time profiling for libomptarget.

Add env variable to enable profiling, better naming

Dec 11 2020, 1:07 PM · Restricted Project
ggeorgakoudis added inline comments to D93055: [OpenMP] Add time profiling for libomptarget.
Dec 11 2020, 10:55 AM · Restricted Project
ggeorgakoudis added inline comments to D93055: [OpenMP] Add time profiling for libomptarget.
Dec 11 2020, 10:53 AM · Restricted Project
ggeorgakoudis added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

Interesting. Not sure about the dependency on an llvm library, though maybe guarding it makes that acceptable.

The DIY equivalent we've been using is functionally similar. Implemented at trace.h in as unintrusive a fashion as I could manage.

In addition to the time taken by calls, maintaining a log of the arguments to the functions (and the return value) has been very helpful as a debugging hack. The proper thing to do is probably to write said data to an in memory ring buffer. The above header just splats it to stdout.

Does this clang-format nicely? I'd expect to have to spell it TIMESCOPE(); or similar.

Dec 11 2020, 10:52 AM · Restricted Project
ggeorgakoudis updated the diff for D93055: [OpenMP] Add time profiling for libomptarget.

Update for comments

Dec 11 2020, 10:50 AM · Restricted Project

Dec 10 2020

ggeorgakoudis requested review of D93055: [OpenMP] Add time profiling for libomptarget.
Dec 10 2020, 11:26 AM · Restricted Project

Dec 8 2020

ggeorgakoudis committed rG18dff2895880: [OpenMP] Add doxygen generation for the runtime (authored by ggeorgakoudis).
[OpenMP] Add doxygen generation for the runtime
Dec 8 2020, 4:21 PM
ggeorgakoudis closed D92779: [OpenMP] Add doxygen generation for the runtime.
Dec 8 2020, 4:20 PM · Restricted Project

Dec 7 2020

ggeorgakoudis added a comment to D92779: [OpenMP] Add doxygen generation for the runtime.

I suspect this is copied from one of the other projects? If so, LGTM.

Dec 7 2020, 12:47 PM · Restricted Project
ggeorgakoudis requested review of D92779: [OpenMP] Add doxygen generation for the runtime.
Dec 7 2020, 10:59 AM · Restricted Project

Nov 18 2020

ggeorgakoudis updated the diff for D90909: [OpenMPOpt][WIP] Expand parallel region merging.

Update to correctly handle inputs to sequential regions.

Nov 18 2020, 9:50 PM · Restricted Project

Nov 11 2020

ggeorgakoudis updated the diff for D90909: [OpenMPOpt][WIP] Expand parallel region merging.

Simplify check for unmergable regions, add flag for extractor sinking in OMPIRBuilder outlining.

Nov 11 2020, 9:19 AM · Restricted Project

Nov 10 2020

Herald added a project to D47300: [RFC] Abstract parallel IR analyzes & optimizations + OpenMP implementations: Restricted Project.
Nov 10 2020, 1:46 PM · Restricted Project

Nov 6 2020

ggeorgakoudis retitled D90909: [OpenMPOpt][WIP] Expand parallel region merging from [OpenMPOpt] Expand parallel region merging to [OpenMPOpt][WIP] Expand parallel region merging.
Nov 6 2020, 1:04 PM · Restricted Project
ggeorgakoudis added inline comments to D90909: [OpenMPOpt][WIP] Expand parallel region merging.
Nov 6 2020, 12:46 PM · Restricted Project
ggeorgakoudis requested review of D90909: [OpenMPOpt][WIP] Expand parallel region merging.
Nov 6 2020, 1:04 AM · Restricted Project

Nov 5 2020

ggeorgakoudis committed rG700d2417d828: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime… (authored by ggeorgakoudis).
[CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime…
Nov 5 2020, 5:01 PM
ggeorgakoudis closed D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
Nov 5 2020, 5:01 PM · Restricted Project
ggeorgakoudis added a comment to D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.

I see your point @vsk. I have added a unit test. Anything else missing for acceptance?

Nov 5 2020, 10:42 AM · Restricted Project
ggeorgakoudis updated the diff for D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.

Add unit test

Nov 5 2020, 10:41 AM · Restricted Project
ggeorgakoudis abandoned D90865: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
Nov 5 2020, 10:37 AM · Restricted Project
ggeorgakoudis requested review of D90865: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
Nov 5 2020, 10:29 AM · Restricted Project

Nov 3 2020

ggeorgakoudis added a comment to D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
In D90689#2371522, @vsk wrote:

In the example, what pass/component is responsible for creating %1 = bitcast i32* %0 to i8*?

If it's CodeExtractor itself, it would be nice to solve the problem earlier by getting rid of bitcasts which only exist to wire up lifetime markers. I tried doing that in 26ee8aff2, but had to revert (099bffe7f) because llvm doesn't support specializing its lifetime intrinsics on opaque pointer types. That's a bug, I think: if we fix that, perhaps this whole problem goes away.

OTOH, if this %1 = bitcast i32* %0 to i8* value comes from a frontend or another pass, I think the approach taken in this patch is reasonable. Please add a test (perhaps in the CodeExtractor unittest).

Nov 3 2020, 10:48 AM · Restricted Project
ggeorgakoudis added a reviewer for D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers: vsk.
Nov 3 2020, 9:01 AM · Restricted Project
ggeorgakoudis updated the summary of D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
Nov 3 2020, 8:56 AM · Restricted Project
ggeorgakoudis updated the diff for D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.

Format better the patch message

Nov 3 2020, 8:53 AM · Restricted Project
ggeorgakoudis added a reviewer for D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers: jdoerfert.
Nov 3 2020, 8:38 AM · Restricted Project
ggeorgakoudis requested review of D90689: [CodeExtractor] Replace uses of extracted bitcasts in out-of-region lifetime markers.
Nov 3 2020, 8:37 AM · Restricted Project

Oct 9 2020

ggeorgakoudis committed rG3a6bfcf2f902: [OpenMPOpt] Merge parallel regions (authored by ggeorgakoudis).
[OpenMPOpt] Merge parallel regions
Oct 9 2020, 9:59 AM
ggeorgakoudis closed D83635: [OpenMPOpt] Merge parallel regions.
Oct 9 2020, 9:59 AM · Restricted Project

Oct 8 2020

ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Amend commit message

Oct 8 2020, 11:54 PM · Restricted Project

Oct 6 2020

ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update commit message

Oct 6 2020, 10:13 PM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update for comments (for real)

Oct 6 2020, 8:20 PM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update for comments

Oct 6 2020, 8:16 PM · Restricted Project

Sep 28 2020

ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Fix clang-tidy complaints

Sep 28 2020, 5:45 PM · Restricted Project
ggeorgakoudis added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Sep 28 2020, 10:26 AM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Fix for .ll files appearing as binary

Sep 28 2020, 10:24 AM · Restricted Project
ggeorgakoudis added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Sep 28 2020, 10:01 AM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Updates per comments

Sep 28 2020, 9:50 AM · Restricted Project

Jul 27 2020

ggeorgakoudis added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Jul 27 2020, 1:31 PM · Restricted Project
ggeorgakoudis added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Jul 27 2020, 12:15 PM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update for comments

Jul 27 2020, 11:51 AM · Restricted Project

Jul 15 2020

ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update diff for linting warning?

Jul 15 2020, 6:29 PM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update for comments

Jul 15 2020, 6:19 PM · Restricted Project

Jul 14 2020

ggeorgakoudis committed rG7f680be593ee: [OpenMPOpt][NFC] Update checks for parallel_deletion test (authored by ggeorgakoudis).
[OpenMPOpt][NFC] Update checks for parallel_deletion test
Jul 14 2020, 11:40 PM
ggeorgakoudis committed rG694ded37b9d7: [OpenMPOpt] Fix preserved analyses return (authored by ggeorgakoudis).
[OpenMPOpt] Fix preserved analyses return
Jul 14 2020, 11:20 PM
ggeorgakoudis committed rGaef60af34ec3: [CallGraph] Ignore callback uses (authored by ggeorgakoudis).
[CallGraph] Ignore callback uses
Jul 14 2020, 1:14 PM
ggeorgakoudis closed D83370: [CallGraph] Ignore callback uses.
Jul 14 2020, 1:13 PM · Restricted Project
ggeorgakoudis added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Jul 14 2020, 12:36 PM · Restricted Project
ggeorgakoudis added a comment to D83635: [OpenMPOpt] Merge parallel regions.

It's great that you're working on this. It's very important that we allow people to write code, structured and decomposed in a way that makes sense from an engineering and maintenance perspective, and have the compiler combine things later to avoid unnecessary overhead. This is just as much true for expressions of parallelism as it is for other aspects of the code.

Jul 14 2020, 12:08 PM · Restricted Project
ggeorgakoudis updated the diff for D83635: [OpenMPOpt] Merge parallel regions.

Update for comments

Jul 14 2020, 12:07 PM · Restricted Project
ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Update for latest comment

Jul 14 2020, 11:16 AM · Restricted Project
ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Update for latest nit comment

Jul 14 2020, 8:48 AM · Restricted Project

Jul 11 2020

ggeorgakoudis added a comment to D83635: [OpenMPOpt] Merge parallel regions.

Note I also update the regression test Transforms/OpenMP/parallel_deletion.ll since the merging optimization, which applies after deletion, changes the output

Jul 11 2020, 6:00 PM · Restricted Project
Herald added a project to D83635: [OpenMPOpt] Merge parallel regions: Restricted Project.
Jul 11 2020, 5:58 PM · Restricted Project
ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Revert changes to regression tests

Jul 11 2020, 2:53 AM · Restricted Project

Jul 10 2020

ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Update regression tests under Transforms/Attributor/IPConstantProp

Jul 10 2020, 8:18 AM · Restricted Project

Jul 9 2020

ggeorgakoudis committed rG205dc0922d5f: [CallGraph] Ignore callback uses (authored by ggeorgakoudis).
[CallGraph] Ignore callback uses
Jul 9 2020, 1:19 PM
ggeorgakoudis closed D83370: [CallGraph] Ignore callback uses.
Jul 9 2020, 1:18 PM · Restricted Project
ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Update regression test

Jul 9 2020, 12:15 PM · Restricted Project

Jul 8 2020

ggeorgakoudis updated the diff for D83370: [CallGraph] Ignore callback uses.

Update for comment

Jul 8 2020, 4:53 PM · Restricted Project
ggeorgakoudis added a comment to D83370: [CallGraph] Ignore callback uses.

I may be missing context, but this may be missing some wording.
*Why* should they not be in the callgraph?

Jul 8 2020, 10:57 AM · Restricted Project
ggeorgakoudis updated the summary of D83370: [CallGraph] Ignore callback uses.
Jul 8 2020, 10:55 AM · Restricted Project

Jul 7 2020

Herald added a project to D83370: [CallGraph] Ignore callback uses: Restricted Project.
Jul 7 2020, 10:52 PM · Restricted Project