Page MenuHomePhabricator

gedatsu217 (Shu Anzai)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2020, 10:25 AM (24 w, 4 d)

Recent Activity

Today

gedatsu217 added a comment to D84355: [lldb] Getting the suggestions also from previous sessions.

And, the test does not work well. Would you check it?

Did you check it? This test seems to work well, but an error occurs.

Fri, Aug 14, 8:00 AM

Tue, Aug 11

gedatsu217 updated the diff for D84355: [lldb] Getting the suggestions also from previous sessions.

Revise the code according to your advice.

Tue, Aug 11, 11:55 AM

Mon, Aug 10

gedatsu217 added a comment to D84355: [lldb] Getting the suggestions also from previous sessions.

ping

Mon, Aug 10, 8:47 AM

Thu, Aug 6

gedatsu217 added a comment to D84355: [lldb] Getting the suggestions also from previous sessions.

Regarding the expected test: This isn't really related to the autosuggestion feature but a more generic feature, so I would make a new separate test where you check that the command history is persistent across lldb instances. The easiest way to check this is to add a unique command to the history and then relaunch LLDB and check its still there (you can list the command history via session history. If your branch isn't fully up-to-date, the command might still be named command history).

Thu, Aug 6, 12:37 PM
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

add comments.

Thu, Aug 6, 11:42 AM · Restricted Project
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Simplify the code.

Thu, Aug 6, 6:09 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Are there any other problems with the current state of the patch that haven't been resolved? (I went over the comments, but it's hard to say what has and hasn't been fixed until now).

Thu, Aug 6, 5:57 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

So, if I would type "b" and then press tab, the autosuggestion would briefly disappear until I type the next character?

Thu, Aug 6, 4:44 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

So the way the issue with the single space is now solved is by doing CC_REDISPLAY when we're only adding the single space? Isn't that also deleting the whole autosuggestion?

Yes. CC_REDISPLAY can delete all the gray characters left.

Thu, Aug 6, 2:46 AM · Restricted Project

Tue, Aug 4

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Add test.

Tue, Aug 4, 10:53 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

@teemperor I understand what you say just now. Indeed, your method is more efficient than mine. I'm fixing the code now.

Tue, Aug 4, 10:22 AM · Restricted Project

Mon, Aug 3

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I don't think the value of m_previous_autosuggestion_size should only grow (which is what this if is doing), as this way we just keep printing a longer and longer space buffer over time. Just printing enough to clear the buffer of the previous completion is enough.

If I keep the number of characters of the only previous command, I think there is a problem. For example, If I type "help frame var" → "help frame info" → "help frame v", the remains are hidden. However, If I type "help frame var" → "help frame info" → "help" → "help frame v", the number of characters of "help frame var" is more than that of "help", so "help frame v[aro]" is displayed. What do you think?

Not sure if I understand your example correctly, but as soon as you type "help frame ", you should have an autosuggestion of "help frame info" and then typing the "v" should clear the "nfo" part. The "help" autosuggestion should not be involved at all in any logic after you typed "help "?

Mon, Aug 3, 7:30 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
@skipIfAsan
@skipIfEditlineSupportMissing
def test_hidden_autosuggestion(self):
@skipIfAsan
@skipIfEditlineSupportMissing
def test_autosuggestion(self):
    self.launch(extra_args=["-o", "settings set show-autosuggestion true", "-o", "settings set use-color true"])
    self.expect("help frame v")
    self.expect("help frame info")
    [type 'help frame v' and check for the three space after the grey part to cover up the "nfo" text]
Mon, Aug 3, 5:32 AM · Restricted Project

Sat, Aug 1

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Add spaces when a character is typed.

Sat, Aug 1, 10:42 PM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Also could you rebase the diff here when you have time (e.g., regenerate the diff from you changes on top of the latest master commit)? It no longer applies at the moment without having to manually resolve a conflict.

Sat, Aug 1, 7:39 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Although I thought of how to clear all the following characters, I did not come up with it. So, I will try to fill the space. Should I add how many spaces? If I add too many spaces, sequences will be two lines, but if I add a few spaces, I can't handle some of the cases.

Sat, Aug 1, 1:19 AM · Restricted Project

Wed, Jul 29

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Sorry, I mistakenly uploaded a different file. This is the correct file.

Wed, Jul 29, 11:32 AM · Restricted Project
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Fix the cursor position. (Editline::TypedCharacter)

Wed, Jul 29, 11:13 AM · Restricted Project

Tue, Jul 28

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

For example, I execute "help frame variable" and save it as command history. Then, when I type "hel", "helhelp [me variable]" (gray characters are in []) is displayed, probably because of cursor position or CC_NORM.

Tue, Jul 28, 12:14 PM · Restricted Project
gedatsu217 added a comment to D84695: [lldb] Change the definition of ANSI_UNFAINT.

I do not know how to land this. So, I would like to land this if I can do.

Tue, Jul 28, 11:05 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Sorry, I found the bug. Please do not check this yet.

Tue, Jul 28, 11:04 AM · Restricted Project
gedatsu217 updated the diff for D84695: [lldb] Change the definition of ANSI_UNFAINT.

Sorry, I misunderstood it.

Tue, Jul 28, 10:34 AM · Restricted Project
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Editline::TypedCharacter is called when delete is pressed. (This probably fix the above bug.)

Tue, Jul 28, 8:42 AM · Restricted Project
gedatsu217 updated the diff for D84695: [lldb] Change the definition of ANSI_UNFAINT.

Add explanations.

Tue, Jul 28, 6:21 AM · Restricted Project

Mon, Jul 27

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Revise Editline::ApplyAutosuggestCommand. (Change the return value.)

Mon, Jul 27, 12:27 PM · Restricted Project
gedatsu217 created D84695: [lldb] Change the definition of ANSI_UNFAINT.
Mon, Jul 27, 12:20 PM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Could you create a patch to change the definition of ANSI_UNFAINT ? (might be worth taking a quick look at git history if there is no good reason for why it uses the color code that it uses)

Mon, Jul 27, 8:40 AM · Restricted Project

Fri, Jul 24

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I do not intend for this feature to work with colors disabled.

Fri, Jul 24, 9:45 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Yes, I'm testing it on Mac.

Fri, Jul 24, 6:36 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

That said, are you sure this is the right sequence? \x1b[1Gl seems like it should print the l at column one, which does not sound right...

I thought it did not add up too, but pexpect probably actually outputs these characters.

Fri, Jul 24, 5:54 AM · Restricted Project

Thu, Jul 23

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I checked what's the sequence that actually gets output, and it was like below.

h\x1b[2melp frame\x1b[0m\x1b[1Ghe\x1b[2mlp frame\x1b[0m\x1b[1Gel\x1b[2mp frame\x1b[0m\x1b[1Gl
Thu, Jul 23, 1:11 PM · Restricted Project

Wed, Jul 22

gedatsu217 created D84355: [lldb] Getting the suggestions also from previous sessions.
Wed, Jul 22, 12:45 PM
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Add the test content.

Wed, Jul 22, 12:11 PM · Restricted Project

Mon, Jul 20

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

In addition to it, I tried the below code, but it did not go well. ("\x1b[nD" moves the cursor n steps to the left.)

Mon, Jul 20, 10:13 AM · Restricted Project
gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Mon, Jul 20, 9:01 AM · Restricted Project

Fri, Jul 17

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

help help frame should not have an autosuggestion to help frame. You can just try to get the autosuggestion for help help frame and check for the error for an invalid command.

Fri, Jul 17, 1:48 PM · Restricted Project

Thu, Jul 16

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Remove extra parts in Editline::TabCommand in Editline.cpp.

Thu, Jul 16, 12:47 PM · Restricted Project

Jul 14 2020

gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jul 14 2020, 9:59 AM · Restricted Project

Jul 13 2020

gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jul 13 2020, 1:18 PM · Restricted Project

Jul 8 2020

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I fixed the code according to your advice.

Jul 8 2020, 10:00 AM · Restricted Project

Jun 25 2020

gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 25 2020, 11:54 AM · Restricted Project
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I revised the code according to your advice.

Jun 25 2020, 8:00 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I understood what you said. Sorry, I misunderstood it. Indeed, m_current_autosuggestion is not good for the future.
I will get the current user input every time calling ApplyCompleteCommand instead of using m_current_autosuggestion.

Jun 25 2020, 6:24 AM · Restricted Project

Jun 23 2020

gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 23 2020, 11:48 AM · Restricted Project

Jun 22 2020

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Change the name and return of the function( bool UseAutosuggestion() -> void SetShowAutosuggestion (bool) ) (ll. 1447 in Editline.cpp and ll.194 in Editline.h).
int -> size_t (ll. 1009 in Editline.cpp).
Fix for normal setter (ll. 269 in IOHandler.cpp).

Jun 22 2020, 10:44 AM · Restricted Project

Jun 16 2020

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Implementation all ascii characters for TypedCharacter.
Making m_use_autosuggestion in Editline.cpp. (I did not know a way to pass the bool value of IOHandlerEditline to Editline constructor, so I made a function, Editline::UseAutosuggestion, in Editline class. If the autosuggestion is valid, this function is called from IOHandlerEditline constructor. Is this implementation good?)

Jun 16 2020, 2:18 PM · Restricted Project

Jun 12 2020

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I updated my codes according to your advice:

Jun 12 2020, 11:26 AM · Restricted Project
gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 12 2020, 9:12 AM · Restricted Project
gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 12 2020, 8:38 AM · Restricted Project

Jun 10 2020

gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 10 2020, 11:41 AM · Restricted Project
gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I corrected codes according to your advice.

Jun 10 2020, 11:40 AM · Restricted Project
gedatsu217 added inline comments to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 10 2020, 11:05 AM · Restricted Project

Jun 8 2020

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

ping

Jun 8 2020, 9:22 AM · Restricted Project

Jun 5 2020

gedatsu217 updated the diff for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

I implemented autosuggestion based on command history first according to your advice.
But I did not understand what you said completely. So I want to know it in detail.

Jun 5 2020, 12:22 PM · Restricted Project

Jun 4 2020

gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

In short, should I implement autosuggestion using m_command_history at first?

Jun 4 2020, 11:00 AM · Restricted Project

Jun 2 2020

gedatsu217 removed rG LLVM Github Monorepo as the repository for D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 2 2020, 9:52 AM · Restricted Project
gedatsu217 created D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .
Jun 2 2020, 7:08 AM · Restricted Project

May 5 2020

gedatsu217 added a comment to D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.

I performed a factory reset for OS upgrade and rebuild LLDB, and solved this problem. Thanks.

May 5 2020, 9:33 PM · Restricted Project

Apr 9 2020

gedatsu217 added a comment to D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.
[39/575] Linking CXX shared library lib/libc++abi.1.0.dylib
FAILED: lib/libc++abi.1.0.dylib 
: && /Library/Developer/CommandLineTools/usr/bin/c++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color  -g  -dynamiclib -Wl,-headerpad_max_install_names -nodefaultlibs  -compatibility_version 1.0.0 -current_version 1.0.0 -o lib/libc++abi.1.0.dylib -install_name @rpath/libc++abi.1.dylib projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_aux_runtime.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_default_handlers.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_demangle.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_exception_storage.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_guard.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_handlers.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_unexpected.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_vector.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_virtual.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_exception.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_stdexcept.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_typeinfo.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/abort_message.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/fallback_malloc.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/private_typeinfo.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/stdlib_new_delete.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_exception.cpp.o projects/libcxxabi/src/CMakeFiles/cxxabi_shared.dir/cxa_personality.cpp.o  -Wl,-rpath,@loader_path/../lib  -lSystem  -Wl,-exported_symbols_list,/Users/shu/Documents/llvm-project/libcxxabi/src/../lib/itanium-base.exp  -Wl,-exported_symbols_list,/Users/shu/Documents/llvm-project/libcxxabi/src/../lib/new-delete.exp  -Wl,-exported_symbols_list,/Users/shu/Documents/llvm-project/libcxxabi/src/../lib/personality-v0.exp && :
Undefined symbols for architecture x86_64:
  "__ZTIDu", referenced from:
     -exported_symbol[s_list] command line option
  "__ZTIPDu", referenced from:
     -exported_symbol[s_list] command line option
  "__ZTIPKDu", referenced from:
     -exported_symbol[s_list] command line option
  "__ZTSDu", referenced from:
     -exported_symbol[s_list] command line option
  "__ZTSPDu", referenced from:
     -exported_symbol[s_list] command line option
  "__ZTSPKDu", referenced from:
     -exported_symbol[s_list] command line option
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Apr 9 2020, 11:10 AM · Restricted Project

Mar 30 2020

gedatsu217 updated the diff for D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.

I revised the test case. If "log timers" is executed, an error will not occur.

Mar 30 2020, 1:37 PM · Restricted Project

Mar 28 2020

gedatsu217 added a comment to D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.

Thanks. I revised it. Then, I want to have a test. How do I have a test?

Mar 28 2020, 3:36 PM · Restricted Project

Mar 27 2020

gedatsu217 added a comment to D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.

Sorry, I do not understand what you said completely. In short, is "log timer" (not "log timers") expected to fail? In that case, for example, "log ena" operates the same as "log enable". Thus, I think that "log timer" should operate the same as "log timers". Or, should I fix CommandObjectMultiword to solve such problems? (In short, should I fix it so that "log ena" do not operate like "log enable", "log timer" do not operate like "log timers", "brea li" do not operate "breakpoint list" and so on?)

Mar 27 2020, 1:10 PM · Restricted Project
gedatsu217 created D76906: [lldb] Fixing the bug that the "log timer" has no tab completion.
Mar 27 2020, 1:01 AM · Restricted Project

Mar 4 2020

gedatsu217 added a comment to D75294: [lldb][NFC] Minor code cleanup in Editline.cpp.

What should I do after this? I think I don't have the right to commit.

Mar 4 2020, 9:00 AM · Restricted Project

Mar 3 2020

gedatsu217 updated the diff for D75294: [lldb][NFC] Minor code cleanup in Editline.cpp.

Sorry, I revised it.

Mar 3 2020, 10:56 AM · Restricted Project

Mar 1 2020

gedatsu217 updated the diff for D75294: [lldb][NFC] Minor code cleanup in Editline.cpp.

I fixed a little according to your instruction, and I made an additional revision. (I revised type inference.)

Mar 1 2020, 9:06 AM · Restricted Project

Feb 27 2020

gedatsu217 created D75294: [lldb][NFC] Minor code cleanup in Editline.cpp.
Feb 27 2020, 1:04 PM · Restricted Project