Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (188 w, 3 d)

Recent Activity

Yesterday

gchatelet updated the diff for D94760: [libc][NFC] remove dependency on non standard ssize_t.
  • buffer values are never modified so we can use char instead of unsigned char.
Fri, Jan 15, 7:42 AM · Restricted Project
gchatelet committed rG5bf47e142b6e: [libc] CopyAlignedBlocks can now specify alignment on top of block size (authored by gchatelet).
[libc] CopyAlignedBlocks can now specify alignment on top of block size
Fri, Jan 15, 7:32 AM
gchatelet closed D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
Fri, Jan 15, 7:32 AM · Restricted Project
gchatelet added a comment to D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.

Eh you beat me to it. Had a similar patch I've been measuring and testing. Your's is more complete though :)

LGTM.

Fri, Jan 15, 7:30 AM · Restricted Project
gchatelet requested review of D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
Fri, Jan 15, 5:43 AM · Restricted Project
gchatelet requested review of D94760: [libc][NFC] remove dependency on non standard ssize_t.
Fri, Jan 15, 3:10 AM · Restricted Project
gchatelet committed rGa10300a2b27c: [libc] Allow customization of memcpy via flags. (authored by gchatelet).
[libc] Allow customization of memcpy via flags.
Fri, Jan 15, 1:27 AM
gchatelet closed D94692: [libc] Allow customization of memcpy via flags..
Fri, Jan 15, 1:27 AM · Restricted Project
gchatelet updated the diff for D94692: [libc] Allow customization of memcpy via flags..
  • Address comments
Fri, Jan 15, 1:24 AM · Restricted Project

Thu, Jan 14

gchatelet requested review of D94692: [libc] Allow customization of memcpy via flags..
Thu, Jan 14, 7:53 AM · Restricted Project

Wed, Jan 13

gchatelet committed rGab577807165c: [libc] Refresh benchmark progress bar when needed. (authored by gchatelet).
[libc] Refresh benchmark progress bar when needed.
Wed, Jan 13, 6:07 AM

Tue, Jan 12

gchatelet accepted D93195: [libc] Add memmove implementation..

LGTM, can you please wait for @sivachandra answer about using assert in code before submitting? Thx!

Tue, Jan 12, 3:46 AM · Restricted Project

Mon, Jan 11

gchatelet requested changes to D93195: [libc] Add memmove implementation..

My apologies for the late reply. I've made a bunch of comments.

Mon, Jan 11, 5:20 AM · Restricted Project

Wed, Jan 6

gchatelet committed rGaa9db51ef69f: [libc] Align src buffer instead of dst buffer (authored by gchatelet).
[libc] Align src buffer instead of dst buffer
Wed, Jan 6, 4:06 AM
gchatelet closed D93457: [libc] Align src buffer instead of dst buffer.
Wed, Jan 6, 4:05 AM · Restricted Project
gchatelet committed rG223a6f94c59c: [libc] remove modulo from CircularArrayRef iterator (authored by gchatelet).
[libc] remove modulo from CircularArrayRef iterator
Wed, Jan 6, 4:04 AM
gchatelet added a comment to D93457: [libc] Align src buffer instead of dst buffer.

Sure, LGTM. What is the usual convention for Libc reviewing? Should I 'accept revision' if I agree with it even though I'm not a maintainer?

Wed, Jan 6, 3:20 AM · Restricted Project
gchatelet added a reviewer for D93457: [libc] Align src buffer instead of dst buffer: avieira.
Wed, Jan 6, 2:10 AM · Restricted Project
gchatelet added a comment to D93457: [libc] Align src buffer instead of dst buffer.

Hi Guillaume,

Sorry for the late reply, I was looking at some other things and then holidays happened. I started looking at making some changes to CopyAlignedBlocks just like we discussed earlier. One of them is this one and I noticed this makes the MemcpyUtilsTest.CopyAlignedBlocks fail in libc_string_unittests. Specifically the ones that test destination misalignment. It seems the testing infrastructure keeps track of what bytes were read and written. I checked and making the source the misaligned input and switching the read and written expected traces makes it passs. Which makes sense I guess.

Would be good to make the change at the same time though.

Wed, Jan 6, 2:10 AM · Restricted Project
gchatelet updated the diff for D93457: [libc] Align src buffer instead of dst buffer.
  • Address comments and rebase
Wed, Jan 6, 2:08 AM · Restricted Project

Tue, Jan 5

gchatelet edited reviewers for D93457: [libc] Align src buffer instead of dst buffer, added: courbet; removed: avieira, sivachandra.
Tue, Jan 5, 6:55 AM · Restricted Project

Dec 17 2020

gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 17 2020, 8:42 AM · Restricted Project
gchatelet added a comment to D93210: [libc] revamp memory function benchmark.

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

Sorry, I am no expert here so I just kept silent while @courbet was steering the review. LGTM.

Dec 17 2020, 8:41 AM · Restricted Project
gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 17 2020, 6:02 AM · Restricted Project
gchatelet requested review of D93457: [libc] Align src buffer instead of dst buffer.
Dec 17 2020, 5:58 AM · Restricted Project
gchatelet committed rGdeae7e982a3b: [libc] revamp memory function benchmark (authored by gchatelet).
[libc] revamp memory function benchmark
Dec 17 2020, 5:24 AM
gchatelet closed D93210: [libc] revamp memory function benchmark.
Dec 17 2020, 5:24 AM · Restricted Project
gchatelet added a comment to D93210: [libc] revamp memory function benchmark.

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

Dec 17 2020, 5:11 AM · Restricted Project
gchatelet added inline comments to D93210: [libc] revamp memory function benchmark.
Dec 17 2020, 5:05 AM · Restricted Project
gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.

rebasing

Dec 17 2020, 5:05 AM · Restricted Project
gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.
  • Address comments
Dec 17 2020, 5:04 AM · Restricted Project

Dec 16 2020

gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.
  • Address comments and fix naming style
Dec 16 2020, 2:07 AM · Restricted Project

Dec 14 2020

gchatelet added inline comments to D82134: [libc] Add strcmp implementation..
Dec 14 2020, 8:19 AM · Restricted Project
gchatelet added a comment to D82134: [libc] Add strcmp implementation..

The granularity of ARMv8.3 PAC is 16 byte. Can you read an invalid address?

Dec 14 2020, 6:59 AM · Restricted Project
gchatelet requested review of D93210: [libc] revamp memory function benchmark.
Dec 14 2020, 6:41 AM · Restricted Project
gchatelet added inline comments to D82134: [libc] Add strcmp implementation..
Dec 14 2020, 1:06 AM · Restricted Project
gchatelet accepted D93009: [libc] Add memcmp implementation..
Dec 14 2020, 12:53 AM · Restricted Project

Dec 7 2020

gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 7 2020, 6:47 AM · Restricted Project

Dec 1 2020

gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 1 2020, 4:20 AM · Restricted Project

Nov 30 2020

gchatelet committed rG699d17d4d64e: [libc] Improve memcpy copy loop (authored by gchatelet).
[libc] Improve memcpy copy loop
Nov 30 2020, 12:25 AM
gchatelet closed D91976: [libc] Improve memcpy copy loop.
Nov 30 2020, 12:25 AM · Restricted Project

Nov 26 2020

gchatelet accepted D91399: [libc] Add strncpy implementation..

Thank you for your contribution!
Please wait for @sivachandra before submitting.

Nov 26 2020, 1:18 AM · Restricted Project

Nov 25 2020

gchatelet committed rGd899f9970e51: Fix case mismatch between definition and declaration (authored by gchatelet).
Fix case mismatch between definition and declaration
Nov 25 2020, 6:24 AM

Nov 23 2020

gchatelet accepted D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs.

Thx for the patch!

Nov 23 2020, 9:40 AM · Restricted Project
gchatelet requested review of D91976: [libc] Improve memcpy copy loop.
Nov 23 2020, 9:34 AM · Restricted Project
gchatelet added a comment to D91399: [libc] Add strncpy implementation..

Thx for the patch!

Nov 23 2020, 9:19 AM · Restricted Project

Nov 19 2020

gchatelet updated subscribers of D91677: Avoid simplification of library functions when callee has an implementation.
Nov 19 2020, 7:46 AM · Restricted Project

Nov 4 2020

gchatelet accepted D90744: [llvm-exegesis][X86] Ignore a few unmeasurable opcodes..
Nov 4 2020, 2:01 AM · Restricted Project
gchatelet accepted D90742: [llvm-exegesis][X86] Save and restore eflags..

Thx!

Nov 4 2020, 1:42 AM · Restricted Project

Nov 2 2020

gchatelet accepted D90592: [llvm-exegesis] Save target state before running the benchmark..
Nov 2 2020, 4:41 AM · Restricted Project
gchatelet added a comment to D90592: [llvm-exegesis] Save target state before running the benchmark..

Can you reformat to fix Lint errors as well.

Nov 2 2020, 4:26 AM · Restricted Project

Oct 30 2020

gchatelet accepted D90453: [llvm-exegesis] Print signal name when the snippet crashed..
Oct 30 2020, 4:07 AM · Restricted Project

Oct 29 2020

gchatelet accepted D90380: [llvm-exegesis] Do not try to assign random registers twice..

Good catch! Thx a lot.

Oct 29 2020, 5:22 AM · Restricted Project

Oct 28 2020

gchatelet accepted D90289: [llvm-exegesis] Do not silently fail on unknown instruction encoding formats..
Oct 28 2020, 1:52 AM · Restricted Project

Oct 15 2020

gchatelet committed rGc400e01c6295: [libc][NFC] Add probability distributions for memory function sizes (authored by gchatelet).
[libc][NFC] Add probability distributions for memory function sizes
Oct 15 2020, 1:16 AM
gchatelet closed D89401: [libc][NFC] Add probability distributions for memory function sizes.
Oct 15 2020, 1:16 AM · Restricted Project
gchatelet updated the diff for D89401: [libc][NFC] Add probability distributions for memory function sizes.

rebase

Oct 15 2020, 1:01 AM · Restricted Project
gchatelet updated the diff for D89401: [libc][NFC] Add probability distributions for memory function sizes.
  • Update file comment
Oct 15 2020, 1:00 AM · Restricted Project
gchatelet updated the diff for D89401: [libc][NFC] Add probability distributions for memory function sizes.
  • Fix style warnings
Oct 15 2020, 12:03 AM · Restricted Project

Oct 14 2020

gchatelet requested review of D89401: [libc][NFC] Add probability distributions for memory function sizes.
Oct 14 2020, 9:35 AM · Restricted Project
gchatelet committed rGcba533febc1e: Fix conjuntion of -Werror,-Wsuggest-override with google/benchmark (authored by gchatelet).
Fix conjuntion of -Werror,-Wsuggest-override with google/benchmark
Oct 14 2020, 8:27 AM

Sep 28 2020

gchatelet accepted D88304: [llvm-exegesis][NFC] Let `ExegesisTarget::randomizeTargetMCOperand`.
Sep 28 2020, 12:37 PM · Restricted Project

Sep 15 2020

gchatelet committed rGc3fd2a50ba13: [libc] Remove special case for 8 and 16 bytes (authored by gchatelet).
[libc] Remove special case for 8 and 16 bytes
Sep 15 2020, 1:49 PM
gchatelet committed rGc19fda9aa073: [libc] use stddef instead of string header (authored by gchatelet).
[libc] use stddef instead of string header
Sep 15 2020, 1:13 PM
gchatelet committed rG00ba1a3de7fa: [libc] remove useless headers (authored by gchatelet).
[libc] remove useless headers
Sep 15 2020, 1:04 PM
gchatelet committed rGe328456a9e6f: [libc] Add missing TableGen dependency (authored by gchatelet).
[libc] Add missing TableGen dependency
Sep 15 2020, 7:26 AM
gchatelet closed D87689: [libc] Add missing TableGen dependency.
Sep 15 2020, 7:26 AM · Restricted Project
gchatelet committed rG00d6e7116c20: [libc] Add missing LibcFPTestHelpers library (authored by gchatelet).
[libc] Add missing LibcFPTestHelpers library
Sep 15 2020, 7:26 AM
gchatelet closed D87690: [libc] Add missing LibcFPTestHelpers library.
Sep 15 2020, 7:25 AM · Restricted Project
gchatelet committed rG85763e0758fb: [libc] Fix typo in platform_defs.h.inc (authored by gchatelet).
[libc] Fix typo in platform_defs.h.inc
Sep 15 2020, 7:25 AM
gchatelet closed D87687: [libc] Fix typo in platform_defs.h.inc.
Sep 15 2020, 7:25 AM · Restricted Project
gchatelet added a comment to D87687: [libc] Fix typo in platform_defs.h.inc.

BTW, you can submit all of these as obvious :)

Sep 15 2020, 7:24 AM · Restricted Project
gchatelet added a comment to D87690: [libc] Add missing LibcFPTestHelpers library.

How did you catch these? With dynamic linking enabled?

Sep 15 2020, 7:22 AM · Restricted Project
gchatelet requested review of D87690: [libc] Add missing LibcFPTestHelpers library.
Sep 15 2020, 5:50 AM · Restricted Project
gchatelet requested review of D87689: [libc] Add missing TableGen dependency.
Sep 15 2020, 5:49 AM · Restricted Project
gchatelet requested review of D87687: [libc] Fix typo in platform_defs.h.inc.
Sep 15 2020, 5:05 AM · Restricted Project

Sep 11 2020

gchatelet added inline comments to D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 11 2020, 1:08 AM · Restricted Project
gchatelet added inline comments to D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 11 2020, 1:05 AM · Restricted Project
gchatelet updated subscribers of D86066: IR: Merge MemCpyInlineInst and MemCpyInst.

Still requires updating more places that create new memcpys from existing ones to clean up this mess

Sep 11 2020, 1:04 AM · Restricted Project
gchatelet committed rGe38be7091ee3: [Clang] Clarify __builtin_memcpy_inline documentation (authored by gchatelet).
[Clang] Clarify __builtin_memcpy_inline documentation
Sep 11 2020, 12:21 AM
gchatelet closed D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 11 2020, 12:21 AM · Restricted Project

Sep 10 2020

gchatelet requested review of D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Sep 10 2020, 8:27 AM · Restricted Project
gchatelet committed rG05d02e5a4e54: Fix invalid link format in Clang LanguageExtension (authored by gchatelet).
Fix invalid link format in Clang LanguageExtension
Sep 10 2020, 5:28 AM
gchatelet committed rGed95f7c7ce18: Fix broken link for Sphinx installation (authored by gchatelet).
Fix broken link for Sphinx installation
Sep 10 2020, 5:28 AM
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.

rebase

Sep 10 2020, 2:42 AM · Restricted Project
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.
  • Use non trivial alignment in tests
Sep 10 2020, 2:39 AM · Restricted Project
gchatelet requested review of D87443: Encode alignment attribute for `cmpxchg`.
Sep 10 2020, 2:28 AM · Restricted Project

Sep 9 2020

gchatelet added inline comments to D83465: Encode alignment attribute for `atomicrmw`.
Sep 9 2020, 1:20 PM · Restricted Project
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.

rebase

Sep 9 2020, 1:19 PM · Restricted Project
gchatelet committed rG5a4a0cfcfb54: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD) (authored by gchatelet).
[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD)
Sep 9 2020, 12:11 PM
gchatelet closed D87373: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Sep 9 2020, 12:10 PM · Restricted Project
gchatelet requested review of D87373: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Sep 9 2020, 5:21 AM · Restricted Project

Sep 7 2020

gchatelet updated the summary of D82454: [ADT] Add Bitfield utilities - design #3.
Sep 7 2020, 9:07 AM · Restricted Project

Aug 31 2020

gchatelet accepted D86067: GlobalISel: Add opcode for llvm.memcpy.inline.

Thx a lot for adding support in GlobalISel

Aug 31 2020, 5:45 AM · Restricted Project

Jul 27 2020

gchatelet added a comment to D69668: Introduce a generic memset to bzero transformation in CodeGen.

A bunch of tests are still failing

LLVM :: CodeGen/AArch64/arm64-memset-to-bzero-pgso.ll
LLVM :: CodeGen/AArch64/arm64-memset-to-bzero.ll
LLVM :: CodeGen/Mips/indirect-jump-hazard/long-calls.ll
LLVM :: CodeGen/Mips/micromips-target-external-symbol-reloc.ll
LLVM :: CodeGen/X86/force-align-stack-alloca.ll
LLVM :: CodeGen/X86/pr36865.ll
LLVM :: CodeGen/X86/stack-clash-unknown-call.ll
LLVM :: Transforms/InferFunctionAttrs/annotate.ll
Jul 27 2020, 2:31 PM · Restricted Project
gchatelet updated the diff for D69668: Introduce a generic memset to bzero transformation in CodeGen.

rebase and revert unrelated changes.

Jul 27 2020, 2:30 PM · Restricted Project
gchatelet added a comment to D83533: [Alignment][NFC] Update Bitcodewriter to use Align.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

Jul 27 2020, 1:50 PM · Restricted Project
gchatelet committed rG754deffd11c7: [NFC] Move BitcodeCommon.h from Bitstream to Bitcode (authored by gchatelet).
[NFC] Move BitcodeCommon.h from Bitstream to Bitcode
Jul 27 2020, 1:49 PM
gchatelet added a comment to D83533: [Alignment][NFC] Update Bitcodewriter to use Align.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Jul 27 2020, 1:30 PM · Restricted Project
gchatelet committed rG1b4d24912a1f: [NFC] Replace ".size() < 1" with ".empty()" (authored by gchatelet).
[NFC] Replace ".size() < 1" with ".empty()"
Jul 27 2020, 6:55 AM