Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (171 w, 6 d)

Recent Activity

Tue, Sep 15

gchatelet committed rGc3fd2a50ba13: [libc] Remove special case for 8 and 16 bytes (authored by gchatelet).
[libc] Remove special case for 8 and 16 bytes
Tue, Sep 15, 1:49 PM
gchatelet committed rGc19fda9aa073: [libc] use stddef instead of string header (authored by gchatelet).
[libc] use stddef instead of string header
Tue, Sep 15, 1:13 PM
gchatelet committed rG00ba1a3de7fa: [libc] remove useless headers (authored by gchatelet).
[libc] remove useless headers
Tue, Sep 15, 1:04 PM
gchatelet committed rGe328456a9e6f: [libc] Add missing TableGen dependency (authored by gchatelet).
[libc] Add missing TableGen dependency
Tue, Sep 15, 7:26 AM
gchatelet closed D87689: [libc] Add missing TableGen dependency.
Tue, Sep 15, 7:26 AM · Restricted Project
gchatelet committed rG00d6e7116c20: [libc] Add missing LibcFPTestHelpers library (authored by gchatelet).
[libc] Add missing LibcFPTestHelpers library
Tue, Sep 15, 7:26 AM
gchatelet closed D87690: [libc] Add missing LibcFPTestHelpers library.
Tue, Sep 15, 7:25 AM · Restricted Project
gchatelet committed rG85763e0758fb: [libc] Fix typo in platform_defs.h.inc (authored by gchatelet).
[libc] Fix typo in platform_defs.h.inc
Tue, Sep 15, 7:25 AM
gchatelet closed D87687: [libc] Fix typo in platform_defs.h.inc.
Tue, Sep 15, 7:25 AM · Restricted Project
gchatelet added a comment to D87687: [libc] Fix typo in platform_defs.h.inc.

BTW, you can submit all of these as obvious :)

Tue, Sep 15, 7:24 AM · Restricted Project
gchatelet added a comment to D87690: [libc] Add missing LibcFPTestHelpers library.

How did you catch these? With dynamic linking enabled?

Tue, Sep 15, 7:22 AM · Restricted Project
gchatelet requested review of D87690: [libc] Add missing LibcFPTestHelpers library.
Tue, Sep 15, 5:50 AM · Restricted Project
gchatelet requested review of D87689: [libc] Add missing TableGen dependency.
Tue, Sep 15, 5:49 AM · Restricted Project
gchatelet requested review of D87687: [libc] Fix typo in platform_defs.h.inc.
Tue, Sep 15, 5:05 AM · Restricted Project

Fri, Sep 11

gchatelet added inline comments to D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Fri, Sep 11, 1:08 AM · Restricted Project
gchatelet added inline comments to D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Fri, Sep 11, 1:05 AM · Restricted Project
gchatelet updated subscribers of D86066: IR: Merge MemCpyInlineInst and MemCpyInst.

Still requires updating more places that create new memcpys from existing ones to clean up this mess

Fri, Sep 11, 1:04 AM · Restricted Project
gchatelet committed rGe38be7091ee3: [Clang] Clarify __builtin_memcpy_inline documentation (authored by gchatelet).
[Clang] Clarify __builtin_memcpy_inline documentation
Fri, Sep 11, 12:21 AM
gchatelet closed D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Fri, Sep 11, 12:21 AM · Restricted Project

Thu, Sep 10

gchatelet requested review of D87458: [Clang] Clarify __builtin_memcpy_inline documentation.
Thu, Sep 10, 8:27 AM · Restricted Project
gchatelet committed rG05d02e5a4e54: Fix invalid link format in Clang LanguageExtension (authored by gchatelet).
Fix invalid link format in Clang LanguageExtension
Thu, Sep 10, 5:28 AM
gchatelet committed rGed95f7c7ce18: Fix broken link for Sphinx installation (authored by gchatelet).
Fix broken link for Sphinx installation
Thu, Sep 10, 5:28 AM
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.

rebase

Thu, Sep 10, 2:42 AM · Restricted Project
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.
  • Use non trivial alignment in tests
Thu, Sep 10, 2:39 AM · Restricted Project
gchatelet requested review of D87443: Encode alignment attribute for `cmpxchg`.
Thu, Sep 10, 2:28 AM · Restricted Project

Wed, Sep 9

gchatelet added inline comments to D83465: Encode alignment attribute for `atomicrmw`.
Wed, Sep 9, 1:20 PM · Restricted Project
gchatelet updated the diff for D83465: Encode alignment attribute for `atomicrmw`.

rebase

Wed, Sep 9, 1:19 PM · Restricted Project
gchatelet committed rG5a4a0cfcfb54: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD) (authored by gchatelet).
[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD)
Wed, Sep 9, 12:11 PM
gchatelet closed D87373: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Wed, Sep 9, 12:10 PM · Restricted Project
gchatelet requested review of D87373: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Wed, Sep 9, 5:21 AM · Restricted Project

Mon, Sep 7

gchatelet updated the summary of D82454: [ADT] Add Bitfield utilities - design #3.
Mon, Sep 7, 9:07 AM · Restricted Project

Mon, Aug 31

gchatelet accepted D86067: GlobalISel: Add opcode for llvm.memcpy.inline.

Thx a lot for adding support in GlobalISel

Mon, Aug 31, 5:45 AM · Restricted Project

Jul 27 2020

gchatelet added a comment to D69668: Introduce a generic memset to bzero transformation in CodeGen.

A bunch of tests are still failing

LLVM :: CodeGen/AArch64/arm64-memset-to-bzero-pgso.ll
LLVM :: CodeGen/AArch64/arm64-memset-to-bzero.ll
LLVM :: CodeGen/Mips/indirect-jump-hazard/long-calls.ll
LLVM :: CodeGen/Mips/micromips-target-external-symbol-reloc.ll
LLVM :: CodeGen/X86/force-align-stack-alloca.ll
LLVM :: CodeGen/X86/pr36865.ll
LLVM :: CodeGen/X86/stack-clash-unknown-call.ll
LLVM :: Transforms/InferFunctionAttrs/annotate.ll
Jul 27 2020, 2:31 PM · Restricted Project
gchatelet updated the diff for D69668: Introduce a generic memset to bzero transformation in CodeGen.

rebase and revert unrelated changes.

Jul 27 2020, 2:30 PM · Restricted Project
gchatelet added a comment to D83533: [Alignment][NFC] Update Bitcodewriter to use Align.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

Jul 27 2020, 1:50 PM · Restricted Project
gchatelet committed rG754deffd11c7: [NFC] Move BitcodeCommon.h from Bitstream to Bitcode (authored by gchatelet).
[NFC] Move BitcodeCommon.h from Bitstream to Bitcode
Jul 27 2020, 1:49 PM
gchatelet added a comment to D83533: [Alignment][NFC] Update Bitcodewriter to use Align.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Jul 27 2020, 1:30 PM · Restricted Project
gchatelet committed rG1b4d24912a1f: [NFC] Replace ".size() < 1" with ".empty()" (authored by gchatelet).
[NFC] Replace ".size() < 1" with ".empty()"
Jul 27 2020, 6:55 AM
gchatelet accepted D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..
Jul 27 2020, 2:35 AM · Restricted Project
gchatelet added a reviewer for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old.: gchatelet.
Jul 27 2020, 2:17 AM · Restricted Project
gchatelet committed rGd9bbe85943f6: [Alignment][NFC] Update Bitcodewriter to use Align (authored by gchatelet).
[Alignment][NFC] Update Bitcodewriter to use Align
Jul 27 2020, 1:17 AM
gchatelet closed D83533: [Alignment][NFC] Update Bitcodewriter to use Align.
Jul 27 2020, 1:17 AM · Restricted Project
gchatelet accepted D84585: Fix a comment error in stack object part .
Jul 27 2020, 12:45 AM · Restricted Project

Jul 23 2020

gchatelet added a comment to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).

To connect the dots for anyone following along: this was reverted in cc28058c13e89ecc85dac7e1bd5d13a2ce1bb620.

Jul 23 2020, 9:08 AM · Restricted Project
gchatelet accepted D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

LGTM

Jul 23 2020, 12:31 AM · Restricted Project

Jul 15 2020

gchatelet resigned from D83745: [ARM] Optimize immediate selection.
Jul 15 2020, 1:23 AM · Restricted Project

Jul 10 2020

gchatelet accepted D83540: [NFC] Change isFPPredicate comparison to ignore lower bound.

LGTM

Jul 10 2020, 2:04 AM · Restricted Project
gchatelet updated the diff for D83533: [Alignment][NFC] Update Bitcodewriter to use Align.
  • Remove newline in BitCodes.h
Jul 10 2020, 1:12 AM · Restricted Project
gchatelet updated the diff for D83533: [Alignment][NFC] Update Bitcodewriter to use Align.
  • update reader as well and address comments
Jul 10 2020, 1:11 AM · Restricted Project

Jul 9 2020

Herald added a project to D83533: [Alignment][NFC] Update Bitcodewriter to use Align: Restricted Project.
Jul 9 2020, 11:30 PM · Restricted Project
gchatelet added a comment to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.

@courbet I'm still willing to push this one. Shall I remove [NFC] and call it a day?
AFAICT it's the only show stopper here.

Jul 9 2020, 9:34 PM · Restricted Project
gchatelet committed rG30582457b470: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD) (authored by gchatelet).
[NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD)
Jul 9 2020, 9:28 PM
gchatelet closed D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Jul 9 2020, 9:28 PM · Restricted Project
gchatelet added inline comments to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).
Jul 9 2020, 9:18 PM · Restricted Project
gchatelet added a comment to D83380: [libc][benchmark] Add display option to render.py3.

Thanks for the contribution @avieira : )

Jul 9 2020, 5:28 AM · Restricted Project
gchatelet accepted D83380: [libc][benchmark] Add display option to render.py3.
Jul 9 2020, 5:24 AM · Restricted Project
gchatelet requested changes to D83380: [libc][benchmark] Add display option to render.py3.
Jul 9 2020, 2:05 AM · Restricted Project
Herald added a project to D83465: Encode alignment attribute for `atomicrmw`: Restricted Project.
Jul 9 2020, 1:29 AM · Restricted Project

Jul 8 2020

gchatelet added a comment to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).

This patch splits the two implementations, moves a few lines and simplifies the code by inferring constant values.
The semantic is unchanged.

Jul 8 2020, 2:41 AM · Restricted Project
Herald added a project to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD): Restricted Project.
Jul 8 2020, 2:35 AM · Restricted Project

Jul 7 2020

gchatelet committed rGabdd367b200a: [Bitfields][NFC] Make sure bitfields are contiguous (authored by gchatelet).
[Bitfields][NFC] Make sure bitfields are contiguous
Jul 7 2020, 7:35 AM
gchatelet closed D83202: [Bitfields][NFC] Make sure bitfields are contiguous.
Jul 7 2020, 7:35 AM · Restricted Project
gchatelet updated the diff for D83202: [Bitfields][NFC] Make sure bitfields are contiguous.

rebase

Jul 7 2020, 6:59 AM · Restricted Project
gchatelet updated the diff for D83202: [Bitfields][NFC] Make sure bitfields are contiguous.
  • Various nits
Jul 7 2020, 3:09 AM · Restricted Project
gchatelet updated the diff for D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.

rebase

Jul 7 2020, 3:00 AM · Restricted Project
gchatelet committed rG74c723757e69: [NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst (authored by gchatelet).
[NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst
Jul 7 2020, 2:54 AM
gchatelet closed D83136: [NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst.
Jul 7 2020, 2:54 AM · Restricted Project
gchatelet added inline comments to D83136: [NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst.
Jul 7 2020, 2:50 AM · Restricted Project
gchatelet updated the diff for D83202: [Bitfields][NFC] Make sure bitfields are contiguous.
  • Address comments
Jul 7 2020, 2:03 AM · Restricted Project
gchatelet added a comment to D83192: Fix off by one error in Bitfields.

Can you add a unit test for this ?

Jul 7 2020, 12:08 AM · Restricted Project

Jul 6 2020

gchatelet updated the diff for D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.

rebase

Jul 6 2020, 2:58 AM · Restricted Project
gchatelet added inline comments to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.
Jul 6 2020, 2:51 AM · Restricted Project
Herald added a project to D83202: [Bitfields][NFC] Make sure bitfields are contiguous: Restricted Project.
Jul 6 2020, 2:33 AM · Restricted Project
gchatelet committed rG4c0a965c0926: Fix off by one error in Bitfields (authored by gchatelet).
Fix off by one error in Bitfields
Jul 6 2020, 1:52 AM
gchatelet closed D83192: Fix off by one error in Bitfields.
Jul 6 2020, 1:52 AM · Restricted Project
gchatelet added a comment to D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.

Fixed by rG04288e93be7bbcdca5707d84149e864923f9ed25

Jul 6 2020, 1:46 AM · Restricted Project
gchatelet committed rG04288e93be7b: Fix 46594 - Alignment assertion failure in instcombine (authored by gchatelet).
Fix 46594 - Alignment assertion failure in instcombine
Jul 6 2020, 1:45 AM
gchatelet added a comment to D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.

Thank you for reporting the issue and providing a reduced test case.
I'm working on a fix.

Jul 6 2020, 1:37 AM · Restricted Project
Herald added a project to D83192: Fix off by one error in Bitfields: Restricted Project.
Jul 6 2020, 1:00 AM · Restricted Project

Jul 3 2020

gchatelet added inline comments to D79279: Add overloaded versions of builtin mem* functions.
Jul 3 2020, 1:04 PM · Restricted Project, Restricted Project
gchatelet created D83136: [NFC] Adding the align attribute on Atomic{CmpXchg|RMW}Inst.
Jul 3 2020, 10:12 AM · Restricted Project
gchatelet committed rG063258eb6e32: [Alignment][NFC] Use 5 bits to store Instructions Alignment (authored by gchatelet).
[Alignment][NFC] Use 5 bits to store Instructions Alignment
Jul 3 2020, 2:08 AM
gchatelet closed D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
Jul 3 2020, 2:07 AM · Restricted Project
gchatelet updated the diff for D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
  • Address comments
Jul 3 2020, 2:07 AM · Restricted Project
gchatelet added inline comments to D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
Jul 3 2020, 2:07 AM · Restricted Project
gchatelet committed rG87e2751cf07c: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and… (authored by gchatelet).
[Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and…
Jul 3 2020, 1:36 AM
gchatelet closed D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.
Jul 3 2020, 1:35 AM · Restricted Project
gchatelet updated the diff for D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
  • Remove assert and move implementation in header
Jul 3 2020, 1:35 AM · Restricted Project
gchatelet updated the summary of D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
Jul 3 2020, 1:35 AM · Restricted Project
gchatelet created D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.
Jul 3 2020, 1:35 AM · Restricted Project
gchatelet committed rG3587c9c4275b: [NFC] Use ADT/Bitfields in Instructions (authored by gchatelet).
[NFC] Use ADT/Bitfields in Instructions
Jul 3 2020, 12:30 AM
gchatelet closed D81662: [NFC] Use ADT/Bitfields in Instructions.
Jul 3 2020, 12:29 AM · Restricted Project

Jul 2 2020

gchatelet added a comment to D81662: [NFC] Use ADT/Bitfields in Instructions.

I'll submit this if nobody objects

Jul 2 2020, 2:35 PM · Restricted Project
gchatelet updated the diff for D81662: [NFC] Use ADT/Bitfields in Instructions.

rebase

Jul 2 2020, 2:35 PM · Restricted Project
gchatelet created D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.
Jul 2 2020, 2:03 PM · Restricted Project
gchatelet committed rG8dbafd24d6da: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment (authored by gchatelet).
[Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment
Jul 2 2020, 4:48 AM
gchatelet committed rGd2dcff60fe23: [Alignment][NFC] VectorLayout now uses Align internally (authored by gchatelet).
[Alignment][NFC] VectorLayout now uses Align internally
Jul 2 2020, 4:48 AM
gchatelet closed D82977: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment.
Jul 2 2020, 4:48 AM · Restricted Project
gchatelet closed D82981: [Alignment][NFC] VectorLayout now uses Align internally.
Jul 2 2020, 4:48 AM · Restricted Project
gchatelet added a reviewer for D81662: [NFC] Use ADT/Bitfields in Instructions: courbet.
Jul 2 2020, 1:34 AM · Restricted Project