Page MenuHomePhabricator

fpichet (Francois Pichet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2017, 6:15 AM (177 w, 3 d)

Recent Activity

Oct 23 2020

fpichet added a comment to D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743).

What is the status of this patch?
Can it be committed?
It helps for our out of tree fork of lldb.

Oct 23 2020, 12:26 PM · Restricted Project

Sep 8 2020

fpichet added a comment to D75808: [ValueTracking] isKnownNonZero, computeKnownBits for freeze.

Another thing: I noticed that SelectionDAG::computeKnownBits doesn't deal with ISD::FREEZE.
Would it be ok to just call computeKnownBits (Op.getOperand(0)) to make it work.
(Since Select_FREEZE just lower to a copy)

Sep 8 2020, 6:52 AM · Restricted Project

Sep 7 2020

fpichet added a comment to D75808: [ValueTracking] isKnownNonZero, computeKnownBits for freeze.

What is the status of this patch?
I've seen cases in a out of tree target where an optimization dependent on ValueTracking was not performed because there was a freeze in the way.

Sep 7 2020, 3:50 PM · Restricted Project

May 29 2020

fpichet added a comment to D53005: Implement machine unroller utility class.

I am working on an out of tree target and this would be useful.
So what is the status of this patch?

May 29 2020, 1:06 PM

Jan 15 2019

fpichet accepted D50432: [DAGCombiner] Reduce load widths of shifted masks.

I tried your patch and the bug is gone. Thanks.

Jan 15 2019, 7:42 AM

Jan 14 2019

fpichet added a comment to D50432: [DAGCombiner] Reduce load widths of shifted masks.

For example:

Jan 14 2019, 8:04 AM

Jan 13 2019

fpichet reopened D50432: [DAGCombiner] Reduce load widths of shifted masks.

I recently resynced an out of tree backend and I got a miscompile because of this commit.
My target is Big Endian.
The C code is :

void swap(unsigned *ptr) {
  *ptr = (*ptr & 0x0000ff00 ) << 8;		
}
Jan 13 2019, 7:37 PM

Jul 25 2017

fpichet committed rL308960: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.
Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT
Jul 25 2017, 2:42 AM
fpichet closed D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT by committing rL308960: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.
Jul 25 2017, 2:42 AM

Jul 17 2017

fpichet added a comment to D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.

is it ok to commit now?

Jul 17 2017, 11:34 AM

Jul 11 2017

fpichet updated the diff for D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.

Update patch with fix for endianness bug in visitEXTRACT_VECTOR_ELT.

Jul 11 2017, 7:47 PM
fpichet added a comment to D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.
Jul 11 2017, 1:30 PM
fpichet updated the summary of D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.
Jul 11 2017, 1:29 PM
fpichet updated the diff for D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.

Update patch taking into account vector size > 2
Also reuse existing isLE variable.

Jul 11 2017, 4:02 AM

Jul 5 2017

fpichet updated the diff for D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.

Added test case

Jul 5 2017, 8:00 PM

Jul 4 2017

fpichet created D34990: Fix endianness bug in DAGCombiner::visitTRUNCATE and visitEXTRACT_VECTOR_ELT.
Jul 4 2017, 11:13 AM