Page MenuHomePhabricator

ergawy (Kareem Ergawy)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:26 AM (193 w, 2 d)

Recent Activity

Fri, Oct 23

ergawy updated the diff for D90022: [MLIR][SPIRV] Start module combiner..
  • Remove trivial braces.
Fri, Oct 23, 8:10 AM · Restricted Project
ergawy updated the diff for D90022: [MLIR][SPIRV] Start module combiner..
  • Add copyright headers.
Fri, Oct 23, 7:15 AM · Restricted Project
ergawy added inline comments to D90022: [MLIR][SPIRV] Start module combiner..
Fri, Oct 23, 4:03 AM · Restricted Project
ergawy requested review of D90022: [MLIR][SPIRV] Start module combiner..
Fri, Oct 23, 3:50 AM · Restricted Project

Mon, Oct 12

ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Rebase.
Mon, Oct 12, 2:55 AM · Restricted Project

Thu, Oct 8

ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

Ping! Is it ok to merge this patch now? (I don't have commit access).

Thu, Oct 8, 3:54 AM · Restricted Project

Tue, Oct 6

ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

Thanks for the review!

Tue, Oct 6, 6:21 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Rebase and handle review comments.
Tue, Oct 6, 6:17 AM · Restricted Project

Mon, Oct 5

ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Update tests to reflect latest master changes.
Mon, Oct 5, 2:28 AM · Restricted Project
ergawy updated the diff for D88732: [MLIR][SPIRV] Extend _reference_of to support SpecConstantCompositeOp..
  • Merge remote-tracking branch 'origin/master' into mlir/spirv/support_op_spec_constant_composite
Mon, Oct 5, 1:17 AM · Restricted Project

Fri, Oct 2

ergawy added a comment to D88732: [MLIR][SPIRV] Extend _reference_of to support SpecConstantCompositeOp..

Looks like I misunderstood how stacked reviews work and that's why the CI fails. Is there a workflow that you can share for creating such stacks of reviews?

Fri, Oct 2, 5:49 AM · Restricted Project
ergawy updated the diff for D88732: [MLIR][SPIRV] Extend _reference_of to support SpecConstantCompositeOp..
  • Rebase (testing how stacked reviews work).
Fri, Oct 2, 5:44 AM · Restricted Project
ergawy updated the diff for D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..
  • Rebase (testing how stacked reviews work).
Fri, Oct 2, 5:42 AM · Restricted Project
ergawy requested review of D88732: [MLIR][SPIRV] Extend _reference_of to support SpecConstantCompositeOp..
Fri, Oct 2, 5:34 AM · Restricted Project
ergawy updated the diff for D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..
  • Update Op docs.
Fri, Oct 2, 2:25 AM · Restricted Project
ergawy added a comment to D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..

@antiagainst , thanks a lot for the prompt review.

Fri, Oct 2, 1:56 AM · Restricted Project
ergawy updated the diff for D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..
  • Handle review comments.
Fri, Oct 2, 1:53 AM · Restricted Project

Thu, Oct 1

ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

Sorry for the delay; I have a little one to my family recently so that eats into my time and effort greatly. :)

No worries and thanks for taking the time @antiagainst.

Thu, Oct 1, 5:59 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Handle review comments.
Thu, Oct 1, 5:52 AM · Restricted Project

Wed, Sep 30

ergawy updated the summary of D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..
Wed, Sep 30, 7:07 AM · Restricted Project
ergawy requested review of D88568: [MLIR][SPIRV] Add initial support for OpSpecConstantComposite..
Wed, Sep 30, 7:06 AM · Restricted Project
ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

@ftynse thanks for the approval, I appreciate you taking the time for a careful review (and apologies for always forgetting to remove trivial braces, in my personal coding I like to always add them :D. But if that's the style mostly followed in MLIR then I will follow it as closely as possible).

Wed, Sep 30, 1:39 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Handle review comments.
Wed, Sep 30, 1:35 AM · Restricted Project

Mon, Sep 28

ergawy updated the diff for D88090: [WIP][mlir] Add struct context to parsing..
  • Rebase.
Mon, Sep 28, 4:15 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Rebase.
Mon, Sep 28, 3:44 AM · Restricted Project

Sep 22 2020

ergawy added inline comments to D88090: [WIP][mlir] Add struct context to parsing..
Sep 22 2020, 5:35 AM · Restricted Project
ergawy added inline comments to D88090: [WIP][mlir] Add struct context to parsing..
Sep 22 2020, 5:30 AM · Restricted Project
ergawy added a comment to D88090: [WIP][mlir] Add struct context to parsing..

This is an attempt to address a comment on this review: https://reviews.llvm.org/D87206 to provide a common mechanism for maintaining the struct parsing stack.

Sep 22 2020, 5:29 AM · Restricted Project
ergawy requested review of D88090: [WIP][mlir] Add struct context to parsing..
Sep 22 2020, 5:26 AM · Restricted Project
ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

Ping! :). I guess all comments from @ftynse are handled now. Please have another look whenever is suitable for you.

Sep 22 2020, 3:15 AM · Restricted Project

Sep 18 2020

ergawy updated the summary of D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 18 2020, 8:58 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Run clang-format.
Sep 18 2020, 8:53 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Remove some trivial braces.
Sep 18 2020, 8:29 AM · Restricted Project
ergawy added inline comments to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 18 2020, 8:19 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Handle some style-related review comments.
  • Use mutate to properly set an identified struct's body.
  • Add more docs to StructTypeStorage.
  • Add more checking to StructTypeStorage::mutate().
Sep 18 2020, 8:10 AM · Restricted Project
ergawy added a comment to D87692: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips..

Thanks @mravishankar for the approval. If there are no doubts about the registration part can you please commit on my behalf? I don't have commit access.

Sep 18 2020, 7:03 AM · Restricted Project

Sep 16 2020

ergawy updated the diff for D87692: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips..

Rebase.

Sep 16 2020, 11:35 PM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Handle review comments
Sep 16 2020, 9:13 AM · Restricted Project

Sep 15 2020

ergawy added a comment to D87692: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips..

Failures seem totally unrelated.

Sep 15 2020, 9:25 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Clean-up, add more docs, and rebase.
Sep 15 2020, 9:16 AM · Restricted Project
ergawy requested review of D87692: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips..
Sep 15 2020, 7:35 AM · Restricted Project

Sep 14 2020

ergawy added inline comments to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 14 2020, 9:15 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Rebase
  • Handle review comments: = Get rid of lookup logic.
Sep 14 2020, 8:58 AM · Restricted Project

Sep 9 2020

ergawy added inline comments to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 9 2020, 12:16 AM · Restricted Project

Sep 8 2020

ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Use thread_local instead of static.
Sep 8 2020, 11:37 PM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Rename some tests.
Sep 8 2020, 8:34 AM · Restricted Project
ergawy added inline comments to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 8 2020, 8:15 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Some more clean-up.
Sep 8 2020, 7:40 AM · Restricted Project
ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Get rid of getStructContext() that was added for printing.
  • Get rid of getStructContext() that was added for parsing.
  • Rebase on top of master.
Sep 8 2020, 7:25 AM · Restricted Project

Sep 7 2020

ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..
  • Run clang-format.
Sep 7 2020, 8:57 AM · Restricted Project
ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

I have concerns about several aspects of what you are doing here. Blocking until I have time to review.

Sep 7 2020, 2:47 AM · Restricted Project

Sep 6 2020

ergawy updated the diff for D87206: [MLIR][SPIRV] Support identified and recursive structs..

Remove debug prints.

Sep 6 2020, 10:23 AM · Restricted Project
ergawy added a comment to D87206: [MLIR][SPIRV] Support identified and recursive structs..

There are still a few TODOs and of course more testing is also needed. Just wanted to make sure that there are no major objections to how I approached things here.

Sep 6 2020, 10:18 AM · Restricted Project
ergawy requested review of D87206: [MLIR][SPIRV] Support identified and recursive structs..
Sep 6 2020, 10:09 AM · Restricted Project

Jul 9 2020

ergawy added inline comments to D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Jul 9 2020, 8:40 AM · Restricted Project
ergawy updated the diff for D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Split template functions into twins.

Jul 9 2020, 8:36 AM · Restricted Project

Jul 8 2020

ergawy added a comment to D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Unfortunately, this still produces a cryptic error on VS2017:

##[error]mlir\lib\Dialect\SPIRV\SPIRVOps.cpp(2865,0): Error C1001: An internal error has occurred in the compiler.
   597>E:\agent\_work\4\s\mlir\lib\Dialect\SPIRV\SPIRVOps.cpp(2865): fatal error C1001: An internal error has occurred in the compiler. [E:\agent\_work\4\b\llvm\tools\mlir\lib\Dialect\SPIRV\obj.MLIRSPIRV.vcxproj]
         (compiler file 'msc1.cpp', line 1518)
          To work around this problem, try simplifying or changing the program near the locations listed above.
Jul 8 2020, 11:48 PM · Restricted Project
ergawy updated the diff for D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Add more docs.

Jul 8 2020, 8:32 AM · Restricted Project

Jul 6 2020

ergawy added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

@rriddle Thanks for your comments. I handled them but in this review: https://reviews.llvm.org/D83241. This one had to be reverted due to some internal error in MSVC.

Jul 6 2020, 11:43 PM · Restricted Project
ergawy updated the diff for D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Handle some small review comments:

Jul 6 2020, 11:41 PM · Restricted Project
ergawy updated the diff for D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Get rid of decltype inside template.

Jul 6 2020, 9:56 AM · Restricted Project
ergawy updated the summary of D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Jul 6 2020, 9:52 AM · Restricted Project
Herald added a project to D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.: Restricted Project.
Jul 6 2020, 9:51 AM · Restricted Project

Jul 3 2020

ergawy added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Hey @ergawy, I reverted this in https://reviews.llvm.org/D83075. This causes a VS2017 MSVC internal compiler bug: http://lab.llvm.org:8011/builders/mlir-windows/builds/4147/steps/build-unified-tree/logs/stdio. I don't know the exact reason; maybe due to the templating or decltype? Might want to cherry-pick the original patch and then modify it to avoid using those "advanced" features to give it a try.

I can help to take a look after coming back from the long weekend. Sorry about the back and forth!

Jul 3 2020, 12:30 AM · Restricted Project

Jul 2 2020

ergawy retitled D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory. from [MLIR][SPIRV] Support 2 memory access attributes in OpCopyMemory. to [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Jul 2 2020, 8:05 AM · Restricted Project
ergawy updated the diff for D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Update commit title.

Jul 2 2020, 8:05 AM · Restricted Project
ergawy added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

It seems that I still don't have commit access. Just to be sure that I didn't do anything wrong. Here what I tried:
1 - I squashed all the commits in my local dev branch into one. Also in the commit messages cleaned up the unnecessary Arcanist tags except for Differential Revision: ...
2 - Rebased on top of master.
3 - Changed the active branch to master.
4 - Cherry picked the squashed commit from step 1.
5 - Tried to: git push.

Jul 2 2020, 12:29 AM · Restricted Project

Jun 30 2020

ergawy added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

@antiagainst Thanks for the review. Handled the issues.

Jun 30 2020, 6:28 AM · Restricted Project
ergawy updated the diff for D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
  • Add TODO to verify the case of 2 two memroy access operands.
  • Better style to test verification failure.
  • Update CopyMemory production rule in docs.
  • Handle review comments:
Jun 30 2020, 6:28 AM · Restricted Project

Jun 28 2020

ergawy updated the diff for D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
  • Update CopyMemory production rule in docs.
Jun 28 2020, 7:04 AM · Restricted Project
ergawy updated the diff for D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
  • Better style to test verification failure.
Jun 28 2020, 7:04 AM · Restricted Project
ergawy updated the diff for D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
  • Add TODO to verify the case of 2 two memroy access operands.
Jun 28 2020, 2:49 AM · Restricted Project
ergawy created D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Jun 28 2020, 2:14 AM · Restricted Project

Jun 26 2020

ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 26 2020, 7:03 AM · Restricted Project

Jun 25 2020

ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 25 2020, 8:00 AM · Restricted Project
ergawy updated the diff for D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
  • Print attr dictionary.
Jun 25 2020, 8:00 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 25 2020, 7:26 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 25 2020, 6:53 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 25 2020, 6:53 AM · Restricted Project
ergawy updated the diff for D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
  • Rename template type arg.
Jun 25 2020, 6:53 AM · Restricted Project
ergawy updated the diff for D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
  • Rearrange code after rebase.
Jun 25 2020, 6:52 AM · Restricted Project
ergawy updated the diff for D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
  • Add verification function for OpCopyMemory.
  • Add tests for printing and verifying maa.
Jun 25 2020, 6:24 AM · Restricted Project

Jun 24 2020

ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 24 2020, 6:27 AM · Restricted Project

Jun 23 2020

ergawy added a comment to D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

@antiagainst Sorry for the noise, but I don't think there anything I can do regarding the failures happening on CI here. Can you please have a look and tell if I am mistaken?

Jun 23 2020, 8:31 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 23 2020, 7:58 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 23 2020, 7:58 AM · Restricted Project
ergawy added inline comments to D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 23 2020, 7:58 AM · Restricted Project
ergawy updated the diff for D82384: [MLIR][SPIRV] Add support for OpCopyMemory..

Remove comments added during development.

Jun 23 2020, 7:58 AM · Restricted Project
ergawy created D82384: [MLIR][SPIRV] Add support for OpCopyMemory..
Jun 23 2020, 7:58 AM · Restricted Project
ergawy abandoned D82380: Add test with memory access operands..
Jun 23 2020, 7:26 AM · Restricted Project
ergawy added a comment to D82380: Add test with memory access operands..

Comitted by mistake, abandoned.

Jun 23 2020, 7:26 AM · Restricted Project
ergawy created D82380: Add test with memory access operands..
Jun 23 2020, 7:26 AM · Restricted Project

Jun 22 2020

ergawy updated the diff for D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

Rebase on top of master again.

Jun 22 2020, 8:35 AM · Restricted Project
ergawy added a comment to D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

Sorry for the mess. It seems that CI fails only for Linux for some reason. Will try to find my around. Any tips are much appreciated.

Jun 22 2020, 8:35 AM · Restricted Project
ergawy added a comment to D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

It seems you accidentally deleted the first commit. You can choose the base SHA to diff against when using arc diff <base-sha-to-diff-against>. the patch is against a non-existing commit; I see errors when trying to apply it to the top of the tree. Could you rebase against the top of the tree so I can land it? Thanks.

Jun 22 2020, 7:30 AM · Restricted Project
ergawy updated the diff for D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

Rebase on top of master.

Jun 22 2020, 7:30 AM · Restricted Project
ergawy updated the diff for D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

arc diff against master.

Jun 22 2020, 7:30 AM · Restricted Project
ergawy updated the diff for D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

Squash commits.

Jun 22 2020, 7:30 AM · Restricted Project

Jun 18 2020

ergawy updated the diff for D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..

Create wrapper script and wrap lines at 80 chars.

Jun 18 2020, 3:14 AM · Restricted Project

Jun 17 2020

ergawy created D82006: [MLIR][SPIRV] Extend automation script to generate coverage report..
Jun 17 2020, 5:53 AM · Restricted Project