Page MenuHomePhabricator

enh (Elliott Hughes)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2015, 4:56 PM (284 w, 2 d)

Recent Activity

Sep 18 2020

enh requested review of D87950: Make libc++ headers "just work" on all Android versions..
Sep 18 2020, 3:05 PM · Restricted Project

Aug 24 2020

enh added a comment to D86321: Fix test for D77924..

sorry about the breakage... thanks for testing on real hardware!

Aug 24 2020, 3:34 PM · Restricted Project
enh committed rG96a979c0c295: Fix test for D77924. (authored by enh).
Fix test for D77924.
Aug 24 2020, 3:33 PM
enh closed D86321: Fix test for D77924..
Aug 24 2020, 3:33 PM · Restricted Project

Aug 21 2020

enh added reviewers for D86321: Fix test for D77924.: EricWF, ldionne.
Aug 21 2020, 4:00 PM · Restricted Project
enh added a comment to D86321: Fix test for D77924..

The test got failed again. I got the following output:

ubuntu@jetson8:~$ ./t.tmp.exe
Testing 29715 symbols.
1ILeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE -> <-0x1.cecececececececececececececep+11983L
Got instead: <-0x1.cecececececececececececececep+11983L>
t.tmp.exe: C:/buildbot/temp/llvm-project/libcxxabi/test/test_demangle.pass.cpp:30001: void testFPLiterals(): Assertion `false' failed.
Aborted (core dumped)

looks like it does not expect trailing >.

Aug 21 2020, 10:46 AM · Restricted Project
enh updated the diff for D86321: Fix test for D77924..

Address vvereschaka's comment.

Aug 21 2020, 10:45 AM · Restricted Project

Aug 20 2020

enh added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

I ran the test directly on our aarch64 board.

Aug 20 2020, 4:02 PM · Restricted Project, Restricted Project
enh requested review of D86321: Fix test for D77924..
Aug 20 2020, 4:01 PM · Restricted Project
enh added a comment to D77924: ld128 demangle: allow space for 'L' suffix..
Aug 20 2020, 9:49 AM · Restricted Project, Restricted Project

Aug 18 2020

enh added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

(sorry, didn't see these comments until after i'd git pushed. i've failed to set up gmail filters so i see the mail i need to see without drowning in thousands of mails i don't need to see :-( )

Aug 18 2020, 4:27 PM · Restricted Project, Restricted Project
enh committed rGa7d0b7a786c7: ld128 demangle: allow space for 'L' suffix. (authored by enh).
ld128 demangle: allow space for 'L' suffix.
Aug 18 2020, 4:15 PM
enh closed D77924: ld128 demangle: allow space for 'L' suffix..
Aug 18 2020, 4:14 PM · Restricted Project, Restricted Project

Jun 25 2020

enh updated the diff for D77924: ld128 demangle: allow space for 'L' suffix..

clang-format the new test (but leave the other 30kloc).

Jun 25 2020, 4:23 PM · Restricted Project, Restricted Project
enh added a comment to D77924: ld128 demangle: allow space for 'L' suffix..
In D77924#2088349, @enh wrote:

Is it possible to add a test to always trigger this bug?

only if you run with hwasan.

Do the current tests fail under hwasan? If not, please add a test case that fails under hwasan, it's better than nothing.

Jun 25 2020, 1:05 PM · Restricted Project, Restricted Project
enh updated the diff for D77924: ld128 demangle: allow space for 'L' suffix..

Add test.

Jun 25 2020, 1:05 PM · Restricted Project, Restricted Project

Jun 11 2020

enh updated the diff for D77924: ld128 demangle: allow space for 'L' suffix..

Use actual upper bound.

Jun 11 2020, 1:47 PM · Restricted Project, Restricted Project
enh added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

Is it possible to add a test to always trigger this bug?

Jun 11 2020, 1:47 PM · Restricted Project, Restricted Project

Apr 10 2020

enh created D77924: ld128 demangle: allow space for 'L' suffix..
Apr 10 2020, 5:47 PM · Restricted Project, Restricted Project

Nov 11 2019

enh added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

actually, it looks like clang is inlining the code for all the is*_l
functions anyway. you're paying for the indirection on
strcoll_l/strxfrm_l/wcscoll_l/wcsxfrm_l, but no one should be using
those anyway.

Nov 11 2019, 8:04 AM · Restricted Project

Nov 7 2019

enh added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

honestly, if it was me, i'd keep all these inlines even for current releases: inlining a call to the underlying function saves you a layer of useless cruft at runtime. (the Android "implementations" are just one-liners that drop the extra argument and call the underlying function, just like these inlines.)

Nov 7 2019, 9:30 PM · Restricted Project

Nov 6 2019

enh created D69929: Fix _LIBCPP_HAS_ definitions for Android..
Nov 6 2019, 9:09 PM · Restricted Project

Jul 16 2019

enh added a comment to D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

i assume the idea here is "all libc++ mutexes are covered by RAII anyway, so there's no value to the error checking"?

Jul 16 2019, 9:31 AM

Sep 19 2018

enh updated subscribers of D52251: [builtins] Add __emutls_unregister_key function.

yeah, we always used the low numbers internally.

Sep 19 2018, 4:05 PM

Jul 14 2015

enh added a comment to D10522: Implement target independent TLS compatible with glibc's emutls.c..

not really though --- i think you're getting that from libgcc. so
although short term you don't need to add this stuff to compiler-rt to
test, it will be necessary for anyone not using libgcc. (like us, at
some point in the future.)

Jul 14 2015, 3:49 PM