Page MenuHomePhabricator

ekovanov (elena)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 16 2020, 3:53 AM (20 w, 1 d)

Recent Activity

Tue, Nov 24

ekovanov added a comment to D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision..

Yes, it's disabled by default. To enable this code the option -DLLVM_USE_INTEL_JITEVENTS=ON should be used.

Tue, Nov 24, 8:36 PM · Restricted Project
ekovanov retitled D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision. from [MCJIT]: Add cmake variables to support llorg builds to [MCJIT] Add cmake variables to customize ittapi git location and revision..
Tue, Nov 24, 8:10 PM · Restricted Project
ekovanov updated the diff for D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision..

fixed llvm/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt:15
CMAKE_CURRENT_SOURCE_DIR -> ITTAPI_SOURCE_DIR

Tue, Nov 24, 10:37 AM · Restricted Project

Mon, Nov 23

ekovanov added a comment to D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision..

Hi @etyurin ,
I do not have commit access - could you please land it?

Mon, Nov 23, 9:28 AM · Restricted Project

Sun, Nov 22

ekovanov requested review of D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision..
Sun, Nov 22, 10:17 AM · Restricted Project

Thu, Nov 12

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

friendly reminder

Thu, Nov 12, 1:09 PM · Restricted Project

Nov 4 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Hi Lang,

Nov 4 2020, 10:17 AM · Restricted Project

Oct 29 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Thanks a lot for your help!
Being very new here, I do not have commit access to land this, could you please land this?

Hi Elena,

I missed that this included a definition of a git submodule. This would be the first in the main LLVM tree and I think we'd need to ask the community about inclusion. Is it required for this patch, or could it be dropped and downloading of that module left to clients who want to enable Intel JIT events support?

Hi Lang!

At my opinion, to add submodule is a good solution for open source project to be up to date with ITT API source.
The alternative solution - just add necessary source files from ITT API to the llvm/lib/ExecutionEngine/IntelJITEvents/ directory and manually update them from time to time.
How do you think, what is better to implement in my case?

I'm not opposed to submodules, but I think you would need to start a thread on LLVM dev about it: I'm not the right person to approve that change.

In the interim, if you would like to land the rest of this patch, do you think it would be reasonable to require clients using intel JIT events to manually create and checkout the submodule? I think that would only be a couple of extra lines when setting up an LLVM checkout, right?

Oct 29 2020, 1:41 PM · Restricted Project
ekovanov updated the diff for D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

removed git submodule, added cmake action to clone ittapi repo

Oct 29 2020, 1:35 PM · Restricted Project

Oct 28 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Thanks a lot for your help!
Being very new here, I do not have commit access to land this, could you please land this?

Hi Elena,

I missed that this included a definition of a git submodule. This would be the first in the main LLVM tree and I think we'd need to ask the community about inclusion. Is it required for this patch, or could it be dropped and downloading of that module left to clients who want to enable Intel JIT events support?

Oct 28 2020, 12:13 PM · Restricted Project

Oct 23 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Thanks a lot for your help!
Being very new here, I do not have commit access to land this, could you please land this?

Oct 23 2020, 5:55 AM · Restricted Project

Oct 22 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

It's not clear to me that Elena's patch should affect this. I'm inclined to accept it and just keep an eye on the bots. If everything passes we can chalk it up to a misconfig on Harbormaster. If the bots fail we can revert, and maybe the logs will give us some more insight into what's going on.

Oct 22 2020, 10:29 AM · Restricted Project

Oct 20 2020

ekovanov updated subscribers of D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

There are several failed tests for both Linux and Windows in "Build Status" section of this review.
The vast majority of failed tests is related to lldb.

Oct 20 2020, 3:49 AM · Restricted Project

Oct 7 2020

ekovanov updated subscribers of D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Hi @lhames @andrew.w.kaylor

Looking at "Build Status" for the last diff, I can see 29 tests failed (windows) and 41 tests failed (linux).
do you think that tests failures are related to my commit?
Thank you in advance!

Hi Elena,

I can't be sure from the error messages -- I don't know the relevant profiling or LLDB APIs well enough. Are you able to reproduce any of them when you build locally?

Oct 7 2020, 11:11 AM · Restricted Project

Sep 9 2020

ekovanov updated the diff for D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

added submodule update command

Sep 9 2020, 1:56 PM · Restricted Project

Sep 4 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Looking at "Build Status" for the last diff, I can see 29 tests failed (windows) and 41 tests failed (linux).
do you think that tests failures are related to my commit?
Thank you in advance!

Sep 4 2020, 6:28 AM · Restricted Project

Sep 2 2020

ekovanov updated the diff for D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

corrections for pre-merge checks

Sep 2 2020, 12:17 PM · Restricted Project
ekovanov updated the diff for D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

updated diff with remarks for pre-merge checks

Sep 2 2020, 2:56 AM · Restricted Project

Aug 25 2020

ekovanov added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

I'm not familiar with the profiling listeners. Out of interest: Is the backwards compatibility mode necessary? Is there a plan to deprecate it in the future?

Aug 25 2020, 12:59 PM · Restricted Project
ekovanov updated the diff for D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

corrected indents that were reported by pre-merge checks

Aug 25 2020, 12:34 PM · Restricted Project

Aug 24 2020

ekovanov requested review of D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.
Aug 24 2020, 2:21 AM · Restricted Project