Page MenuHomePhabricator

dylanmckay (Dylan McKay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:21 AM (267 w, 1 h)

Recent Activity

Mon, Sep 21

dylanmckay added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

Hey @aykevl, could you please confirm that this patch looks okay?

Mon, Sep 21, 1:26 AM · Restricted Project

Aug 27 2020

dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:01 AM · Restricted Project, Restricted Project
dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:00 AM · Restricted Project, Restricted Project
dylanmckay requested changes to D78491: Avoid relying on address space zero default parameter in llvm/IR.
Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project
dylanmckay added a comment to D78491: Avoid relying on address space zero default parameter in llvm/IR.

Note to the readers: A recent-ish llvm-dev discussion around this patch can be found in here whrein a consensus is found on the way forward on this patch.

Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project

Aug 26 2020

dylanmckay added inline comments to D70947: Add a default address space for globals to DataLayout.
Aug 26 2020, 9:28 AM · Restricted Project
dylanmckay added a comment to D70947: Add a default address space for globals to DataLayout.

I've split the backwards compat tests and AMDGPU changes out to D84345. Is the DataLayout upgrade what you meant with bitcode compatibility tests or should I be adding additional tests?

Aug 26 2020, 9:26 AM · Restricted Project
dylanmckay accepted D86418: [AVR] Improve inline rotate/shift expansions.

Great patch

Aug 26 2020, 8:59 AM · Restricted Project
dylanmckay requested review of D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Aug 26 2020, 8:28 AM · Restricted Project

Aug 24 2020

dylanmckay added a comment to D85589: Add support for AVR attiny441 and attiny841.

@ixoo committed in 0f0be3fb8ddeca4bbcffc7b22319254c360ca24b - thanks for the patch!

Aug 24 2020, 1:36 AM · Restricted Project
dylanmckay committed rG0f0be3fb8dde: Add support for AVR attiny441 and attiny841 (authored by ixoo).
Add support for AVR attiny441 and attiny841
Aug 24 2020, 1:36 AM
dylanmckay closed D85589: Add support for AVR attiny441 and attiny841.
Aug 24 2020, 1:36 AM · Restricted Project

Aug 11 2020

dylanmckay accepted D85589: Add support for AVR attiny441 and attiny841.

Looks good, thanks for the patch. Do you need someone to commit this for you @ixoo?

Aug 11 2020, 6:56 AM · Restricted Project
dylanmckay requested changes to D82684: AVR Backend: Add harvard program address space checker pass.
Aug 11 2020, 5:10 AM · Restricted Project
dylanmckay added a comment to D82684: AVR Backend: Add harvard program address space checker pass.

Patch is looking really good, only suggestions are the adding a test and a couple formatting nitpicks.

Aug 11 2020, 5:10 AM · Restricted Project

Jun 23 2020

dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 4:12 AM
dylanmckay committed rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the… (authored by dylanmckay).
Revert "[AVR] Explicitly set the address of the data section when invoking the…
Jun 23 2020, 3:40 AM
dylanmckay added a reverting change for rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker: rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the….
Jun 23 2020, 3:40 AM
dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 3:40 AM
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Thanks for the patch @rodrigorc, appreciate it!

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Committed in

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay committed rGb9c26a9cfe53: [AVR] Rewrite the function calling convention. (authored by dylanmckay).
[AVR] Rewrite the function calling convention.
Jun 23 2020, 2:37 AM
dylanmckay closed D68524: [AVR] Rewrite the function calling convention..
Jun 23 2020, 2:37 AM · Restricted Project

Jun 19 2020

dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Rebased version with @Sh4rK's comments fixed.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

@Sh4rK your review is always welcome - I've updated the code with your comments, here's the delta containing just the fixes you've suggested.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

This conflicts with master now, he's a rebased patch

Jun 19 2020, 6:59 AM · Restricted Project

Jun 18 2020

dylanmckay committed rG01741d6dbec1: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay committed rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory" (authored by dylanmckay).
Revert "[AVR] Remove duplicate specification of lib directory"
Jun 18 2020, 10:52 PM
dylanmckay added a reverting change for rG03b0831144a9: [AVR] Remove duplicate specification of lib directory: rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory".
Jun 18 2020, 10:52 PM
dylanmckay committed rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay closed D77334: [AVR] Remove duplicate specification of lib directory.
Jun 18 2020, 10:52 PM · Restricted Project
dylanmckay added a comment to D77334: [AVR] Remove duplicate specification of lib directory.

Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82088: [AVR] Disassemble instructions with fixed Z operand.

Note: I don't know whether the way I've made the Z register printable is the correct way. Maybe the register should be added to the MCInst instead.

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82093: [AVR] Disassemble double register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81971: [AVR] Disassemble multiplication instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81968: [AVR] Decode single register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78459: [AVR] Don't adjust for instruction size.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78439: [AVR] Fix miscompilation of zext + add.

Good reproduction, works exactly as expected and indeed this value is being miscalculated.

Jun 18 2020, 4:52 AM · Restricted Project

Jun 17 2020

dylanmckay requested changes to D81968: [AVR] Decode single register instructions.
Jun 17 2020, 11:11 PM · Restricted Project
dylanmckay requested changes to D81971: [AVR] Disassemble multiplication instructions.

Couple of nitpicks, otherwise good to go.

Jun 17 2020, 11:11 PM · Restricted Project
dylanmckay accepted D81961: [AVR] Implement disassembly of 32-bit instructions.
Jun 17 2020, 11:11 PM · Restricted Project

Jun 16 2020

dylanmckay accepted D78581: [AVR] Remove faulty stack pushing behavior.

This is good, this is good. Nice work @aykevl, approved.

Jun 16 2020, 4:58 AM · Restricted Project
dylanmckay accepted D78579: [AVR] Fix stack size in functions with a frame pointer.

Added an integration test case

Jun 16 2020, 4:23 AM · Restricted Project

Jun 14 2020

dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Also, you may already know about it but if not, the LLVM bugpoint tool can usually heavily reduce testcase size. I usually get 99% cutdown from some of the larger IR files. If the file must be large though, it must be large (as some tests are) so let's add it anyway.

Jun 14 2020, 4:17 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Ok, I can add the test case (need to recompile LLVM first). It just seems a bit large to me (over 1000 lines).

Jun 14 2020, 4:17 AM · Restricted Project

Jun 8 2020

dylanmckay accepted D81099: [AVR][test] Remove test for naked function containing a return..
Jun 8 2020, 11:25 PM · Restricted Project

May 31 2020

dylanmckay requested changes to D78741: [LLD][ELF][AVR] Implement the missing relocation types.
May 31 2020, 5:19 AM · Restricted Project, lld
dylanmckay added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

I've checked over all of the relocation logic, cross referenced with both the AVR ISA manual and the AVR LLVM fixture implementations in AVRAsmBackend.cpp - everything looks consistent to me.

May 31 2020, 5:19 AM · Restricted Project, lld
dylanmckay requested changes to D78459: [AVR] Don't adjust for instruction size.
May 31 2020, 4:47 AM · Restricted Project
dylanmckay requested changes to D70947: Add a default address space for globals to DataLayout.
May 31 2020, 4:47 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Are you planning on adding these integration tests to the LLVM buildbot or something more manual?

May 31 2020, 4:47 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Added an integration test for this and verified that the test does indeed miscompile and crash the AVR simulator before the patch, but work correctly afterwards. The testcase output is also consistent with AVR-GCC.

May 31 2020, 4:47 AM · Restricted Project

May 30 2020

dylanmckay added inline comments to D78459: [AVR] Don't adjust for instruction size.
May 30 2020, 7:05 PM · Restricted Project

May 17 2020

dylanmckay committed rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker (authored by dylanmckay).
[AVR] Explicitly set the address of the data section when invoking the linker
May 17 2020, 7:27 AM
dylanmckay committed rG1420f4efbe7c: [AVR] Fix I/O instructions on XMEGA (authored by dylanmckay).
[AVR] Fix I/O instructions on XMEGA
May 17 2020, 1:01 AM
dylanmckay committed rG1335737ee119: [LLVM][AVR] Support for R_AVR_6 fixup (authored by dylanmckay).
[LLVM][AVR] Support for R_AVR_6 fixup
May 17 2020, 1:01 AM
dylanmckay closed D78721: [LLVM][AVR] Support for R_AVR_6 fixup.
May 17 2020, 1:01 AM · Restricted Project
dylanmckay closed D77207: [AVR] Fix I/O instructions on XMEGA.
May 17 2020, 1:01 AM · Restricted Project
dylanmckay added a comment to D78721: [LLVM][AVR] Support for R_AVR_6 fixup.

@LemonBoy merged in into master in 1335737ee119b59bc25ee6d1bb200cf3b975e196

May 17 2020, 1:01 AM · Restricted Project
dylanmckay added a comment to D77207: [AVR] Fix I/O instructions on XMEGA.

@vlastik Merged into master in 1420f4efbe7ca34355b2dd85d396197d92cd5e3f.

May 17 2020, 1:01 AM · Restricted Project

May 16 2020

dylanmckay added a comment to D77221: [AVR] Rework MCU family detection to support more AVR MCUs.

A thought: should the AVR family be included in the target triple? Like avr5-unknown-unknown (similar to armv6m-none-eabi, armv7m-none-eabi, etc).
The different variations do sometimes change the architecture in incompatible ways, such as with the call instruction which pushes a return address of two or three bytes depending on the architecture variant (and thus makes it impossible to pass parameters on the stack reliably).

May 16 2020, 9:44 PM · Restricted Project, Restricted Project
dylanmckay added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

Good question, I wasn't able to find any document online.
All the info I've used come from this ISA manual and by feeding some asm into ld to see if the result matched my expectations.

May 16 2020, 8:40 PM · Restricted Project, lld
dylanmckay requested changes to D78491: Avoid relying on address space zero default parameter in llvm/IR.
May 16 2020, 8:40 PM · Restricted Project, Restricted Project
Herald added a project to D78491: Avoid relying on address space zero default parameter in llvm/IR: Restricted Project.

I really like the idea behind this patch, but I suspect there is a better way to go about it.

May 16 2020, 8:40 PM · Restricted Project, Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Hey @aykevl, I like this patch, it definitely removes a special cases that intuitively feels like it should not need to be there. Nice work

May 16 2020, 8:08 PM · Restricted Project
dylanmckay added a comment to D70947: Add a default address space for globals to DataLayout.

Reposting a comment from Matt from earlier

May 16 2020, 8:08 PM · Restricted Project

May 10 2020

dylanmckay accepted D78721: [LLVM][AVR] Support for R_AVR_6 fixup.

Nice work @LemonBoy, thanks for the patch.

May 10 2020, 11:57 PM · Restricted Project
dylanmckay accepted D74049: [AVR] Implement disassembly support for I/O instructions.
May 10 2020, 11:24 PM · Restricted Project

Apr 21 2020

dylanmckay added a comment to D78491: Avoid relying on address space zero default parameter in llvm/IR.

should help targets such as AVR than use a non-zero program address space.

Apr 21 2020, 3:44 AM · Restricted Project, Restricted Project

Apr 18 2020

dylanmckay requested changes to D77221: [AVR] Rework MCU family detection to support more AVR MCUs.
Apr 18 2020, 11:58 PM · Restricted Project, Restricted Project
dylanmckay requested changes to D78439: [AVR] Fix miscompilation of zext + add.
Apr 18 2020, 11:25 PM · Restricted Project
dylanmckay added a comment to D78439: [AVR] Fix miscompilation of zext + add.

I'm not sure that this is a miscompile. Note that AVR has no "add with immediate" instruction, instead subsumed by the "subtract with immediate" instruction, which of course with immediate values being immediately known to the compiler, can be negated directly at the callsite to effectively form a "add with immediate" instruction.

Apr 18 2020, 11:25 PM · Restricted Project
dylanmckay accepted D78212: [AVR] Do not place functions in .progmem.data.

Good catch, great fix.

Apr 18 2020, 8:28 PM · Restricted Project
dylanmckay accepted D78437: [AVR] Do not use divmod calls for bigger integers.
Apr 18 2020, 8:28 PM · Restricted Project
dylanmckay accepted D77207: [AVR] Fix I/O instructions on XMEGA.

Really nice work, it's good to go.

Apr 18 2020, 7:56 PM · Restricted Project

Apr 11 2020

dylanmckay added a comment to D77207: [AVR] Fix I/O instructions on XMEGA.

Nice work, I didn't know of this particular XMEGA quirk.

Apr 11 2020, 1:34 AM · Restricted Project
dylanmckay accepted D77334: [AVR] Remove duplicate specification of lib directory.

Nice catch, cheers.

Apr 11 2020, 1:34 AM · Restricted Project

Apr 1 2020

dylanmckay committed rG57fd86de879c: [AVR] Fix function pointer address space (authored by vlastik).
[AVR] Fix function pointer address space
Apr 1 2020, 1:37 AM
dylanmckay closed D77119: [AVR] Fix function pointer address space.
Apr 1 2020, 1:37 AM · Restricted Project

Mar 31 2020

dylanmckay accepted D77119: [AVR] Fix function pointer address space.
Mar 31 2020, 4:56 AM · Restricted Project
dylanmckay added a comment to D77119: [AVR] Fix function pointer address space.

Nice work @vlastik, do you need someone to commit this for you?

Mar 31 2020, 4:56 AM · Restricted Project

Mar 30 2020

dylanmckay committed rG7b808b105f6a: [AVR] Generalize the previous interrupt bugfix to signal handlers too (authored by dylanmckay).
[AVR] Generalize the previous interrupt bugfix to signal handlers too
Mar 30 2020, 11:58 PM
dylanmckay committed rG339b34266c1b: [AVR] Respect the 'interrupt' function attribute (authored by dylanmckay).
[AVR] Respect the 'interrupt' function attribute
Mar 30 2020, 11:25 PM
dylanmckay added a comment to D76182: [AVR] Support aliases in non-zero address space.

I think we should add a test, it shouldn't be too hard I think.

Mar 30 2020, 11:25 PM · Restricted Project
dylanmckay added a comment to D76182: [AVR] Support aliases in non-zero address space.

Nice patch by the way, the code looks fine, if we can get a basic test in here then it's good to go

Mar 30 2020, 11:25 PM · Restricted Project

Mar 18 2020

dylanmckay committed rZORGe6568e907d70: Revert "[AVR] Use 'avr-unknown-unknown' as the default target triple" (authored by dylanmckay).
Revert "[AVR] Use 'avr-unknown-unknown' as the default target triple"
Mar 18 2020, 4:52 AM
dylanmckay added a reverting change for rZORGf4ceb905ff6f: [AVR] Use 'avr-unknown-unknown' as the default target triple: rZORGe6568e907d70: Revert "[AVR] Use 'avr-unknown-unknown' as the default target triple".
Mar 18 2020, 4:52 AM

Mar 16 2020

dylanmckay committed rG56aed6144a16: [AVR] Add a release note about the AVR backend becoming an official backend (authored by dylanmckay).
[AVR] Add a release note about the AVR backend becoming an official backend
Mar 16 2020, 12:16 AM

Mar 15 2020

dylanmckay committed rZORGf4ceb905ff6f: [AVR] Use 'avr-unknown-unknown' as the default target triple (authored by dylanmckay).
[AVR] Use 'avr-unknown-unknown' as the default target triple
Mar 15 2020, 10:51 PM

Mar 12 2020

dylanmckay committed rGc480c584a0b7: [AVR] Include AVR by default in LLVM builds (authored by dylanmckay).
[AVR] Include AVR by default in LLVM builds
Mar 12 2020, 9:54 PM
dylanmckay committed rG2cf4b4de0c7b: [AVR] Fix reads of uninitialized variables from constructor of AVRSubtarget (authored by dylanmckay).
[AVR] Fix reads of uninitialized variables from constructor of AVRSubtarget
Mar 12 2020, 5:14 AM
dylanmckay committed rG13be27482e53: [AVR] Fix read of uninitialized variable AVRSubtarget:::ELFArch (authored by dylanmckay).
[AVR] Fix read of uninitialized variable AVRSubtarget:::ELFArch
Mar 12 2020, 4:30 AM
dylanmckay committed rG9059056e273c: Revert "[AVR] Include AVR by default in LLVM builds" (authored by dylanmckay).
Revert "[AVR] Include AVR by default in LLVM builds"
Mar 12 2020, 12:09 AM
dylanmckay added a reverting change for rGdfecec65e679: [AVR] Include AVR by default in LLVM builds: rG9059056e273c: Revert "[AVR] Include AVR by default in LLVM builds".
Mar 12 2020, 12:09 AM

Mar 11 2020

dylanmckay committed rGdfecec65e679: [AVR] Include AVR by default in LLVM builds (authored by dylanmckay).
[AVR] Include AVR by default in LLVM builds
Mar 11 2020, 11:18 PM
dylanmckay closed D75099: [AVR] Include AVR by default in LLVM builds.
Mar 11 2020, 11:18 PM · Restricted Project

Mar 10 2020

dylanmckay added a comment to D75099: [AVR] Include AVR by default in LLVM builds.

I'm keen to get at least one more approval before merging this one.

Mar 10 2020, 10:17 PM · Restricted Project

Mar 6 2020

dylanmckay added a comment to D75099: [AVR] Include AVR by default in LLVM builds.

The AVR buildbot has been running successfully for a few days now: http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/63.

Mar 6 2020, 7:18 PM · Restricted Project

Mar 4 2020

dylanmckay added a comment to D75595: [AVR][NFC] Use Register instead of unsigned.

LGTM

Mar 4 2020, 5:06 AM · Restricted Project
dylanmckay added inline comments to D75595: [AVR][NFC] Use Register instead of unsigned.
Mar 4 2020, 4:34 AM · Restricted Project