Page MenuHomePhabricator

dstenb (David Stenberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2016, 1:55 AM (240 w, 6 d)

Recent Activity

Tue, Jan 5

dstenb added a comment to D90020: [AArch64][SVE] Emit DWARF location expression for SVE stack objects..

I'm sorry for chiming in so late here! I have a comment about the prependOffsetExpression target hook.

Thanks for the suggestion, you made a good point that this interface was error prone when new flags are added in the future. I've updated the patch and added the virtual interface getOffsetOpcodes alongside prependOffsetExpression (made non-virtual and now handles the Deref, Stack/Entry Value). Let me know if this is how you imagined it.

Tue, Jan 5, 2:00 AM · Restricted Project

Dec 15 2020

dstenb added inline comments to D90020: [AArch64][SVE] Emit DWARF location expression for SVE stack objects..
Dec 15 2020, 8:25 AM · Restricted Project
dstenb added a comment to D90020: [AArch64][SVE] Emit DWARF location expression for SVE stack objects..

I'm sorry for chiming in so late here! I have a comment about the prependOffsetExpression target hook.

Dec 15 2020, 8:23 AM · Restricted Project

Dec 10 2020

dstenb added a comment to D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts.
In D76146#2438388, @mib wrote:

Hi @dstenb, any update on this ? I tried to look for DW_OP_LLVM_convert_generic in the codebase but couldn't find any occurence ... Thanks.

Dec 10 2020, 8:56 AM · Restricted Project, debug-info

Dec 8 2020

dstenb accepted D92851: [DebugInfo][NFC] Refactor BinOp and GEP salvaging in salvageDebugInfoImpl out to separate functions.

Thanks!

Dec 8 2020, 9:17 AM · Restricted Project, debug-info

Dec 7 2020

dstenb accepted D92471: [CSInfo] Do not create CSInfo for undef arguments.

As both the emission of the IMPLICIT_DEF instructions in SelectionDAG, and the resolving of those instructions in "Process Implicit Definitions", is target independent code, I think it would be sufficient with only keeping one of these test cases, but I would be fine with landed this with all five.

Dec 7 2020, 2:50 AM · debug-info, Restricted Project

Dec 2 2020

dstenb added a comment to D92471: [CSInfo] Do not create CSInfo for undef arguments.

I think it would be preferable if we could do this in a target independent place, so that downstream targets, and upstream targets that do not yet support call sites, do not have to care about this.

Dec 2 2020, 7:23 AM · debug-info, Restricted Project

Nov 26 2020

dstenb committed rG384996f9e18f: [IndVarSimplify] Fix Modified status when handling dead PHI nodes (authored by dstenb).
[IndVarSimplify] Fix Modified status when handling dead PHI nodes
Nov 26 2020, 5:29 AM
dstenb closed D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.
Nov 26 2020, 5:28 AM · Restricted Project
dstenb added a comment to D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32.

What is the status of the expensive check failure? It has been present for five days now. Should we revert this patch until that is resolved?

Nov 26 2020, 1:13 AM · Restricted Project

Nov 25 2020

dstenb added a comment to D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.

Please move the test out of MIPS-specific into general test directory if it's possible. Otherwise, LGTM.

Nov 25 2020, 2:26 PM · Restricted Project
dstenb updated the diff for D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.

Use X86 reproducer instead.

Nov 25 2020, 2:24 PM · Restricted Project

Nov 19 2020

dstenb committed rG2d1f471e45af: [Mach0] Fix unused-variable warnings (authored by ehjogab).
[Mach0] Fix unused-variable warnings
Nov 19 2020, 1:52 AM
dstenb closed D91519: [AST][Mach0] Fix unused-variable warnings.
Nov 19 2020, 1:52 AM · Restricted Project, Restricted Project

Nov 18 2020

dstenb added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

I took the liberty to add some review comments whilst familiarizing myself with the code.

Nov 18 2020, 9:24 AM · debug-info, Restricted Project
dstenb added inline comments to D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.
Nov 18 2020, 2:53 AM · Restricted Project
dstenb added inline comments to D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.
Nov 18 2020, 12:49 AM · Restricted Project
dstenb added a comment to D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.

I'm not very familiar with the IndVars pass, so I have not idea if this is the correct way to solve this.

This seems correct to me, but I'm not familiar with IndVar either, so maybe someone else should take a look.
However, I think it would be better if we can return false in this case (i.e. if all PHI nodes created in rewriteLoopExitValues are dead).
But I don't know whether there's some edge case that forces us to return true here.

Nov 18 2020, 12:43 AM · Restricted Project

Nov 12 2020

dstenb accepted D91083: [AsmPrinter] fix -disable-debug-info option.

Thanks! This looks good to me.

Nov 12 2020, 2:15 AM · Restricted Project

Nov 10 2020

dstenb added a comment to D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.

I'm not very familiar with the IndVars pass, so I have not idea if this is the correct way to solve this.

Nov 10 2020, 5:23 AM · Restricted Project
dstenb requested review of D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes.
Nov 10 2020, 5:22 AM · Restricted Project

Nov 5 2020

dstenb added a comment to D89613: make the AsmPrinterHandler array public.

The .cfi_startproc directive is part of the unwind information (eh_frame), and is not debug info, so that seems like a possible bugfix even? I'd expect that observation to be consistent with the goal of this PR, though I didn't see specifically where that pass was being affected in a cursory glance back through the PR.

Nov 5 2020, 9:40 AM · Restricted Project

Oct 29 2020

dstenb added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 29 2020, 3:55 AM · debug-info, Restricted Project

Oct 22 2020

dstenb committed rG13edfcc97d29: [DebugInfo] Clear subreg in setDebugValueUndef() (authored by dstenb).
[DebugInfo] Clear subreg in setDebugValueUndef()
Oct 22 2020, 11:51 PM
dstenb closed D89941: [DebugInfo] Clear subreg in setDebugValueUndef().
Oct 22 2020, 11:51 PM · debug-info, Restricted Project
dstenb requested review of D89941: [DebugInfo] Clear subreg in setDebugValueUndef().
Oct 22 2020, 2:54 AM · debug-info, Restricted Project

Oct 20 2020

dstenb committed rG0c0fcea557e4: Handle value uses wrapped in metadata for the use-list order (authored by dstenb).
Handle value uses wrapped in metadata for the use-list order
Oct 20 2020, 11:11 AM
dstenb closed D53758: Handle value uses wrapped in metadata for the use-list order.
Oct 20 2020, 11:11 AM · Restricted Project
dstenb added a comment to D53758: Handle value uses wrapped in metadata for the use-list order.

I totally lost track of this :/.

The patch looks correct, thanks very much for tracking this down. This LGTM if you add an explanation to the testcase of exactly what it’s testing (I worry it’s not obvious for someone trying to update the test later).

Oct 20 2020, 10:28 AM · Restricted Project
dstenb updated the diff for D53758: Handle value uses wrapped in metadata for the use-list order.

Rebase, and update comment in test case.

Oct 20 2020, 10:27 AM · Restricted Project

Oct 9 2020

dstenb added a comment to D88808: [X86] Defer the creation of LCMPXCHG16B_SAVE_RBX until finalize-isel.

This seems to have broken the expensive-checks build bots:

Oct 9 2020, 2:43 AM · Restricted Project

Oct 7 2020

dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

If I understand this correctly, the new {EntryValue, EntryExpr} operands do, if EntryExpr is not undef, specify a location that is identical to the dbg.value's current {Value, Expr} operands, but with DW_OP_LLVM_entry_value implicitly being applied to EntryValue before EntryExpr. Is that correct?

Oct 7 2020, 2:01 AM · Restricted Project, debug-info

Oct 6 2020

dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

Some minor code style comments while I look into this.

Oct 6 2020, 7:07 AM · Restricted Project, debug-info

Sep 29 2020

dstenb added a comment to D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.

I added a comment about eliminateTrunc to the commit message. I'll see if I can create a reproducer for that, and if so, I'll upload a revision for that.

Sep 29 2020, 4:23 AM · Restricted Project
dstenb committed rGe6f332ef1e41: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics (authored by dstenb).
[IndVarSimplify] Fix Modified status for removal of overflow intrinsics
Sep 29 2020, 4:22 AM
dstenb closed D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.
Sep 29 2020, 4:21 AM · Restricted Project

Sep 24 2020

dstenb accepted D87233: [POC][DebugInfo] Use entry values within IR.

I'm equally fine with doing the Implicit flag change here, or for someone to do it in a separate patch.

Sep 24 2020, 3:16 PM · Restricted Project, debug-info

Sep 23 2020

dstenb added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 23 2020, 6:25 AM · Restricted Project, debug-info

Sep 22 2020

dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

Sorry for a piecemeal review from my part!

Sep 22 2020, 3:07 PM · Restricted Project, debug-info

Sep 14 2020

dstenb committed rGbfcb824ba528: [JumpThreading] Fix an incorrect Modified status (authored by dstenb).
[JumpThreading] Fix an incorrect Modified status
Sep 14 2020, 1:37 AM
dstenb closed D87392: [JumpThreading] Fix an incorrect Modified status.
Sep 14 2020, 1:37 AM · Restricted Project
dstenb added a comment to D87392: [JumpThreading] Fix an incorrect Modified status.

Thanks for the review!

Sep 14 2020, 12:41 AM · Restricted Project

Sep 10 2020

dstenb added a comment to D86812: [DebugInstrRef][1/3] Track PHI values through register allocation.

Just some drive-by nits while familiarizing myself with this patch series.

Sep 10 2020, 9:01 AM · Restricted Project
dstenb updated the diff for D87392: [JumpThreading] Fix an incorrect Modified status.

Continue using a bool return instead of a tri-state.

Sep 10 2020, 12:27 AM · Restricted Project
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Sep 10 2020, 12:03 AM · Restricted Project, debug-info

Sep 9 2020

dstenb updated the summary of D87392: [JumpThreading] Fix an incorrect Modified status.
Sep 9 2020, 9:30 AM · Restricted Project
dstenb requested review of D87392: [JumpThreading] Fix an incorrect Modified status.
Sep 9 2020, 9:30 AM · Restricted Project
dstenb committed rG48fc78143876: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks (authored by dstenb).
[UnifyFunctionExitNodes] Fix Modified status for unreachable blocks
Sep 9 2020, 4:36 AM
dstenb closed D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Sep 9 2020, 4:36 AM · Restricted Project
dstenb added inline comments to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Sep 9 2020, 4:31 AM · Restricted Project

Sep 8 2020

dstenb added a comment to D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.

Thanks, and sorry for overlooking the comments!

Sep 8 2020, 11:44 AM · Restricted Project
dstenb committed rG17dce2fe43c9: [UnifyFunctionExitNodes] Remove unused getters, NFC (authored by dstenb).
[UnifyFunctionExitNodes] Remove unused getters, NFC
Sep 8 2020, 11:43 AM
dstenb closed D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.
Sep 8 2020, 11:42 AM · Restricted Project
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Sep 8 2020, 6:24 AM · Restricted Project, debug-info
dstenb added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Sep 8 2020, 6:09 AM · Restricted Project, debug-info
dstenb added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

I will go through this more deeply, but just an initial comment is that I think it may be worth considering splitting it into two patches, in order to make it easier to review:

Sep 8 2020, 5:55 AM · Restricted Project, debug-info

Sep 3 2020

dstenb added inline comments to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Sep 3 2020, 6:25 AM · Restricted Project
dstenb added a reviewer for D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks: bjope.
Sep 3 2020, 6:24 AM · Restricted Project
dstenb updated the diff for D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.

Address review comments.

Sep 3 2020, 6:23 AM · Restricted Project
dstenb accepted D87024: [DebugInfo] Fix emitting DWARF64 .debug_macro[.dwo] sections (17/19)..

LGTM!

Sep 3 2020, 5:58 AM · debug-info, Restricted Project
dstenb requested review of D87078: [UnifyFunctionExitNodes] Remove unused getters, NFC.
Sep 3 2020, 2:18 AM · Restricted Project

Sep 2 2020

dstenb added a comment to D85837: [GlobalOpt] Fix incorrect Modified status.

Thanks for the review!

Sep 2 2020, 6:03 AM · Restricted Project
dstenb committed rG6d36b22b219f: [GlobalOpt] Fix an incorrect Modified status (authored by dstenb).
[GlobalOpt] Fix an incorrect Modified status
Sep 2 2020, 6:02 AM
dstenb closed D85837: [GlobalOpt] Fix incorrect Modified status.
Sep 2 2020, 6:02 AM · Restricted Project

Sep 1 2020

dstenb added inline comments to D85837: [GlobalOpt] Fix incorrect Modified status.
Sep 1 2020, 6:21 AM · Restricted Project
dstenb added a comment to D85837: [GlobalOpt] Fix incorrect Modified status.

Ping.

Sep 1 2020, 2:53 AM · Restricted Project

Aug 24 2020

dstenb added a comment to D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.

Gentle ping. I was not sure which reviews to add to this one, since the code has mostly remained unchanged since its original introduction in 2004, except for it being affected by wider changes.

Aug 24 2020, 6:45 AM · Restricted Project

Aug 20 2020

dstenb committed rG8206257cb86b: [GlobalOpt] Fix an incorrect Modified status (authored by dstenb).
[GlobalOpt] Fix an incorrect Modified status
Aug 20 2020, 2:54 AM
dstenb committed rG7a1029fd1e41: Reland "[LoopUnswitch] Fix incorrect Modified status" (authored by dstenb).
Reland "[LoopUnswitch] Fix incorrect Modified status"
Aug 20 2020, 2:53 AM
dstenb closed D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 20 2020, 2:53 AM · Restricted Project
dstenb added a comment to D86149: [GlobalOpt] Fix another incorrect Modified status.

I'll land this with a comment added to the test case in the meanwhile.

Aug 20 2020, 2:38 AM · Restricted Project
dstenb added a reverting change for rGdfd447c22043: [LoopUnswitch] Fix incorrect Modified status: rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status".
Aug 20 2020, 2:15 AM
dstenb committed rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status" (authored by dstenb).
Revert "[LoopUnswitch] Fix incorrect Modified status"
Aug 20 2020, 2:15 AM
dstenb added a reverting change for D86085: [LoopUnswitch] Fix incorrect Modified status: rGca688ae49759: Revert "[LoopUnswitch] Fix incorrect Modified status".
Aug 20 2020, 2:15 AM · Restricted Project
dstenb committed rGdfd447c22043: [LoopUnswitch] Fix incorrect Modified status (authored by dstenb).
[LoopUnswitch] Fix incorrect Modified status
Aug 20 2020, 12:05 AM
dstenb closed D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 20 2020, 12:05 AM · Restricted Project

Aug 19 2020

dstenb added inline comments to D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 19 2020, 2:52 PM · Restricted Project

Aug 18 2020

dstenb added inline comments to D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 18 2020, 11:41 PM · Restricted Project
dstenb added a reviewer for D85837: [GlobalOpt] Fix incorrect Modified status: efriedma.
Aug 18 2020, 9:36 AM · Restricted Project
dstenb requested review of D86149: [GlobalOpt] Fix another incorrect Modified status.
Aug 18 2020, 9:36 AM · Restricted Project
dstenb requested review of D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 18 2020, 9:18 AM · Restricted Project
dstenb added a comment to D86085: [LoopUnswitch] Fix incorrect Modified status.

If you'd be able to add reproducers in follow up patch, that would be great.

Aug 18 2020, 9:17 AM · Restricted Project
dstenb updated the diff for D86085: [LoopUnswitch] Fix incorrect Modified status.

Slight refactoring of the existing test case, and add test cases for the other two returns.

Aug 18 2020, 9:16 AM · Restricted Project

Aug 17 2020

dstenb requested review of D86085: [LoopUnswitch] Fix incorrect Modified status.
Aug 17 2020, 9:10 AM · Restricted Project
dstenb added inline comments to D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.
Aug 17 2020, 12:23 AM · Restricted Project

Aug 14 2020

dstenb requested review of D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics.
Aug 14 2020, 6:25 AM · Restricted Project

Aug 13 2020

dstenb committed rGe8ebebb0bde6: [InstCombine] Fix incorrect Modified status (authored by dstenb).
[InstCombine] Fix incorrect Modified status
Aug 13 2020, 6:11 AM
dstenb closed D85839: [InstCombine] Fix incorrect Modified status.
Aug 13 2020, 6:11 AM · Restricted Project

Aug 12 2020

dstenb updated the summary of D85839: [InstCombine] Fix incorrect Modified status.
Aug 12 2020, 8:13 AM · Restricted Project
dstenb requested review of D85839: [InstCombine] Fix incorrect Modified status.
Aug 12 2020, 8:13 AM · Restricted Project
dstenb requested review of D85837: [GlobalOpt] Fix incorrect Modified status.
Aug 12 2020, 7:26 AM · Restricted Project
dstenb requested review of D85818: [UnifyFunctionExitNodes] Fix Modified status for unreachable blocks.
Aug 12 2020, 1:47 AM · Restricted Project

Aug 11 2020

dstenb committed rGe2f32404727f: [DebugInfo] Allow GNU macro extension to be emitted (authored by dstenb).
[DebugInfo] Allow GNU macro extension to be emitted
Aug 11 2020, 8:01 AM
dstenb committed rGbb640645f524: [DebugInfo] Simplify DwarfDebug::emitMacro (authored by dstenb).
[DebugInfo] Simplify DwarfDebug::emitMacro
Aug 11 2020, 8:01 AM
dstenb closed D82975: [DebugInfo] Allow GNU macro extension to be emitted.
Aug 11 2020, 8:00 AM · Restricted Project, debug-info
dstenb closed D83557: [DebugInfo] Simplify DwarfDebug::emitMacro.
Aug 11 2020, 8:00 AM · Restricted Project, debug-info
dstenb committed rG91bd9db2cdbc: [DebugInfo] Allow GNU macro extension to be read (authored by dstenb).
[DebugInfo] Allow GNU macro extension to be read
Aug 11 2020, 4:31 AM
dstenb committed rG2892ed6d0fa9: [DebugInfo] Introduce GNU macro extension entry encodings (authored by dstenb).
[DebugInfo] Introduce GNU macro extension entry encodings
Aug 11 2020, 4:31 AM
dstenb committed rGa73008c1aed2: [DebugInfo] Refactor .debug_macro checks. NFCI (authored by dstenb).
[DebugInfo] Refactor .debug_macro checks. NFCI
Aug 11 2020, 4:31 AM
dstenb closed D82974: [DebugInfo] Allow GNU macro extension to be read.
Aug 11 2020, 4:31 AM · Restricted Project, debug-info