Page MenuHomePhabricator

dsrbecky (David Srbecký)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2015, 10:13 AM (328 w, 6 d)

Recent Activity

Jul 8 2015

dsrbecky committed rL241679: Tolerate DWARF compile unit without filename..
Tolerate DWARF compile unit without filename.
Jul 8 2015, 7:00 AM
dsrbecky closed D11003: Tolerate DWARF compile unit without filename. by committing rL241679: Tolerate DWARF compile unit without filename..
Jul 8 2015, 7:00 AM

Jul 7 2015

dsrbecky added a comment to D11003: Tolerate DWARF compile unit without filename..

Does it have any serious consequence if we get it wrong? (in this case there is only one entry in line table anyway)

Jul 7 2015, 4:10 PM
dsrbecky added a comment to D11003: Tolerate DWARF compile unit without filename..

Well, you still need to parse the line table prologue to understand DW_AT_decl_file, etc, but I get your point. If you are doing some simple processing, it nice to have the extra copy so you do not have to bother.

Jul 7 2015, 4:01 PM
dsrbecky added a comment to D11003: Tolerate DWARF compile unit without filename..

Thank you for the answer. If you pardon my ignorance... what is the purpose of *primary* source file? How does it differ from the other files? I do not imagine that the entries in the line table care whether the source is primary. I imagine DW_AT_decl_file and similar do not care either. I guess there is a good reason, I just can not think of it.

Jul 7 2015, 3:31 PM
dsrbecky added inline comments to D11003: Tolerate DWARF compile unit without filename..
Jul 7 2015, 2:54 PM
dsrbecky added a comment to D11003: Tolerate DWARF compile unit without filename..

As a side note, what is the compilation unit filename needed for? The filenames in the line table are obviously used for PC->line mapping, and they may be referenced from the debug_info. However, it is not clear to me why compilation unit needs a filename. I believe it is perfectly valid to aggregate all debug information info to single compilation unit, and then there is no obvious primary source file.

Jul 7 2015, 12:17 PM
dsrbecky updated the diff for D11003: Tolerate DWARF compile unit without filename..

Parse line table after creating the compilation unit.

Jul 7 2015, 12:07 PM
dsrbecky added reviewers for D11003: Tolerate DWARF compile unit without filename.: ovyalov, clayborg.
Jul 7 2015, 10:46 AM
dsrbecky added reviewers for D11003: Tolerate DWARF compile unit without filename.: tberghammer, labath.
Jul 7 2015, 10:33 AM
dsrbecky retitled D11003: Tolerate DWARF compile unit without filename. from to Tolerate DWARF compile unit without filename..
Jul 7 2015, 10:29 AM