Page MenuHomePhabricator

dongAxis1944 (Yifeng Dong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2020, 11:19 PM (16 w, 10 h)

Recent Activity

Tue, Nov 3

Herald added a reviewer for D11861: [IR] Add token types: deadalnix.
Tue, Nov 3, 7:46 PM · Restricted Project

Sep 6 2020

dongAxis1944 committed rG1fd7dc40748b: When dumping results of StackLifetime, it will print the following (authored by dongAxis1944).
When dumping results of StackLifetime, it will print the following
Sep 6 2020, 8:45 PM
dongAxis1944 closed D87152: [StackLifetime] add more detail log.
Sep 6 2020, 8:44 PM · Restricted Project

Sep 4 2020

dongAxis1944 retitled D87152: [StackLifetime] add more detail log from [StackLifetime] to [StackLifetime] add more detail log.
Sep 4 2020, 5:08 PM · Restricted Project
dongAxis1944 requested review of D87152: [StackLifetime] add more detail log.
Sep 4 2020, 8:57 AM · Restricted Project

Sep 1 2020

dongAxis1944 added inline comments to D85812: [coroutine] should disable inline before calling coro split.
Sep 1 2020, 6:58 AM · Restricted Project
dongAxis1944 added inline comments to D85812: [coroutine] should disable inline before calling coro split.
Sep 1 2020, 6:57 AM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.

hello, i just update previous patch, if it is ok, i will commit the code

Sep 1 2020, 6:54 AM · Restricted Project

Aug 27 2020

dongAxis1944 added a comment to D85812: [coroutine] should disable inline before calling coro split.

I want to point out a strange layering issue. Note that the test llvm/test/Transforms/Coroutines/coro-inline.ll uses -sample-profile: this implies that Coroutines should be a higher level library than sample-profile (a higher level library can use all facilities available at lower layers). However, LLVMipo (the library which contains sample-profile) has a dependency on LLVMCoroutines (the library which contains Coroutines.h)....... This is a conflict of library layering.

edit: LLVMCoroutines actually depends on LLVMipo, so circular dependency

You're right about the circular dependency on headers. Unlike actual circular dependency on actual libs though, such layering violation from header is not obvious, curious how did you catch this?

@dongAxis1944 to avoid the layering issues, I think you may need to revert back to your original version that prohibits inlining of pre-split coroutine in the general inline cost computation. The down side of that is we might cover up pass ordering issue in the future, but that's minor comparing the layering issue.

Aug 27 2020, 6:34 PM · Restricted Project

Aug 24 2020

dongAxis1944 committed rG2e43acfed89b: [coroutine] should disable inline before calling coro split (authored by dongAxis1944).
[coroutine] should disable inline before calling coro split
Aug 24 2020, 7:24 AM
dongAxis1944 closed D85812: [coroutine] should disable inline before calling coro split.
Aug 24 2020, 7:24 AM · Restricted Project

Aug 18 2020

dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 18 2020, 2:39 AM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.

move check to SampleProfileLoader::inlineCallInstruction

Aug 18 2020, 2:15 AM · Restricted Project

Aug 17 2020

dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.

move the check from llvm::getInlineCost to SampleProfileLoader::inlineHotFunctions and AlwaysInlinerLegacyPass::getInlineCost

Aug 17 2020, 7:47 PM · Restricted Project

Aug 16 2020

dongAxis1944 added a comment to D85812: [coroutine] should disable inline before calling coro split.

Looking at sample profile loader inline and your test case (either always inline or with sample profile), I'm guessing your change in the general llvm::getInlineCost was for sample profile loader inline, not CGSCC inline? If that's the case, it might be better to find a way to do this targeting just always inline and sample profile loader inline, then assert this shouldn't happen for CGSCC inline (would be a pass ordering bug).

Aug 16 2020, 3:38 AM · Restricted Project

Aug 15 2020

dongAxis1944 added a comment to D85812: [coroutine] should disable inline before calling coro split.

The "repository" of this change seems incorrect. It should be "rG LLVM Github Monorepo", instead it's "rZORG LLVM Github Zorg". I wonder if that's why the context of the changes isn't available?

Aug 15 2020, 7:29 AM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 15 2020, 7:28 AM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.

update new diff for showing the context of the changes

Aug 15 2020, 2:27 AM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 15 2020, 2:21 AM · Restricted Project

Aug 14 2020

dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 14 2020, 6:43 PM · Restricted Project

Aug 12 2020

dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 12 2020, 11:28 PM · Restricted Project
dongAxis1944 updated the summary of D85812: [coroutine] should disable inline before calling coro split.
Aug 12 2020, 11:01 PM · Restricted Project
dongAxis1944 updated the diff for D85812: [coroutine] should disable inline before calling coro split.
Aug 12 2020, 10:59 PM · Restricted Project

Aug 11 2020

dongAxis1944 updated subscribers of D85812: [coroutine] should disable inline before calling coro split.
Aug 11 2020, 11:54 PM · Restricted Project
dongAxis1944 removed reviewers for D85812: [coroutine] should disable inline before calling coro split: junparser, chandlerc, wenlei.
Aug 11 2020, 11:53 PM · Restricted Project
dongAxis1944 updated the summary of D85812: [coroutine] should disable inline before calling coro split.
Aug 11 2020, 11:49 PM · Restricted Project
dongAxis1944 added reviewers for D85812: [coroutine] should disable inline before calling coro split: chandlerc, wenlei.
Aug 11 2020, 11:48 PM · Restricted Project
dongAxis1944 added a reviewer for D85812: [coroutine] should disable inline before calling coro split: junparser.
Aug 11 2020, 11:44 PM · Restricted Project
dongAxis1944 requested review of D85812: [coroutine] should disable inline before calling coro split.
Aug 11 2020, 11:42 PM · Restricted Project