Page MenuHomePhabricator

dmccrevan (Daniel McCrevan)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2020, 11:36 AM (11 w, 6 d)

Recent Activity

Mon, Jan 11

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

reverse ping.

I think this is almost ready, it would be great to get the last remaining comments with respect to wording & tests wrapped up.

If you won't be able to follow up on this, it would be great if you could let us know, so potentially someone else could pick it up.

Mon, Jan 11, 5:19 AM · Restricted Project

Dec 2 2020

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

So I just confirmed that the new test case runs & passes, and every other test passed (except the 3 that "expectedly fail").

Dec 2 2020, 7:11 AM · Restricted Project

Dec 1 2020

dmccrevan updated the diff for D90328: Eliminates dead store of an exisiting value.
Dec 1 2020, 5:47 PM · Restricted Project
dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

Got it, I ran it like ./utils/update_test_checks.py --opt=../build/bin/opt test/Transforms/DeadStoreElimination/MSSA/simple.ll for each failed test.

Dec 1 2020, 5:14 PM · Restricted Project
dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

Please use llvm/utils/update_test_checks.py to update them. Then please upload all changed files.

Dec 1 2020, 5:07 PM · Restricted Project
dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

So I tried to build the check-llvm-transforms-deadstoreelimination target, but it seems that 4 tests are failing:

********************
********************
Failed Tests (4):
  LLVM :: Transforms/DeadStoreElimination/MSSA/multiblock-loops.ll
  LLVM :: Transforms/DeadStoreElimination/MSSA/multiblock-memoryphis.ll
  LLVM :: Transforms/DeadStoreElimination/MSSA/multiblock-simple.ll
  LLVM :: Transforms/DeadStoreElimination/MSSA/simple.ll
Dec 1 2020, 4:51 PM · Restricted Project

Nov 27 2020

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

reverse ping. Any progress? :)

Nov 27 2020, 9:35 AM · Restricted Project

Nov 6 2020

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

So actually I just realized that my current implementation I have on this revision isn't correct. For some reason, I must've not noticed the test result is different.

Nov 6 2020, 12:08 PM · Restricted Project

Nov 4 2020

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

So I fixed up the implementation by removing the worklist & just looped through the uses. For some reason, I had to add a lot of NULL checks to ensure that each variable I used wasn't NULL, but I feel like there may be another way to do this using separate functions I may not be aware of.

Nov 4 2020, 10:06 AM · Restricted Project
dmccrevan updated the summary of D90328: Eliminates dead store of an exisiting value.
Nov 4 2020, 10:02 AM · Restricted Project
dmccrevan updated the diff for D90328: Eliminates dead store of an exisiting value.
Nov 4 2020, 10:01 AM · Restricted Project

Nov 2 2020

dmccrevan added inline comments to D90328: Eliminates dead store of an exisiting value.
Nov 2 2020, 9:56 AM · Restricted Project
dmccrevan added inline comments to D90328: Eliminates dead store of an exisiting value.
Nov 2 2020, 9:50 AM · Restricted Project

Oct 28 2020

dmccrevan added a comment to D90328: Eliminates dead store of an exisiting value.

Disregard the previous comment, fixed the revision.

Oct 28 2020, 1:02 PM · Restricted Project
dmccrevan updated the diff for D90328: Eliminates dead store of an exisiting value.
Oct 28 2020, 1:02 PM · Restricted Project
dmccrevan reclaimed D90328: Eliminates dead store of an exisiting value.
Oct 28 2020, 12:44 PM · Restricted Project
dmccrevan abandoned D90328: Eliminates dead store of an exisiting value.

When uploading a new diff, make sure that the patch you're uploading is against the git master, not the previously uploaded diff/etc

Oct 28 2020, 12:43 PM · Restricted Project
dmccrevan updated the diff for D90328: Eliminates dead store of an exisiting value.

Added test case for eliminateDeadStoresOfExisitingValues

Oct 28 2020, 12:06 PM · Restricted Project
dmccrevan added a reviewer for D90328: Eliminates dead store of an exisiting value: fhahn.
Oct 28 2020, 12:04 PM · Restricted Project
dmccrevan updated the summary of D90328: Eliminates dead store of an exisiting value.
Oct 28 2020, 12:02 PM · Restricted Project
dmccrevan requested review of D90328: Eliminates dead store of an exisiting value.
Oct 28 2020, 11:58 AM · Restricted Project