Page MenuHomePhabricator

denik (Denis Nikitin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 2 2019, 2:52 PM (76 w, 1 d)

Recent Activity

Jan 17 2020

denik added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

We are hitting the warning in template code with bool and loop like this: "for (const auto& element : value)" where element is bool from template. But not always.
When it is bool the warning triggers:
error: loop variable 'element' is always a copy because the range of type 'const std::vector<bool, allocator<bool> >' does not return a reference [-Werror,-Wrange-loop-analysis]

Jan 17 2020, 12:09 PM · Restricted Project

Sep 12 2019

denik added inline comments to D52524: Add -Wpoison-system-directories warning.
Sep 12 2019, 8:20 AM · Restricted Project
denik updated the diff for D52524: Add -Wpoison-system-directories warning.

Combined two if into one.

Sep 12 2019, 8:19 AM · Restricted Project

Sep 11 2019

denik added a comment to D52524: Add -Wpoison-system-directories warning.

Ping @aaron.ballman , please verify the change.

Sep 11 2019, 11:52 AM · Restricted Project

Aug 28 2019

denik added a comment to D52524: Add -Wpoison-system-directories warning.

Hi Aaron,

Aug 28 2019, 5:54 PM · Restricted Project
denik updated the diff for D52524: Add -Wpoison-system-directories warning.
Aug 28 2019, 5:19 PM · Restricted Project

Aug 19 2019

denik updated the diff for D52524: Add -Wpoison-system-directories warning.

Removed check for libraries.

Aug 19 2019, 4:34 PM · Restricted Project
denik retitled D52524: Add -Wpoison-system-directories warning from Add -Wno-poison-system-directories flag to Add -Wpoison-system-directories warning.
Aug 19 2019, 4:33 PM · Restricted Project
denik added a comment to D52524: Add -Wpoison-system-directories warning.

Manoj, please check updated diff.

Aug 19 2019, 11:33 AM · Restricted Project
denik updated the diff for D52524: Add -Wpoison-system-directories warning.
Aug 19 2019, 11:33 AM · Restricted Project
denik added inline comments to D52524: Add -Wpoison-system-directories warning.
Aug 19 2019, 10:38 AM · Restricted Project
denik updated the diff for D52524: Add -Wpoison-system-directories warning.

Changed Wpoison-system-directories warning to be disabled by default.

Aug 19 2019, 10:37 AM · Restricted Project

Aug 14 2019

denik updated the diff for D52524: Add -Wpoison-system-directories warning.

Fixed clang-format.

Aug 14 2019, 3:41 PM · Restricted Project
denik updated the diff for D52524: Add -Wpoison-system-directories warning.

Updated the code (removed Diag propagation).
Added test cases.

Aug 14 2019, 3:00 PM · Restricted Project

Aug 8 2019

denik commandeered D52524: Add -Wpoison-system-directories warning.

Taking ownership of the change as Yunlian is no longer working on this CL.

Aug 8 2019, 10:02 AM · Restricted Project