Page MenuHomePhabricator

cynecx (Paul)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2015, 3:14 PM (291 w, 2 d)

Recent Activity

Thu, Mar 25

cynecx added a comment to D95745: Support unwinding from inline assembly.

Weekly Ping!

Thu, Mar 25, 8:31 AM · Restricted Project, Restricted Project

Mar 13 2021

cynecx added a comment to D95745: Support unwinding from inline assembly.

Weekly ping!

Mar 13 2021, 1:35 PM · Restricted Project, Restricted Project

Mar 3 2021

cynecx added a comment to D95745: Support unwinding from inline assembly.

Weekly ping :)

Mar 3 2021, 8:34 AM · Restricted Project, Restricted Project

Feb 21 2021

cynecx added inline comments to D96164: [lld-macho] add code signature for native arm64 macOS.
Feb 21 2021, 12:29 PM · Restricted Project, Restricted Project
cynecx updated the diff for D95745: Support unwinding from inline assembly.

clang-format

Feb 21 2021, 11:44 AM · Restricted Project, Restricted Project
cynecx added a comment to D95745: Support unwinding from inline assembly.

@rnk This is ready for a proper review :)

Feb 21 2021, 10:38 AM · Restricted Project, Restricted Project
cynecx updated the diff for D95745: Support unwinding from inline assembly.

Added tests and updated splitted patchset.

Feb 21 2021, 10:37 AM · Restricted Project, Restricted Project

Feb 20 2021

cynecx added inline comments to D96164: [lld-macho] add code signature for native arm64 macOS.
Feb 20 2021, 8:56 AM · Restricted Project, Restricted Project

Feb 18 2021

cynecx added inline comments to D96164: [lld-macho] add code signature for native arm64 macOS.
Feb 18 2021, 11:42 AM · Restricted Project, Restricted Project
cynecx added inline comments to D96164: [lld-macho] add code signature for native arm64 macOS.
Feb 18 2021, 11:15 AM · Restricted Project, Restricted Project
cynecx added inline comments to D96164: [lld-macho] add code signature for native arm64 macOS.
Feb 18 2021, 11:09 AM · Restricted Project, Restricted Project

Feb 14 2021

cynecx added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.

Hmm, this is indeed very weird. I have seen "similar" behavior with codesign. codesign can actually fail. The only way to "get it working" again is to copy the file and codesign the copy, then replacing the original file (a different inode fixes codesigning).

Feb 14 2021, 1:24 PM · Restricted Project, Restricted Project
cynecx added a comment to D96540: [llvm/Support] Add SHA256 implementation.

@mehdi_amini That's alright. Thank You!

Feb 14 2021, 9:35 AM · Restricted Project
cynecx updated the summary of D96540: [llvm/Support] Add SHA256 implementation.
Feb 14 2021, 9:28 AM · Restricted Project

Feb 12 2021

cynecx updated the summary of D96540: [llvm/Support] Add SHA256 implementation.
Feb 12 2021, 10:36 AM · Restricted Project

Feb 11 2021

cynecx added a comment to D96540: [llvm/Support] Add SHA256 implementation.

I'll wait a couple of days to see if anyone has a concern with this, ping me on Monday if I forget :)

Feb 11 2021, 2:56 PM · Restricted Project
cynecx added a comment to D96540: [llvm/Support] Add SHA256 implementation.

@mehdi_amini Thanks for the review. I don't have commit rights. I'd be great if someone could commit this!

Feb 11 2021, 2:42 PM · Restricted Project
cynecx added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.

SHA256 patch is up here: https://reviews.llvm.org/D96540.

Feb 11 2021, 1:23 PM · Restricted Project, Restricted Project
cynecx updated the diff for D96540: [llvm/Support] Add SHA256 implementation.

Cleanup

Feb 11 2021, 1:21 PM · Restricted Project
cynecx requested review of D96540: [llvm/Support] Add SHA256 implementation.
Feb 11 2021, 1:19 PM · Restricted Project
cynecx added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.

@gkm Re: the linker flag. I think they were talking about this (linkerSigned):

Feb 11 2021, 12:25 PM · Restricted Project, Restricted Project
cynecx added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.

@gkm Is it okay for you if I post a patch which adds a SHA-256 implementation to LLVM? I actually have a patchset ready here. But to answer your question, yes it should be possible to simply drop the files into the right locations.

Feb 11 2021, 12:07 PM · Restricted Project, Restricted Project

Feb 10 2021

cynecx added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.

Perhaps this might help: SHA256 impl for LLVM. This is based on botan's sha256 implementation and mimics the current SHA1 api design. It should be compatible with LLVM's license since it's based on botan's implementation, which is BSD-2 licensed.

Feb 10 2021, 1:39 PM · Restricted Project, Restricted Project
Herald added a project to D96164: [lld-macho] add code signature for native arm64 macOS: Restricted Project.
Feb 10 2021, 8:26 AM · Restricted Project, Restricted Project

Feb 4 2021

cynecx edited reviewers for D95745: Support unwinding from inline assembly, added: rnk, nikic; removed: deadalnix.
Feb 4 2021, 9:11 AM · Restricted Project, Restricted Project
cynecx updated the diff for D95745: Support unwinding from inline assembly.

clang-format changes

Feb 4 2021, 9:08 AM · Restricted Project, Restricted Project
cynecx abandoned D96054: Support unwinding from inline assembly.
Feb 4 2021, 9:04 AM · Restricted Project
cynecx abandoned D96052: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly.
Feb 4 2021, 9:04 AM · Restricted Project
cynecx abandoned D96053: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly.
Feb 4 2021, 9:03 AM · Restricted Project
cynecx requested review of D96054: Support unwinding from inline assembly.
Feb 4 2021, 9:02 AM · Restricted Project
cynecx requested review of D96053: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly.
Feb 4 2021, 8:50 AM · Restricted Project
cynecx requested review of D96052: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly.
Feb 4 2021, 8:47 AM · Restricted Project

Jan 31 2021

cynecx updated the summary of D95745: Support unwinding from inline assembly.
Jan 31 2021, 10:04 AM · Restricted Project, Restricted Project
cynecx updated the summary of D95745: Support unwinding from inline assembly.
Jan 31 2021, 10:03 AM · Restricted Project, Restricted Project
cynecx updated the summary of D95745: Support unwinding from inline assembly.
Jan 31 2021, 10:03 AM · Restricted Project, Restricted Project
cynecx updated the summary of D95745: Support unwinding from inline assembly.
Jan 31 2021, 10:03 AM · Restricted Project, Restricted Project

Jan 30 2021

cynecx added a comment to D95745: Support unwinding from inline assembly.

Tests are missing right now. But I'd like to get some feedback first whether this approach goes in the right direction.

Jan 30 2021, 11:25 AM · Restricted Project, Restricted Project
cynecx requested review of D95745: Support unwinding from inline assembly.
Jan 30 2021, 11:20 AM · Restricted Project, Restricted Project

Aug 3 2017

cynecx added inline comments to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
Aug 3 2017, 1:31 PM

Jul 29 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jul 29 2017, 4:28 PM

Jul 26 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jul 26 2017, 3:54 PM

Jul 19 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jul 19 2017, 1:16 PM

Jul 14 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jul 14 2017, 5:17 PM

Jul 9 2017

cynecx updated the diff for D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
  • [Sema] Fix 'has internal linkage but is not defined' for CXXDeductionGuideDecl
  • Add new test
  • Add comment in test
  • Fix comment
Jul 9 2017, 6:13 AM
cynecx added inline comments to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
Jul 9 2017, 6:13 AM

Jul 3 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jul 3 2017, 8:34 AM

Jun 28 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jun 28 2017, 2:31 PM

Jun 25 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jun 25 2017, 5:40 PM

Jun 22 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jun 22 2017, 3:12 PM

Jun 20 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Thanks. So when can this be committed?

Jun 20 2017, 8:01 AM

Jun 15 2017

cynecx added inline comments to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
Jun 15 2017, 2:24 PM
cynecx updated the diff for D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
  • Add comment in test
Jun 15 2017, 11:21 AM
cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Ping.

Jun 15 2017, 7:46 AM

Jun 13 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Another gentle ping :)

Jun 13 2017, 2:44 PM

Jun 12 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Gentle ping for review.

Jun 12 2017, 4:32 PM
cynecx updated the diff for D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
  • [Sema] Fix 'has internal linkage but is not defined' for CXXDeductionGuideDecl
  • Add new test
Jun 12 2017, 4:31 PM
cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Gentle ping.

Jun 12 2017, 11:30 AM

Jun 9 2017

cynecx added a comment to D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Does this require a test? Ping.

Jun 9 2017, 4:30 PM

Jun 8 2017

cynecx created D34045: [Sema] Don't emit undefined-internal warnings for CXXDeductionGuideDecls.
Jun 8 2017, 3:58 PM

May 12 2017

cynecx added a comment to D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization.

Gentle ping.

May 12 2017, 5:12 PM

May 8 2017

cynecx added a comment to D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization.

Would it be possible to land this patch? I would really like to see this fixed.

May 8 2017, 10:03 AM

Sep 17 2015

cynecx added a comment to D10881: [Sema] Catch a case when 'volatile' qualifier is dropped while binding .

First of all, I would like to say that I am new into all the clang stuff (software architecture/internal concepts) but I wanted to start hacking clang so I went here to check out some trivial clang bugs to fix so I can learn internal stuff about clang, with internal stuff I mean how AST/Sema are implemented and kinda these things.

Sep 17 2015, 3:52 PM