Page MenuHomePhabricator

ctetreau (Christopher Tetreault)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2019, 12:14 PM (43 w, 1 d)

Recent Activity

Wed, Aug 5

ctetreau added a comment to D84212: [SVE] Remove default-false VectorType::get.

ping?

Wed, Aug 5, 9:57 AM · Restricted Project
ctetreau planned changes to D82582: [SVE] Remove calls to VectorType::getNumElements from clang.

I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped right now so it may take a bit.

Wed, Aug 5, 9:56 AM · Restricted Project

Mon, Aug 3

ctetreau abandoned D85171: [Polly] Use containers with deterministic iteration order.
Mon, Aug 3, 4:50 PM · Restricted Project
ctetreau committed rGc9e6887f8379: [SVE] Remove bad calls to VectorType::getNumElements() from X86 (authored by ctetreau).
[SVE] Remove bad calls to VectorType::getNumElements() from X86
Mon, Aug 3, 4:35 PM
ctetreau closed D85156: [SVE] Remove bad calls to VectorType::getNumElements() from X86.
Mon, Aug 3, 4:35 PM · Restricted Project
ctetreau added reviewers for D85171: [Polly] Use containers with deterministic iteration order: efriedma, chrisj, Meinersbur, gchatelet.
Mon, Aug 3, 4:12 PM · Restricted Project
ctetreau requested review of D85171: [Polly] Use containers with deterministic iteration order.
Mon, Aug 3, 4:08 PM · Restricted Project
ctetreau committed rG3b92db4c846e: [SVE] Remove bad call to VectorType::getNumElements() from AMDGPU (authored by ctetreau).
[SVE] Remove bad call to VectorType::getNumElements() from AMDGPU
Mon, Aug 3, 3:56 PM
ctetreau closed D85151: [SVE] Remove bad call to VectorType::getNumElements() from AMDGPU.
Mon, Aug 3, 3:56 PM · Restricted Project
ctetreau committed rGb5059b714023: [SVE] Remove bad call to VectorType::getNumElements() from ARM (authored by ctetreau).
[SVE] Remove bad call to VectorType::getNumElements() from ARM
Mon, Aug 3, 3:41 PM
ctetreau closed D85152: [SVE] Remove bad call to VectorType::getNumElements() from ARM.
Mon, Aug 3, 3:41 PM · Restricted Project
ctetreau committed rGb43791e7016d: [SVE] Remove bad calls to VectorType::getNumElements() from PowerPC (authored by ctetreau).
[SVE] Remove bad calls to VectorType::getNumElements() from PowerPC
Mon, Aug 3, 3:15 PM
ctetreau closed D85154: [SVE] Remove bad calls to VectorType::getNumElements() from PowerPC.
Mon, Aug 3, 3:15 PM · Restricted Project
ctetreau added reviewers for D85156: [SVE] Remove bad calls to VectorType::getNumElements() from X86: craig.topper, RKSimon, david-arm, kmclaughlin.
Mon, Aug 3, 1:33 PM · Restricted Project
ctetreau requested review of D85156: [SVE] Remove bad calls to VectorType::getNumElements() from X86.
Mon, Aug 3, 1:31 PM · Restricted Project
ctetreau requested review of D85154: [SVE] Remove bad calls to VectorType::getNumElements() from PowerPC.
Mon, Aug 3, 1:25 PM · Restricted Project
ctetreau requested review of D85152: [SVE] Remove bad call to VectorType::getNumElements() from ARM.
Mon, Aug 3, 1:22 PM · Restricted Project
ctetreau requested review of D85151: [SVE] Remove bad call to VectorType::getNumElements() from AMDGPU.
Mon, Aug 3, 1:20 PM · Restricted Project
ctetreau updated the diff for D82237: [SVE] Remove calls to VectorType::getNumElements from InstCombine.

rebase, catch stragglers

Mon, Aug 3, 1:18 PM · Restricted Project

Thu, Jul 23

ctetreau updated the diff for D82582: [SVE] Remove calls to VectorType::getNumElements from clang.

address code review issues

Thu, Jul 23, 2:08 PM · Restricted Project
ctetreau updated the diff for D82237: [SVE] Remove calls to VectorType::getNumElements from InstCombine.

rebase

Thu, Jul 23, 12:57 PM · Restricted Project
ctetreau added inline comments to D81500: [SVE] Remove calls to VectorType::getNumElements from IR.
Thu, Jul 23, 12:53 PM · Restricted Project
ctetreau added inline comments to D82582: [SVE] Remove calls to VectorType::getNumElements from clang.
Thu, Jul 23, 8:16 AM · Restricted Project

Wed, Jul 22

ctetreau added reviewers for D82582: [SVE] Remove calls to VectorType::getNumElements from clang: c-rhodes, david-arm, sdesmalen, ABataev, RKSimon.
Wed, Jul 22, 4:30 PM · Restricted Project
ctetreau committed rG23c5e59d9fee: [SVE] Remove calls to VectorType::getNumElements from Analysis (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from Analysis
Wed, Jul 22, 3:19 PM
ctetreau closed D81504: [SVE] Remove calls to VectorType::getNumElements from Analysis.
Wed, Jul 22, 3:19 PM · Restricted Project
ctetreau committed rGae35c09c34f0: [MVT] Fix getTypeForEVT for v64f16 and v128f16 (authored by ctetreau).
[MVT] Fix getTypeForEVT for v64f16 and v128f16
Wed, Jul 22, 2:28 PM
ctetreau closed D84211: [MVT] Fix getTypeForEVT for v64f16 and v128f16.
Wed, Jul 22, 2:27 PM · Restricted Project

Mon, Jul 20

ctetreau added reviewers for D84212: [SVE] Remove default-false VectorType::get: fpetrogalli, kmclaughlin, huntergr.
Mon, Jul 20, 9:16 PM · Restricted Project
Herald added a project to D84211: [MVT] Fix getTypeForEVT for v64f16 and v128f16: Restricted Project.
Mon, Jul 20, 9:16 PM · Restricted Project
Herald added a project to D84212: [SVE] Remove default-false VectorType::get: Restricted Project.
Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau added reviewers for D84211: [MVT] Fix getTypeForEVT for v64f16 and v128f16: cameron.mcinally, efriedma, sdesmalen, paulwalker-arm.
Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D81504: [SVE] Remove calls to VectorType::getNumElements from Analysis.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D82218: [SVE] Remove calls to VectorType::getNumElements from AggressiveInstCombine.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D82582: [SVE] Remove calls to VectorType::getNumElements from clang.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D82237: [SVE] Remove calls to VectorType::getNumElements from InstCombine.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D82056: [SVE] Remove calls to VectorType::getNumElements from Transforms/Vectorize.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau updated the diff for D81500: [SVE] Remove calls to VectorType::getNumElements from IR.

rebase

Mon, Jul 20, 9:16 PM · Restricted Project
ctetreau abandoned D81620: [SVE] Allow scalable vector splats to be gep indices.
Mon, Jul 20, 9:16 PM · Restricted Project

Fri, Jul 17

ctetreau added a comment to D83995: Provide some instructions to guide the user on how to get a more up-to-date CMake in CMake error message.

I think a change such as this would be an improvement. However, I think the linux special case is encouraging bad security habits "wget this random binary and run it!", and IMO should be removed.

Fri, Jul 17, 9:47 AM · Restricted Project

Tue, Jul 14

ctetreau closed D83005: [NFC] Combine cstfp_pred_ty and cst_pred_ty.
Tue, Jul 14, 3:04 PM · Restricted Project
ctetreau committed rG9c87c5580575: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats (authored by ctetreau).
[SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats
Tue, Jul 14, 2:21 PM
ctetreau closed D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.
Tue, Jul 14, 2:20 PM · Restricted Project

Jul 9 2020

ctetreau abandoned D82419: [SVE] add derived vector get(Type *, ElementCount) and get(Type *, VectorType).
Jul 9 2020, 12:50 PM · Restricted Project
ctetreau committed rGff5b9a7b3b27: [SVE] Remove calls to VectorType::getNumElements from CodeGen (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from CodeGen
Jul 9 2020, 12:44 PM
ctetreau closed D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.
Jul 9 2020, 12:43 PM · Restricted Project
ctetreau updated the diff for D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

account for abandoned D82329

Jul 9 2020, 12:43 PM · Restricted Project
ctetreau abandoned D82329: [SVE] Fix invalid Scalable to fixed width vetor type demotion in LLT.

This patch (in the form of an unconditional cast to FixedVectorType on line 22) has been rolled into D82210

Jul 9 2020, 12:42 PM · Restricted Project

Jul 8 2020

ctetreau added reviewers for D83005: [NFC] Combine cstfp_pred_ty and cst_pred_ty: efriedma, lebedev.ri, fhahn, spatel.
Jul 8 2020, 1:42 PM · Restricted Project
ctetreau updated the diff for D81500: [SVE] Remove calls to VectorType::getNumElements from IR.

rebase

Jul 8 2020, 1:13 PM · Restricted Project
ctetreau updated the diff for D83005: [NFC] Combine cstfp_pred_ty and cst_pred_ty.

rebase

Jul 8 2020, 1:06 PM · Restricted Project
ctetreau updated the diff for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.

rebase

Jul 8 2020, 12:57 PM · Restricted Project
ctetreau updated the diff for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.

fix comments

Jul 8 2020, 12:27 PM · Restricted Project
ctetreau updated the diff for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.

Apparently SEC is defined in sys/time.h on solaris

Jul 8 2020, 12:24 PM · Restricted Project
ctetreau committed rGd2eb40937976: [Solaris] Fix Solaris build bots (authored by ctetreau).
[Solaris] Fix Solaris build bots
Jul 8 2020, 12:21 PM
ctetreau closed D83415: [Solaris] Fix Solaris build bots.
Jul 8 2020, 12:21 PM · Restricted Project
ctetreau added a comment to D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

@ro That's unfortunate. I pushed D83415, I'll submit without review when my local tests pass.

Jul 8 2020, 12:12 PM · Restricted Project
ctetreau added a reviewer for D83415: [Solaris] Fix Solaris build bots: ro.
Jul 8 2020, 12:12 PM · Restricted Project
Herald added a project to D83415: [Solaris] Fix Solaris build bots: Restricted Project.
Jul 8 2020, 12:10 PM · Restricted Project
ctetreau added a comment to D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

@sdesmalen I went ahead and made the requested changes. In ValueType.cpp, rather than leaving the code alone, I went ahead and returned getElementCount().Min along with adding a warning if the vector was scalable. This way getNumElement() can be removed in the future without having to touch this file again.

Jul 8 2020, 11:57 AM · Restricted Project
ctetreau updated the diff for D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

address code review issues

Jul 8 2020, 11:51 AM · Restricted Project
ctetreau committed rGc444b1b904b1: [SVE] Remove calls to VectorType::getNumElements from Scalar (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from Scalar
Jul 8 2020, 11:08 AM
ctetreau closed D82243: [SVE] Remove calls to VectorType::getNumElements from Scalar.
Jul 8 2020, 11:08 AM · Restricted Project

Jul 7 2020

ctetreau updated the diff for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.

Add unit tests

Jul 7 2020, 4:58 PM · Restricted Project
ctetreau committed rGc17120a3a4c1: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from AsmParserTest
Jul 7 2020, 2:56 PM
ctetreau closed D83339: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest.
Jul 7 2020, 2:56 PM · Restricted Project
ctetreau committed rG021d56abb9ee: [SVE] Make Constant::getSplatValue work for scalable vector splats (authored by ctetreau).
[SVE] Make Constant::getSplatValue work for scalable vector splats
Jul 7 2020, 1:46 PM
ctetreau closed D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.
Jul 7 2020, 1:46 PM · Restricted Project
ctetreau updated the diff for D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

fix test

Jul 7 2020, 1:13 PM · Restricted Project
ctetreau added reviewers for D83339: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest: c-rhodes, david-arm, kmclaughlin, fpetrogalli, sdesmalen.
Jul 7 2020, 1:09 PM · Restricted Project
Herald added a project to D83339: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest: Restricted Project.
Jul 7 2020, 1:07 PM · Restricted Project
ctetreau updated the diff for D82243: [SVE] Remove calls to VectorType::getNumElements from Scalar.

rebase

Jul 7 2020, 11:25 AM · Restricted Project
ctetreau updated the diff for D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

rebase

Jul 7 2020, 11:23 AM · Restricted Project
ctetreau updated the diff for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.

add comment for mul.ll

Jul 7 2020, 10:27 AM · Restricted Project

Jul 1 2020

ctetreau created D83005: [NFC] Combine cstfp_pred_ty and cst_pred_ty.
Jul 1 2020, 3:42 PM · Restricted Project
ctetreau added reviewers for D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats: lebedev.ri, fhahn, c-rhodes, david-arm.
Jul 1 2020, 3:10 PM · Restricted Project
ctetreau created D83001: [SVE] Make cstfp_pred_ty and cst_pred_ty work with scalable splats.
Jul 1 2020, 3:09 PM · Restricted Project
ctetreau updated the diff for D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

address code review issues

Jul 1 2020, 1:32 PM · Restricted Project
ctetreau updated the diff for D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

add regression test

Jul 1 2020, 1:32 PM · Restricted Project
ctetreau added a comment to D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

@sdesmalen Would you like me to hold off on this one until after the branch?

Jul 1 2020, 10:15 AM · Restricted Project
ctetreau updated subscribers of D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.
Jul 1 2020, 10:15 AM · Restricted Project
ctetreau updated the diff for D82210: [SVE] Remove calls to VectorType::getNumElements from CodeGen.

address code review issues

Jul 1 2020, 9:42 AM · Restricted Project

Jun 30 2020

ctetreau updated the diff for D77442: [SVE] Take constant fold fast path for splatted vscale vectors.

rebase

Jun 30 2020, 4:50 PM · Restricted Project
ctetreau updated the diff for D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

rebase

Jun 30 2020, 4:50 PM · Restricted Project
ctetreau updated the diff for D77442: [SVE] Take constant fold fast path for splatted vscale vectors.

fix tests, use new support for getSplatValue workikng with scalable vectors from D82416

Jun 30 2020, 4:18 PM · Restricted Project
ctetreau added a comment to D82416: [SVE] Make Constant::getSplatValue work for scalable vector splats.

ping?

Jun 30 2020, 12:29 PM · Restricted Project
ctetreau committed rGab35ba574221: [SVE] Remove calls to VectorType::getNumElements from AArch64 (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from AArch64
Jun 30 2020, 11:25 AM
ctetreau closed D82214: [SVE] Remove calls to VectorType::getNumElements from AArch64.
Jun 30 2020, 11:25 AM · Restricted Project
ctetreau committed rG9b500e564a74: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from ExecutionEngine
Jun 30 2020, 11:25 AM
ctetreau closed D82211: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine.
Jun 30 2020, 11:24 AM · Restricted Project
ctetreau added a comment to D82211: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine.

@sdesmalen Are you satisfied with the state of this patch? May I submit this?

Jun 30 2020, 9:12 AM · Restricted Project

Jun 29 2020

ctetreau updated the diff for D81500: [SVE] Remove calls to VectorType::getNumElements from IR.

catch straggler

Jun 29 2020, 3:50 PM · Restricted Project
ctetreau committed rGbdcd20062933: [SVE] Remove calls to VectorType::getNumElements from Instrumentation (authored by ctetreau).
[SVE] Remove calls to VectorType::getNumElements from Instrumentation
Jun 29 2020, 3:33 PM
ctetreau closed D82241: [SVE] Remove calls to VectorType::getNumElements from Instrumentation.
Jun 29 2020, 3:33 PM · Restricted Project
ctetreau updated the diff for D82241: [SVE] Remove calls to VectorType::getNumElements from Instrumentation.

add FIXMEs to the file header comments

Jun 29 2020, 2:58 PM · Restricted Project
ctetreau committed rG657ac8e717e3: [CMake] Fix incorrect handling of get_target_property failure (authored by ctetreau).
[CMake] Fix incorrect handling of get_target_property failure
Jun 29 2020, 2:46 PM
ctetreau closed D81762: [CMake] Fix incorrect handling of get_target_property failure.
Jun 29 2020, 2:46 PM · Restricted Project
ctetreau added inline comments to D82056: [SVE] Remove calls to VectorType::getNumElements from Transforms/Vectorize.
Jun 29 2020, 2:12 PM · Restricted Project
ctetreau updated the diff for D81500: [SVE] Remove calls to VectorType::getNumElements from IR.

address code review issues

Jun 29 2020, 2:12 PM · Restricted Project
ctetreau updated the diff for D82211: [SVE] Remove calls to VectorType::getNumElements from ExecutionEngine.

address code review issues

Jun 29 2020, 1:36 PM · Restricted Project