Page MenuHomePhabricator

cristian.adam (Cristian Adam)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2019, 5:49 AM (69 w, 2 d)

Recent Activity

Apr 27 2020

cristian.adam updated subscribers of rG665471907a5c: [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC.

@thakis has a use case at https://reviews.llvm.org/D74907 building a SHARED libclang with LLVM_ENABLE_PIC set to OFF.

Apr 27 2020, 3:43 AM
cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

Rather than wholly reverting this, I committed a fix: 665471907a5c072c6653a38c35f35e5d54cef220

The problem is that "NOT LIBCLANG_BUILD_STATIC" does not imply PIC, so there is no point in trying to build the SHARED version. Please let me know if I somehow missed something. Thanks!

Apr 27 2020, 3:42 AM · Restricted Project

Apr 24 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

@mstorsjo can you merge (again) this on my behalf? Thank you in advance!

Apr 24 2020, 2:40 AM · Restricted Project

Apr 23 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

Since I do not have commit rights, I require help to get this merged.

Apr 23 2020, 11:52 AM · Restricted Project

Apr 21 2020

cristian.adam added a reviewer for D75068: libclang: Add static build support for Windows : Restricted Project.
Apr 21 2020, 6:27 AM · Restricted Project

Apr 20 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

@thakis ping?

Apr 20 2020, 3:43 AM · Restricted Project

Apr 6 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

ping

Apr 6 2020, 4:49 AM · Restricted Project

Mar 30 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

Ping

Mar 30 2020, 3:12 AM · Restricted Project

Mar 23 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .
Mar 23 2020, 4:53 AM · Restricted Project

Mar 16 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

Ping.

Mar 16 2020, 5:52 AM · Restricted Project

Mar 9 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

ping?

Mar 9 2020, 4:16 AM · Restricted Project

Feb 27 2020

cristian.adam added a comment to D74599: llvm-ar: Fix MinGW compilation.

The pre-merge check complains with clang-tidy not being able to locate windows.h and io.h. Is there anything I can do?

Feb 27 2020, 9:30 AM · Restricted Project
cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

ping?

Feb 27 2020, 4:19 AM · Restricted Project

Feb 26 2020

cristian.adam added a comment to D74599: llvm-ar: Fix MinGW compilation.
In D74599#1893597, @rnk wrote:

lgtm

Do you need someone to commit this? Thanks for the portability fix!

Feb 26 2020, 8:32 AM · Restricted Project
cristian.adam updated the diff for D74599: llvm-ar: Fix MinGW compilation.

Use WindowsSupport.h in llvm-ar, which sets _WIN32_WINNT to 0x0601

Feb 26 2020, 8:04 AM · Restricted Project

Feb 25 2020

cristian.adam added a comment to D75068: libclang: Add static build support for Windows .

I've tested this patch with:

Feb 25 2020, 6:48 AM · Restricted Project

Feb 24 2020

cristian.adam created D75068: libclang: Add static build support for Windows .
Feb 24 2020, 11:16 AM · Restricted Project

Feb 20 2020

cristian.adam added a comment to D74907: libclang: Make shared object symbol exporting by default .

Thank you!

Feb 20 2020, 11:42 AM · Restricted Project
cristian.adam added a comment to D74907: libclang: Make shared object symbol exporting by default .

The problem is (I believe) that add_clang_library(libclang is passed ${ENABLE_SHARED} and that used to be true on Windows but no longer is after your change (due to the change in line 80 in your original change), so libclang.dll isn't built at all any longer. If it was still built, the _CINDEX_LIB_ logic around line 128 wouldn't be passed for the same reason.

Feb 20 2020, 10:20 AM · Restricted Project
cristian.adam added a comment to D74907: libclang: Make shared object symbol exporting by default .
Feb 20 2020, 10:11 AM · Restricted Project
cristian.adam updated the diff for D74907: libclang: Make shared object symbol exporting by default .

-DLLVM_ENABLE_PIC=OFF on Windows if LIBCLANG_BUILD_STATIC is not set to ON will generate a SHARED libclang.dll

Feb 20 2020, 10:02 AM · Restricted Project
cristian.adam added a comment to D74907: libclang: Make shared object symbol exporting by default .

I do not have commit rights, I need help to submit this patch.

Feb 20 2020, 9:24 AM · Restricted Project
cristian.adam added a comment to D74907: libclang: Make shared object symbol exporting by default .

Thanks! Does this make it so that libclang.dll is built again with -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that correct? If so, could you reinstantiate that too?

Feb 20 2020, 9:24 AM · Restricted Project
cristian.adam added inline comments to D74907: libclang: Make shared object symbol exporting by default .
Feb 20 2020, 9:15 AM · Restricted Project
cristian.adam created D74907: libclang: Make shared object symbol exporting by default .
Feb 20 2020, 9:06 AM · Restricted Project
cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

I'll submit it today.

Feb 20 2020, 9:06 AM · Restricted Project
cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

Great, thanks. Since we're currently broken due to this change, any ETA for the follow-up?

Feb 20 2020, 7:44 AM · Restricted Project
cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

Given that this is currently a breaking change: Does it make sense to re-use LLVM_ENABLE_PIC for this, which currently doesn't have an effect on Windows anywhere? Maybe there should be a dedicated "I want libclang to be a static library" opt-in? And maybe the Platform.h should default to the dll setup and require a define to not use it, instead of the other way round? That seems safer for embedders.

Feb 20 2020, 7:17 AM · Restricted Project
cristian.adam added inline comments to D74564: libclang: Add static build support for Windows.
Feb 20 2020, 6:04 AM · Restricted Project

Feb 19 2020

cristian.adam updated the diff for D74599: llvm-ar: Fix MinGW compilation.

Added _WIN32_WINNT to have the same value as WINVER

Feb 19 2020, 8:45 AM · Restricted Project
cristian.adam edited reviewers for D74564: libclang: Add static build support for Windows, added: mstorsjo; removed: chapuni.
Feb 19 2020, 4:35 AM · Restricted Project
cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

@mstorsjo can you help me with pushing this commit? Thank you in advance!

Feb 19 2020, 4:35 AM · Restricted Project
cristian.adam added a comment to D74599: llvm-ar: Fix MinGW compilation.

I have a bug report regarding this review at: https://bugs.llvm.org/show_bug.cgi?id=44907

Feb 19 2020, 4:32 AM · Restricted Project

Feb 18 2020

cristian.adam updated the diff for D74599: llvm-ar: Fix MinGW compilation.

Updated revision with a -U9999 diff.

Feb 18 2020, 5:00 AM · Restricted Project
cristian.adam added a comment to D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

This could also be cherry-picked for release/10.x. Would close https://bugs.llvm.org/show_bug.cgi?id=44906

Feb 18 2020, 3:37 AM · Restricted Project
cristian.adam added a comment to D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

I can try to get it committed soon. What form do you want for the author line, "Cristian Adam <cristian.adam@gmail.com>"?

Feb 18 2020, 3:28 AM · Restricted Project
cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

I do not have commit rights, I need help to submit this patch.

Feb 18 2020, 2:41 AM · Restricted Project
cristian.adam added a comment to D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.

I do not have commit rights, I need help to submit this patch.

Feb 18 2020, 2:41 AM · Restricted Project

Feb 17 2020

cristian.adam updated the diff for D74564: libclang: Add static build support for Windows.
Feb 17 2020, 5:21 AM · Restricted Project
cristian.adam added inline comments to D74564: libclang: Add static build support for Windows.
Feb 17 2020, 5:21 AM · Restricted Project

Feb 14 2020

cristian.adam updated the diff for D74599: llvm-ar: Fix MinGW compilation.

Updated from Windows Vista (0x600) to Windows 7 (0x601)

Feb 14 2020, 5:46 AM · Restricted Project
cristian.adam retitled D74599: llvm-ar: Fix MinGW compilation from llvm: Set WINVER to 0x600 (Vista) for MinGW to llvm: Set WINVER to 0x601 (Windows 7) for MinGW.
Feb 14 2020, 5:37 AM · Restricted Project
cristian.adam added a comment to D74599: llvm-ar: Fix MinGW compilation.

I'm new to Phabricator. I don't feel like installing php on my Windows machine. I wish llvm would have used github as review. But this won't happen anytime soon. Oh well.

Feb 14 2020, 3:33 AM · Restricted Project
cristian.adam created D74599: llvm-ar: Fix MinGW compilation.
Feb 14 2020, 3:09 AM · Restricted Project

Feb 13 2020

cristian.adam added a comment to D74564: libclang: Add static build support for Windows.

Build with this patch being built on GitHub Actions on Windows MSVC, Windows MinGW, Linux, macOS:
https://github.com/cristianadam/llvm-project/actions/runs/38838989

Feb 13 2020, 9:47 AM · Restricted Project
cristian.adam created D74564: libclang: Add static build support for Windows.
Feb 13 2020, 8:51 AM · Restricted Project
cristian.adam added reviewers for D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable: zturner, mstorsjo.
Feb 13 2020, 8:24 AM · Restricted Project
cristian.adam created D74561: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable.
Feb 13 2020, 8:24 AM · Restricted Project

Jul 5 2019

cristian.adam abandoned D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

BUILD_SHARED_LIBS does create lots of shared objects, and LLVM_BUILD_LLVM_DYLIB should be the right solution for Qt Creator where we have a bit of big binaries.

Jul 5 2019, 5:29 AM · Restricted Project
cristian.adam added a comment to D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

This is definitely not the right fix. We don’t want to set everything as Public dependencies. Our build system’s model for dependencies is that each component specified what it directly uses which is its Private dependencies. If you are having issues that probably means missing dependencies.

Jul 5 2019, 5:13 AM · Restricted Project
cristian.adam added a reviewer for D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON : nik.
Jul 5 2019, 3:30 AM · Restricted Project
cristian.adam added reviewers for D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON : chapuni, beanz.
Jul 5 2019, 3:30 AM · Restricted Project

Jun 27 2019

cristian.adam added a comment to D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

I don't understand the change for the PRIVATE to PUBLIC. That doesn't make a different to the import library handling, which is baked right into CMake, so that will always be handled properly irrespective of the link dependency's visibility. I think the only thing that may be needed is the Core dependency on the TestPlugin.

Jun 27 2019, 1:37 PM · Restricted Project
cristian.adam created D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .
Jun 27 2019, 8:31 AM · Restricted Project