Page MenuHomePhabricator

cjdb (Christopher Di Bella)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2017, 5:18 AM (209 w, 2 d)

Recent Activity

Today

cjdb committed rGf280505aa084: [libcxx] adds `std::indirectly_readable_traits` to <iterator> (authored by cjdb).
[libcxx] adds `std::indirectly_readable_traits` to <iterator>
Thu, Apr 15, 5:00 PM
cjdb closed D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 4:59 PM · Restricted Project
cjdb added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Thu, Apr 15, 4:56 PM · Restricted Project
cjdb updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.

rebases so @zoecarver can commandeer without issue

Thu, Apr 15, 2:54 PM · Restricted Project
cjdb commandeered D99855: [libcxx] makes `iterator_traits` C++20-aware.
Thu, Apr 15, 2:53 PM · Restricted Project
cjdb added inline comments to D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
Thu, Apr 15, 1:00 PM · Restricted Project
cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

rebases to activate CI

Thu, Apr 15, 12:49 PM · Restricted Project
cjdb added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 12:36 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

rebases to activate CI (and gets it right this time)

Thu, Apr 15, 12:33 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

rebases to activate CI

Thu, Apr 15, 12:32 PM · Restricted Project
cjdb committed rG6f3bce911ecf: [libcxx][NFC] removes IndentRequires from .clang-format (authored by cjdb).
[libcxx][NFC] removes IndentRequires from .clang-format
Thu, Apr 15, 12:29 PM
cjdb added inline comments to D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..
Thu, Apr 15, 12:13 PM · Restricted Project
cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

adds archetype cpp17-iterators for testing

Thu, Apr 15, 12:07 PM · Restricted Project
cjdb accepted D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for..

LGTM

Thu, Apr 15, 11:39 AM · Restricted Project
cjdb added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Overall LGTM, thank you for working on this :-)

Thu, Apr 15, 11:37 AM · Restricted Project
cjdb updated the diff for D100271: [libcxx] adds `input_iterator` and `input_range`.

rebases to activate CI

Thu, Apr 15, 9:59 AM · Restricted Project
cjdb updated the diff for D100269: [libcxx] adds concept `range` and range aliases.

rebases to activate CI

Thu, Apr 15, 9:56 AM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

rebases to activate CI

Thu, Apr 15, 9:56 AM · Restricted Project
cjdb updated the diff for D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.

rebases to activate CI

Thu, Apr 15, 9:54 AM · Restricted Project
cjdb updated the diff for D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

rebases to activate CI

Thu, Apr 15, 9:54 AM · Restricted Project
cjdb updated the diff for D100078: [libcxx] adds `std::indirectly_writable` to <iterator>.

rebases to activate CI

Thu, Apr 15, 9:54 AM · Restricted Project
cjdb updated the diff for D100073: [libcxx] adds `std::indirectly_readable` to <iterator>.

rebases to activate CI

Thu, Apr 15, 9:54 AM · Restricted Project
cjdb updated the diff for D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.

rebases to activate CI

Thu, Apr 15, 9:53 AM · Restricted Project
cjdb updated the diff for D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.

rebases to activate CI

Thu, Apr 15, 9:53 AM · Restricted Project
cjdb updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.

rebases to activate CI

Thu, Apr 15, 9:53 AM · Restricted Project
cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

rebases to activate CI

Thu, Apr 15, 9:52 AM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

rebases to activate CI

Thu, Apr 15, 9:52 AM · Restricted Project
cjdb committed rGff0ada4e1607: [libcxx][NFC] removes BreakBeforeConceptDeclarations from .clang-format (authored by cjdb).
[libcxx][NFC] removes BreakBeforeConceptDeclarations from .clang-format
Thu, Apr 15, 8:30 AM

Yesterday

cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

applies feedback

Wed, Apr 14, 9:07 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

rebase went wrong, reverting what should've been applied to D99854

Wed, Apr 14, 8:47 PM · Restricted Project
cjdb added inline comments to D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.
Wed, Apr 14, 8:38 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

applies feedback

Wed, Apr 14, 8:38 PM · Restricted Project
cjdb added a comment to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

Will merge after @ldionne green tick and @zoecarver clarifies a few points.

Wed, Apr 14, 8:09 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

applies feedback issued by @zoecarver and @ldionne

Wed, Apr 14, 8:09 PM · Restricted Project
cjdb committed rG2e3a78b8ca10: [libcxx][NFC] adjusts formatting rules (authored by cjdb).
[libcxx][NFC] adjusts formatting rules
Wed, Apr 14, 7:47 PM
cjdb closed D99691: [libcxx] adjusts formatting rules.
Wed, Apr 14, 7:47 PM · Restricted Project
cjdb added a comment to D99691: [libcxx] adjusts formatting rules.

Is it possible to increase the length of lines as enforced by clang-format? Libc++ tends to have a lot of verbose identifiers and macros, and it really helps readability if that doesn't cause us to break lines all around the place.

Wed, Apr 14, 7:46 PM · Restricted Project
cjdb added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Wed, Apr 14, 7:41 PM · Restricted Project
cjdb accepted D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..

LGTM

Wed, Apr 14, 5:03 PM · Restricted Project
cjdb added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Wed, Apr 14, 12:52 PM · Restricted Project
cjdb added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Wed, Apr 14, 12:38 PM · Restricted Project
cjdb added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Wed, Apr 14, 11:31 AM · Restricted Project

Tue, Apr 13

cjdb added a comment to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..

LGTM overall, thanks for working on this :-)

Tue, Apr 13, 5:53 PM · Restricted Project
cjdb added inline comments to D100275: [libcxx] adds `forward_iterator` and `forward_range`.
Tue, Apr 13, 2:21 PM · Restricted Project
cjdb added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Tue, Apr 13, 2:15 PM · Restricted Project
cjdb added a comment to D100271: [libcxx] adds `input_iterator` and `input_range`.

I like the test coverage but I believe that we should get @CaseyCarter on board to port the ranges test machinery over. It is quite extensive and rebuilding it for the fun of it seems a waste of time

Tue, Apr 13, 11:44 AM · Restricted Project
cjdb accepted D100393: [libc++][docs] Add status docs for ranges..

LGTM. You don't necessarily need to apply my comments; they're for tracking so that I remember to mark as WIP or complete before making a final merge.

Tue, Apr 13, 11:13 AM · Restricted Project

Mon, Apr 12

cjdb committed rG0fcea41920ce: [libcxx][NFC] tweaks `incrementable_traits` per review (authored by cjdb).
[libcxx][NFC] tweaks `incrementable_traits` per review
Mon, Apr 12, 10:22 PM
cjdb added inline comments to D90999: [libc++] Implements ranges::enable_borrowed_range.
Mon, Apr 12, 10:08 PM · Restricted Project
cjdb committed rGfe31f11cc821: [libcxx] adds `std::incrementable_traits` to <iterator> (authored by cjdb).
[libcxx] adds `std::incrementable_traits` to <iterator>
Mon, Apr 12, 10:03 PM
cjdb closed D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Mon, Apr 12, 10:02 PM · Restricted Project
cjdb updated the diff for D100278: [libcxx] adds `bidirectional_iterator` and `bidirectional_range`.

updates subsumption test

Mon, Apr 12, 10:01 PM · Restricted Project
cjdb updated the diff for D100275: [libcxx] adds `forward_iterator` and `forward_range`.

updates subsumption test

Mon, Apr 12, 10:00 PM · Restricted Project
cjdb updated the diff for D100271: [libcxx] adds `input_iterator` and `input_range`.

updates subsumption test

Mon, Apr 12, 9:38 PM · Restricted Project
cjdb updated the diff for D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

adds subsumption tests

Mon, Apr 12, 9:36 PM · Restricted Project
cjdb updated the diff for D100271: [libcxx] adds `input_iterator` and `input_range`.

adds subsumption tests

Mon, Apr 12, 5:58 PM · Restricted Project
cjdb updated the diff for D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.

adds subsumption test

Mon, Apr 12, 5:45 PM · Restricted Project
cjdb updated the diff for D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.

reverts _If to conditional_t to avoid substitution failure problem in future commits

Mon, Apr 12, 4:57 PM · Restricted Project
cjdb requested review of D100342: [libcxx] removes operator!= and globally guards against no spaceship operator.
Mon, Apr 12, 2:05 PM · Restricted Project

Sun, Apr 11

cjdb requested review of D100283: [libcxx] removes `weak_equality` and `strong_equality` from <compare>.
Sun, Apr 11, 10:27 PM · Restricted Project
cjdb requested review of D100278: [libcxx] adds `bidirectional_iterator` and `bidirectional_range`.
Sun, Apr 11, 6:20 PM · Restricted Project
cjdb added a comment to D100277: [libc++] [test] Detect an improperly noexcept'ed __decay_copy..

Maybe it's worth cleaning up __decay_copy in this patch too? It's probably best if we commit separately to D100225.

Sun, Apr 11, 4:21 PM · Restricted Project
cjdb requested review of D100275: [libcxx] adds `forward_iterator` and `forward_range`.
Sun, Apr 11, 3:12 PM · Restricted Project
cjdb updated the diff for D100271: [libcxx] adds `input_iterator` and `input_range`.

updates synopsis, rebases to activate CI

Sun, Apr 11, 2:45 PM · Restricted Project
cjdb updated the diff for D100269: [libcxx] adds concept `range` and range aliases.

rebases to activate CI

Sun, Apr 11, 2:42 PM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

rebases to activate CI

Sun, Apr 11, 2:42 PM · Restricted Project
cjdb updated the diff for D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.

updates synopsis, rebases to activate CI

Sun, Apr 11, 2:42 PM · Restricted Project
cjdb updated the diff for D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

updates synopsis, rebases to activate CI

Sun, Apr 11, 2:40 PM · Restricted Project
cjdb updated the diff for D100078: [libcxx] adds `std::indirectly_writable` to <iterator>.

updates synopsis, rebases to activate CI

Sun, Apr 11, 2:39 PM · Restricted Project
cjdb updated the diff for D100073: [libcxx] adds `std::indirectly_readable` to <iterator>.

adds synopsis, rebases to activate CI

Sun, Apr 11, 2:38 PM · Restricted Project
cjdb updated the diff for D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.

rebases to activate CI

Sun, Apr 11, 2:37 PM · Restricted Project
cjdb updated the diff for D99863: [libcxx] adds `iter_difference_t` and `iter_value_t`.

rebases to activate CI

Sun, Apr 11, 2:36 PM · Restricted Project
cjdb updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.

rebases to activate CI

Sun, Apr 11, 2:35 PM · Restricted Project
cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

rebases to activate CI

Sun, Apr 11, 2:35 PM · Restricted Project
cjdb updated the diff for D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.

rebases to activate CI

Sun, Apr 11, 2:35 PM · Restricted Project
cjdb updated the diff for D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.

rebases to activate CI

Sun, Apr 11, 2:34 PM · Restricted Project
cjdb requested review of D100271: [libcxx] adds `input_iterator` and `input_range`.
Sun, Apr 11, 1:58 PM · Restricted Project
cjdb added inline comments to D100255: [libcxx] adds `range` access CPOs.
Sun, Apr 11, 12:43 PM · Restricted Project
cjdb added inline comments to D100255: [libcxx] adds `range` access CPOs.
Sun, Apr 11, 12:42 PM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

addresses feedback from @Quuxplusone and @tcanens

Sun, Apr 11, 12:41 PM · Restricted Project
cjdb requested review of D100269: [libcxx] adds concept `range` and range aliases.
Sun, Apr 11, 10:44 AM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

re-adds missing underscore that was deleted in clang-format cleanup

Sun, Apr 11, 10:01 AM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

updates commit message (NFC)

Sun, Apr 11, 9:25 AM · Restricted Project

Sat, Apr 10

cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

corrects and suppresses clang-format due to its inexperience with concepts

Sat, Apr 10, 10:45 PM · Restricted Project
cjdb updated the diff for D100255: [libcxx] adds `range` access CPOs.

fixes dependency in commit message (NFC)

Sat, Apr 10, 10:37 PM · Restricted Project
cjdb requested review of D100255: [libcxx] adds `range` access CPOs.
Sat, Apr 10, 10:36 PM · Restricted Project

Thu, Apr 8

cjdb requested review of D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>.
Thu, Apr 8, 7:12 PM · Restricted Project
cjdb added inline comments to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Thu, Apr 8, 11:06 AM · Restricted Project
cjdb added inline comments to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Thu, Apr 8, 10:55 AM · Restricted Project
cjdb accepted D90999: [libc++] Implements ranges::enable_borrowed_range.
Thu, Apr 8, 10:45 AM · Restricted Project
cjdb added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.
Thu, Apr 8, 8:49 AM · Restricted Project
cjdb updated the diff for D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

corrects typo tanking CI

Thu, Apr 8, 8:43 AM · Restricted Project
cjdb added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.
Thu, Apr 8, 8:31 AM · Restricted Project

Wed, Apr 7

cjdb updated the diff for D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t.

fixes iter_move per @tcanens' feedback
moves __class_or_enum out of __swap scope since it's useful elsewhere

Wed, Apr 7, 11:00 PM · Restricted Project
cjdb updated the diff for D99855: [libcxx] makes `iterator_traits` C++20-aware.

moves iterator_traits into __iterator_traits as per @tcanens' feedback
hopefully gets CI working

Wed, Apr 7, 8:58 PM · Restricted Project
cjdb updated the diff for D99854: [libcxx] adds `cpp17-.*iterator` concepts for iterator_traits.

applies LWG3420 and (hopefully) fixes locale build failure

Wed, Apr 7, 8:02 PM · Restricted Project
cjdb added inline comments to D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Wed, Apr 7, 7:43 PM · Restricted Project
cjdb updated the diff for D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.

renames all the cryptic types imported from cjdb-ranges

Wed, Apr 7, 5:55 PM · Restricted Project
cjdb requested review of D100080: [libcxx] adds `std::weakly_incrementable` and `std::incrementable` to <iterator>.
Wed, Apr 7, 5:48 PM · Restricted Project
cjdb requested review of D100078: [libcxx] adds `std::indirectly_writable` to <iterator>.
Wed, Apr 7, 5:07 PM · Restricted Project