Page MenuHomePhabricator

chrish_ericsson_atx (Chris Hamilton)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2019, 8:09 AM (68 w, 2 d)

Recent Activity

Mon, Nov 2

chrish_ericsson_atx added a comment to D86743: [analyzer] Ignore VLASizeChecker case that could cause crash.

Is anything planned or in progress that would address this issue?

Mon, Nov 2, 6:50 AM · Restricted Project

Sep 29 2020

chrish_ericsson_atx reopened D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).

Reverted due to another obscure test failure. Working to diagnose.

Sep 29 2020, 1:47 PM · Restricted Project
chrish_ericsson_atx added a reverting change for rGd9ee935679e7: [Sema] Address-space sensitive check for unbounded arrays (v2): rG155d2d530055: Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)".
Sep 29 2020, 1:46 PM
chrish_ericsson_atx committed rG155d2d530055: Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)" (authored by chrish_ericsson_atx).
Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"
Sep 29 2020, 1:46 PM
chrish_ericsson_atx added a reverting change for D88174: [Sema] Address-space sensitive check for unbounded arrays (v2): rG155d2d530055: Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)".
Sep 29 2020, 1:46 PM · Restricted Project
chrish_ericsson_atx committed rGd9ee935679e7: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx).
[Sema] Address-space sensitive check for unbounded arrays (v2)
Sep 29 2020, 7:15 AM
chrish_ericsson_atx closed D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).
Sep 29 2020, 7:15 AM · Restricted Project
chrish_ericsson_atx added a comment to D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).

I'm going to land this as-is, based on Bevin's LGTM and my own confidence that the 10 lines I added are correct (enough). @aaron.ballman , please reopen this review if you have additional comments or concerns. Thanks.

Sep 29 2020, 7:10 AM · Restricted Project

Sep 28 2020

chrish_ericsson_atx added a reviewer for D88174: [Sema] Address-space sensitive check for unbounded arrays (v2): ebevhan.
Sep 28 2020, 7:54 AM · Restricted Project
chrish_ericsson_atx added a comment to D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).

Ping. :-)

Sep 28 2020, 4:08 AM · Restricted Project

Sep 23 2020

chrish_ericsson_atx added inline comments to D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).
Sep 23 2020, 11:34 AM · Restricted Project
chrish_ericsson_atx requested review of D88174: [Sema] Address-space sensitive check for unbounded arrays (v2).
Sep 23 2020, 11:31 AM · Restricted Project

Sep 21 2020

chrish_ericsson_atx committed rG2697d138a65a: [Analyzer] GNU named variadic macros in Plister (authored by chrish_ericsson_atx).
[Analyzer] GNU named variadic macros in Plister
Sep 21 2020, 1:39 PM
chrish_ericsson_atx closed D87942: [Analyzer] GNU named variadic macros in Plister.
Sep 21 2020, 1:39 PM · Restricted Project
chrish_ericsson_atx added a comment to D87942: [Analyzer] GNU named variadic macros in Plister.

Thanks for the quick feedback, Kristof! I changed the macro to be just a decrement operator, and triggered DBZ with that. Added the checks as you suggested.

Sep 21 2020, 6:30 AM · Restricted Project
chrish_ericsson_atx updated the diff for D87942: [Analyzer] GNU named variadic macros in Plister.

Addressed feedback from @Szelethus

Sep 21 2020, 6:27 AM · Restricted Project

Sep 19 2020

chrish_ericsson_atx added inline comments to D87942: [Analyzer] GNU named variadic macros in Plister.
Sep 19 2020, 5:20 AM · Restricted Project

Sep 18 2020

chrish_ericsson_atx requested review of D87942: [Analyzer] GNU named variadic macros in Plister.
Sep 18 2020, 2:12 PM · Restricted Project

Sep 15 2020

chrish_ericsson_atx committed rG86ccf4f728c2: [NFC] Test commit (authored by chrish_ericsson_atx).
[NFC] Test commit
Sep 15 2020, 12:20 AM
chrish_ericsson_atx added a reverting change for rGda55e9ba1273: [Sema] Address-space sensitive index check for unbounded arrays: rGc8ddf27ddbbe: Revert "[Sema] Address-space sensitive index check for unbounded arrays".
Sep 15 2020, 12:04 AM
chrish_ericsson_atx committed rGc8ddf27ddbbe: Revert "[Sema] Address-space sensitive index check for unbounded arrays" (authored by chrish_ericsson_atx).
Revert "[Sema] Address-space sensitive index check for unbounded arrays"
Sep 15 2020, 12:04 AM
chrish_ericsson_atx added a reverting change for D86796: [Sema] Address-space sensitive index check for unbounded arrays: rGc8ddf27ddbbe: Revert "[Sema] Address-space sensitive index check for unbounded arrays".
Sep 15 2020, 12:04 AM · Restricted Project

Sep 14 2020

chrish_ericsson_atx committed rGda55e9ba1273: [Sema] Address-space sensitive index check for unbounded arrays (authored by chrish_ericsson_atx).
[Sema] Address-space sensitive index check for unbounded arrays
Sep 14 2020, 4:15 PM
chrish_ericsson_atx closed D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Sep 14 2020, 4:15 PM · Restricted Project

Sep 11 2020

chrish_ericsson_atx added a comment to D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Addressed all feedback from Aaron, except for two comments about reachability that I don't understand.

Sep 11 2020, 4:45 AM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Addressed feedback from Aaron Ballman

Sep 11 2020, 4:41 AM · Restricted Project

Sep 10 2020

chrish_ericsson_atx added a comment to D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Thank you for the comments, @aaron.ballman . I'll update with the changes you requested shortly. I did have some requests for clarification of you, though. Thanks!

Sep 10 2020, 4:36 PM · Restricted Project

Sep 9 2020

chrish_ericsson_atx added a comment to D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Ping?

Sep 9 2020, 8:25 AM · Restricted Project

Sep 4 2020

chrish_ericsson_atx added a comment to D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Thanks for the excellent feedback, @ebevhan . @aaron.ballman , @krememek , or @rsmith , could one of you take a look at this change and if it's acceptable, please approve it? I have not requested commit privileges yet, either, so I will need your assistance to land this change, assuming it's acceptable.

Sep 4 2020, 7:30 AM · Restricted Project

Sep 3 2020

chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

NC push did not resolve failed test. Rebased in hopes that whatever has
broken the build has been resolved in the intervening commits.

Sep 3 2020, 3:09 PM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

NC. Pushing null change in hopes of re-triggering testing.

Sep 3 2020, 2:38 PM · Restricted Project
chrish_ericsson_atx added inline comments to D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Sep 3 2020, 12:21 PM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Refactored as ebevhan suggested to simplify patch.

Sep 3 2020, 12:19 PM · Restricted Project
chrish_ericsson_atx added inline comments to D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Sep 3 2020, 10:27 AM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Addressed reviewer feedback.

Sep 3 2020, 10:16 AM · Restricted Project
chrish_ericsson_atx added inline comments to D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Sep 3 2020, 8:52 AM · Restricted Project

Sep 2 2020

chrish_ericsson_atx added inline comments to D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Sep 2 2020, 10:13 AM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Updating D86796: [Sema] Address-space sensitive index check for unbounded arrays

Sep 2 2020, 10:06 AM · Restricted Project

Sep 1 2020

chrish_ericsson_atx added a comment to D86796: [Sema] Address-space sensitive index check for unbounded arrays.

I will tinker with the math to simplify as you suggest. Working with APInt and APSInt seems to promulgate sensitive and brittle code, which makes trying alternative expressions more tedious than I'd like (which is why I bailed on an earlier attempt to simplify this). However, that same observation about brittle code supports the goal that simpler math would be safer, as there would presumably be fewer opportunities for AP/APSInt to misbehave as they interact.

Sep 1 2020, 7:26 AM · Restricted Project
chrish_ericsson_atx added a reviewer for D86796: [Sema] Address-space sensitive index check for unbounded arrays: aaron.ballman.
Sep 1 2020, 7:17 AM · Restricted Project

Aug 31 2020

chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Corrected formatting (per git-clang-format)

Aug 31 2020, 11:28 AM · Restricted Project

Aug 28 2020

chrish_ericsson_atx added a reviewer for D86796: [Sema] Address-space sensitive index check for unbounded arrays: rsmith.
Aug 28 2020, 12:00 PM · Restricted Project
chrish_ericsson_atx updated the summary of D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Aug 28 2020, 10:56 AM · Restricted Project
chrish_ericsson_atx updated the diff for D86796: [Sema] Address-space sensitive index check for unbounded arrays.

Removed Change-Id from commit log message

Aug 28 2020, 10:27 AM · Restricted Project
chrish_ericsson_atx requested review of D86796: [Sema] Address-space sensitive index check for unbounded arrays.
Aug 28 2020, 10:23 AM · Restricted Project

Jun 2 2020

chrish_ericsson_atx added a comment to D74746: [clang][doxygen] Fix -Wdocumentation warning for tag typedefs.

I reported this issue back in November, as https://bugs.llvm.org/show_bug.cgi?id=44143. This change fixes the bug -- I'll mark it as such.

Jun 2 2020, 3:23 PM · Restricted Project

Nov 26 2019

chrish_ericsson_atx added a comment to D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A..

Hi @sammccall .
Just a heads up. Looks like this might have caused: https://bugs.llvm.org/show_bug.cgi?id=44143 .

Nov 26 2019, 1:21 PM · Restricted Project

Nov 21 2019

chrish_ericsson_atx added a comment to rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive.

Thank you, Erik. Appreciate the quick fix! :)

Nov 21 2019, 5:22 AM

Nov 20 2019

chrish_ericsson_atx added a comment to rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive.

Was this intended to affect the behavior of -Wswitch-bool? The following code did not trigger a warning with -Wswitch-bool prior to this commit, but now it does:

Nov 20 2019, 1:48 PM

Nov 15 2019

chrish_ericsson_atx added inline comments to D62953: [Syntax] Do not glue multiple empty PP expansions to a single mapping.
Nov 15 2019, 12:19 PM · Restricted Project, Restricted Project

Aug 25 2019

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

@Szelethus, firstly, thank you for landing this change. I really appreciate it! Secondly, apologies for misspelling your name earlier. And lastly, thank you for your patient explanation of how to get the diffs updated correctly in a Phabricator review. I think my mistake was that I made the change and the updates updates in a private branch, and not directly off master, and then duplicated the changes on master. For one of those sets of changes, I amended the first commit with the second round of changes, and I think I confused myself by doing that. In any case, lesson learned, and thank you again for your coaching!

Aug 25 2019, 6:01 AM · Restricted Project, Restricted Project

Aug 21 2019

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Kristoff, if you wouldn't mind, since you offered earlier, please go ahead and commit this change as-is, since it was accepted. I ran into some non-technical issues with my follow-up changes and I'm going to be unavailable for several weeks. To mitigate risk and work for my team, I'd like to submit the newer changes separately (and will reference this review in that changeset when I do, of course), after I return to work.

Aug 21 2019, 5:05 AM · Restricted Project, Restricted Project

Aug 15 2019

chrish_ericsson_atx updated the diff for D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Follow-up on reviewer feedback. Changed from blacklisting LValueToRValue to whitelisting IntegralCast. This was a good call -- additional testing with different cast kinds showed that the assertion tripped for other casts besides LValueToRValue, e.g., FloatToIntegral. I couldn't see any casts other than Integral where the enum check seemed appropriate. Testing with only IntegralCast enabled gave expected (correct) results.

Aug 15 2019, 10:37 AM · Restricted Project, Restricted Project
chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

LGTM, thanks! Do you need someone to commit this on your behalf? Also, could you please make the comments capitalized, terminated, and fitting in 80 columns?

Aug 15 2019, 9:30 AM · Restricted Project, Restricted Project

Aug 13 2019

chrish_ericsson_atx added inline comments to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 13 2019, 5:27 AM · Restricted Project, Restricted Project

Aug 12 2019

chrish_ericsson_atx added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Oh, btw, thank you for working on this!

Aug 12 2019, 2:25 PM · Restricted Project, Restricted Project
chrish_ericsson_atx added inline comments to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 12 2019, 9:52 AM · Restricted Project, Restricted Project

Aug 9 2019

chrish_ericsson_atx added reviewers for D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts: Restricted Project, Szelethus.
Aug 9 2019, 8:06 AM · Restricted Project, Restricted Project
chrish_ericsson_atx created D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.
Aug 9 2019, 8:02 AM · Restricted Project, Restricted Project