Page MenuHomePhabricator

charco (Marco Vanotti)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 9 2019, 11:29 AM (78 w, 5 d)

Recent Activity

Thu, Apr 1

charco committed rG0889181625bb: Tweak SimpleFastHash (authored by aarongreen).
Tweak SimpleFastHash
Thu, Apr 1, 11:27 PM
charco closed D94510: Tweak SimpleFastHash.
Thu, Apr 1, 11:26 PM · Restricted Project

Mar 11 2021

charco committed rG6708186c91dd: [crt][fuzzer] Fix up various numeric conversions (authored by aarongreen).
[crt][fuzzer] Fix up various numeric conversions
Mar 11 2021, 4:02 PM
charco closed D97992: [crt][fuzzer] Fix up various numeric conversions.
Mar 11 2021, 4:01 PM · Restricted Project
charco accepted D94522: Add remote flags and external functions.
Mar 11 2021, 3:40 PM · Restricted Project
charco accepted D94515: Add ExternalFunctions to fuzzer::TestEnvironment..
Mar 11 2021, 3:04 PM · Restricted Project

Mar 4 2021

charco added a comment to D97992: [crt][fuzzer] Fix up various numeric conversions.

LGTM, but someone else must approve

Mar 4 2021, 6:39 PM · Restricted Project

Feb 23 2021

charco committed rG97a304cc8f94: [scan-build-py] Add sarif-html support in scan-build-py (authored by Daniel Hwang <arkay@google.com>).
[scan-build-py] Add sarif-html support in scan-build-py
Feb 23 2021, 2:42 PM
charco closed D96570: [scan-build-py] Add sarif-html support in scan-build-py.
Feb 23 2021, 2:42 PM · Restricted Project

Feb 18 2021

charco updated the diff for D96450: [libFuzzer] Use crash stack for fuchsia..

Fix cfi directives for the crash trampoline.

Feb 18 2021, 5:39 PM · Restricted Project

Feb 17 2021

charco added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

Registers_arm64::jumpto in UnwindRegistersRestore.S.

Isn't that code filling x30 with the __pc register?

Line 587 says: ldr x30, [x0, #0x100] // restore pc into lr

And offset #0x100 is __pc

Feb 17 2021, 6:49 PM · Restricted Project, Restricted Project
charco added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

Registers_arm64::jumpto in UnwindRegistersRestore.S.

Feb 17 2021, 6:47 PM · Restricted Project, Restricted Project
charco added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

Let me rephrase then. The restore code explicitly ends in "ret x30". It cannot set "pc" separate from "x30" in the current form. I'm not saying that the DWARF register shouldn't be supported, but this change doesn't do that.

Feb 17 2021, 6:26 PM · Restricted Project, Restricted Project
charco added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

I don't get this change. The restore code is literally returning by jumping to x30, so how is splitting PC and LR supposed to work?

Feb 17 2021, 6:06 PM · Restricted Project, Restricted Project
charco added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

Could you add [libunwind] to the beginning of title?
but otherwise LGTM as the author of the corresponding dwarf spec change.

Thanks for this patch.

Feb 17 2021, 5:47 PM · Restricted Project, Restricted Project
charco committed rG78eabcaa48df: [libunwind] Add support for PC reg column in arm64 (authored by charco).
[libunwind] Add support for PC reg column in arm64
Feb 17 2021, 5:42 PM
charco closed D96901: [libunwind] Add support for PC reg column in arm64.
Feb 17 2021, 5:42 PM · Restricted Project, Restricted Project
charco updated the diff for D96901: [libunwind] Add support for PC reg column in arm64.

Add [libunwind] to the commit message.

Feb 17 2021, 5:23 PM · Restricted Project, Restricted Project
charco retitled D96901: [libunwind] Add support for PC reg column in arm64 from Add support for PC reg column in arm64 to [libunwind] Add support for PC reg column in arm64.
Feb 17 2021, 5:20 PM · Restricted Project, Restricted Project
charco requested review of D96901: [libunwind] Add support for PC reg column in arm64.
Feb 17 2021, 2:24 PM · Restricted Project, Restricted Project
charco committed rG10993bf072d9: Bugfix for collecting features from very small DSOs. (authored by aarongreen).
Bugfix for collecting features from very small DSOs.
Feb 17 2021, 1:05 PM
charco closed D94507: Bugfix for collecting features from very small DSOs..
Feb 17 2021, 1:05 PM · Restricted Project

Feb 12 2021

charco committed rG0fe4701e5153: Expand unit tests for fuzzer::Merger (authored by charco).
Expand unit tests for fuzzer::Merger
Feb 12 2021, 11:19 AM
charco closed D94506: Expand unit tests for fuzzer::Merger.
Feb 12 2021, 11:18 AM · Restricted Project

Feb 10 2021

charco updated the diff for D96450: [libFuzzer] Use crash stack for fuchsia..

clang-format

Feb 10 2021, 2:13 PM · Restricted Project
charco requested review of D96450: [libFuzzer] Use crash stack for fuchsia..
Feb 10 2021, 2:10 PM · Restricted Project

Feb 3 2021

charco accepted D95919: [sanitizer_common] Use zx_system_get_page_size() on Fuchsia.

Ah! It is already in the VDSO! I thought it was a regular system call, my bad. Fuchsia should probably document that.

Feb 3 2021, 10:32 AM · Restricted Project

Feb 2 2021

charco added a comment to D95919: [sanitizer_common] Use zx_system_get_page_size() on Fuchsia.

The CL seems fine, but should we use sanitizer_common's GetPageSizeCached()[0] where we call GetPageSize() ? Fuchsia documentation indicates that it's OK for user apps to cache that value.

Feb 2 2021, 11:32 PM · Restricted Project

Jan 27 2021

charco committed rG98c21ae7a8ec: [sanitizer][fuchsia] Implement ReleaseMemoryPagesToOS (authored by charco).
[sanitizer][fuchsia] Implement ReleaseMemoryPagesToOS
Jan 27 2021, 11:13 AM
charco closed D95384: [sanitizer][fuchsia] Implement ReleaseMemoryPagesToOS.
Jan 27 2021, 11:13 AM · Restricted Project

Jan 25 2021

charco added inline comments to D95384: [sanitizer][fuchsia] Implement ReleaseMemoryPagesToOS.
Jan 25 2021, 12:20 PM · Restricted Project
charco requested review of D95384: [sanitizer][fuchsia] Implement ReleaseMemoryPagesToOS.
Jan 25 2021, 11:54 AM · Restricted Project

Jan 20 2021

charco added inline comments to D94508: Add functions to encode/decode feature files.
Jan 20 2021, 6:58 PM · Restricted Project
charco added a comment to D94510: Tweak SimpleFastHash.

Can you explain in the summary / commit message why this is needed? How do you intend to use it?

Jan 20 2021, 6:23 PM · Restricted Project
charco accepted D94507: Bugfix for collecting features from very small DSOs..
Jan 20 2021, 6:19 PM · Restricted Project

Oct 29 2020

charco committed rG6777919d5ac2: [libFuzzer] Remove InterruptHandler from Fuchsia implementation (authored by eep).
[libFuzzer] Remove InterruptHandler from Fuchsia implementation
Oct 29 2020, 12:03 AM
charco closed D89266: [libFuzzer] Remove InterruptHandler from Fuchsia implementation.
Oct 29 2020, 12:03 AM · Restricted Project

Oct 2 2020

charco added a reviewer for D88347: [tsan] Refactor Memory Release Functions.: vitalybuka.
Oct 2 2020, 4:41 PM · Restricted Project
charco updated subscribers of D88765: [tsan] split malloc interceptors from posix_interceptors.
Oct 2 2020, 4:38 PM · Restricted Project
charco requested review of D88765: [tsan] split malloc interceptors from posix_interceptors.
Oct 2 2020, 4:37 PM · Restricted Project
charco updated the diff for D88347: [tsan] Refactor Memory Release Functions..

wrong argument order.

Oct 2 2020, 11:14 AM · Restricted Project
charco updated the diff for D88347: [tsan] Refactor Memory Release Functions..

Fix ptrdiff error.

Oct 2 2020, 11:06 AM · Restricted Project

Sep 25 2020

charco requested review of D88347: [tsan] Refactor Memory Release Functions..
Sep 25 2020, 5:35 PM · Restricted Project
charco committed rGa83eb048cb9a: [lsan] Add interceptor for pthread_detach. (authored by charco).
[lsan] Add interceptor for pthread_detach.
Sep 25 2020, 2:23 PM
charco closed D88184: [lsan] Add interceptor for pthread_detach..
Sep 25 2020, 2:22 PM · Restricted Project
charco updated the diff for D88184: [lsan] Add interceptor for pthread_detach..
  • simplify test.
Sep 25 2020, 2:18 PM · Restricted Project

Sep 24 2020

charco updated the diff for D88184: [lsan] Add interceptor for pthread_detach..
  • Add tests for spawning multiple threads.
  • Add comment for max number of threads.
Sep 24 2020, 2:56 PM · Restricted Project

Sep 23 2020

charco updated the diff for D88184: [lsan] Add interceptor for pthread_detach..

Fix.

Sep 23 2020, 3:27 PM · Restricted Project
charco updated the diff for D88184: [lsan] Add interceptor for pthread_detach..

Add test for spawning multiple threads.

Sep 23 2020, 3:26 PM · Restricted Project
charco requested review of D88184: [lsan] Add interceptor for pthread_detach..
Sep 23 2020, 2:47 PM · Restricted Project

Aug 28 2020

charco committed rG6760f7ee6f00: [compiler-rt][tsan] Remove unnecesary typedefs (authored by charco).
[compiler-rt][tsan] Remove unnecesary typedefs
Aug 28 2020, 6:45 PM
charco closed D86826: compiler-rt: Remove unnecesary typedefs in tsan_interface.
Aug 28 2020, 6:45 PM · Restricted Project
charco updated the diff for D86826: compiler-rt: Remove unnecesary typedefs in tsan_interface.

Update commit message.

Aug 28 2020, 6:37 PM · Restricted Project
charco committed rG2e800495a78a: [clang] Enable -fsanitize=thread on Fuchsia. (authored by charco).
[clang] Enable -fsanitize=thread on Fuchsia.
Aug 28 2020, 5:26 PM
charco closed D86822: [clang] Enable -fsanitize=thread on Fuchsia..
Aug 28 2020, 5:26 PM · Restricted Project
charco updated the diff for D86822: [clang] Enable -fsanitize=thread on Fuchsia..

remove change-id lines.

Aug 28 2020, 5:23 PM · Restricted Project
charco requested review of D86826: compiler-rt: Remove unnecesary typedefs in tsan_interface.
Aug 28 2020, 5:13 PM · Restricted Project
charco requested review of D86822: [clang] Enable -fsanitize=thread on Fuchsia..
Aug 28 2020, 4:05 PM · Restricted Project

Jul 21 2020

charco committed rGdb00fac2a2b8: [compiler-rt][asan] decommit shadow memory for unmaps in fuchsia. (authored by charco).
[compiler-rt][asan] decommit shadow memory for unmaps in fuchsia.
Jul 21 2020, 11:08 AM
charco closed D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
Jul 21 2020, 11:08 AM · Restricted Project

Jul 20 2020

charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
  • Move FlushUnneededASanShadowMemory into asan_fuchsia.cpp
  • Fork FlushUnneededASanShadowMemory for all platforms.
Jul 20 2020, 9:16 PM · Restricted Project

Jul 13 2020

charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Rebase.

Jul 13 2020, 3:23 PM · Restricted Project
charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Rebase... Third try.

Jul 13 2020, 3:22 PM · Restricted Project
charco added a comment to D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Do you need someone to land it for you?

Jul 13 2020, 2:43 PM · Restricted Project
charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Rebase

Jul 13 2020, 1:37 PM · Restricted Project
charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Rebase.

Jul 13 2020, 12:34 PM · Restricted Project

Jun 26 2020

charco added a comment to D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

I'm not sure what the harbormaster errors are about, is there a way to see the error logs?

Jun 26 2020, 11:29 AM · Restricted Project
charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
  • Move FlushUnneededASanShadowMemory into asan_fuchsia.cpp
  • Fork FlushUnneededASanShadowMemory for all platforms.
Jun 26 2020, 9:50 AM · Restricted Project
charco added a comment to D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

do you need empty version in _fuchsia.cpp ?

Jun 26 2020, 9:50 AM · Restricted Project

Jun 25 2020

charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Create platform-specific versions of FlushUnneededASanShadowMemory.

Jun 25 2020, 10:21 PM · Restricted Project

Jun 23 2020

charco added inline comments to D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
Jun 23 2020, 7:26 PM · Restricted Project

May 21 2020

charco added inline comments to D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
May 21 2020, 10:15 AM · Restricted Project
charco updated the diff for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..

Move FlushUnneededASanShadowMemory into asan_fuchsia.cpp

May 21 2020, 10:15 AM · Restricted Project

May 20 2020

charco added a reviewer for D80355: compiler-rt: decommit asan memory for unmaps in fuchsia.: vitalybuka.
May 20 2020, 10:33 PM · Restricted Project
charco created D80355: compiler-rt: decommit asan memory for unmaps in fuchsia..
May 20 2020, 9:29 PM · Restricted Project

Jan 17 2020

charco committed rG44aaca3de4f4: [libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia. (authored by charco).
[libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia.
Jan 17 2020, 12:19 PM
charco closed D72894: [libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia..
Jan 17 2020, 12:18 PM · Restricted Project, Restricted Project
charco added a comment to D72894: [libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia..

Thanks for the review, Aaron!

Jan 17 2020, 12:18 PM · Restricted Project, Restricted Project

Jan 16 2020

charco updated the diff for D72894: [libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia..

Ran clang-format

Jan 16 2020, 5:47 PM · Restricted Project, Restricted Project
charco created D72894: [libFuzzer] Allow discarding output in ExecuteCommand in Fuchsia..
Jan 16 2020, 5:37 PM · Restricted Project, Restricted Project

Nov 21 2019

charco committed rGe5b603a4c320: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia. (authored by charco).
[libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia.
Nov 21 2019, 4:56 PM
charco closed D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..
Nov 21 2019, 4:56 PM · Restricted Project, Restricted Project
charco updated the diff for D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Add missing header for _dup2 in windows.

Nov 21 2019, 4:56 PM · Restricted Project, Restricted Project
charco committed rG46c7fc22cfb1: [libFuzzer] Fix unwinding for Fuchsia (authored by charco).
[libFuzzer] Fix unwinding for Fuchsia
Nov 21 2019, 3:52 PM
charco closed D69579: [libFuzzer] Fix unwinding for Fuchsia.
Nov 21 2019, 3:52 PM · Restricted Project, Restricted Project
charco committed rG16d9f44fd154: [libFuzzer] Fix fd check in DupAndCloseStderr. (authored by charco).
[libFuzzer] Fix fd check in DupAndCloseStderr.
Nov 21 2019, 3:34 PM
charco closed D68775: [libFuzzer] Fix fd check in DupAndCloseStderr..
Nov 21 2019, 3:34 PM · Restricted Project, Restricted Project

Nov 19 2019

charco added a comment to D69579: [libFuzzer] Fix unwinding for Fuchsia.

Thanks for the comments!

Nov 19 2019, 6:05 PM · Restricted Project, Restricted Project
charco updated the diff for D69579: [libFuzzer] Fix unwinding for Fuchsia.

Update comments & commit message.

Nov 19 2019, 6:05 PM · Restricted Project, Restricted Project

Nov 12 2019

charco updated the diff for D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Fix reviewer comments.

Nov 12 2019, 4:35 PM · Restricted Project, Restricted Project
charco added a comment to D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Ping :)

Nov 12 2019, 1:34 PM · Restricted Project, Restricted Project
charco added reviewers for D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia.: morehouse, hctim.
Nov 12 2019, 1:34 PM · Restricted Project, Restricted Project

Nov 11 2019

charco added a comment to D69579: [libFuzzer] Fix unwinding for Fuchsia.

@phosek would you land this change? I don't have land access

Nov 11 2019, 4:46 PM · Restricted Project, Restricted Project

Nov 5 2019

charco added a comment to D69579: [libFuzzer] Fix unwinding for Fuchsia.

Thanks for the comments, Petr!

Nov 5 2019, 3:33 PM · Restricted Project, Restricted Project
charco updated the diff for D69579: [libFuzzer] Fix unwinding for Fuchsia.

Make code consistent with llvm code style.

Nov 5 2019, 3:33 PM · Restricted Project, Restricted Project
charco updated the diff for D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Move DiscardOutput to FuzzerUtil*.

Nov 5 2019, 11:34 AM · Restricted Project, Restricted Project

Nov 4 2019

charco edited reviewers for D69085: [libFuzzer] don't change sanitizer_report_fd for fuchsia., added: phosek; removed: mcgrathr.
Nov 4 2019, 6:02 PM · Restricted Project, Restricted Project
charco added a reviewer for D69085: [libFuzzer] don't change sanitizer_report_fd for fuchsia.: mcgrathr.
Nov 4 2019, 1:00 PM · Restricted Project, Restricted Project

Oct 29 2019

charco added a comment to D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Hi Reviewers!

Oct 29 2019, 3:50 PM · Restricted Project, Restricted Project
charco created D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..
Oct 29 2019, 3:42 PM · Restricted Project, Restricted Project