- User Since
- Oct 20 2020, 8:47 AM (12 w, 4 d)
Mon, Jan 4
Fri, Dec 18
Updated the test filename to reflect the change made in D93559.
Thanks a lot, Aditya. Again, my apologies for the screw-up. I will make sure I won't make the same mistake next time I add a new file.
Thanks for catching this for me. I don't work on Mac. :(
Dec 17 2020
Dec 8 2020
Dec 7 2020
Dec 3 2020
Made changes based on the review comments.
Dec 1 2020
Oct 28 2020
Oct 26 2020
Typed the attributes as PointerUnion<DIExpression *, DIVariable *>, and updated the test to exercise the DIVariable case.
Oct 23 2020
Reverted back to type those attributes as Metadata to allow DIVairbale.
Oct 22 2020
Also, DIBuilder::createConstantValueExpression(uint64_t) is already available for doing constant via DIExpression,, and its usage is demonstrated in the unit test.
Typed the attributes as DIExpression*, as suggested by @aprantl.
Oct 21 2020
Including the rank attribute in the patch.
Added a unit test for the patch.
Sorry. Please ignore Patch 2.
Per review comments, fixed/enhanced the description of createTypeArray.
Per review comments, fixed/enhanced the description of createArrayType.
Regarding test: Does the test idea laid out in my opening comment sound reasonable?
Oct 20 2020
I'd appreciate some guidance on what test to add for this change. Would it be sufficient to have a unittest that calls createArrayType to create a DICompositeType, and then get the three new attributes back from the DICompositeType using the getRaw* functions to check that they match with the arguments to the createArrayType call? Thanks.