- User Since
- Aug 21 2019, 11:47 AM (86 w, 6 d)
I mark this patch as "plan changed" since the assert message indicates that something wrong in IRBuilder or Codegen, however, main branch also have the same issue so I think this patch does not trigger the issue.
Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874.
Fri, Apr 16
Initially we did not have an OMPIRBuilder object unconditionally, now we have. Let's move over everything that is ready. So master and critical should be good to go as well I suppose.
Thu, Apr 15
Update test and fix code format
Wed, Apr 14
Fri, Apr 9
Fix lit-test failure for dispatch_ast_print and rebase
Thu, Apr 8
Fix/Add test for "can not have more than one filter clause" issue and rebase.
Wed, Apr 7
Rebase and fix based on comments.
Tue, Apr 6
Thu, Apr 1
Update codegen test
Wed, Mar 31
Add some codegen tests
Tue, Mar 30
Mar 10 2021
I think some existing Clang OpenMP codegen tests will break if they are testing against __kmpc_push_target_tripcount.
Jan 4 2021
@alokmishra.besu, I'm trying to play/learn with your patch so I downloaded the diff and apply it to the master branch, however, I'm getting error messages everywhere if llvm::omp::OMPD_metadirective appears:
Dec 15 2020
Dec 11 2020
Fix outdated comment in test
Dec 9 2020
Dec 7 2020
Below test asserts inside generateInfoForComponentList:
Assertion failed: (!IsPointer && "Unexpected base element with the pointer type."), function generateInfoForComponentList, file /Users/cchen/workspace/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp, line 7754. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
Just tried this patch and found that below test abort inside generateInfoCapture.
#include <stdio.h> #define LEN 100 int buf[LEN];
Dec 3 2020
Add more tests and store location for present modifier
Update based on comment
Dec 2 2020
Dec 1 2020
I now only update target_defaultmap_messages test since I'm not sure what I've done is correct for the new version. Will add all other defaultmap_messages tests once corrected the stuff I added in target_defaultmap_messages.
Rebase and fix coding style
Nov 24 2020
I think I'll just land it since it's an nfc.
Nov 23 2020
Nov 19 2020
Nov 18 2020
Nov 17 2020
Apply LLVM coding style
Nov 10 2020
Nov 9 2020
Fix coding style
Fix build error
Nov 6 2020
Nov 5 2020
Rebase and fix based on feedback
Nov 4 2020
Fix coding style
Fix based on feedback
Nov 3 2020
Separate test to a independent file
Oct 2 2020
Oct 1 2020
@ABataev, the below test is extracted from Sollve test suite and Clang now emit:
test.c:17:35: error: subscripted value is not an array or pointer #pragma omp target update to( (([N][N])foo)[1:M] ) ^~~~~~~~~~~~~ test.c:17:5: error: expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update' #pragma omp target update to( (([N][N])foo)[1:M] )
This error message came from the ActOnOMPArraySectionExpr which is called inside ParsePostfixExpressionSuffix. The issue is that the base expression in ActOnOMPArraySectionExpr looks like:
ParenExpr 0x122859be0 '<OpenMP array shaping type>' lvalue `-OMPArrayShapingExpr 0x122859b98 '<OpenMP array shaping type>' lvalue |-IntegerLiteral 0x122859b38 'int' 5 |-IntegerLiteral 0x122859b58 'int' 5 `-DeclRefExpr 0x122859b78 'int *' lvalue Var 0x1228599d0 'foo' 'int *'
which is not a base that we would expect in an array section expr. I've tried relaxing the base type check in ActOnOMPArraySectionExpr but not sure it's the way to go. (or should I just extract the DeclReExpr from ArrayShapingExpr before calling ActOnOMPArraySectionExpr?)
Aug 21 2020
Aug 18 2020
In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there is a reduced test case that failed after adding this patch. The assertion is from OMPChildren::getInnermostCapturedStmt.
Aug 7 2020
Fix commit message
Jul 31 2020
Jul 24 2020
Ping, compiler support is in this patch: https://reviews.llvm.org/D84192.
@ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks!