Page MenuHomePhabricator

bartell (Sean Bartell)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2018, 6:55 PM (107 w, 6 d)

Recent Activity

Sep 1 2020

bartell added a comment to D86847: [Bitcode] Add BITCODE_SIZE_BLOCK_ID to encode the size of the bitcode.

@bartell mentioned something about a bitcode wrapper that does provide the length - how does this patch's strategy compare to that approach? Are they redundant? Should the wrapper be replaced with this patch's approach? (or should the bitcode wrapper approach be used instead of adding this patch?)

I guess that is an implementation choice. This approach prefers a simple linker implementation, while the bitcode wrapper requires linker know to treat this section differently and write bitcode wrapper into section.
@MaskRay Do you have any specific use case in mind for this? If you are tied to a linker like lld, it might be better just teach lld to treat this section differently so we don't need worry about concatenated bitcode file.

Sep 1 2020, 10:49 AM · Restricted Project

Apr 16 2019

Herald added a project to D53942: IR Outliner Pass: Restricted Project.
Apr 16 2019, 12:29 PM · Restricted Project

Oct 9 2018

bartell created D53050: [IR] Make TypeFinder check function metadata attachments..
Oct 9 2018, 3:52 PM

Sep 27 2018

bartell created D52641: Bitcode: Fix assert when writing arrays as blobs..
Sep 27 2018, 7:51 PM